From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C0C2EB64D9 for ; Thu, 29 Jun 2023 14:49:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B627C8D0002; Thu, 29 Jun 2023 10:49:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B120E8D0001; Thu, 29 Jun 2023 10:49:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9B2B58D0002; Thu, 29 Jun 2023 10:49:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 885A18D0001 for ; Thu, 29 Jun 2023 10:49:54 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id DC2BA1A0C2B for ; Thu, 29 Jun 2023 14:49:53 +0000 (UTC) X-FDA: 80956069866.17.07270F3 Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) by imf19.hostedemail.com (Postfix) with ESMTP id C02281A0004 for ; Thu, 29 Jun 2023 14:49:51 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf19.hostedemail.com: domain of sagigrim@gmail.com designates 209.85.167.52 as permitted sender) smtp.mailfrom=sagigrim@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688050191; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2+V2QoP1g+tUtgNa3Zg1YUxv30ED+AV1SxmDuok5KeI=; b=EAhKhPdZ7BSpu8EMV45i6GlOTQtc9pVcDWmY+WmGzgjXM+BlidYBo69gwu/XiOw+YE5Ehe e9ejVzWKuR4NtFTz7Jh83El89+T2pjiIWEaSg/pLqRXqSXkj8R3ApxVFW+b3xiOxWcBhc6 gaxPRC0qTKSi8srnDHnCnV8Zl89I0Fs= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf19.hostedemail.com: domain of sagigrim@gmail.com designates 209.85.167.52 as permitted sender) smtp.mailfrom=sagigrim@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688050191; a=rsa-sha256; cv=none; b=8PQee+XoMstF2E51HDvfZvMxWHCWOdEmk5q0iWfwX+3lfA655RNJEjARol2hBUeABVvCln 27Yph7mNy9RgH128bpDfr8MSeEMP44i1/Jdp0BYSOMm6cfYklSXe3nxlb8y1IygbB20oNW zHumBvrsgfFMonERCNW1n1TdK5G48u8= Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-4f14e14dc00so209082e87.1 for ; Thu, 29 Jun 2023 07:49:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688050190; x=1690642190; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2+V2QoP1g+tUtgNa3Zg1YUxv30ED+AV1SxmDuok5KeI=; b=kGYSvOtys3VL9wQJmbO92DwRduxrccLVOGKyafhZr5kNjFEo9SXoP3TCOeacTLwKdU bOPqCNp0puBMcvF/9wpqMwpnunj5sC53UUlCyQth/hTskkt5SZDhGBYwetCEW/XfMM/c tmDH4gvBucs90yU1ADG49lqMQ/BiycV8PS9P+WMCzEWCXkvuukO0wgJJVPKgUa59cV6G X6GL1z6ggA6gyDxncCoONbFdwnHCXSDPrVtRVvcuZA5t+nXb0VlL/zirp1xxYqEFTUdK 15niqFL/jNJ5BcvZheiIf3pWibp5Pn1uby1Mu9ve9t9gzLvOJxlD1fE8y0OvpqfqIT32 HGcQ== X-Gm-Message-State: ABy/qLYLrMAcYah1wy0MerZ5E+oturBqc+PSHQ63HxWk+PF6izZfIgf7 1ycLiH12NuYfUnnZA6tgD94= X-Google-Smtp-Source: APBJJlHFD7hzN7Y6/gs5D8g7Wgnjk2WzxoDiPG1+WoxbmItuuVfbd1xLD5VmbMR/3dURiDtF7IasRQ== X-Received: by 2002:ac2:5499:0:b0:4fb:8cb9:7ad8 with SMTP id t25-20020ac25499000000b004fb8cb97ad8mr120263lfk.2.1688050189484; Thu, 29 Jun 2023 07:49:49 -0700 (PDT) Received: from [10.100.102.14] (46-116-229-137.bb.netvision.net.il. [46.116.229.137]) by smtp.gmail.com with ESMTPSA id c6-20020a05600c0ac600b003f9c0a7c6bcsm16709186wmr.0.2023.06.29.07.49.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Jun 2023 07:49:48 -0700 (PDT) Message-ID: Date: Thu, 29 Jun 2023 17:49:46 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH net-next v3 10/18] nvme/host: Use sendmsg(MSG_SPLICE_PAGES) rather then sendpage Content-Language: en-US To: Aurelien Aptel , David Howells , netdev@vger.kernel.org Cc: Alexander Duyck , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Willem de Bruijn , David Ahern , Matthew Wilcox , Jens Axboe , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Willem de Bruijn , Keith Busch , Jens Axboe , Christoph Hellwig , Chaitanya Kulkarni , linux-nvme@lists.infradead.org References: <20230620145338.1300897-1-dhowells@redhat.com> <20230620145338.1300897-11-dhowells@redhat.com> <253mt0il43o.fsf@mtr-vdi-124.i-did-not-set--mail-host-address--so-tickle-me> From: Sagi Grimberg In-Reply-To: <253mt0il43o.fsf@mtr-vdi-124.i-did-not-set--mail-host-address--so-tickle-me> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: mx3upxm6q1ymdmxfr1pm7uo8zh3j5zmh X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: C02281A0004 X-HE-Tag: 1688050191-618867 X-HE-Meta: U2FsdGVkX1/nT08nJfDxhmn9rPV5r1xe6IedjGOpJf0zwqx2edJ3TrkHTxiGSf930mCT6V/gRlWUnm1KtqvAW3H/7ghJIPYwhs8sql7s8kgj1OevAG5Ehb2gNeOs7Iw19Mjz3TxAnlFtQX7wpD2aWgEBeAcJfPPV99cRLHs5ZazXt8Iw/7bAI7raCMFmyU4+4K/mxSXjs2zcda4v/5VKnfngP4ZGEUWKX/h+QrIzLmLLG4V9OmW7e3xdfW9HmIu9KbKsN0N06o3/r4XMT8DGw6776hpSV80LM5ne10fAAfnPd0AvbmMC/RUoEKSRBR/8mWNGnYGH8dYht+C0QC2kX+vAMPtIz/m6TSDZlLgTcz8GUgP4JGIj5zXjhdX1CXCW1yMmhKf8PlsLIx5pNJscbAxnqNS4plbNfEmd4O6qTUd+1bQPo91NZEyioR6/zQ9Zh+IMTSPwUARjThTUaKygKSP8Z8r6yKnN3BkT3CAuhRKKIrgXQTmglweVw6O9kGOnDxWbR5hABtjW5R3Iw2WjekvdMiNkkGgmYbouLx3+ipbpnqTzBvSgAhxD837q/5oyD1IUU7OCv4zY2eY1msmivWduGij1aSTQ0wzwYFU4Lw8yPmIM7wNPgrqgHF6l7QbmcMBzqOQDYCNCrM+BuGBzYO9clBRtDMrvVSbt2XKP/Ioch8WntekuW4GBkmrRNwQ9+4EoCSk6WtoDp0/uNVvM487NoV29RgjjLU3JqvXYRnVSSNwOq/BzMKCs5eaiHr1kMIqCqEIwcNtpE//CQ7FXlC8Kdid5rFTbqPRzg+5hMfUfnBF3AhVXxOqY1c+EQvlq7fcXpcHeUHKoY9XNiNyf6wxH8j9Th3fInBtSxubFqTksC4zocoLC0a+ZvHanYMZt7zfTeDrAIl7pXMRIs0F42J7bRgTW2vCKIhAShZp0xNkLcIsfMUzGpfu909D/lrjrIugNfn1Pzs8vJIi8hCC A8WvPolb kjy8YFTGncO1Du6QnbV39KlmWsVuRIeMCoSxjL1PPwz4K51dYMbdhwhZcA8imIraX51+5X+JGRlqM2BdBic5ShTSWG+qMXxNQ2N7h+YXQ3AIsvOUBQNdwem7T0BCOR21lRDY5uKxg7a50W6DIuofgyNGI+sBQFh/FdZ4BjIpLCntMlxc7d1PReYeSdxHhrGbRekAws9ciDS90Dfy0jNm0Afgd/u/E6G38nhPAryCxMP+HNTAabTxMl/L3NnAQwt29FwW/JlTax1mWusXnwr1MT7urXdow5TVPriPWYbDmpE+gDcItDvsE2AvaSDjgQPZWria4oEiQApKNJT/Pr7aLaw1G5bDxsB0GFBR4jCrKW2DUCYfZhRWFY+VrHvDg8W1r1ItmTIyHQHiEjqjMEs9E4GNv/Y2YqJpPq9KXDwcN+9tZi6phi0X/3ScTH7tAlXWVgm66N7ytDeqRyhw8VjxACscsTY2e0i4ZTwvLIDAnKiA0AnYVYJwoFsoJPJ/Nv1Aw4UrdSCOr06YJHHij1NIfvbeRsebSnA1GhYwSyweYv6U2nikdcVyivswl4QVIBgJA2fkbK228sAjig3bi/nxDHDQ5TVc2IjFfOzBTR5iSUxvfq+y/svow5LunQ+ke+asA5KNje2m35kV1I6f1I3QOuWDkIeht87YDzspJpfzLwVQA4Ck= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > Hi David, > > David Howells writes: >> When transmitting data, call down into TCP using a single sendmsg with >> MSG_SPLICE_PAGES to indicate that content should be spliced rather than >> performing several sendmsg and sendpage calls to transmit header, data >> pages and trailer. > > This series makes my kernel crash. > > From the current net-next main branch: > > commit 9ae440b8fdd6772b6c007fa3d3766530a09c9045 (HEAD) > Merge: b545a13ca9b2 b848b26c6672 > Author: Jakub Kicinski > Date: Sat Jun 24 15:50:21 2023 -0700 > > Merge branch 'splice-net-switch-over-users-of-sendpage-and-remove-it' > > > Steps to reproduce: > > * connect a remote nvme null block device (nvmet) with 1 IO queue to keep > things simple > * open /dev/nvme0n1 with O_RDWR|O_DIRECT|O_SYNC > * write() a 8k buffer or 4k buffer Most likely this also reproduces with blktests? https://github.com/osandov/blktests simple way to check is to run: nvme_trtype=tcp ./check nvme This runs nvme tests over nvme-tcp. No need for network, disk or anything. It runs both nvme and nvmet over the lo device..