From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EB8DC352A7 for ; Tue, 12 Apr 2022 09:28:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 00F376B0078; Tue, 12 Apr 2022 05:28:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F027F6B007B; Tue, 12 Apr 2022 05:28:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DA3A96B007D; Tue, 12 Apr 2022 05:28:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id CDDE96B0078 for ; Tue, 12 Apr 2022 05:28:21 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id 8984261EE6 for ; Tue, 12 Apr 2022 09:28:21 +0000 (UTC) X-FDA: 79347701202.05.D06D07B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf10.hostedemail.com (Postfix) with ESMTP id 03833C0028 for ; Tue, 12 Apr 2022 09:28:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1649755700; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BPZL0gQJQGj2dxWVcV/vLfhS55E7VF45Sx/T/CMMfLY=; b=LAZoXHEGk98aAFkvqeLIVY42e3ucobC9vj0JC7EGbFnN63qw/e/kDA6QAH3MogWuERgu14 5Oq1B1rLKqboIy3tdthdHMPEI0X/MjrFYUM09Jf3rqmO0/lI76ye8toD1qIOU3fS7BoFJN oJ1lW64jQJZeJBhlLqG7e5EfNH/8YQc= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-652-wo7HVpczMfGUuw6QrxVoxQ-1; Tue, 12 Apr 2022 05:28:17 -0400 X-MC-Unique: wo7HVpczMfGUuw6QrxVoxQ-1 Received: by mail-wm1-f71.google.com with SMTP id i66-20020a1c3b45000000b0038eab4e0feaso3581896wma.9 for ; Tue, 12 Apr 2022 02:28:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=BPZL0gQJQGj2dxWVcV/vLfhS55E7VF45Sx/T/CMMfLY=; b=MvoIFhg7FLs8hrRS0G+PQdjZxidLgf/9AvPqOCUw4RGoL4+i24E/lXeTGOqnHQ/KyS qohqMuHP9sIwsL23xbs4ppO2Oo5Cs2F519R+OccBjNJwlBUhiXIt0i/FnAgSnn/ZO0LI +OnPLJzqv6ZFwenEP9NwFldY3tWB5XBCRldm+IcwfyxZgN3gwIdelicHAC134gEKkXdF UMO0O+AZRtn5MeFoOeNDdi1h604WJGRYvzGRFKmkBbU2FljxOWUa+5Nxnne29xT1Erhu WoH9N6UkKzN4cb4mYi0PAEoHwNHs8Mdgpy8CYAnwM3vkHA2h9/MpSEqoZhogTCC6Hmik VVXA== X-Gm-Message-State: AOAM531oLXpLA5BNEAxu2v7q7aSyamAsT+F73HAo9lM3G9EAh6JM/i4e EsS2Xej/pzQTKM3Tew5akE2LE6M+DGzNsaibG3AQqYNngfdqFYulnfKdfieNlckeWzL4kpVCWD9 0SzsSGS6m1Ck= X-Received: by 2002:a05:600c:2744:b0:38e:b6f7:d548 with SMTP id 4-20020a05600c274400b0038eb6f7d548mr3223449wmw.49.1649755696312; Tue, 12 Apr 2022 02:28:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzPb5RwgNVG0/CMAQXa8th3l2BPON0WeEZdxNgyMhc/eoLviJMQjndKh+kSFR0wgqOPunt1GQ== X-Received: by 2002:a05:600c:2744:b0:38e:b6f7:d548 with SMTP id 4-20020a05600c274400b0038eb6f7d548mr3223398wmw.49.1649755696013; Tue, 12 Apr 2022 02:28:16 -0700 (PDT) Received: from ?IPV6:2003:cb:c707:1800:7c14:16cc:5291:a9f3? (p200300cbc70718007c1416cc5291a9f3.dip0.t-ipconnect.de. [2003:cb:c707:1800:7c14:16cc:5291:a9f3]) by smtp.gmail.com with ESMTPSA id e14-20020a5d6d0e000000b002078ea4f6bdsm13735358wrq.75.2022.04.12.02.28.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Apr 2022 02:28:15 -0700 (PDT) Message-ID: Date: Tue, 12 Apr 2022 11:28:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH v3 09/16] mm/rmap: use page_move_anon_rmap() when reusing a mapped PageAnon() page exclusively To: Vlastimil Babka , linux-kernel@vger.kernel.org Cc: Andrew Morton , Hugh Dickins , Linus Torvalds , David Rientjes , Shakeel Butt , John Hubbard , Jason Gunthorpe , Mike Kravetz , Mike Rapoport , Yang Shi , "Kirill A . Shutemov" , Matthew Wilcox , Jann Horn , Michal Hocko , Nadav Amit , Rik van Riel , Roman Gushchin , Andrea Arcangeli , Peter Xu , Donald Dutile , Christoph Hellwig , Oleg Nesterov , Jan Kara , Liang Zhang , Pedro Gomes , Oded Gabbay , linux-mm@kvack.org References: <20220329160440.193848-1-david@redhat.com> <20220329160440.193848-10-david@redhat.com> <7225391a-5798-94ae-7a01-9a9dd344e13a@suse.cz> From: David Hildenbrand Organization: Red Hat In-Reply-To: <7225391a-5798-94ae-7a01-9a9dd344e13a@suse.cz> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=LAZoXHEG; spf=none (imf10.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Stat-Signature: gzzgpjij5axyhw934rioaigqxm9dfxzw X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 03833C0028 X-HE-Tag: 1649755700-738925 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 12.04.22 11:26, Vlastimil Babka wrote: > On 3/29/22 18:04, David Hildenbrand wrote: >> We want to mark anonymous pages exclusive, and when using >> page_move_anon_rmap() we know that we are the exclusive user, as >> properly documented. This is a preparation for marking anonymous pages >> exclusive in page_move_anon_rmap(). >> >> In both instances, we're holding page lock and are sure that we're the >> exclusive owner (page_count() == 1). hugetlb already properly uses >> page_move_anon_rmap() in the write fault handler. > > Yeah, note that do_wp_page() used to call page_move_anon_rmap() always since > the latter was introduced, until commit 09854ba94c6a ("mm: do_wp_page() > simplification"). Probably not intended. Yeah, it was buried underneath all that reuse_swap_page() complexity. -- Thanks, David / dhildenb