From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8E61C47DAF for ; Thu, 18 Jan 2024 22:14:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 69B546B0078; Thu, 18 Jan 2024 17:14:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6244A6B007B; Thu, 18 Jan 2024 17:14:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4C4CF6B007E; Thu, 18 Jan 2024 17:14:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 386016B0078 for ; Thu, 18 Jan 2024 17:14:22 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id DC29B404FD for ; Thu, 18 Jan 2024 22:14:21 +0000 (UTC) X-FDA: 81693836322.20.39203B1 Received: from gentwo.org (gentwo.org [62.72.0.81]) by imf25.hostedemail.com (Postfix) with ESMTP id 4684FA000F for ; Thu, 18 Jan 2024 22:14:19 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=linux.com (policy=none); spf=softfail (imf25.hostedemail.com: 62.72.0.81 is neither permitted nor denied by domain of cl@linux.com) smtp.mailfrom=cl@linux.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705616059; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KNzMXxvj1PRO1JNAxJ39l4/YUa8pBQvllxzTgn89BZU=; b=Q8vCRS8cdzOhtBblssnCf6krNOcV+g3YD9feJBwaYF9iWDHYlNgSjYz0dMVcgEgTX7cAPC 5FTGYw69OHUTfkJy5ybZ/hJUdivEVpS/XHVXKj/nQPAEF8GkGmvD0Z6979AdOFdmCoI7zi rGL5ykss9X7vaE/16teEtOVjlbXtdPs= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=linux.com (policy=none); spf=softfail (imf25.hostedemail.com: 62.72.0.81 is neither permitted nor denied by domain of cl@linux.com) smtp.mailfrom=cl@linux.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705616059; a=rsa-sha256; cv=none; b=pWC7iXK/WhBipKj4P1FM3IS2GeOmVG8IISmJwyyA2bW8IEcnG6aFCNa7bEfqJHBAtR7a+C aW5Y2SiRToTCRp2X00KTE5yifJKVmpP8946jaAXRcHSLJv5UIgd9mZ7uL6NXc6OXZfw8WU 1mW1kuP/MDSShceENMSCewxhoHs68AI= Received: by gentwo.org (Postfix, from userid 1003) id C879C40AAD; Thu, 18 Jan 2024 14:14:17 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by gentwo.org (Postfix) with ESMTP id C67AA40A82; Thu, 18 Jan 2024 14:14:17 -0800 (PST) Date: Thu, 18 Jan 2024 14:14:17 -0800 (PST) From: "Christoph Lameter (Ampere)" To: Chengming Zhou cc: Hyeonggon Yoo <42.hyeyoo@gmail.com>, Joonsoo Kim , Vlastimil Babka , Pekka Enberg , Andrew Morton , Roman Gushchin , David Rientjes , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] mm/slub: directly load freelist from cpu partial slab in the likely case In-Reply-To: <412b8618-0941-4d9d-85df-ee480695e7f7@bytedance.com> Message-ID: References: <20240117-slab-misc-v1-0-fd1c49ccbe70@bytedance.com> <20240117-slab-misc-v1-1-fd1c49ccbe70@bytedance.com> <76641777-1918-2b29-b6aa-bda9b5467aa3@gentwo.org> <412b8618-0941-4d9d-85df-ee480695e7f7@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed X-Rspamd-Queue-Id: 4684FA000F X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: oxyag6c9ipu3nkn5oecqi3ctzokfgh7x X-HE-Tag: 1705616059-640006 X-HE-Meta: U2FsdGVkX19hVde/Fg7Fbvw+JnT5y5GiBkqIZVLkKgFlbccmq/1+ylhAyceTMYZpd3bJOAXlf3Oks6aR9BHyZ5pzqfkMpnLHYvs1CIIfmWP5q6r5f3MA5fpnVxfp2DIGO2VrYj+NKwJUMXX8FnOI3ozVQwGsgz1TidOSCcLoqpCJclaLUEkPc5TyKwJXIybfbkM2F2NuP2MlN9+Ufs+/uKgS2G40SnP2AQmClNLwtfwaeABDl1nWxna4Ipq7jahnxFuOLIrJkYmfTE/eoIdcxD6+g23b6vtisVs6z5B/+LuAwhapl/40nbDGRhk3KCygRXGSZfCamLgKFJv898fEM+kkFMMchTNa+RMJ/uSNvRgKNKBnPcP7vHU8oWa2k9eT9ft9O8y/nIFU7gvHQ+zBiCkYayuNj+Zl7vXylnom7WkCs6XS7dvEMGsOYIpYppce02cPbU3V7MSbIdQ4e/YfSvghfmPUPTL4jyn5WsvfSytpQsDDIOeiI1wjkYHQ7kA1AeNaN41AdKlcAiVdT/6Id9Pki7c3jDkaxMssPQwLtnT2QT7YPMYRh7QkmMh++IFjyt1Xs4iByN9oAJfQVdNWDd5kxzG8/eRrE0glqkqZ9zC3OtD/mA3xWl01n1Et1mj4Yyo9Q0/dD3Mp2VPav91heMN5Zs5P9lSkrAc7/yUHlYonMBjinXk6Re6zJ7pjoXorEZ1eEzslj8GNnmWsF2i7KLHP0VqfwLTmGqWsdwJsue1BpNjxfNPHpUyog1IzTyLvkv35msy893zJWztF5BVqgIO7CqpzOWLbzuSIXNwps+csi1QAtXAn5RoR9qaqL3YuEbRKzIN9Uk/f8jUEc0AJiZj2D5N/pweHHZ8vOH8OZkRqjBS6ptw26ZvpjhzNApWUNoeTylgnyEOye0cTk5vEvuucwx7rHma0X666fGae/KfcD0yMgcValGes/i3FopVelBsZY8XgpXKCwU1FnYJ PTzpK3NT YhXp3h5BbhVdWhLl5Ud7q4A2PNLEaIN2/CE6LIes2ppO2aM7VGfUxKD4j6JTClsGxUob+/pXO4ZnJBahvJ2O/nuni5hpDomeUpz1DmtcRhKXF02yG/rc/xwiO6QD0wOrYPtE3vjqSENtd63wgdqEu0OMZmCc8nMElZqsS57D3yUCzvuE1nYk8t1iPUwPxmViklOTGm+3uIiEkGVo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 18 Jan 2024, Chengming Zhou wrote: > So get_freelist() has two cases to handle: cpu slab and cpu partial list slab. > The latter is NOT frozen, so need to remove "VM_BUG_ON(!new.frozen)" from it. Right so keep the check if it is the former?