From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D4C7C67861 for ; Fri, 5 Apr 2024 07:28:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AFB026B00B7; Fri, 5 Apr 2024 03:28:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A82BE6B00B4; Fri, 5 Apr 2024 03:28:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8FAA56B00B6; Fri, 5 Apr 2024 03:28:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 6E8306B00B1 for ; Fri, 5 Apr 2024 03:28:39 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 24FAC12084C for ; Fri, 5 Apr 2024 07:28:39 +0000 (UTC) X-FDA: 81974650758.25.707304C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf16.hostedemail.com (Postfix) with ESMTP id E1E90180015 for ; Fri, 5 Apr 2024 07:28:36 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=G2ay7Q47; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712302116; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=82z78k3qbBNXb5WziufgS3SHGhfcfQ7Rm3h2BYxo3yc=; b=N43GKc4GaFgcuck4efxMU/0cqorcY5ZbblJHow69VG5htX/iLtBS55QXYP5dDGoD2CA6Cu BlqrzWN+lIAn0Dz0bbf6ucpIssqunAjgUL+k2D0i7A0Xc9/zVOO5pVeaU1QpQj7aXFeEuJ FpxjjdLLr8XJdZFI9kft9avX528HUG8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712302116; a=rsa-sha256; cv=none; b=U9fazXczEOTHzY5JzWXZc54I1QQ3vAdrAUIRXYslbFGclrf4esB+/eOusNMMdAulAhs6YC IfBIbpk4wOwgKzV7++L5fa2+W11Ga6xn4czzOnQ82Petv9WYSL11usUP2jBJLwbU12WKmU 19cqC7vvamFBdZ35kR6ezhlfreYktjM= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=G2ay7Q47; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712302116; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=82z78k3qbBNXb5WziufgS3SHGhfcfQ7Rm3h2BYxo3yc=; b=G2ay7Q47QB4AYBQSH4doqvQi3ZyGYeDI1BNFZZXcE0BR2hAvtTJgnzGyGj9Qpk4HWdf7Hh 6psLYFwBpFrXjfVzsHkfa7pJCQnIbBTo75S4ofZVODmoeWX9u9990XnWF6yCa43xwC2OdM byT4cFMbkswh/W1Hnp244LtCylHiz58= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-28-VFt8t4BrNvmaa7R325GppQ-1; Fri, 05 Apr 2024 03:28:34 -0400 X-MC-Unique: VFt8t4BrNvmaa7R325GppQ-1 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2d818a149bbso15322881fa.3 for ; Fri, 05 Apr 2024 00:28:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712302113; x=1712906913; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=82z78k3qbBNXb5WziufgS3SHGhfcfQ7Rm3h2BYxo3yc=; b=FdO5N/ArohAW4lwgyeQ09imDxRjvlqC8Eu/+iwj5Z5IuKMza6dnaPtY0MNKvRaqDWd S5wVdmMRp20fBUDtTQAFCEtyHiDODoHR7cHENNe1amnFTG7MOGLKMHT4K614KZjD+4rb diGguIxUbnyFMyqELSjkNZqT5+LN6fYOKlRdStr2as+E94zf1U9L5qjtDXsxr+80E1aQ jx8uEHspNrNB3lmBp1uq2Py3QceN2VBVHZd+2ew9XqKxDcP4KFFbHajf4OPWxmY/kWj5 pfm7OSq/XWkyqx0527DQH73BzQ2kbeoNOwgtYEnPbbMFM5e4iJx0N4dJLHJmCEk6XJrD DAlQ== X-Forwarded-Encrypted: i=1; AJvYcCXftGrviNz5yv/qXm1NlsXQZQMNdp4n1K2zpwAr+KYwAewQGOUtf7/7x6K4AUSGVfPlDGwYZ8c60xEAyTFlcEbieig= X-Gm-Message-State: AOJu0YxlG3TZrJPH9+DYTix45MM3eSIZoPPlNJN8dXT3H9xeD0H6iJSt XX0FJtskpjd9smkn538jGBbOnyEWHCzrfWq6OWcf9oojEVgkSqN8yvkSRIbzQ+tkqXlWdqc1isC Pr021WeWa5nmU+0VccsYKrSz3iyEiIb1U2RYI6ydtaB4WRlRK X-Received: by 2002:a2e:8958:0:b0:2d2:4783:872a with SMTP id b24-20020a2e8958000000b002d24783872amr591993ljk.29.1712302113203; Fri, 05 Apr 2024 00:28:33 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHxRT4V7Z+YFyaty0n7nO97PULTc5vJFcQU4EWZVLOkXFwVFzyC1ZQsiOhRX2Blhk7uWNk3gA== X-Received: by 2002:a2e:8958:0:b0:2d2:4783:872a with SMTP id b24-20020a2e8958000000b002d24783872amr591977ljk.29.1712302112661; Fri, 05 Apr 2024 00:28:32 -0700 (PDT) Received: from [192.168.3.108] (p4ff2306b.dip0.t-ipconnect.de. [79.242.48.107]) by smtp.gmail.com with ESMTPSA id j10-20020a05600c488a00b004161ea7ed6dsm5266303wmp.38.2024.04.05.00.28.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Apr 2024 00:28:32 -0700 (PDT) Message-ID: Date: Fri, 5 Apr 2024 09:28:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 06/14] mm/ksm: use ksm_get_folio in scan_get_next_rmap_item To: alexs@kernel.org, Matthew Wilcox , Andrea Arcangeli , Izik Eidus , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, ryncsn@gmail.com Cc: Hugh Dickins , Chris Wright References: <20240325124904.398913-1-alexs@kernel.org> <20240325124904.398913-7-alexs@kernel.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240325124904.398913-7-alexs@kernel.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: E1E90180015 X-Rspam-User: X-Stat-Signature: ep9yy5nqfyeahdp9yy4bnk1rjnewnso9 X-Rspamd-Server: rspam03 X-HE-Tag: 1712302116-23303 X-HE-Meta: U2FsdGVkX1+xjKo2F9sntBDzZoijnTd9Az7vK1XoIjbhL+jeZ7mEZZaDf2mOWOK1rgVYlUQMQqQsZYxw+ezn7JuZZJ/GNR7pLLl2xnNcmC9q3SMoj/GsHuwKz00xQrKpXiEWisuoMIT483ycnLyY6oIjZcjaHIVgp9JC6VgaZgGt0//0R7PwzA6ZrUdz4vuCd4en1iTniPBLUexVbHaBm+xf0NTVwV84jr31g2Qso39xQECZezbqbF2liM3kt5o8F0lBTN8FpNI/Acyvnmf+U17CHxEeAeRiD5y1tP3JptNqxFjl+1o88nCv+7W1Apq8gIBO6NPMt1WvDkkOQypobV3g0Bp61xAjggNdbXIw9A3Opu+F8UgYi6bKBeGiL1y05bEroHaIz7MsMV3HbT4iTw+oKzXbyav5ge64+38P1rZLOK2hLIgCg0pAkUmg/EiZFq/9KtYEnEntY3GRXgTEaHfAbKP/a3k9Wozwm/2DDm0uPXISjd4YT81k46An65yjEV0JtO5HB7VrrYCcgdzpl/DHwAa0INO8TwzsSnQzztJdfPy8Yq315JGk42FcrhgcKH8gCU7BOUXs7Cs4/eIYjptUMc2aCG5tm4WFLkT+1Xa2hKdSAFxJnd4B2uCQ1uOf+Q6iSbK7KENINZ4kZx124R2MWGFm2h1fSgqyDbYnMeU83P7eqN8SC1wVnyF8JNGB4xJudIHfc3d0WM48+cY5ZZMDxw49zfMQbCM90I797y5ZchInM+hTjWemSRSr1VkgxZ97WB9vF0SPvbga4D6lxVLM3sMPh46+178F5E+zZg19mnZJVzbxUAlhgsn26aX4kurfOD0JndjHM7VdNApd1mqVsdGKYwNOsn6kk06Qir19wx3mCgAM1mpe2Xqtn11Cl/u5N+FdOJWPchvhlPGRpnwURLSgt8U6aJrWaSDpGM22dXd6rJBv1OnYUyq1ajQZZE8dKA1SVY9ivxD1fWf fVAxuEFp 81Vc2fs34k9IKQjWcdP8ZiCjiIMMwkkj3HnR2qhq+loxA0HfaM8rRnmIjPIFoOZ0oX69nsyE2LVtJTjWG6i0RV15xm3XgS2BqUuZ1l619CPTdA8ydfZ++iItYFHbsaIAg9WOI/zzkZASRRVamcNkGbnI9cxIMpyD8egp5XbZL7zUyc4k9R5OasvfU0UYpL5wX5MMhBiWWECbSfCWipjZi7JNHtrKAZErPvd60+IAHgEPDxCbgRyD61/b/vYmikUO3CAPV16LjWwLzSrRujixNr+LsLwyugBLztqnaDUeg4ioih1FrggPCm4VNHG8EYgTR7Q+7zzZj9Mz4+mg445sg915DDwksqa10pDTro6+6ftAc0TcElY5utqspAWSSgl9jp1QTNVg97NWkPj1pBM71YIoJmg40fyaoQXp/X9qqH2cQpgog9L8wfumKk1gQwooOeNDzuuTA/VMkEB2SghBO6OElrBfdS8fB/JTPLWV405xIrMvJrhmY9ORKC/+Sl0ypFRpgNS1P6TzdiVbgK/Zi7u1wRcvqbZYrYfyABpeqPhelf2fszeD3oYiGqyo7s0L4M7USKawMg10BgG6yVeO6ma/Sz9nx/bCThi1SiPkPa3I7CpTsQrqxpbJieDEyWxXEuODKRLUmSSK49uz4TC5XP0d3bloZotl983EV0XJMJGlSt9YcvBqNGCJOupXSYoUxHJVzoQxSqGAI3mu42ZwInMLNoH6OCzN6V8dxKaXRRionL3Q7q7lLZoggmK4boc8dDrAkiE6nVB8a/5E= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 25.03.24 13:48, alexs@kernel.org wrote: > From: "Alex Shi (tencent)" > > Save a compound calls. > > Signed-off-by: Alex Shi (tencent) > Cc: Izik Eidus > Cc: Matthew Wilcox > Cc: Andrea Arcangeli > Cc: Hugh Dickins > Cc: Chris Wright > --- > mm/ksm.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/mm/ksm.c b/mm/ksm.c > index aa80fbf3a8e0..95a487a21eed 100644 > --- a/mm/ksm.c > +++ b/mm/ksm.c > @@ -2611,14 +2611,14 @@ static struct ksm_rmap_item *scan_get_next_rmap_item(struct page **page) > */ > if (!ksm_merge_across_nodes) { > struct ksm_stable_node *stable_node, *next; > - struct page *page; > + struct folio *folio; > > list_for_each_entry_safe(stable_node, next, > &migrate_nodes, list) { > - page = get_ksm_page(stable_node, > - GET_KSM_PAGE_NOLOCK); > - if (page) > - put_page(page); > + folio = ksm_get_folio(stable_node, > + GET_KSM_PAGE_NOLOCK); > + if (folio) > + folio_put(folio); > cond_resched(); > } > } Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb