Re: [Patch v3 4/4] mm/huge_memory: optimize old_order derivation during folio splitting

[David Hildenbrand <david@redhat.com>]

On 21.10.25 23:21, Wei Yang wrote:
> Folio splitting requires both the folio's original order (@old_order)
> and the new target order (@split_order).
> 
> In the current implementation, @old_order is repeatedly retrieved using
> folio_order().
> 
> However, for every iteration after the first, the folio being split is
> the result of the previous split, meaning its order is already known to
> be equal to the previous iteration's @split_order.
> 
> This commit optimizes the logic:
> 
>    * Instead of calling folio_order(), we now set @old_order directly to
>      the value of @split_order from the previous iteration.
> 
> This change avoids unnecessary function calls and simplifies the loop
> setup.
> 
> Also it removes a check for non-existent case, since for uniform
> splitting we only do split when @split_order == @new_order.
> 
> Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
> Cc: Zi Yan <ziy@nvidia.com>
> Cc: wang lian <lianux.mm@gmail.com>
> ---

Acked-by: David Hildenbrand <david@redhat.com>

-- 
Cheers

David / dhildenb