From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC1F1C48260 for ; Fri, 16 Feb 2024 16:52:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 55C9E8D0007; Fri, 16 Feb 2024 11:52:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 50B668D0002; Fri, 16 Feb 2024 11:52:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3D3678D0007; Fri, 16 Feb 2024 11:52:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 2CB478D0002 for ; Fri, 16 Feb 2024 11:52:40 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id ECC9D8017D for ; Fri, 16 Feb 2024 16:52:39 +0000 (UTC) X-FDA: 81798260838.14.BA3CD96 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf11.hostedemail.com (Postfix) with ESMTP id 6FF9040013 for ; Fri, 16 Feb 2024 16:52:37 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=gfwPmBXr; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=5f+K6CWT; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=gfwPmBXr; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=5f+K6CWT; dmarc=none; spf=pass (imf11.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708102358; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bjFfGHq1FbZX5RctuoEE2JMZaFbk7fCFrSUdFxCZeQM=; b=UgIcjXnAd70l3HrMLXRqx3W0wcgK7MBren6fIarCb4T7JcWmPfQaREL1gwtLQDR2cxYDse BX4GZlibe9+o31uTNgfgIQNgIyQ3WJCFr97vqzNTXpcjOdSKGP2r6d7NGvYl5z0KqnaVcU A9PaaJD+gCnaEdtuCOv5VQGgxLymHGI= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=gfwPmBXr; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=5f+K6CWT; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=gfwPmBXr; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=5f+K6CWT; dmarc=none; spf=pass (imf11.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708102358; a=rsa-sha256; cv=none; b=CBO//DG6xPRLxikCVHxNd9rILO5zCgt86sRus45RDfEVQNFELgTEFJ3G+ARknKD9ur+I2F +kG0HHMGviEyC4STWC3iFxfaRYU1P90jOF/ywRASBwSAaMjGrrGIu1AI8mGpWgsA2PjJe0 4yCTyZC/ukdOoRqZLOTHqaiQpnH1T2k= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 19EED1FB73; Fri, 16 Feb 2024 16:52:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1708102355; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bjFfGHq1FbZX5RctuoEE2JMZaFbk7fCFrSUdFxCZeQM=; b=gfwPmBXrOQkJAnTdNzEhnp/agnnibHhiJyUDTlS4Yi2VTrb3IA69570I2qH2Dq9w9OCfye yxYnEP6Hf7Oajb/o/H05S6+hQ2i066X961IWR6LbLJpDuXhvlbopXi1xyNUt+JxndXS1DO d8CrJL6LkZAY2JIdSC+pPSU1KutC/Mo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1708102355; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bjFfGHq1FbZX5RctuoEE2JMZaFbk7fCFrSUdFxCZeQM=; b=5f+K6CWTzCWeRCrTYtcPXe4eP2DBGf5KgTKiEmuqzNp5dQdmJ2kvIE73z2E2Dv5//S9pZn 3WOa8WiEGgu+8kCw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1708102355; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bjFfGHq1FbZX5RctuoEE2JMZaFbk7fCFrSUdFxCZeQM=; b=gfwPmBXrOQkJAnTdNzEhnp/agnnibHhiJyUDTlS4Yi2VTrb3IA69570I2qH2Dq9w9OCfye yxYnEP6Hf7Oajb/o/H05S6+hQ2i066X961IWR6LbLJpDuXhvlbopXi1xyNUt+JxndXS1DO d8CrJL6LkZAY2JIdSC+pPSU1KutC/Mo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1708102355; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bjFfGHq1FbZX5RctuoEE2JMZaFbk7fCFrSUdFxCZeQM=; b=5f+K6CWTzCWeRCrTYtcPXe4eP2DBGf5KgTKiEmuqzNp5dQdmJ2kvIE73z2E2Dv5//S9pZn 3WOa8WiEGgu+8kCw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 7C8D71398D; Fri, 16 Feb 2024 16:52:34 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id rjARHtKSz2X4VAAAD6G6ig (envelope-from ); Fri, 16 Feb 2024 16:52:34 +0000 Message-ID: Date: Fri, 16 Feb 2024 17:52:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 22/35] mm/slab: enable slab allocation tagging for kmalloc and friends Content-Language: en-US To: Suren Baghdasaryan , akpm@linux-foundation.org Cc: kent.overstreet@linux.dev, mhocko@suse.com, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org References: <20240212213922.783301-1-surenb@google.com> <20240212213922.783301-23-surenb@google.com> From: Vlastimil Babka In-Reply-To: <20240212213922.783301-23-surenb@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 6FF9040013 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 1h669mds4j8hgagrkbsrcbc4w3qe3zq1 X-HE-Tag: 1708102357-843830 X-HE-Meta: U2FsdGVkX1+h8ZRpCDj9keJTvjWYGu0PmUU+k6IwohtPkaBca0mFvrl+wwYesm1elVgXmP8CKOSsWHT4ii+EBA60R6Y0+fush3nNspHABPoHO6i1KGQZX+eb8f7xA8momv0qLcMNVRnqB6SX6nh7kyq7j4A9e/p/LZ10rdIBBmEd3v9nivnygojd4pO45gZXrz/uKOJrkWvYflkB4iPozdx8ksOgkL9BvoD1VjvLLmqgi/WGYKPE+6bTTLK5GP8YyGEOLWwnFAzb7h3YX6VcJUig1w7aI35qKQGpH02rL5z68MQHJUZQMmJhWqk1cSVj1AvzzxHsOxaaPhtwY9TpQQsZL2I68705NvsQ5ZCGrb/e5oj+fAQ2DccfAYNBiOgz6xt1WP4BpA/ckVxW+I6+S8pOnD6ofYUu0v2DgxvxpNJyargchaz48uHw2cc9ilFEKnRChBUpxAyQR/PjELgpds4NY5uXQp9sa6gzJR1tx9jN8iJBqG+24cj0Z055rVJyzJrZyP8xczieb8JmzUp+HpBqYdbcDzvNLrxlZjVaqeD9FEKRCjcAJgMqfZB8M+J6VmugylV4MURMzA7s4QqwE6WZKxaxEgJQ+PZi2i3M4MKLVfeNCOmgmxy8I6jHKPV//SDgeJ9fum31OtfJivLwGoWhhq9nMouEIzoKKoHn1dMfq4x2BmWN4d0Jc9paphScNJRne4H0q9qBL7iU9gERfOfbN1PtN7gLyVp7LXaPmsDngNKE2ezX1z/OYyLejBs1gJiq7P0wPXn0L77H9i6Ad+7EYYcLRh/5WZeKINjK2PhJdliQyL5m2XHwZp1zfSnnRnVbDU+/DQUh+bu/JtCHIBdHLakEqAh2QlEM15SEGbprsWjtoCOvY390luqFRIftAvniKPw17lkUAo+tSv7BiEnYN76UmhJfPy/FEDmYbvoECywpY0m0EK6NiIQiw0bSXERs+wiH7WB9y5CvF/4 CiY9BANV fXuVquzLXTPo9OcNlZPc4eMgc32Km8ROcrTbhchUkMRPGADdgYxGJux9jbE8zMI+GryGxvn6nvdTemHayZO3UYptUm16rBNZHtdArwvy06MfvrQbBEHXnZLEKrLlm9VhVQvm/9JufeQs/Ui5JY8aJpTPmCgnjMlr5LZCiS6x5Wi2ujO9Tltc4QkJ22+hZwOmojVWG6AiNMMGFUsCn9hgGM/zZJ//xtY1wFWilGknbpAcFd6Q/lhuwnfuKs86/oN+7Z0wNSNC7D7agRwF+zL31h4HImOmnE07NWFF9Mi4Z5kB7iFcm61AsJbdYfB8IX9TUL/eN4BW3wdO5qb9+JmI3an6J0VcvVpReKItrIJoJJdAfqTE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/12/24 22:39, Suren Baghdasaryan wrote: > Redefine kmalloc, krealloc, kzalloc, kcalloc, etc. to record allocations > and deallocations done by these functions. > > Signed-off-by: Suren Baghdasaryan > Co-developed-by: Kent Overstreet > Signed-off-by: Kent Overstreet > -} > +#define kvmalloc(_size, _flags) kvmalloc_node(_size, _flags, NUMA_NO_NODE) > +#define kvzalloc(_size, _flags) kvmalloc(_size, _flags|__GFP_ZERO) > > -static inline __alloc_size(1, 2) void *kvmalloc_array(size_t n, size_t size, gfp_t flags) This has __alloc_size(1, 2) > -{ > - size_t bytes; > - > - if (unlikely(check_mul_overflow(n, size, &bytes))) > - return NULL; > +#define kvzalloc_node(_size, _flags, _node) kvmalloc_node(_size, _flags|__GFP_ZERO, _node) > > - return kvmalloc(bytes, flags); > -} > +#define kvmalloc_array(_n, _size, _flags) \ > +({ \ > + size_t _bytes; \ > + \ > + !check_mul_overflow(_n, _size, &_bytes) ? kvmalloc(_bytes, _flags) : NULL; \ > +}) But with the calculation now done in a macro, that's gone? > -static inline __alloc_size(1, 2) void *kvcalloc(size_t n, size_t size, gfp_t flags) Same here... > -{ > - return kvmalloc_array(n, size, flags | __GFP_ZERO); > -} > +#define kvcalloc(_n, _size, _flags) kvmalloc_array(_n, _size, _flags|__GFP_ZERO) ... transitively? But that's for Kees to review, I'm just not sure if he missed it or it's fine.