From: Andrea Righi <righi.andrea@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org,
linux-kernel@vger.kernel.org,
Geert Uytterhoeven <geert@linux-m68k.org>,
Roman Zippel <zippel@linux-m68k.org>,
David Howells <dhowells@redhat.com>,
Hirokazu Takata <takata@linux-m32r.org>
Subject: Re: [PATCH -mmotm] mm: unify some pmd_*() functions
Date: Wed, 28 Jan 2009 18:59:37 +0100 [thread overview]
Message-ID: <a2776ec50901280959l6f96d2e0g72ce5eed665894a7@mail.gmail.com> (raw)
In-Reply-To: <20090127174158.519e5abd.akpm@linux-foundation.org>
On Wed, Jan 28, 2009 at 2:41 AM, Andrew Morton
<akpm@linux-foundation.org> wrote:
> On Sun, 25 Jan 2009 22:35:37 +0100
> Andrea Righi <righi.andrea@gmail.com> wrote:
>
>> diff --git a/include/asm-generic/pgtable-nopmd.h b/include/asm-generic/pgtable-nopmd.h
>> index a7cdc48..b132d69 100644
>> --- a/include/asm-generic/pgtable-nopmd.h
>> +++ b/include/asm-generic/pgtable-nopmd.h
>> @@ -4,6 +4,7 @@
>> #ifndef __ASSEMBLY__
>>
>> #include <asm-generic/pgtable-nopud.h>
>> +#include <asm/bug.h>
>>
>> struct mm_struct;
>>
>
> Why not include the preferred <linux/bug.h>?
Using linux/bug.h leads to include hell (i.e. on x86 with
CONFIG_X86_PAE not set):
...
CC arch/x86/kernel/asm-offsets.s
In file included from include/linux/thread_info.h:55,
from include/linux/preempt.h:9,
from include/linux/spinlock.h:50,
from include/linux/seqlock.h:29,
from include/linux/time.h:8,
from include/linux/stat.h:60,
from include/linux/module.h:10,
from include/linux/bug.h:4,
from include/asm-generic/pgtable-nopmd.h:7,
from
/home/arighi/Software/linux/mmotm/arch/x86/include/asm/page.h:132,
from
/home/arighi/Software/linux/mmotm/arch/x86/include/asm/processor.h:18,
from
/home/arighi/Software/linux/mmotm/arch/x86/include/asm/atomic_32.h:6,
from
/home/arighi/Software/linux/mmotm/arch/x86/include/asm/atomic.h:2,
from include/linux/crypto.h:20,
from arch/x86/kernel/asm-offsets_32.c:7,
from arch/x86/kernel/asm-offsets.c:2:
/home/arighi/Software/linux/mmotm/arch/x86/include/asm/thread_info.h:34:
error: expected specifier-qualifier-list before 'mm_segment_t'
...
-Andrea
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-01-28 17:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-25 21:35 [PATCH -mmotm] mm: unify some pmd_*() functions Andrea Righi
2009-01-25 21:39 ` Andrea Righi
2009-01-28 1:41 ` Andrew Morton
2009-01-28 17:59 ` Andrea Righi [this message]
2009-01-29 20:02 ` Geert Uytterhoeven
2009-02-09 17:06 ` David Howells
2009-02-10 13:41 ` Andrea Righi
2009-02-11 10:16 ` Martin Schwidefsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2776ec50901280959l6f96d2e0g72ce5eed665894a7@mail.gmail.com \
--to=righi.andrea@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=geert@linux-m68k.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=takata@linux-m32r.org \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).