From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D63D3C43334 for ; Fri, 17 Jun 2022 10:14:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 625C26B0071; Fri, 17 Jun 2022 06:14:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5D5496B0073; Fri, 17 Jun 2022 06:14:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 475B66B0074; Fri, 17 Jun 2022 06:14:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 35CB76B0071 for ; Fri, 17 Jun 2022 06:14:20 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 03AD135B66 for ; Fri, 17 Jun 2022 10:14:19 +0000 (UTC) X-FDA: 79587317880.09.8C40B10 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf28.hostedemail.com (Postfix) with ESMTP id 5B5ABC0095 for ; Fri, 17 Jun 2022 10:14:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1655460854; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OO/vzqKXxtmhmREmRXYJJgBI7tFlamAdTQoTX2eqNDk=; b=aUBT2A5noIxfR6SmvAw+exjocNmiuA0OiH85qDaG9+I3QqXArU3NcZtZOxYF4d5Nf6b3Zo 4507nRXQLQ/1dq3wdpagWRp6hm9qqzsg+jfHvu0ljiU46Gk4RF5RZ8NbGpPyeqxExiXAH+ Al0coZz7bBIrCO5DYBJ9DQr9hNIfrZ8= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-437-CHmVJbTHNu25KvAEYUmlZw-1; Fri, 17 Jun 2022 06:14:05 -0400 X-MC-Unique: CHmVJbTHNu25KvAEYUmlZw-1 Received: by mail-wm1-f70.google.com with SMTP id be12-20020a05600c1e8c00b0039c506b52a4so3559478wmb.1 for ; Fri, 17 Jun 2022 03:14:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent :content-language:to:cc:references:from:organization:subject :in-reply-to:content-transfer-encoding; bh=OO/vzqKXxtmhmREmRXYJJgBI7tFlamAdTQoTX2eqNDk=; b=RnjLHABS+PnEC6TSZ0qwO7FfID+jaH7FwJhx396vnbHpfqbq3BKJpAPZal3RuoU1eQ Ln3jyy4k46BRNFhxf/aSi48HEBEjJfNLdR7nkJcR9tW3LU5ZPxPYZraK6OTKCwEc2Vbl 7IPt7a+ghornwvZFHr7aNDOLxygZRHodFP95D0+lSJoO9pztOBmoYjaPzPil+2uEj6mY mqUrFr4c3U3PfYYnrTb6p97IUT4je/l+NPgG9oRRYokH66pd+1g4BoXgENMa6h/pOisv 56x2ZN20PNP130VFjnSkPEUdYCUvEpksUlkZE8dL3XFBNIbZW6wvakUThyIBL0KBfoQH vM2g== X-Gm-Message-State: AOAM530f9YROkJJpezKW2777Oul4rWjhPfCVZLuSd5OCyTgoJGve6fJR F520OWmeK0Xmja1c06D7EjPGTZ+XeeVRQPOexDEYC4updtPgaBPXUHjc+1M4Jqae8090Ms5K763 hyeWWugX6Q1Y= X-Received: by 2002:a05:600c:4f47:b0:39c:62cc:75da with SMTP id m7-20020a05600c4f4700b0039c62cc75damr20098277wmq.114.1655460843748; Fri, 17 Jun 2022 03:14:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyAqCbokM4EypDJ6RFBar89VSpzcIn9BxE48MuTqUwN0XUnXRQ8aU829NJZHCJkS0ZFmCCu7w== X-Received: by 2002:a05:600c:4f47:b0:39c:62cc:75da with SMTP id m7-20020a05600c4f4700b0039c62cc75damr20098249wmq.114.1655460843470; Fri, 17 Jun 2022 03:14:03 -0700 (PDT) Received: from ?IPV6:2003:cb:c70a:7e00:bb5b:b526:5b76:5824? (p200300cbc70a7e00bb5bb5265b765824.dip0.t-ipconnect.de. [2003:cb:c70a:7e00:bb5b:b526:5b76:5824]) by smtp.gmail.com with ESMTPSA id q17-20020a056000137100b002183ee5c0c5sm4276786wrz.50.2022.06.17.03.14.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Jun 2022 03:14:02 -0700 (PDT) Message-ID: Date: Fri, 17 Jun 2022 12:14:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 To: Oscar Salvador Cc: Muchun Song , corbet@lwn.net, akpm@linux-foundation.org, paulmck@kernel.org, mike.kravetz@oracle.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, duanxiongchun@bytedance.com, smuchun@gmail.com References: <20220520025538.21144-1-songmuchun@bytedance.com> <20220520025538.21144-3-songmuchun@bytedance.com> <53024884-0182-df5f-9ca2-00652c64ce36@redhat.com> <24d5ec20-9c9e-93aa-11f4-c4619f51f7d1@redhat.com> <186924ab-651f-71a1-93d2-3500a67dffee@redhat.com> From: David Hildenbrand Organization: Red Hat Subject: Re: [PATCH v2 2/2] mm: memory_hotplug: introduce SECTION_CANNOT_OPTIMIZE_VMEMMAP In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655460859; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OO/vzqKXxtmhmREmRXYJJgBI7tFlamAdTQoTX2eqNDk=; b=Bd7GKfUUBxvEiidcCrpf0ngjVSLH6FP1x8+ZqTpgIkC2sKhuHZMiqgEBH7OjVmz3CjNMcy sSZfADiQMU1f4JwQ55iGrIHA6mR8mzVi2mIP8L48dPkKTr7MCcI4NpQdVnTrRaw+BP0Zxx 6USIQemERBmq1oNCAgvbG4TTHfRJDqo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655460859; a=rsa-sha256; cv=none; b=EvAp5m6+SASpAHzMm+XAD0UAcKTzl2sOtPHlgzQq6Nr3hlRlvX6KgGNpY1JPcilgwF/KYW tvHdK90sZcZy3IA+OsCisuWE2IkkHpnzVqYhdN/K3XDxaV6lPg+4BSqOfI3VKE4rC9z2+f S0mdj+6hdLvv/6J/GJU8uiBU5C5MEs4= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=aUBT2A5n; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf28.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=aUBT2A5n; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf28.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com X-Rspamd-Server: rspam12 X-Rspam-User: X-Stat-Signature: 7txhb9aharz9m8dcrb51m8beiwzczhkb X-Rspamd-Queue-Id: 5B5ABC0095 X-HE-Tag: 1655460859-969622 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 17.06.22 11:54, Oscar Salvador wrote: > On Fri, Jun 17, 2022 at 09:43:33AM +0200, David Hildenbrand wrote: >> VmemmapSelfHosted, then the function names get nicer. > > Definitely. > >> >>> +#endif >>> + >>> /* >>> * On an anonymous page mapped into a user virtual memory area, >>> * page->mapping points to its anon_vma, not to a struct address_space; >>> diff --git a/mm/hugetlb_vmemmap.c b/mm/hugetlb_vmemmap.c >>> index 1089ea8a9c98..e2de7ed27e9e 100644 >>> --- a/mm/hugetlb_vmemmap.c >>> +++ b/mm/hugetlb_vmemmap.c >>> @@ -101,6 +101,14 @@ void hugetlb_vmemmap_free(struct hstate *h, struct page *head) >>> { >>> unsigned long vmemmap_addr = (unsigned long)head; >>> unsigned long vmemmap_end, vmemmap_reuse, vmemmap_pages; >>> + struct mem_section *ms = __pfn_to_section(page_to_pfn(head)); >>> + struct page *memmap; >>> + >>> + memmap = sparse_decode_mem_map(ms->section_mem_map, >>> + pfn_to_section_nr(page_to_pfn(head))); >> >> Why can't we check the head page directly? Either I need more coffee or >> this can be simplified. > > Uhm, maybe I'm the one who needs coffe here but we have something like: > > [ hot-plugges section ] > [memmap pages][normal pages] Oh, right, we need the memmap for our hugetlb page (which resides in the reserved section), but these are not marked. We need the memmap of that memmap. I assume one could directly via the page address. Because we want the memmap of the memmap. vmmemmap_page = virt_to_page(head); Not sure, though, if that would work with that function. -- Thanks, David / dhildenb