From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25640C3ABAD for ; Fri, 2 May 2025 15:31:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E40DD6B0096; Fri, 2 May 2025 11:31:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DEE726B0098; Fri, 2 May 2025 11:31:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C906B6B0099; Fri, 2 May 2025 11:31:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A8C966B0096 for ; Fri, 2 May 2025 11:31:54 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id B7AA8141A37 for ; Fri, 2 May 2025 15:31:54 +0000 (UTC) X-FDA: 83398358148.02.262658F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf24.hostedemail.com (Postfix) with ESMTP id 2D631180007 for ; Fri, 2 May 2025 15:31:52 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gyKSWKOq; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746199912; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jM8M6akj52fCQHHjXX1/nsZvwbcymr7x1EGpLLdZdRo=; b=ED7GROqvp91wH/2gsRtmrdyoKgrwAz8rbfle8a10PM6ZVnB71I6w6TcESlRzzyNaUvqQmh kXC6q8FUFZUd8PaC/46JAfn0ycYiCxuDZ6Ba4LLkDxH7bt5rSTeont5Yzdo8O7lbzAe+3w mZ2FRigFyCrVVhWHtPJUc8jo828ftoc= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gyKSWKOq; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746199912; a=rsa-sha256; cv=none; b=OsiGSKyu3j4pBmRa/NTUtRK1F1vv5WCXdXM26ZcS4dE9hClTZ0D1+XuF3fT7YhPd6R5FA/ p57/ysZdKT1jeWBeK+S2Vc62qPHYzPCJ40ZDfh/2nbwx/3z9ff4EM73+Te6rx+AONBCNg/ vfjQuynAVyoZJUxkhNRVOAA2+vYLg0M= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1746199911; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=jM8M6akj52fCQHHjXX1/nsZvwbcymr7x1EGpLLdZdRo=; b=gyKSWKOqP4uLnebtLqw1aFbxEhh1XEYr5QoKpoPiCkik3lZgmbS6cyJw5Bf7WyDVDDHC3v o6bML0BgKm8KLksdkehSZI3UGOYlLkS+T/m3FhBsPK9AHOJh+A7c9c+RFyAk12EdyC8QJS k03MfQcVl5C9NmlPkAJUN/TBygPFIvw= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-377-COSuxNFYM_KODt4fCkpS7g-1; Fri, 02 May 2025 11:31:50 -0400 X-MC-Unique: COSuxNFYM_KODt4fCkpS7g-1 X-Mimecast-MFC-AGG-ID: COSuxNFYM_KODt4fCkpS7g_1746199909 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-43947a0919aso13909605e9.0 for ; Fri, 02 May 2025 08:31:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746199909; x=1746804709; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=jM8M6akj52fCQHHjXX1/nsZvwbcymr7x1EGpLLdZdRo=; b=SBEgPvcvPr/CdoZ7Sd2m5VfxNYTYVebN52EYyj0rOBJKkFVfpwUGJgyvgTdLQvleSU IciPR230was9DLQpqPbHlEk3RSYVniln0qGlbkcYzsRDcFKPnm/a71xeTSXigZrSPEEh 1NjAb52dL86CtCp0ZyIrk74loAimC843EuenKHvQSaMp7W/UMfqlHpU+BZ70f3irKZJB xh5t1C4axqzaTqrjfod/c0xRUXEU2nP3Si1AOzSlQlJanbwqJqSC5q/AerkZwbtyQrTR p2WPRTZpQtPPhh/0QepYEcKsnZuvMMgCN1ta3k5LHZv/gFVKzIjp+TxOLQqH3V9lrbQb yIhw== X-Forwarded-Encrypted: i=1; AJvYcCVAi46CYyar28YI+DrZwiVtG0qFPOHTdAbbWi4s1eO19wINm0FIDNjgmr5hEQJp1XLnd/zT+9PxwQ==@kvack.org X-Gm-Message-State: AOJu0Yy9Udp/STP5uVivP3xoeoclAZpdujxWbivoFCvOqm5aVherAguO wdU44hP7LG/wxWA6ZlRP5YuzItjsahKusNg/QdisoQy/eKTY1g3GAq4R2n3AREJpHJpaYOMVljU 6Z5gqVaHDnr697n1kdFjXaj43TEzgOtlok8osiM9QGQVqBLB0 X-Gm-Gg: ASbGnct+4vUbTkjO7rY8+ch70/vQT6DbefuUE6kXVMgS8YoAhXq0RJc8NIkewxxhhkK j9X5/e8sVTkfhm0SLxS9LxLpn4LliqrugynPGTPH4WyM29vqg7Jt86SMSM5qmwZdEQMoweEYA1s j06JLjHc/fmHs8kvLDCsuKGgyRpBFM02jbDlY1Hr9AAsn5WvEP19aGGCCDuBGFz68yKMcnEZB7b /aT6fzt5dBYeP78Nbp23TdhW1idPmnnkgPJpSO5ho4lYZK4XUpztif+dQXGkRMHxL45cvUb7D6c 307k5e6fbNSrnTrmHf3160vOR/nGWGrBAdugj7pNsOVZTr4jHSe+9qgWpKw+WiWktg1i7VkoSiJ SjyamSKSytTX2jnBIc7oPatJazaCQHFu9X32C6Tg= X-Received: by 2002:a05:600c:a368:b0:43c:f969:13c0 with SMTP id 5b1f17b1804b1-441bbf37f2bmr27033205e9.29.1746199909393; Fri, 02 May 2025 08:31:49 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFEvYzEZlLwr2sfu3x5hwxFQiu1NtDm78iDWETxYBo0k9U7Y9unR1MHkU940jUVDxeM2iTskQ== X-Received: by 2002:a05:600c:a368:b0:43c:f969:13c0 with SMTP id 5b1f17b1804b1-441bbf37f2bmr27032725e9.29.1746199908975; Fri, 02 May 2025 08:31:48 -0700 (PDT) Received: from ?IPV6:2003:cb:c713:d600:afc5:4312:176f:3fb0? (p200300cbc713d600afc54312176f3fb0.dip0.t-ipconnect.de. [2003:cb:c713:d600:afc5:4312:176f:3fb0]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-441b2aecc20sm93468795e9.13.2025.05.02.08.31.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 02 May 2025 08:31:47 -0700 (PDT) Message-ID: Date: Fri, 2 May 2025 17:31:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [REGRESSION] Re: [PATCH v3 3/6] mm: shmem: add large folio support for tmpfs To: Daniel Gomez , Baolin Wang Cc: =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= , akpm@linux-foundation.org, hughd@google.com, willy@infradead.org, wangkefeng.wang@huawei.com, 21cnbao@gmail.com, ryan.roberts@arm.com, ioworker0@gmail.com, da.gomez@samsung.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, regressions@lists.linux.dev, intel-gfx@lists.freedesktop.org, Eero Tamminen References: <035bf55fbdebeff65f5cb2cdb9907b7d632c3228.1732779148.git.baolin.wang@linux.alibaba.com> <57dc4929-268b-4f3f-a0f8-43d6ec85974f@linux.alibaba.com> <72978e3a-ee67-47d4-b06d-e911bc5d57ff@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: FrpMGFdtU9LGkuS-ZHJY5kG8iTzrGBcFmNEOVcpY6FE_1746199909 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Stat-Signature: ewgetxsk1kf7phg8fo3t6mskyzh1zz6m X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 2D631180007 X-Rspam-User: X-HE-Tag: 1746199912-528930 X-HE-Meta: U2FsdGVkX1+BVf7+gGgvkOrOz//4QNF+b5C6NFXTrNNFRp2gFz/EV00fcZwiD5MAzy/OxUNbkBYUVqa5NRZF0x0iOLwg2hEacUQGrqbLjJeHsgTbBLVy1V04+DHpKSvy9oqfyCr3e7ID39t8pLSBJtWHPPSxNtkM+5zp0b9wBYHMMmFr6VuGn5vUy5M6DqPsLjujQdoi2g5AAHCcZD7dHPvivV1CEPv25ew+xbfFPXMOrIs4+hrQ23IzL7YIyi5ISxmMXBC1W9Ac6TS3oE4ughQ86Ra0id87Wmv+J5s74H09gVHftNKsx09yiZvF/QyoLGRybVgRsjnUyvNzjOJ4lF6I1xrh+1GkGKb9eZ/ZnWGBucOjVPKozfVq2h3C1aIFkqXKkr25eNmy1eeGVyOCo+Y5Mf+t/rynKvRIQNw52mmBXQ7OVGsqROwamDJkgEcDP8wWSRc5mdBXjPtyQmnAParyzpxSX/ooaydzt2KzorVb4Wvuht/ivfVw4/ztUtaeNQ3sRtiW86FVqldOK44RZL9X1UFuuWWrHj2vWA2DxtV3DeP/4ZHyGeLvG7fpRy0lC2yFltauS7bWWwAi+Hsc6xzDh0BWUNeeL9NyUROc+vdIalKL6gppxRyB1ORstVAFDhEuer1mXMRfCLpmBZn4zb/6XACBkGWORUvAmSZ/gMw6K9QJO7zhdGKuBTVH19uctXau96pd+wDykOABgkNIicx2aSF23DJsUVxVIdbJhjLvNFCHgb1NsjdcnEtrwRYheiwMBTQAbaJTbfkRlSNTAQlcyRxBhXklE5cMaxYD0z2fT3DKHzA3MwlcxgAWA1QJzDOCgmAE+ULFnj1RLnEa53LVNEa5nWiDy0NejejT5NUy9g2WhMN/lppQ7hk/4jDMvuSsoXmuaJugDaeV4n4hz+PWdNxO9uVupjqT++8GyFXSX5Og8qUukRsMO1oK3RTd0mNLGI8HpkYBoSpYpGz wna5flyF 2a5VI4yiZTMug/YPFW+KzbCLc81wNN1UzGVKIQdBUDb9awRgcrd7EGLCopqHk1Tug2ZrPlu+eYHZtpq6KkjqbgXPoWBVJxGEJ/DfvSfU9txXLtTI8OM4c9o/mP2VJK4hJqwsup0bnvmQL9pEr6dqSchOSP4LqmP45DfTRdhR67jh3P+orpKc7GRTwxIQOy6fUKYeGH1FIQcIf52oTYKXA04n9tRQ4e/ZNjvbaIceMxE1EcG5jxn0527ceNORrizM8+hhAu+EVcyLrkJtJOB7SfTlpVF7utq+60h0BONLURAA6vwpNWWeP4DQJg1Nqa0KCwRs+3VKr4ALC5SNTrWASmcwI+Rq5vU4823aBFhtha6kN7hVvnDCo0xMuf6nJdCFHUnEcm3RnMK1keQ2dxqUWUZ2m7zM76pXpStilw+nKaE+546o= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 02.05.25 15:10, Daniel Gomez wrote: > On Fri, May 02, 2025 at 09:18:41AM +0100, David Hildenbrand wrote: >> On 02.05.25 03:02, Baolin Wang wrote: >>> >>> >>> On 2025/4/30 21:24, Daniel Gomez wrote: >>>> On Wed, Apr 30, 2025 at 02:20:02PM +0100, Ville Syrjälä wrote: >>>>> On Wed, Apr 30, 2025 at 02:32:39PM +0800, Baolin Wang wrote: >>>>>> On 2025/4/30 01:44, Ville Syrjälä wrote: >>>>>>> On Thu, Nov 28, 2024 at 03:40:41PM +0800, Baolin Wang wrote: >>>>>>> Hi, >>>>>>> >>>>>>> This causes a huge regression in Intel iGPU texturing performance. >>>>>> >>>>>> Unfortunately, I don't have such platform to test it. >>>>>> >>>>>>> >>>>>>> I haven't had time to look at this in detail, but presumably the >>>>>>> problem is that we're no longer getting huge pages from our >>>>>>> private tmpfs mount (done in i915_gemfs_init()). >>>>>> >>>>>> IIUC, the i915 driver still limits the maximum write size to PAGE_SIZE >>>>>> in the shmem_pwrite(), >>>>> >>>>> pwrite is just one random way to write to objects, and probably >>>>> not something that's even used by current Mesa. >>>>> >>>>>> which prevents tmpfs from allocating large >>>>>> folios. As mentioned in the comments below, tmpfs like other file >>>>>> systems that support large folios, will allow getting a highest order >>>>>> hint based on the size of the write and fallocate paths, and then will >>>>>> attempt each allowable huge order. >>>>>> >>>>>> Therefore, I think the shmem_pwrite() function should be changed to >>>>>> remove the limitation that the write size cannot exceed PAGE_SIZE. >>>> >>>> To enable mTHP on tmpfs, the necessary knobs must first be enabled in sysfs >>>> as they are not enabled by default IIRC (only THP, PMD level). Ville, I >>>> see i915_gemfs the huge=within_size mount option is passed. Can you confirm >>>> if /sys/kernel/mm/transparent_hugepage/hugepages-*/enabled are also marked as >>>> 'always' when the regression is found? >>> >>> The tmpfs mount will not be controlled by >>> '/sys/kernel/mm/transparent_hugepage/hugepages-*Kb/enabled' (except for >>> the debugging options 'deny' and 'force'). >> >> Right, IIRC as requested by Willy, it should behave like other FSes where >> there is no control over the folio size to be used. > > Thanks for reminding me. I forgot we finally changed it. > > Could the performance drop be due to the driver no longer using PMD-level pages? I suspect that the faulting logic will now go to a smaller order first, indeed. ... trying to digest shmem_allowable_huge_orders() and shmem_huge_global_enabled(), having a hard time trying to isolate the tmpfs case: especially, if we run here into the vma vs. !vma case. Without a VMA, I think we should have "mpfs will allow getting a highest order hint based on and fallocate paths, then will try each allowable order". With a VMA (no access hint), "we still use PMD-sized order to locate huge pages due to lack of a write size hint." So if we get a fallocate()/write() that is, say, 1 MiB, we'd now allocate an 1 MiB folio instead of a 2 MiB one. -- Cheers, David / dhildenb