From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42E23C433EF for ; Tue, 7 Sep 2021 20:52:24 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C537F61051 for ; Tue, 7 Sep 2021 20:52:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C537F61051 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 33C5C6B0071; Tue, 7 Sep 2021 16:52:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2C4CB6B0072; Tue, 7 Sep 2021 16:52:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 118516B0073; Tue, 7 Sep 2021 16:52:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0166.hostedemail.com [216.40.44.166]) by kanga.kvack.org (Postfix) with ESMTP id EE0B96B0071 for ; Tue, 7 Sep 2021 16:52:22 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 99742180AFE2E for ; Tue, 7 Sep 2021 20:52:22 +0000 (UTC) X-FDA: 78561975324.04.BB2EADB Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf03.hostedemail.com (Postfix) with ESMTP id 42D9530000AA for ; Tue, 7 Sep 2021 20:52:22 +0000 (UTC) Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 187HsZMR027987; Tue, 7 Sep 2021 20:52:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2021-07-09; bh=NtCpcJga/XpI/G08oe/0Wzm7hCb83jmGLfhZOaxOft4=; b=NO5HIzSGym6e8rrR1RFjrK47b5gZkXes2xOi0dGaSlKFRKyiT0Kk1+yTMc3g0ywYpdr1 OI/+KvBzKFgpAuRUKtcKGGFio8K14RWFd+3sYZ54zXGTvtNaNAAPnUzFztfQ8vjGJnxY AzLj47Z+ulgmA+1A1L1w473uA9jvELb1rebw6CtaPtoc13nTadDAAjZGOhXogo84gzPO +60FSSrnWCgfwVnHlEjR99FqdlbXuA9Og7uLkNVH9RDG5LRoi15V5MGW/BypIfMMPVQD qAvyb818cMAg/Pz6op4gnaFauriA3GnBTAwsTN6VJKaR2ZvfwwXUufj56QJyHYTmu5vb nw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2020-01-29; bh=NtCpcJga/XpI/G08oe/0Wzm7hCb83jmGLfhZOaxOft4=; b=ti40V26JDRKNdK53sp6ARHRF3t3tZkhjfsrvuwX6nLLkrTDc2WbETupHnmL80un7jjwd uXi2IOqR/PMJwyen5iGq1pATA9Xtsj7VSFWknwNNrc1m18D0LqAEYW/uppHvHhmqxv// VMatw5bGAkj2wmmdNUGSyQLVK2R8Z/yN+kwR3XKIdKiH3BqGuKcHuTWHSedTekE/mrjg l6wwX3xn36QmMh2GytIqSskwGGXLmu2kMxKcQY0LtYimkffVjBK58TEoYZNpLzBTtzRA BqLTxxkAPSgjhJHlYLUH0IAFISqiufKV8g6JYMjnYMF31oOdgsrKLXCuwkIXmaCjKiZb xg== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by mx0b-00069f02.pphosted.com with ESMTP id 3axcw68epw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 07 Sep 2021 20:52:10 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 187Kolf4083018; Tue, 7 Sep 2021 20:52:09 GMT Received: from nam02-sn1-obe.outbound.protection.outlook.com (mail-sn1anam02lp2049.outbound.protection.outlook.com [104.47.57.49]) by userp3030.oracle.com with ESMTP id 3axcq08mh3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 07 Sep 2021 20:52:09 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BPXJMAVrsKDzT6PX6GYHXBug389FyxRHv9v4AHWxMnGzQs17n3DY94ltXXJnnn2S04sIPZzY/dsapP+4PcX2tO7MjtXc3VNYLQ2fKPCjDIRWp5S4OfWUhCxbACEzH/5zeMn89pgt/gVeEt48EwxBIEj9dzsfXvwIijdYNDBdUaPJqcjliAyQ9cX44Wxv5nkYdMn7vnJoZ+NJ8Io2BMtv23cKsMryhTkGIAsp2SQb3iMqSWXppfTNyO5Sb1ZyXmypmZWXvEGH00+acRSfFt/2A+e8spz8BAYFA+nAnB3GItHoyVh62XqXwh8TuO7fOmoMMCMRmFT0Oofs8f011JQ7vQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=NtCpcJga/XpI/G08oe/0Wzm7hCb83jmGLfhZOaxOft4=; b=FPqTRwSiAk9c2mIyoE8GL8ZaA1lHgB9TL+AAFMO2HwoSM6Xx+7WZ0M/07eJynaPGYlx7xf8i89+n27tbkCMi4++oJlaA4PCXSbg2Q1CBV4uQkjmPRw73THW/96EvrAslteCjSfnScwHiydQpPLqHpb3ML3HBGQC7oTtKdpO40Gj5NKbsyw9rviPViS79I0yNbZvGFeldtyA9AalE4/IJKC4lh6YCgse696bCBD9s7UYztd342L37v/nLG7N9OlELoFg9RoU9to+tE4F0hTQxOAvgeUD0DeKMeHp/M0t91TTHskazyOgjIwjQBdCcYSXR/BkzDom/1PFVVK8njRSYUQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NtCpcJga/XpI/G08oe/0Wzm7hCb83jmGLfhZOaxOft4=; b=E8yipvaLiSRAjEUHy55ed+0j6D7iqr0FrsxlCTCz5IlA8iOF0WlJqK8mJnM1ULVms859t8o2or3UzVeKWlHR2QBHtszfOiYGuall48QFcQOhpClJ1fMRPglFyw32uT45qA5IvVwy5DZ+ZkhTIypwyKELigIX4t8nU/fxUxgvOcA= Received: from BY5PR10MB4196.namprd10.prod.outlook.com (2603:10b6:a03:20d::23) by BYAPR10MB2613.namprd10.prod.outlook.com (2603:10b6:a02:b5::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19; Tue, 7 Sep 2021 20:52:07 +0000 Received: from BY5PR10MB4196.namprd10.prod.outlook.com ([fe80::a4a2:56de:e8db:9f2b]) by BY5PR10MB4196.namprd10.prod.outlook.com ([fe80::a4a2:56de:e8db:9f2b%9]) with mapi id 15.20.4478.026; Tue, 7 Sep 2021 20:52:07 +0000 Subject: Re: [PATCH Vx RESEND] mm,hugetlb: remove mlock ulimit for SHM_HUGETLB To: zhangyiru Cc: linux-mm@kvack.org, wuxu.wu@huawei.com, liusirui@huawei.com, Andrew Morton , Michal Hocko References: <20210904075458.51012-1-zhangyiru3@huawei.com> From: Mike Kravetz Message-ID: Date: Tue, 7 Sep 2021 13:52:04 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 In-Reply-To: <20210904075458.51012-1-zhangyiru3@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MWHPR17CA0077.namprd17.prod.outlook.com (2603:10b6:300:c2::15) To BY5PR10MB4196.namprd10.prod.outlook.com (2603:10b6:a03:20d::23) MIME-Version: 1.0 Received: from [192.168.2.123] (50.38.35.18) by MWHPR17CA0077.namprd17.prod.outlook.com (2603:10b6:300:c2::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14 via Frontend Transport; Tue, 7 Sep 2021 20:52:07 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b87620f2-a804-4729-9032-08d972415b01 X-MS-TrafficTypeDiagnostic: BYAPR10MB2613: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LikjupUtUFBw/VbcneQ+vdd3Ttogfi4jE4em0pNLPcqan4yjFadmagoMBNhJ88h6odzyzQ0DtaZ3VqpPLwVamPtbw3WdDeoMFW5EOgd8t6mogp2fPSihnzemBubkc1aUh9R0TAMKWYtaU4j22usROkFjWmI4LLF1onsLXYrqSEvF+SrY9Re067U1Y+aFl1fmBj7yVArOXiw3RfLN4K8to24VIj54mKoMfBup3nJziFEE6qCbS0XT7QMM4nF17qNjoTDFMz260k1C4FPvzVo5HNsmh/Wg+s0DrPQD7PpUz1PvqR6gLb8mUdZxHEqMhcgo+0KY/XL5eF2CIgsfZZA/UYzN3BzOXZBARFwOKFpLljFLwp6Nbl97a+2JuCmVjKxYZbJB8PFKssPzEge8od/Ga3tmCAZaiU40X1tfzH3yPunp4IVz0u3je9tytoL1T7DOWPCngU9ZPfIfKjJsfqhsNQX8uDcMg+B8Iu/d/rDMobp4N7L32fs+GqSOeJmIcgf9S6oTxtfiClbaf9pF5k1AMY4FktJOVoGcpzpmdXgmnnwAGDalrG8zKWJ6aE2mAmhNGofvbvsDLTAPTr0g8RUX+zpbboPrrUeyfav4U2SlzgQ0/L9jKMzkxWlYf+CI4PanJwg+WaH0/BxaWNQ09miYDNVkpM6EdT3Xh8XK+2C1JHLIlaEIcEiJk/dCIxkbr1aQN7oWgiBwCRpt1n4MJLyYo9+k6WQnecFelqgfsIQRGHcrsXM9TlBVI710rTWjE6u3 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY5PR10MB4196.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(346002)(376002)(396003)(366004)(136003)(39860400002)(36756003)(66946007)(4326008)(44832011)(186003)(478600001)(16576012)(66556008)(86362001)(52116002)(31696002)(6666004)(5660300002)(8676002)(6916009)(31686004)(38350700002)(8936002)(2906002)(316002)(38100700002)(53546011)(83380400001)(66476007)(956004)(26005)(6486002)(54906003)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VEJZOVFTWklIL2JNSTRVZFdyUVJLODNCWnU1ZnhFWmlacWE2cEdYYnk3RzBm?= =?utf-8?B?R2pkTUw5ZGZzMnJ6Z1lhUlUrZEdDOWJpeXNhOVNaNWVJbWlnb3g3WU9YWlF0?= =?utf-8?B?OGNaVHlvc2hhRTdrVm5jRHc1TFQvMVV2UmlaTTBRTlZ6MDk4UXNMUlRoakRW?= =?utf-8?B?R001ZnNoTjY0YWdzbVpxY0tyZmNYRlluMGhlaWRlejFCUUlJQm9GaFhGcjRw?= =?utf-8?B?MlgwMkVHWnZWMXpHWFJaRjNCNy9wdmVacVZVR1JaeHFhQ3dPNTRoU1A2MStj?= =?utf-8?B?ZHFEeGtGQVovK2Y2L281N0RPZGh0amJxNmVvU3NBSVByRnhkODFzNjM5WnVz?= =?utf-8?B?MGRVRlBuU3FvYUt4WVBaa1YyeXpweGlEdm9BZG1XUEFlcS9OYmdpdENwNzRC?= =?utf-8?B?OUpDNCtTZ2ZkTDB3bkIvVmdyVzJ4Q0JjKzBvMlNEcUl5MCs2c2p3SVovTG5S?= =?utf-8?B?SlBHeXR2eDJrc004Q0ZvTUc3dmhWZ3NoMFJNSFhPWnlwZ09Ia1lwenJJL3dq?= =?utf-8?B?Nm40d3doYTExdm5iLzFSek1RZkxoVk8yQ1NONUtmYkNxdjdaR1hYNmhVRUFR?= =?utf-8?B?MlRnOTMxbVhINTV5QlhiNlhyOVcrbnRtaXcwZ29RdjJBQmY2S0x1ZE5CTEtl?= =?utf-8?B?aDRoM1U1TlFleHp5c2lrQThVNHFrQ3ZXaGVUOC9md1kvNGFUbE1qZzV4NlFs?= =?utf-8?B?K3dvaFgvVHRaeFNtMG1yK0U2VnF2ekJPU3RNNlhVQk9EUE45M1JSZFI4dU5T?= =?utf-8?B?eUhpdFNLYnF1ZzMxYUhmUTRueGxlNUZZVHQ0ZEN6RCtoYjRCN1FsNkdoVzUx?= =?utf-8?B?TXJMY0pRajUxYzFWdEVISVY0WThqUFExVjZQU2tlSUZOYVFrbmNoT2hDY3hx?= =?utf-8?B?RTNtRDZSN24velErTmhOTlVEUlhjYkhQM05odlNiWjFna1prTlFhampYRVlz?= =?utf-8?B?S3NLcnNGR1AvQUhNN2JhL2NBSUVlejdyMnNoRTEwNkV4aTc2SkRQcklCSWFS?= =?utf-8?B?MkZBZnllaHBYWVZPdUYxRlJ1Umd6QnNjR25tMFlsRXNaY1dlcjlpVG9HMkxD?= =?utf-8?B?UmpiMTBjbWF3di9YSGtUTi90NE5JSFZ6Wk4xNW9ra3RJbnd5L0pwcjhzQ2No?= =?utf-8?B?Mkpuekd6YXVuQW12MEdKcWU4K0Z4dE12QzdaZkc2ZE81eXBHOTBBVStZaVBE?= =?utf-8?B?NFBUOFZQcjRpYWFMcC9JZFhrYXNIbDQrTEhDSTNiTW9sTlVEOEtGUi94MXpq?= =?utf-8?B?Q21sT292Yk5VS3puZS9wQ3J1ZnB2TERuVXdjTFVxZElveXhYQnBMVlEreXdK?= =?utf-8?B?VWNBMGgrNE1rTFVxcFBpQ3JUdjFZT0I4N1ZzdXM3Q1E4YnIvUUJjMkxXRnNy?= =?utf-8?B?L0VqZjVqZktFa21FamxZb0x1RVFMb1Y2Um1LU1E2aFlxMVQ1dkg2allkcG96?= =?utf-8?B?UVRWZmtSV3poZG5RTGJhK0pETGNYZjFYZmJKNC9mNTd4Qzk5RkF3SEoxcytr?= =?utf-8?B?N0NQVCtYWTlrWGxYa3QwVC9aR2RpWHA1bnBNQUpXK0Q5QUE0TW5ybXlSQlhr?= =?utf-8?B?U3A2d3FyeDh2VVdqOXBUTUk5S1lSQWNyMmxmZURnOHlzUjNJYnE2MTg0Z1p1?= =?utf-8?B?Z2tKZlcrQm1DcUVGU2JHTnR6QkRaamp0SWhIVWhSck1kSndWdjRjSXR5K3N2?= =?utf-8?B?S0RRSngyN3p2NHkyTXhqUGNuSm16ZTNQOE1TejZla2ZzOUN5cENidGRIaStE?= =?utf-8?Q?R3SoLfFb3MCGunaZc/JRLNbDny3WVMUEfbIu5Tw?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: b87620f2-a804-4729-9032-08d972415b01 X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2021 20:52:07.7583 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rnH6apxonhCSE/PP5X6rkZeckbUVI7UuOcGodBdZK+sp5xPTZxpaxQsnIxjCMMJd+G8kHYNWecu0APywo9yrfg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB2613 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10100 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 adultscore=0 malwarescore=0 mlxscore=0 spamscore=0 bulkscore=0 mlxlogscore=999 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109030001 definitions=main-2109070131 X-Proofpoint-GUID: yLsnzlH3Zg_7elMNXj-PFkp90LWEnELd X-Proofpoint-ORIG-GUID: yLsnzlH3Zg_7elMNXj-PFkp90LWEnELd Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2021-07-09 header.b=NO5HIzSG; dkim=pass header.d=oracle.com header.s=corp-2020-01-29 header.b=ti40V26J; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=E8yipvaL; spf=none (imf03.hostedemail.com: domain of mike.kravetz@oracle.com has no SPF policy when checking 205.220.177.32) smtp.mailfrom=mike.kravetz@oracle.com; dmarc=pass (policy=none) header.from=oracle.com X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 42D9530000AA X-Stat-Signature: m4yg3yqpie36p4ranpphntig5zne8w98 X-HE-Tag: 1631047942-20911 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 9/4/21 12:54 AM, zhangyiru wrote: > remove mlock ulimit for SHM_HUGETLB > commit 21a3c273f88c9cbbaf7e ("mm, hugetlb: add thread name and pid to > SHM_HUGETLB mlock rlimit warning") marked this as deprecated in 2012, > but it is not deleted yet A better commit to mention would be 2584e517320b ("mm: reintroduce and deprecate rlimit based access for SHM_HUGETLB"). IIUC, 21a3c273f88c just modified the log message. There is nothing wrong with the code. Adding Andrew and Michal on Cc: as I have little or no experience with removing deprecated features/code. This certainly has been marked deprecated for a long time (since 2.6.31). However, I still see that message in log files on occasion. Andrew/Michal, comments? -- Mike Kravetz > > Signed-off-by: zhangyiru > --- > fs/hugetlbfs/inode.c | 14 ++------------ > 1 file changed, 2 insertions(+), 12 deletions(-) > > diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c > index cdfb1ae78a3f..c092c4931c3e 100644 > --- a/fs/hugetlbfs/inode.c > +++ b/fs/hugetlbfs/inode.c > @@ -1463,18 +1463,8 @@ struct file *hugetlb_file_setup(const char *name, size_t size, > if (!mnt) > return ERR_PTR(-ENOENT); > > - if (creat_flags == HUGETLB_SHMFS_INODE && !can_do_hugetlb_shm()) { > - *ucounts = current_ucounts(); > - if (user_shm_lock(size, *ucounts)) { > - task_lock(current); > - pr_warn_once("%s (%d): Using mlock ulimits for SHM_HUGETLB is deprecated\n", > - current->comm, current->pid); > - task_unlock(current); > - } else { > - *ucounts = NULL; > - return ERR_PTR(-EPERM); > - } > - } > + if (creat_flags == HUGETLB_SHMFS_INODE && !can_do_hugetlb_shm()) > + return ERR_PTR(-EPERM); > > file = ERR_PTR(-ENOSPC); > inode = hugetlbfs_get_inode(mnt->mnt_sb, NULL, S_IFREG | S_IRWXUGO, 0); >