From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FC7BD2A559 for ; Wed, 16 Oct 2024 20:00:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 30AEE6B008C; Wed, 16 Oct 2024 16:00:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2BB426B0092; Wed, 16 Oct 2024 16:00:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 134A56B0093; Wed, 16 Oct 2024 16:00:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id EA0006B008C for ; Wed, 16 Oct 2024 16:00:32 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id B18BCC0A68 for ; Wed, 16 Oct 2024 20:00:21 +0000 (UTC) X-FDA: 82680532452.30.6D941DD Received: from mail-io1-f46.google.com (mail-io1-f46.google.com [209.85.166.46]) by imf07.hostedemail.com (Postfix) with ESMTP id C1BE34001A for ; Wed, 16 Oct 2024 20:00:17 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=d8mowcXF; spf=pass (imf07.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.46 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729108757; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/PVXpXafwswvIYBcxSLxNIvr3U2zHo65AX9f3Pm1fo0=; b=AenAZvcmuhdTnGMU+fPyxeibA6H560yaH/mzhTYiEHGkWJ6f9iMyhn+/fsrx71oy76uTls fr23XRuiyjyfN5aiZjsV3hY95gNbJ6Eh1sIGSs0hRu77vN+pJSDyQmlf3JnijMtz/0DYNN nwEuJdOK7fVB5LfH+cui1Q+q0tinMJA= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=d8mowcXF; spf=pass (imf07.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.46 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729108757; a=rsa-sha256; cv=none; b=bhuTmLTNcc+gKDrdp2g7ZlT4DNr/2bJAc0cfyzdA2EmHaggaq01xQkW3PXkxdOY4MN88y9 BQUvCVu+cQNXMViE0gOfPhPGC7pAMtvB6gef8FwlY28GnB8uP2fq7tieBTLbgC242Vjxz3 nXVKIuB34wLoa2x0dQQiHvnGZhP0PyI= Received: by mail-io1-f46.google.com with SMTP id ca18e2360f4ac-8323b555a6aso9026239f.3 for ; Wed, 16 Oct 2024 13:00:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1729108829; x=1729713629; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/PVXpXafwswvIYBcxSLxNIvr3U2zHo65AX9f3Pm1fo0=; b=d8mowcXFk0zH23z7yzjJ5dU5aojiFI/4NeJEAv4/u2zFS1q2aaqKpejMyHQypyOoF+ 6zFziqNDgNkyybGDR6SyLaLFJoxFyFB4Kj581kZ6G+0QQ5OcZXStF0bV0OBC4g5X6UGc J2D2JFi7lZ7U9Lzzob+iCM0HJoGWu81SNXBrE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729108829; x=1729713629; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/PVXpXafwswvIYBcxSLxNIvr3U2zHo65AX9f3Pm1fo0=; b=MvslxgJih+uPDkhREaDgDe93l7h/qi5AIyl8USpl3JcbnC4lJRwGoAbMNNnxGknThe L4TdnV+NBqSz02TAehIH/QR6Z6+ecIdWVLWYQchw+Sg7nDVK0DOAWM1f1/CooBC3nXFI etS+kikfwg6AyFURKMchGKEj1/W771dKz50HHVRxr+IUj0TIUlc4m58eUXENWUKTOiXM 21U/gCwsfu0oY/OEGk2Chh8cw3xb1TyvUuCKrp4pYBuNLrYpayTONVp2OnA42a8dVcRw VdOCYlUDEbm0nO6FeHssGpD3lpoglhDWK2fWhZuyNeWM1byb/6OMwKDQuDKaZVb1kJrc jMQA== X-Forwarded-Encrypted: i=1; AJvYcCVrplFH/ANuUiOecQAqEyWytvKJHhqF4Pq6kVNEIUhKNba9Jqlaldu69t49z8zPzuLjf4kv9oVStQ==@kvack.org X-Gm-Message-State: AOJu0Yyub8H0gxG16TPD3Zq3fj45rM0jNctvDtSHoOu/AzBIgcyj2waF P+isRGwmFo/pXCRJTmyIecEtPejp+Wq9ng6PbuXUpSSlvYwszQ4HZ7DH5Awxeyg= X-Google-Smtp-Source: AGHT+IFhemGMrTXm0sMyQyLUJ9gqBzqux5ju24bsXrdrLEcJKKlddo3PTMuUfwbHsZl+/lq10WstqQ== X-Received: by 2002:a05:6602:6403:b0:837:7f69:eac2 with SMTP id ca18e2360f4ac-8379241ac0emr1848647239f.1.1729108829163; Wed, 16 Oct 2024 13:00:29 -0700 (PDT) Received: from [192.168.1.128] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4dbecc44a2asm981213173.154.2024.10.16.13.00.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Oct 2024 13:00:28 -0700 (PDT) Message-ID: Date: Wed, 16 Oct 2024 14:00:27 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/3] selftests: pidfd: add tests for PIDFD_SELF_* To: Lorenzo Stoakes , Christian Brauner Cc: Shuah Khan , "Liam R . Howlett" , Suren Baghdasaryan , Vlastimil Babka , pedro.falcato@gmail.com, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, Oliver Sang , Shuah Khan References: Content-Language: en-US From: Shuah Khan In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: C1BE34001A X-Stat-Signature: dotj1azj54yiztbq1qux3oyqfojq6beq X-HE-Tag: 1729108817-26528 X-HE-Meta: U2FsdGVkX18ilxlmQc5D6PJnc8Fa12y2bXbSlJsvYmV4tSIYnkubuLR6Hnn9vvS80s6ChVQKv682MXdCUbrJhGtAvxzallu0fgV0nAUF4uvFcIS9xDNZRHiEiJqPJlQSZA+6GYga8mwoHOZVilnkSjBzgacKCwEEZXyzsw41gOPcOpZTTTznM5Gm6C9Mz1/kWePe7g4b9dzJWv6cpnCqmDgBSB1iYyGewgfnwvzRsk/3WXYdnbZ/X7JO2W3ZM4RuiFy0Bw6baa/WVVBpToWOWlzajFHVtaqrGklJ6jJ81rtcM56eZi+wMVYfpchfY+lakxmLcX2zmvYbYLNz9SuISX7+/zfGgsbCNQb6NvsuaI3N9Wy8HUdaFATbSQlUCWlxOLlWOfVlLgXDdjLNIIsDVHCEjifL3r4UtGKO5GiZB1wP7IhufhTzdyAHP57hka+E640aa4BkJ5uwxEGxuaG/l2BTjAfo/3DQxvvHtss8Czjhj/8gmeOo3Q6zwDJG49ayQAkIDKLmfpzRHpFNdOjsRsny1fzOSww5EnY3h0IE6eyZney+QIFP/0V9/P4/tr033AUc8RnXSlc16N78HwkQc/UCKhFygnoRSYMZHJKacG0pXZyi7Qxk73YOtNpQp4AFeL+qf9o2E5ILFrKKBCMQQtb5/T1mmoG5HIqtCgt3MfwNmNuoeNQ39s6SlxSA6ibcQwA6B9t/v6IrG/Equo+legTbytvcS2bmAW3K/hKeAhtaZGxtaYojclHPhWMK6YNXQJyFWnwjc6hW4aKYfgaOlFHUYZJ72dLXKTaPRpavrjXdA6IMv9+ozp7nOMxaOpwcOYn9ORCbpzWdvMidw/KAmTs14fVyH03X3wzAldYZy0VuIevikCGwi7/i8QCUgGtSFRaW4dfVUiYMkyTToBW+T4MK2ydPcOJjt9/4xR7R98rdzVZpuO1egsbbXHDL2xzYnw/Mix5HeZs3HLSkC0y DXp3lIOD PcV9WVktjTfpM6oeh9Nmq7V6cInisjFVq2E+cWOxZlj6DStgXCu4MoBz/udoQdLuoCSjp2YjocYRcpSFRHP9ci8Yap3wDY9TE8PH+06rOqHJS8Zxhqh1ZBjNX527oOTgxCbLckJcriOIiS2HmCTMSH91FHlegDYAAVJZ9plgbbOGyFb44Dgh8jD8mmn4P4M4xVz26g1KdNE53qZ0Z3GScTzHqSSd+E3mnvZn3b7mjgPt5iXiUQP7V4Drl7vBKRXvx/ZKeiVDEjLmOqD7TTpvSvoOYFmLHRSwnFZxxuSWpXKdjI2gc5Sgx4orWNegWnDJyBzVg1XPjmauTuWFWYJ6cTGIZ0bml1LcGnYGuPT8nkxwejPAfPI+nTIpHiE+0qmzYDXL5WdkcikPKcO7lP/6zSkn8hFa9X+uqdYp/MVdoS/pZACJ11ydnTjTPehD1//jwrIMCca1tef9wmSffk4d9zPKCaVZWb9K+Q1cEv26kH86QmrFhTTXLbVbz8w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/16/24 04:20, Lorenzo Stoakes wrote: > Add tests to assert that PIDFD_SELF_* correctly refers to the current > thread and process. > > This is only practically meaningful to pidfd_send_signal() and > pidfd_getfd(), but also explicitly test that we disallow this feature for > setns() where it would make no sense. > > We cannot reasonably wait on ourself using waitid(P_PIDFD, ...) so while in > theory PIDFD_SELF_* would work here, we'd be left blocked if we tried it. > > We defer testing of mm-specific functionality which uses pidfd, namely > process_madvise() and process_mrelease() to mm testing (though note the > latter can not be sensibly tested as it would require the testing process > to be dying). > > Signed-off-by: Lorenzo Stoakes > --- > tools/testing/selftests/pidfd/pidfd.h | 8 + > .../selftests/pidfd/pidfd_getfd_test.c | 141 ++++++++++++++++++ > .../selftests/pidfd/pidfd_setns_test.c | 11 ++ > tools/testing/selftests/pidfd/pidfd_test.c | 76 ++++++++-- > 4 files changed, 224 insertions(+), 12 deletions(-) > > diff --git a/tools/testing/selftests/pidfd/pidfd.h b/tools/testing/selftests/pidfd/pidfd.h > index 88d6830ee004..1640b711889b 100644 > --- a/tools/testing/selftests/pidfd/pidfd.h > +++ b/tools/testing/selftests/pidfd/pidfd.h > @@ -50,6 +50,14 @@ > #define PIDFD_NONBLOCK O_NONBLOCK > #endif > > +/* System header file may not have this available. */ > +#ifndef PIDFD_SELF_THREAD > +#define PIDFD_SELF_THREAD -100 > +#endif > +#ifndef PIDFD_SELF_THREAD_GROUP > +#define PIDFD_SELF_THREAD_GROUP -200 > +#endif > + As mentioned in my response to v1 patch: kselftest has dependency on "make headers" and tests include headers from linux/ directory These local make it difficult to maintain these tests in the longer term. Somebody has to go clean these up later. The import will be fine and you can control that with -I flag in the makefile. Remove these and try to get including linux/pidfd.h working. Please revise this patch to include the header file and remove these local defines. thanks, -- Shuah