From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 629D9C433EF for ; Mon, 6 Jun 2022 13:01:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5AF1B6B0071; Mon, 6 Jun 2022 09:01:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 536B66B0073; Mon, 6 Jun 2022 09:01:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 35C6D6B0074; Mon, 6 Jun 2022 09:01:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 1FD1E6B0071 for ; Mon, 6 Jun 2022 09:01:19 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id E535D8064F for ; Mon, 6 Jun 2022 13:01:18 +0000 (UTC) X-FDA: 79547821836.14.8539EF1 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf02.hostedemail.com (Postfix) with ESMTP id 5409680083 for ; Mon, 6 Jun 2022 13:01:11 +0000 (UTC) Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 256AqI1t023783; Mon, 6 Jun 2022 13:01:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=P2pTrKGmriKa8MjpMA2AodEX/embIURuicigU2uAguE=; b=YlC1LPUmx0gLwBkvBHC6AYHRBvQisdXXwgoJlGsyTwxAaRnuDg8SP9JS8BpD2wsWQRp2 4Di/Pl1g2gY2bhpiwdjQyw25LFkiELFsk0E3JfnckoMoR1Q+UYaLcT34YlGbG4dRblUx /wqNA3Ns11vtnrdOiiFlFFbifJRTS+uqNVlDoolnxH8mzyZG3cWTc93MMZiKd6qlx73W zpWcsk1dSUKOyzWG+bgB+yjCdxGrnZXLygakwtu4jBBntwc1zU45VCa53PH+hm4eqiQg SWKjrorIr1q7mS/nBGnJW381a4mFqqdcTg+6XA5ZP1JlN1egpXdgDfzxYUsn9Zu/M7HQ Hg== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3gggr900vx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 06 Jun 2022 13:01:03 +0000 Received: from m0098396.ppops.net (m0098396.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 256CTK5X014642; Mon, 6 Jun 2022 13:01:03 GMT Received: from ppma03ams.nl.ibm.com (62.31.33a9.ip4.static.sl-reverse.com [169.51.49.98]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3gggr900u0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 06 Jun 2022 13:01:02 +0000 Received: from pps.filterd (ppma03ams.nl.ibm.com [127.0.0.1]) by ppma03ams.nl.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 256Cpg5j020245; Mon, 6 Jun 2022 13:00:59 GMT Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by ppma03ams.nl.ibm.com with ESMTP id 3gfy19adqq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 06 Jun 2022 13:00:59 +0000 Received: from d06av23.portsmouth.uk.ibm.com (d06av23.portsmouth.uk.ibm.com [9.149.105.59]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 256D0voD12648854 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 6 Jun 2022 13:00:57 GMT Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 28516A404D; Mon, 6 Jun 2022 13:00:57 +0000 (GMT) Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 229A1A4040; Mon, 6 Jun 2022 13:00:52 +0000 (GMT) Received: from [9.43.87.254] (unknown [9.43.87.254]) by d06av23.portsmouth.uk.ibm.com (Postfix) with ESMTP; Mon, 6 Jun 2022 13:00:51 +0000 (GMT) Message-ID: Date: Mon, 6 Jun 2022 18:30:51 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [RFC PATCH v4 4/7] mm/demotion/dax/kmem: Set node's memory tier to MEMORY_TIER_PMEM Content-Language: en-US To: Bharata B Rao , linux-mm@kvack.org, akpm@linux-foundation.org Cc: Huang Ying , Greg Thelen , Yang Shi , Davidlohr Bueso , Tim C Chen , Brice Goglin , Michal Hocko , Linux Kernel Mailing List , Hesham Almatary , Dave Hansen , Jonathan Cameron , Alistair Popple , Dan Williams , Feng Tang , Jagdish Gediya , Baolin Wang , David Rientjes References: <20220527122528.129445-1-aneesh.kumar@linux.ibm.com> <20220527122528.129445-5-aneesh.kumar@linux.ibm.com> <5706f5e9-0609-98c9-a0cd-7d96336d73dd@amd.com> <8e651a1e-d189-3e8a-438f-298f21402bd2@linux.ibm.com> <87fski80sx.fsf@linux.ibm.com> From: Aneesh Kumar K V In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: lzJsKC7-09VxNPdYZY2PR8UFTW5HgccR X-Proofpoint-GUID: yDQ-_ayEtl6ToGmLOv8naK-5JGSOe49s X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.874,Hydra:6.0.517,FMLib:17.11.64.514 definitions=2022-06-06_04,2022-06-03_01,2022-02-23_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 priorityscore=1501 mlxscore=0 impostorscore=0 mlxlogscore=999 suspectscore=0 malwarescore=0 phishscore=0 spamscore=0 clxscore=1015 bulkscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000 definitions=main-2206060057 Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=YlC1LPUm; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf02.hostedemail.com: domain of aneesh.kumar@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=aneesh.kumar@linux.ibm.com X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 5409680083 X-Rspam-User: X-Stat-Signature: o5femn875eqjztqngbtetu1s8zjk93pw X-HE-Tag: 1654520471-490145 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 6/6/22 5:39 PM, Bharata B Rao wrote: > On 6/6/2022 5:24 PM, Aneesh Kumar K.V wrote: >> Aneesh Kumar K V writes: >>> >> Can you try this change? >> >> diff --git a/drivers/dax/kmem.c b/drivers/dax/kmem.c >> index 7a11c387fbbc..905609260dda 100644 >> --- a/drivers/dax/kmem.c >> +++ b/drivers/dax/kmem.c >> @@ -94,6 +94,17 @@ static int dev_dax_kmem_probe(struct dev_dax *dev_dax) >> goto err_reg_mgid; >> data->mgid = rc; >> >> + /* >> + * This get called before the node is brought online. That >> + * is because depending on the value of mhp_default_online_type >> + * the kernel will online the memory along with hotplug >> + * operation. Add the new memory tier before we try to bring >> + * memory blocks online. Otherwise new node will get added to >> + * the default memory tier via hotplug callbacks. >> + */ >> +#ifdef CONFIG_TIERED_MEMORY >> + node_set_memory_tier(numa_node, MEMORY_TIER_PMEM); >> +#endif >> for (i = 0; i < dev_dax->nr_range; i++) { >> struct resource *res; >> struct range range; >> @@ -148,9 +159,6 @@ static int dev_dax_kmem_probe(struct dev_dax *dev_dax) >> >> dev_set_drvdata(dev, data); >> >> -#ifdef CONFIG_TIERED_MEMORY >> - node_set_memory_tier(numa_node, MEMORY_TIER_PMEM); >> -#endif >> return 0; >> >> err_request_mem: > > Yes, this fixes the issue for me. Thanks. > I might put the below change instead of the above. In the end I guess it is better to add a NUMA node to memory tier after the node is brought online than before even though with the current code it shouldn't matter much. modified drivers/dax/kmem.c @@ -147,9 +147,15 @@ static int dev_dax_kmem_probe(struct dev_dax *dev_dax) } dev_set_drvdata(dev, data); - + /* + * node_reset_memory_tier is used here to ensure we force + * update the NUMA node memory tier. Depending on the value + * of mhp_default_online_type the kernel will online the memory + * blocks along with hotplug operation above. This can result in dax + * kmem memory NUMA node getting added to default memory tier. + */ #ifdef CONFIG_TIERED_MEMORY - node_set_memory_tier(numa_node, MEMORY_TIER_PMEM); + node_reset_memory_tier(numa_node, MEMORY_TIER_PMEM); #endif return 0;