From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 300F6C3DA7F for ; Mon, 5 Aug 2024 08:20:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7E9DA6B0085; Mon, 5 Aug 2024 04:20:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7999F6B0088; Mon, 5 Aug 2024 04:20:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 688CA6B0089; Mon, 5 Aug 2024 04:20:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 479606B0085 for ; Mon, 5 Aug 2024 04:20:24 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id E07C31C5C69 for ; Mon, 5 Aug 2024 08:20:23 +0000 (UTC) X-FDA: 82417494726.12.45B1792 Received: from mail-il1-f169.google.com (mail-il1-f169.google.com [209.85.166.169]) by imf16.hostedemail.com (Postfix) with ESMTP id D8F07180013 for ; Mon, 5 Aug 2024 08:20:21 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Q5Q10NPN; spf=pass (imf16.hostedemail.com: domain of seakeel@gmail.com designates 209.85.166.169 as permitted sender) smtp.mailfrom=seakeel@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722845991; a=rsa-sha256; cv=none; b=yIriuVW8Lz8xwm9shIyPvoGvM9OpSihmOu//FF4EsRonLnA/mDCJnuHK/X/C3kQFgap3dA QvmibUq5DnDiRoyw80G+8CLCuFnh+BlqtZvUeqs3N7FoLQm5y7H5PnCfkzMNvpBf/KEMQA NzOdSihwKCnpi9tTIPlZRPyZeapwJlM= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Q5Q10NPN; spf=pass (imf16.hostedemail.com: domain of seakeel@gmail.com designates 209.85.166.169 as permitted sender) smtp.mailfrom=seakeel@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722845991; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+fi+vj00+JjvH+mj3sa9KgQtZBR2qBmi2SsAqsNdYE0=; b=D60GdtsQN1/8y0R1GW7DD4IoUUX4TzEBCFtX5H8t3C4T2PnAZ02w3dLM9hpSXyVw1/cumo dx/5emqzxs+O6jLpJ7Obh2H1ak7vj6oyVkW7fKednNxcy9EGqwv8xLccJx+1+whk26LK6w Y8eKCZKAFVlPo4CcY2T31gtu7NqwpPY= Received: by mail-il1-f169.google.com with SMTP id e9e14a558f8ab-39b3c36d247so4436665ab.3 for ; Mon, 05 Aug 2024 01:20:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722846021; x=1723450821; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+fi+vj00+JjvH+mj3sa9KgQtZBR2qBmi2SsAqsNdYE0=; b=Q5Q10NPN4MqKGrueXw1mFHmP9GC28BiT/Pw6z+avSXLE6C0bquHvf+NkYGstDSugAX D1K2zJDNECOhfmt0A97FiqAqvf9WXimfYUkNuAVyotzdEM5XDlCWakXlpyCbLrsA7L3q t/RbxP6uBWOkL2sNTEbq1oDNSXOmY4N8azte2N9Yi74AuTwDtS751Lm33thfXLalouKl dK52pOLlO0jtn56sP/Wqy7zcWImcbkSQf3w0ImcOhFh+/0MvEJsKwQb1GyF2YlUCAk1r 0R8OppgqA6+u3JfQH/qDAm303gF5DHgRMyJ1RNFFgFS+zlIX+62UDVpMasWAOw4Y48TE Jojw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722846021; x=1723450821; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+fi+vj00+JjvH+mj3sa9KgQtZBR2qBmi2SsAqsNdYE0=; b=Ic2ZJpXiLQgPCYb5HWrROZ32u+OvJ8A5Cx9KXJEkaSJImSLqM70G5e1CTg6BMbGgVz kiLoXbHhSOKsdTPxQlNFFo6wjWEk4XsEBQqACuNXla9nlEKfWxHfck8BS0Hxh8AdCrAS 4IMi99Hxcxdk5m/rG6837/BoZhlS+krlvj56Vzw2VENT6Wpjd7A2sMTuLGBWndy8w9CT yY0wpVFjmUkvtJJIgYFqNh5WhGTKJ6iHz6y2KVRYSO9yIPntSISddIfagMT2DTGiHfFC GC5+nDb+dJR8PWzNTWQ9Dez+AU82IhAGUQzBPsjVgLtX7xbbc+lJ4LzNFdGpGp/8VLfQ SFXA== X-Forwarded-Encrypted: i=1; AJvYcCUg0fPTfkZ5RsudJKZq2+1QTe34h/F+orgcQLHQz+Pv9zqo4MyAtp7ujUVhIlFP8kJEysa1Z3II/q7uU6Kv6hUJV1k= X-Gm-Message-State: AOJu0Yx8uEWP04GoLr0IuKdaubCcpVkGxMsgPAUUzSGMVyU1ta5W1qHn wFzTTgmEjlVEgeL5P+qnW8EYZyELQCVVqi3vqrPQX3AGgwH9a9jI X-Google-Smtp-Source: AGHT+IEvzlGQG1DU5sAenS+ngpsQ68verMtVLUc4c+qzKZTmgYmforjQMlP9JolotZUa0h+Xjc0uvg== X-Received: by 2002:a92:c64d:0:b0:381:fa54:fb33 with SMTP id e9e14a558f8ab-39b1fc1e182mr129162445ab.17.1722846020730; Mon, 05 Aug 2024 01:20:20 -0700 (PDT) Received: from [192.168.255.10] ([43.132.141.20]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7b7653b4c74sm4978190a12.82.2024.08.05.01.20.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Aug 2024 01:20:20 -0700 (PDT) Message-ID: Date: Mon, 5 Aug 2024 16:20:15 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 06/22] mm/zsmalloc: convert create_page_chain() and its users to use zpdesc To: Vishal Moola , alexs@kernel.org Cc: Vitaly Wool , Miaohe Lin , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, minchan@kernel.org, willy@infradead.org, senozhatsky@chromium.org, david@redhat.com, 42.hyeyoo@gmail.com, Yosry Ahmed , nphamcs@gmail.com References: <20240729112534.3416707-1-alexs@kernel.org> <20240729112534.3416707-7-alexs@kernel.org> <66ad2ef0.170a0220.8fae7.6e38@mx.google.com> Content-Language: en-US From: Alex Shi In-Reply-To: <66ad2ef0.170a0220.8fae7.6e38@mx.google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: 6yjbgehxkpdqtn4si713peamwdufm5zf X-Rspamd-Queue-Id: D8F07180013 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1722846021-967163 X-HE-Meta: U2FsdGVkX1+IMdXW3MZYV3jGBQsKIx2NeQqptQdXPRIDkCnZldHJP2vzJtaalA7Kd0eX1WKyfwL3wAtdXZBtX0VZO+HGa9o20O+ttqqb5TbyUQNheBXdEzdofJlYd684H+0/3KTUWoTq/0XMWFQoXvDudqHT2DlLSaz77oya5fcqAOz2KtkLCn0N6sKwHY6xv5Bk/D+tNxXHk4o3Bn4loHNXNwXb74X0/WePeIhDu/VgZs4JtIOk8WC7Lu+obfEWyw+aAlBreo7IHa86vaTOOUHA58BoC+v80a4C71BNV/+XVlQqbQOmgLGuFdXCQ1Pw6O24WT5oO9YCQEG+szRJOCbKC71cGyyqi8alafht2sK6UbPebI/gyrvdDSdArrL0Dh1Xv3PvPN+UeYER1hZs3NuamhkutS3ByLljxrQK+3mDq3J9Yx/JYL2y/8cw8LXi6nBMa5LxXmuWQqsBdjjJ9OeaJvNbZGp7s3DziNWINT31ukLYOwG0IEDT7WYna2Wfpwo8lxomMJuDUXNL1h5N48++ikoIkgRp0Lb6q6SuGYGjsECwfPCwudiJjk7m0nyO/6Sjs9yhHto46TSukY9Nea9e3DiHdmlpGGQuAgRhZyGDbMr8GBXz2/BUHZAMDuoTfEWonJ2ZmQaxc4iG9G1mnAd62G4GTChcGHc59UMkBgNMznVK56XjLC5p0+CLeTvPZ0jJ2Q1ExnHQEiRX4cE8GNzJH1HNiA5udBm6Ph1lYclsaLejDsotujwlf5pbskWb3wANxzFKkHPGQvWtxV7x4KpcPfzAZMf2VWCQm1+kfpxl23uolGUz/JfJDIkf8V+B3GWRgWq2zEn7WEs1uD1ZcBV0qHlIjug7JmTIKKVvvrHwSeCxjDEgYivvLNFGt8/dVAK3caWuS9wI9dEPx8UOLTmt+/+6iAsITmmeFshb1jVd2mtSS+hLzEDAL8Fb2w5ISv1yqNM3CEr5EHg7/Lr 0z84gybN OnbJ4S6jg5A1TrI0dIq6ne7a0yUp811vOComFm+5ZNh3qHGKzZuvA8U6AeaRSCuSlT5NexIX0rt8xFuvz8QV+tMQSrcC3z+2nJKcY/Zb0GeRu6IGln//MQDZ8dbnYJL00spprYq1feX5s8U0PI+IPyfSp6ycadsBHHkYcSuPA1YgIG7JYzLO+OFDkHz32/80NszbW5QcGRai53zDhVqev/XQ7c0kumdMkJsG9UeErtlRz9gC2vh6skOlAJclNPwDYicR6TXyjH7gTYgyhi4CihTA+dWidcZ9skbxNhjBnoI4w5BPk1E2MJniBSeOy0/C5pkLAVpnYA33FmUdGFrf1/rEngGYjdRMggz1uSlfHYuDzwdVc4I7fdVYSxXhNNNmhZB7v8ueHRQvgYTbTBoBCDMOoFDWH2pSo72Ek6CldBkT6akiHlNrMfDT12UvCtoyUuMMvO3BmoeEWrTU+7s4G8+UsWlxiQPSUlp4PKNHMubnOR3M6V50j2jeLKekGpWTWKvNgUJf7wbX0iojTiuzfflnptMLfpBT312B2iKfX0AMcVSW6HJ2p/++qi5psQO658GpYQwAyGpe2TCs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 8/3/24 3:09 AM, Vishal Moola wrote: > On Mon, Jul 29, 2024 at 07:25:18PM +0800, alexs@kernel.org wrote: >> From: Alex Shi >> >> Introduce a few helper functions for conversion to convert create_page_chain() >> to use zpdesc, then use zpdesc in replace_sub_page() too. > > As a general note, I've been having trouble keeping track of your helper > functions throughout your patchset. Things get confusing when helper > functions are "add-ons" to patches and are then replaced/rewritten > in various subsequent patches - might just be me though. Right, maybe too much helper doesn't give necessary help. > >> Originally-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> >> Signed-off-by: Alex Shi >> --- >> mm/zpdesc.h | 6 +++ >> mm/zsmalloc.c | 115 +++++++++++++++++++++++++++++++++----------------- >> 2 files changed, 82 insertions(+), 39 deletions(-) >> >> diff --git a/mm/zpdesc.h b/mm/zpdesc.h >> index 79ec40b03956..2293453f5d57 100644 >> --- a/mm/zpdesc.h >> +++ b/mm/zpdesc.h >> @@ -102,4 +102,10 @@ static inline struct zpdesc *pfn_zpdesc(unsigned long pfn) >> { >> return page_zpdesc(pfn_to_page(pfn)); >> } >> + >> +static inline void __zpdesc_set_movable(struct zpdesc *zpdesc, >> + const struct movable_operations *mops) >> +{ >> + __SetPageMovable(zpdesc_page(zpdesc), mops); >> +} >> #endif >> diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c >> index bbc165cb587d..a8f390beeab8 100644 >> --- a/mm/zsmalloc.c >> +++ b/mm/zsmalloc.c >> @@ -248,6 +248,41 @@ static inline void *zpdesc_kmap_atomic(struct zpdesc *zpdesc) >> return kmap_atomic(zpdesc_page(zpdesc)); >> } >> >> +static inline void zpdesc_set_zspage(struct zpdesc *zpdesc, >> + struct zspage *zspage) >> +{ >> + zpdesc->zspage = zspage; >> +} >> + >> +static inline void zpdesc_set_first(struct zpdesc *zpdesc) >> +{ >> + SetPagePrivate(zpdesc_page(zpdesc)); >> +} >> + > > I'm not a fan of the names above. IMO, naming should follow some > semblance of consistency regarding their purpose (or have comments > that describe their purpose instead). > > At a glance zpdesc_set_zspage() and zpdesc_set_first() sound like they > are doing similar things, but I don't think they serve similar purposes? zpdesc_set_zspage() only used in one place, a helper maynot needed. Let me remove it. Same thing for the alloc_zpdesc() and free_zpdesc(), they could be merge into using place. Thanks Alex > >> +static inline void zpdesc_inc_zone_page_state(struct zpdesc *zpdesc) >> +{ >> + inc_zone_page_state(zpdesc_page(zpdesc), NR_ZSPAGES); >> +} >> + >> +static inline void zpdesc_dec_zone_page_state(struct zpdesc *zpdesc) >> +{ >> + dec_zone_page_state(zpdesc_page(zpdesc), NR_ZSPAGES); >> +} >> + >> +static inline struct zpdesc *alloc_zpdesc(gfp_t gfp) >> +{ >> + struct page *page = alloc_page(gfp); >> + >> + return page_zpdesc(page); >> +} >> + >> +static inline void free_zpdesc(struct zpdesc *zpdesc) >> +{ >> + struct page *page = zpdesc_page(zpdesc); >> + >> + __free_page(page); >> +} >> + >