From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6975C5B552 for ; Tue, 10 Jun 2025 15:08:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 247CE6B008A; Tue, 10 Jun 2025 11:08:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1F8DC6B008C; Tue, 10 Jun 2025 11:08:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0EA146B0092; Tue, 10 Jun 2025 11:08:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id E312B6B008A for ; Tue, 10 Jun 2025 11:08:04 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 7277C806B0 for ; Tue, 10 Jun 2025 15:08:04 +0000 (UTC) X-FDA: 83539821288.26.C7130A1 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) by imf05.hostedemail.com (Postfix) with ESMTP id 0944C100018 for ; Tue, 10 Jun 2025 15:08:01 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=czmsGW44; spf=pass (imf05.hostedemail.com: domain of dave.hansen@intel.com designates 198.175.65.18 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749568082; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iDIH7L1fCYh4CtbN7PvPQ+tWxXPwKnn3E4jgMmkUR3I=; b=fxd9yD+34z4vFIyik9GXvAoPY+pxoKpYUq3nTSQQy6E2vDZe44n3O6EDmgWqoqlCxrVhTp x3j/7uyij0eVJAAepyQFEvzwXEXBifbV/7J/31KpFepxnC6h8lMgNVcX0sXgg9j69nfLP5 1HwVAQZ6kxtqPSqAMZqBW/NhWgKe7Bc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749568082; a=rsa-sha256; cv=none; b=Orn3TR2NIcucEK7PF9MOwH0Al4bFThDbSqJtin25B1h1ug4+52F0AzbvSd245Zre26wTAx r5glHky7A7kkP4744L2Q1bMMmWLVCN2VEG39obMsRASdAPig7Tk9ZaO73axSnu5Ykd4XEE 9K+Zs/eFbqRaG0s3/doYdXW5FebGElQ= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=czmsGW44; spf=pass (imf05.hostedemail.com: domain of dave.hansen@intel.com designates 198.175.65.18 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1749568082; x=1781104082; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=LH9kMZY6tdKBox0tAJV0Zq5FBDQa1LW23wHkBAN/LTE=; b=czmsGW441QlnzGKhXFNK4bwNs7iDYfFZAV5aVs1RDF8Qh5EIVe3CnpHD d9513W5jntqxvJajcfHLvxXSEd0jiKRKP0tf1zpAITcKIq2z/v9urMv0g tdZufDOBT3LIa1YOzH0XiiP2UwncmAkigmu38HTPdnIPm3UBwKo48VIOM VMAQLIq+G4a5VGZnstKokGyOjqH9568uh9fTI2FIhr1kQy7X8hE9Vudes L7oTmwEuEbdE0bLNume6TEVUiih6XDJLOTkZ5QeJGiQUp2vIeY80gcWcS 4fhAEs6sXdeRqq3G1spgfFZn6J8CTY8zYluCdwEPKEFn9Yk0ijHkQcMC1 g==; X-CSE-ConnectionGUID: J1T0p5AzRF+/Sordr5ou0g== X-CSE-MsgGUID: RuS27edbTLO/GJWOcEyXhg== X-IronPort-AV: E=McAfee;i="6800,10657,11460"; a="51825366" X-IronPort-AV: E=Sophos;i="6.16,225,1744095600"; d="scan'208";a="51825366" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jun 2025 08:08:01 -0700 X-CSE-ConnectionGUID: 2oH32c8FQmyPAjaSLzclOw== X-CSE-MsgGUID: ErjVAIvYTRmBypNJPpWeqQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,225,1744095600"; d="scan'208";a="152009362" Received: from cmdeoliv-mobl4.amr.corp.intel.com (HELO [10.125.111.131]) ([10.125.111.131]) by fmviesa004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jun 2025 08:07:59 -0700 Message-ID: Date: Tue, 10 Jun 2025 08:07:59 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/2] x86/mm: Handle alloc failure in phys_*_init() To: Em Sharnoff , linux-kernel@vger.kernel.org, x86@kernel.org, linux-mm@kvack.org Cc: Ingo Molnar , "H. Peter Anvin" , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Borislav Petkov , "Edgecombe, Rick P" , Oleg Vasilev , Arthur Petukhovsky , Stefan Radig , Misha Sakhnov References: From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 0944C100018 X-Stat-Signature: mrn7pfstzrtkk1exbdsa7i4g8wbf3imc X-Rspamd-Server: rspam04 X-HE-Tag: 1749568081-409116 X-HE-Meta: U2FsdGVkX1+wxC4uj3a3csQVZkbUZpBBY9Clf+phNJdjE2TXc5g37I3ip/Zw+9hoKF5RdENPuLXHK60SNjf5QOWrIkBfNVqv5cVwNbtwaTqBHvCap8tfRP01A9yteLsXGVBFPAOudH0fP+AsLtwqqu+KTXwJyvOrNJQs7CD8tG3KgEnu6KbQnr/TE8mzSufY+rLKHlapFilKjXYNd6f1xP2bvOevAr+Mfz8EWx3rZCeYQncggcp7tnp2VhMwR50yzXvErnzSlZt6ncGxA5qvF6uKxddiaN3xBVpsxrLfvPaJbxG4voQb/w1nhNbqun11/5X0FgFlWUBgqU/tRax+WQtAg31Y8FrOnPEeoziR0Rxvu5QTz4JZHKWvfZwBRR+xSELzLEbaqUAaQwRR+8XuPP23R+noL1CIONEPeyWf46NyjX0IHxmWxhA/YkkTMC9uBwP1xBVxRd/HK/35Hv+DMjg6/IdE5zAFxf/ZXxTPqHd0S7gO1Iz+lt7RZihBuuSl6yqEmDqhyEYh2iN4yQVSm4XdhbDQr3hIqeLFS9E+Q0Q4IVkVFat1Royftg1jjRtSrBCDqvgS2mbXaQkgkSb4pHLztsVRzxOSralPZht7Xqglhk6uE9qQZLRHeLox63cAQzIizlFnzDKsXvZ6Fj/QOsPjhqroCai/zcRQM+sULD3gifkXOlEAuEalwB5OR7fbENYNgCC80NJaoNHM/CemfSTkJ06CyRJVeejT0ZsZAUw+RelaVVpe6DGnJgA7hzvKwN8LtZ6XRz8C/WGtiVFnt3XDTy6YqCNALrR1Deh6K3hdaD2WLqoioS9vB/V+z7L5lPiuCiEwT/JtM40GHDHLU7sCJo2h6EU+Z417MomN/RvSGrKkg8Zkvk0ayZG1nAf4/2ZzH2ijNMaWuIHBEJHIGy9apqlFm0Hldutgm2dBFadnL1ANzfHBNphVK39Yb9PZO9r70Vo1/gzH9NrKfal lv6ctYB0 uRzhf3uAXVPHnUZWv0B4bA9IKJl6iFvx956UhOLmD/UfWmwjOv6qLWabUIBPMacknvmLtD5k0w2LGsEJ0yRiOf7kIam6P9+VP6gZKj9S047PI6T1Qt2E8Afk+d4WkYowZ6bRkhmWJRra53gUqt11p/S/F4D49IFtiJfaIdukkXHiX3Vj49S9eR6dXr7Ca0Wh1If59ryfOKaADDY3S7+cQ/PsX8ABmk7BvxXzvADG+LIhKBH4wXcuZscZUg0hpxJCvyjqu X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/10/25 03:16, Em Sharnoff wrote: > + /* > + * phys_{ppmd,pud,p4d}_init return allocation errors via ERR_PTR. ^ typo? > + * phys_pte_init makes no allocations, so should not error. > + */ > + BUG_ON(IS_ERR((void *)paddr_last));