From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4A0FCA0ED3 for ; Mon, 2 Sep 2024 09:06:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 440EC8D00AD; Mon, 2 Sep 2024 05:06:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3EFF28D0065; Mon, 2 Sep 2024 05:06:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2441C8D00AD; Mon, 2 Sep 2024 05:06:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 0234B8D0065 for ; Mon, 2 Sep 2024 05:06:48 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 98B9741B29 for ; Mon, 2 Sep 2024 09:06:48 +0000 (UTC) X-FDA: 82519218096.25.3C9808E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf29.hostedemail.com (Postfix) with ESMTP id 41EB3120022 for ; Mon, 2 Sep 2024 09:06:46 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=T4iNfHIm; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725267882; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=erTWAWvBD42Ui51I9I1W98Q+PawCGs6ApXaV5CHdeYA=; b=p5+B9SS86o8C7Ka9bqfqHaCqXl46wUBH809OU3BPtn+arhbL4a+pwPsZsuUIVejJdBqj8W O8srwtKupKBDYFvhtuLJIvfAqlm+LA39y2qpgobMELYVjnqh2aoivrsxBcPD9mohtV+Dtu zYzCrJJA1DAjTsx6Sx7vO6emGLQ7VZE= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=T4iNfHIm; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725267882; a=rsa-sha256; cv=none; b=Tgn2HqxwhwGz0hohAhWGUWFejXpKHurLYfoANTMowviriEwn8nVsjmLOQz2BiwIAfrMav/ /NE1/C8/6QnlyVnhG/Ev0a4QYLypzUQhYo8HrGnsRo4Bh/U9Z3IGWXQNHqMfvhsi7XF5t2 Pm1Lk7NI3mpQgAiYOUuYmaK2MXjlyXg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1725268005; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=erTWAWvBD42Ui51I9I1W98Q+PawCGs6ApXaV5CHdeYA=; b=T4iNfHImSTk2ye9hnhE2Cg+2TytsbnQ4RzAfawW4U59qChCz1Tky8qFv4g1zgPbhEaMqG3 84kPd1QE9Z2XL3MKNMXKfccK/bCrH7Y84RhiBGSQ7EYg+G+Poz5fv5H+1VR3LASuPq3ato IZScKilIiQxOZen2dzqyFuPPiqbbTEs= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-488-zRK2M_lyPaWD-Ws2bUMfcA-1; Mon, 02 Sep 2024 05:06:44 -0400 X-MC-Unique: zRK2M_lyPaWD-Ws2bUMfcA-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-42bb68e1706so37564615e9.3 for ; Mon, 02 Sep 2024 02:06:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725268003; x=1725872803; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=erTWAWvBD42Ui51I9I1W98Q+PawCGs6ApXaV5CHdeYA=; b=CZdlHlf3VJ0qvn5sGT/YWENRtm+pIesBlo5+G/SYFelRD6TsVd96nZzGnw3tL/vNrb roe7vcaTHmfsAzradqyRzX4HE+bFBqRY04vLUy7Nj2834Mz3GvjVEKdXtBHtVzSBTOBl uMFSN/kyNx3FrqEQJWwGolosa5fHUD852KCpCBKyTYdIuOuH+lvOan5JyrTdcKKyGoog tM6wp1vtztjxmqj3CXmYBFpQmGIF+by9eA2k29kLH7J+jy205WTQICaBKtCX9RkfnAf1 roMiI/tzjGKINOiX1EjshISsaBQFAlSowkh/HFuJsJjAgdSJnwj5H+Kw8n+vHbJRCElL tRug== X-Forwarded-Encrypted: i=1; AJvYcCUoJW7pdCUNNPoeEuCh3Eoh4adSZVy31J3DMjYP4cwOrdlTzpM3a9CIhACsr+f9a18F15ROa1Uddg==@kvack.org X-Gm-Message-State: AOJu0YwwmeLb7hB1RxqmTpVSTcYeAj2TAjrIdu9V/kt4sq2gd0KVR9iT baaPy/8cc50tI11Yikvp8BHUQGR0pwmzZpP+cZm3MOQsdzwNwA4FborfQCpIRd+ssps7e+gcMVA try0P+P/u27JjWP3j32xwpxzJXqCZRzTV0U8lqFgXSMjkTKGu X-Received: by 2002:a5d:4fcb:0:b0:374:bcdc:625f with SMTP id ffacd0b85a97d-374bcdc63bamr4404792f8f.51.1725268003202; Mon, 02 Sep 2024 02:06:43 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGPcikM1+8NbFnmE62X9EbEUfsfrldaU4ny3SfZ3riP351/VviEtFWwxcERC/0pY102h3tglw== X-Received: by 2002:a5d:4fcb:0:b0:374:bcdc:625f with SMTP id ffacd0b85a97d-374bcdc63bamr4404744f8f.51.1725268002239; Mon, 02 Sep 2024 02:06:42 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42bb6df936dsm130351285e9.28.2024.09.02.02.06.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Sep 2024 02:06:41 -0700 (PDT) Message-ID: Date: Mon, 2 Sep 2024 11:06:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 4/4] mm/page_isolation: remove migratetype parameter from more functions. To: Zi Yan , linux-mm@kvack.org Cc: Oscar Salvador , Vlastimil Babka , Johannes Weiner , Baolin Wang , "Kirill A. Shutemov" , Mel Gorman , linux-kernel@vger.kernel.org References: <20240828202240.2809740-1-ziy@nvidia.com> <20240828202240.2809740-5-ziy@nvidia.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240828202240.2809740-5-ziy@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 41EB3120022 X-Stat-Signature: 93dtx8otmc49jh8pn37qe6wcspor91kj X-Rspam-User: X-HE-Tag: 1725268006-991609 X-HE-Meta: U2FsdGVkX18TdM8kVltA/Ft6VFwCUr74WcyE7NfExDQ4Ltq3Klqqw2yloSf7i+QzhfmTSM9k1qpKAYQRqSYCs758bEYB7s4uHfA0KvuiQEUvUcR00TQ3veNqNyXH/mvET+Zmiq6Bd/J8MDGHUZgTGnHloxYNREzWoHA6bZSf8KR5HpQCXPOAmg0biKMj857WvS9s1t73GKkyIjCT4lVFxcl8YDaND1qd0q+dYn9NoW8eKChlbp5TmnPS1EWTubLj/LR2OHZ5EYU/plIotFc1m6+YJ8/g89eIYCL1josPuHBeL67w17PRS1IyqEmIfOIO0BWrwDPSAAX3RUT/hgghQAtApFB0SUL4jIN//sznr65NkqjosO+Zkt5jBYf23XPz0whl6FATjG4NWry4MhHt+Uehy9rXmtECeBEKp90d8rzX/jwcwXENx0sgmVFnaIBzdMWwtNTbEvMIAh/D08AeYcy0s5Yw5PIp7SPhYKp54KUbojwKJw2HESfImmSRQoy4n8qx+1yNOcAj3BVPY5u8ZbAnF0NWqjjopDlVq2wd0bFM90tQkixxq+qXi2sjFH2upifnPWdXoqwiPW61n9QEczMwFKgJCJhzm80wopattyyMBc4ezKbBrwxZJIKt280Lp4NRlU95sqdS788nCpNp/9A/l8PapAtmjtRUvd7IzdFwTuGHnRaeSMRoCrdGBTge+KBlcCQQPLQWuOTR9QXJbkH2WYzhtQNMznwyD0Bsfgf/w+fMny0Hn3g2ykIUD1CnRvtKYL0MfDEKdlLULGpWGemuxTW/FRKJL/r7Rp/4GzWcxie+Ob7s+P34ohT+eA3asNXbM6hGl99/tmSAFbyTi/sez4HNtweNPNAIhsENmXjDbyujgwCTE8a5MAASuGkMDap97pVOzDESXrrqxm8YAWb7d/y7rt7k288mqr2kWXSlU3AARnGyL2vpLhufLniSJhHAISPihuag07n/yEY WcdUmpe5 S+B3FMfaXxTzphlXRjd3+/wl8tYjpvgJOGge5W5QvWU3I0B+2l5s9umSfKzJ2XaCgcQTOOEl+K3zKtl4rX6xtB8dKAmGFofEFKuYciMpFnsRuxngV5ZnjVk9SPBnuHwy2vmE/q9BJ028F4cPJTybtXE/SAogLQUKhzLXYoyuGIC/XrWpxYL/sZvAdhu/eeDodfIs/29jCOO+C2wOnCOtsEDVDiDM9Z4VIGVnKKlb5xRukKKSu1V5/Cnb3W828J9YKMu2D6L3y/8w7N+SZPwOIG2IuT28hkCyGO4H4A8wFyoVf2ZvV7p4P+WsLb/Iz1qgHet8h3V4OYwjqMKQSbQUHb9xiGy5q6csKLlYsojvpKfKG64KrnxNs9TZrSB0WyTKq+Aq2HMo3bGc9RLbpymCwLMNjutSF06p454H31Y1LlwtbyRbYGeaVSc9lYHuvIx0WRNDtT+cjp429Sy8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 28.08.24 22:22, Zi Yan wrote: > migratetype is no longer overwritten during pageblock isolation, > start_isolate_page_range(), has_unmovable_pages(), and > set_migratetype_isolate() no longer need which migratetype to restore > during isolation failure. For has_unmoable_pages(), it needs to know if > the isolation is for CMA allocation, so adding CMA_ALLOCATION to isolation > flags to provide the information. > > Signed-off-by: Zi Yan > --- > include/linux/page-isolation.h | 3 ++- > mm/memory_hotplug.c | 1 - > mm/page_alloc.c | 4 +++- > mm/page_isolation.c | 27 +++++++++++---------------- > 4 files changed, 16 insertions(+), 19 deletions(-) > > diff --git a/include/linux/page-isolation.h b/include/linux/page-isolation.h > index c2a1bd621561..e94117101b6c 100644 > --- a/include/linux/page-isolation.h > +++ b/include/linux/page-isolation.h > @@ -32,13 +32,14 @@ static inline bool is_migrate_isolate(int migratetype) > > #define MEMORY_OFFLINE 0x1 > #define REPORT_FAILURE 0x2 > +#define CMA_ALLOCATION 0x4 > > void set_pageblock_migratetype(struct page *page, int migratetype); > > bool move_freepages_block_isolate(struct zone *zone, struct page *page); > > int start_isolate_page_range(unsigned long start_pfn, unsigned long end_pfn, > - int migratetype, int flags, gfp_t gfp_flags); > + int flags, gfp_t gfp_flags); > > void undo_isolate_page_range(unsigned long start_pfn, unsigned long end_pfn); > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index 4265272faf4c..fe0b71e0f307 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -1993,7 +1993,6 @@ int offline_pages(unsigned long start_pfn, unsigned long nr_pages, > > /* set above range as isolated */ > ret = start_isolate_page_range(start_pfn, end_pfn, > - MIGRATE_MOVABLE, > MEMORY_OFFLINE | REPORT_FAILURE, > GFP_USER | __GFP_MOVABLE | __GFP_RETRY_MAYFAIL); > if (ret) { > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 4d06932ba69a..c60bb95d7e65 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -6607,7 +6607,9 @@ int alloc_contig_range_noprof(unsigned long start, unsigned long end, > * put back to page allocator so that buddy can use them. > */ > > - ret = start_isolate_page_range(start, end, migratetype, 0, gfp_mask); > + ret = start_isolate_page_range(start, end, > + migratetype == MIGRATE_CMA ? CMA_ALLOCATION : 0, Can we have flags for alloc_contig_range() instead of passing in a (weird) migratetype? Then, we should make sure that we warn if we try a CMA allocation on any pageblock that is not of type CMA. I'm trying to remember what happens if we try offlining a memory region that is of type MIGRATE_CMA right now ... I remember that we fail it. We should make sure that is still the case, otherwise we could seriously break something. -- Cheers, David / dhildenb