From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 68067C79F9F for ; Thu, 10 Sep 2026 15:14:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6608F6B008C; Thu, 10 Sep 2026 11:14:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 611356B0092; Thu, 10 Sep 2026 11:14:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4FFF16B0093; Thu, 10 Sep 2026 11:14:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 256D66B008C for ; Thu, 10 Sep 2026 11:14:36 -0400 (EDT) Received: from smtpin07.hostedemail.com (lb01a-stub [10.200.18.249]) by unirelay10.hostedemail.com (Postfix) with ESMTP id CD1B4C054C for ; Thu, 10 Sep 2026 15:14:34 +0000 (UTC) X-FDA: 85198199268.07.8A30A25 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf31.hostedemail.com (Postfix) with ESMTP id 2B17F20004 for ; Thu, 10 Sep 2026 15:14:33 +0000 (UTC) Authentication-Results: imf31.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20260515 header.b="f8/Hh26n"; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf31.hostedemail.com: domain of david@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=david@kernel.org ARC-Authentication-Results: i=1; imf31.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20260515 header.b="f8/Hh26n"; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf31.hostedemail.com: domain of david@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=david@kernel.org ARC-Seal: i=1; a=rsa-sha256; d=hostedemail.com; s=arc-20220608; cv=none; t=1789053273; b=lxeRB9aRsH6ZzQ36MyQhiFvhIl8RSOW07ZFppy0CLW+N9l4/Y88GJSW0INIa/fgRiPCYRn 9GwlbdyJQpc9PhDil6q/z5qkyeXTmJ8vj22whibupjIqKsPsd1jX1gTSwCB/IRP9LX9OHU u6xrhwljsz+pI00joHbTjYXmHfLvWfs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1789053273; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=i71iPk/nmN9G4xlBgwAONHJyflCRetRnssw9AwqSJHM=; b=Z/jicwMZeHiEJrAggZDv8tuSUy2URuL616GhD7XArxVBEA+Fr3CuzXr3IfJ0WwOf1XNOHo yJZ2M5KdTfbTdBpwubiSlhhdR7WIXgcTu69jLUIRmbwJl+i1d2w8Sode2KMwLzIe0k6OgE mBYCWuOoqbmWbP8xdZxnpZ736uDK7pQ= Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 7C50F600E2; Thu, 10 Sep 2026 15:14:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 25AB31F000FF; Thu, 10 Sep 2026 15:14:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789053272; bh=i71iPk/nmN9G4xlBgwAONHJyflCRetRnssw9AwqSJHM=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=f8/Hh26nq+vVlLOiS5KT2eaI74x8SSamCLxJp5B6lM9ghwH1iXmyQ5ZQzxvpEfzVy 1SRAiuz7mwiqt3spBDTCSj41GoNnyifoWTweI0P/VHXIAsbLhEDaG9bHXsOOmFS5mi 9JIVLu5oH9n1sr9qnTQvpZNiP55Ue57JLPbsBSChckpNhn8HFS0jYo6J2JzRCkso7y AxU2zVNMuNOv+sd0UEci6u4kV28SP+2o4gHy5VzDFGqdi/ysuN/JLyXyk97/8Tsa5b Z8OaFqrw2q+YooSjvOwkk1PqwFoA6KqQKest7wl5OdBcVVkx+zKaxwxvCM8H0wJv1F ZBsCF1NXVdODw== Message-ID: Date: Thu, 10 Sep 2026 17:14:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 11/12] fs/proc/page: clarify comment in get_max_dump_pfn() To: "Lorenzo Stoakes (ARM)" Cc: Andrew Morton , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Kairui Song , Qi Zheng , Shakeel Butt , Barry Song , Axel Rasmussen , Yuanchu Xie , Wei Xu , Baoquan He , Baolin Wang , Brendan Jackman , Johannes Weiner , Zi Yan , Oscar Salvador , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Jan Kiszka , Kieran Bingham , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-cxl@vger.kernel.org, driver-core@lists.linux.dev, linux-fsdevel@vger.kernel.org References: <20260909-b4-sparsemem_cleanups-v1-0-008fc8d579fe@kernel.org> <20260909-b4-sparsemem_cleanups-v1-11-008fc8d579fe@kernel.org> From: "David Hildenbrand (Arm)" Content-Language: en-US Autocrypt: addr=david@kernel.org; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzS5EYXZpZCBIaWxk ZW5icmFuZCAoQ3VycmVudCkgPGRhdmlkQGtlcm5lbC5vcmc+wsGQBBMBCAA6AhsDBQkmWAik AgsJBBUKCQgCFgICHgUCF4AWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaYJt/AIZAQAKCRBN 3hD3AP+DWriiD/9BLGEKG+N8L2AXhikJg6YmXom9ytRwPqDgpHpVg2xdhopoWdMRXjzOrIKD g4LSnFaKneQD0hZhoArEeamG5tyo32xoRsPwkbpIzL0OKSZ8G6mVbFGpjmyDLQCAxteXCLXz ZI0VbsuJKelYnKcXWOIndOrNRvE5eoOfTt2XfBnAapxMYY2IsV+qaUXlO63GgfIOg8RBaj7x 3NxkI3rV0SHhI4GU9K6jCvGghxeS1QX6L/XI9mfAYaIwGy5B68kF26piAVYv/QZDEVIpo3t7 /fjSpxKT8plJH6rhhR0epy8dWRHk3qT5tk2P85twasdloWtkMZ7FsCJRKWscm1BLpsDn6EQ4 jeMHECiY9kGKKi8dQpv3FRyo2QApZ49NNDbwcR0ZndK0XFo15iH708H5Qja/8TuXCwnPWAcJ DQoNIDFyaxe26Rx3ZwUkRALa3iPcVjE0//TrQ4KnFf+lMBSrS33xDDBfevW9+Dk6IISmDH1R HFq2jpkN+FX/PE8eVhV68B2DsAPZ5rUwyCKUXPTJ/irrCCmAAb5Jpv11S7hUSpqtM/6oVESC 3z/7CzrVtRODzLtNgV4r5EI+wAv/3PgJLlMwgJM90Fb3CB2IgbxhjvmB1WNdvXACVydx55V7 LPPKodSTF29rlnQAf9HLgCphuuSrrPn5VQDaYZl4N/7zc2wcWM7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 2B17F20004 X-Stat-Signature: 9mnixtckjdxbazww65asyko4jioca9fz X-Rspamd-Server: rspam01 X-HE-Tag: 1789053273-939807 X-HE-Meta: U2FsdGVkX1/YK9Yvw1T9fJCH+epBo19tPhp87EcKySRuBgwSSynVCi6E+gR3cgDfTmtCy7eKN08onCGGgwP4zvhPbhhUoU+k96hYs+eqk6zsthAOg6AsRc2LPCLkNrHgiHe3iULBFdsv7B2CGgQoHrV65l1Km+Uouk752eVQkDetr3uBj5bLHTW2xzqTv6vxTxjqCHME82CuhX8z4vkCsgG1m914wbixOmaIRr+6tX1P9r3i0r+frr7Te/l/yfW7ZsFvIatxmqvPBhD8klcHkjGcMajB6ay0zclLwLlLS4Ub2FjY5RzkmdRisojjNC/ry6mz/lLpcn64FlFScls5eJgN1yCS7m/SE1ZO2vn/mKYsaOd/n0Ula8AHjUnetR9Y/TrqGr3boXFrXvlF5GzqUD/F5VV/GxKJyr3Z0vYAIiP8o2okq5N4tFCTYFiJTD00RN3G8PLGKnZMFC63CpUIipAes2opQyAmLmeL9tXgPc/7mc52gI+ynVPQeE2PCoSfak+dA44CQOHRwXRpKv3ouOdtlcoHh2b+rOki89qwLM4ORcEu5QTV1uv2/kZRBlpfIuZq3VkiJlBd3RkC9b4st5UhzchhHebfuWHac4GWpp2z7c8s2KJ1ASku79qWzWOSpQbjuMBRPMxsVNTPZ7CFc0catNEJzqN4CTcClPZgNqiGzoNuHSqMGu0aN4NAL/kqvRW9kjeDXvqPdP3pH9dMJBKzfh7qMhJhijGkl2zLdUkmwJMz4TmVSISliym6ZzY1xij3oWGnE2ubd8yTkxzeM+CP6YTxhF3VxM6gRY/hnf8OpnjYdDXPGchNi3lLEylkMjz+PYhflUB3/tk3I7mBEZj2A18iKwj3sniDnV5kYNy8A5nvFfYLMzZXtuRM8pEjneJ3y44HWGdJuTRasaeYsA+Tc5laaAfCEaIhjsqvx1aI30ODqsYrS3X67CjnArDYevWI1XvHkIonRM7WKZs 94FbJEbH ByotufIURItqYZWjVBRAqFSp2DbNo+4kpH/B6MUbXC4vKhJxbwQhJtObHKAD+tu2vdckkqZNvYcF4uOaElqNyw4RrwAV9BNB3OBmZPyYE2NJswiWGGfQP3fqHyU9jJizCKSRN2Och3Yz7YE16YKe66xkJ7Ee0plNy/Brw7sGOY5UOhaCSXP3QnSLHy+tdlTrn8aeKl6+EFZmTMf+uRW6OpTNubT2Vew+qCC/vl+rvV1p7d5Eg2w643nwKM7aPhoxRQO6m+inJ6wmbhtMjPVqgar3TXwL1o/w61Vi8oGPavL1jbd42PFItsnc5N67edNKqZimVNQas/qwDbUM= Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 9/10/26 16:41, Lorenzo Stoakes (ARM) wrote: > On Wed, Sep 09, 2026 at 03:33:04PM +0200, David Hildenbrand (Arm) wrote: >> pfn_to_online_page() will only succeed on some PFNs within the same >> section, not necessarily all. Let's make that clearer. >> >> Signed-off-by: David Hildenbrand (Arm) > > Nit on comment below, but LGTM so: > > Acked-by: Lorenzo Stoakes (ARM) > >> --- >> fs/proc/page.c | 7 +++---- >> 1 file changed, 3 insertions(+), 4 deletions(-) >> >> diff --git a/fs/proc/page.c b/fs/proc/page.c >> index 260772b20bd99..6856ff3e3cf28 100644 >> --- a/fs/proc/page.c >> +++ b/fs/proc/page.c >> @@ -31,10 +31,9 @@ static inline unsigned long get_max_dump_pfn(void) >> { >> #ifdef CONFIG_SPARSEMEM >> /* >> - * The memmap of early sections is completely populated and marked >> - * online even if max_pfn does not fall on a section boundary - >> - * pfn_to_online_page() will succeed on all pages. Allow inspecting >> - * these memmaps. >> + * If max_pfn does not fall on a section boundary, pfn_to_online_page() >> + * can succeed on PFNs beyond max_pfn within the same section. Allow >> + * inspecting these memmaps. > > 'Allow inspection of' these memmaps is clearer I think. But this odd turn of > phrase existed before this change also :) Done, thanks! -- Cheers, David