From: Donet Tom <donettom@linux.ibm.com>
To: Kexin Sun <kexinsun@smail.nju.edu.cn>,
david@kernel.org, osalvador@suse.de, gregkh@linuxfoundation.org,
rafael@kernel.org, dakr@kernel.org, linux-mm@kvack.org,
linux-cxl@vger.kernel.org, driver-core@lists.linux.dev,
linux-kernel@vger.kernel.org
Cc: julia.lawall@inria.fr, xutong.ma@inria.fr, yunbolyu@smu.edu.sg,
ratnadiraw@smu.edu.sg
Subject: Re: [PATCH] drivers/base/memory: fix stale reference to memory_block_add_nid()
Date: Mon, 23 Mar 2026 14:26:24 +0530 [thread overview]
Message-ID: <a691d42b-f4a2-4f4a-8284-4dc537c04285@linux.ibm.com> (raw)
In-Reply-To: <20260321105704.6093-1-kexinsun@smail.nju.edu.cn>
On 3/21/26 4:27 PM, Kexin Sun wrote:
> The function memory_block_add_nid() was renamed to
> memory_block_add_nid_early() by commit 0a947c14e48c
> ("drivers/base: move memory_block_add_nid() into the
> caller"). Update the stale reference in add_memory_block().
>
> Assisted-by: unnamed:deepseek-v3.2 coccinelle
> Signed-off-by: Kexin Sun <kexinsun@smail.nju.edu.cn>
> ---
> drivers/base/memory.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/base/memory.c b/drivers/base/memory.c
> index a3091924918b..0d6ccc7cdf05 100644
> --- a/drivers/base/memory.c
> +++ b/drivers/base/memory.c
> @@ -815,7 +815,7 @@ static int add_memory_block(unsigned long block_id, int nid, unsigned long state
> /*
> * MEM_ONLINE at this point implies early memory. With NUMA,
> * we'll determine the zone when setting the node id via
> - * memory_block_add_nid(). Memory hotplug updated the zone
> + * memory_block_add_nid_early(). Memory hotplug updated the zone
> * manually when memory onlining/offlining succeeds.
> */
> mem->zone = early_node_zone_for_memory_block(mem, NUMA_NO_NODE);
LGTM
Reviewed by: Donet Tom <donettom@linux.ibm.com>
prev parent reply other threads:[~2026-03-23 8:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-21 10:57 [PATCH] drivers/base/memory: fix stale reference to memory_block_add_nid() Kexin Sun
2026-03-23 8:52 ` David Hildenbrand (Arm)
2026-03-23 8:56 ` Donet Tom [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a691d42b-f4a2-4f4a-8284-4dc537c04285@linux.ibm.com \
--to=donettom@linux.ibm.com \
--cc=dakr@kernel.org \
--cc=david@kernel.org \
--cc=driver-core@lists.linux.dev \
--cc=gregkh@linuxfoundation.org \
--cc=julia.lawall@inria.fr \
--cc=kexinsun@smail.nju.edu.cn \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=osalvador@suse.de \
--cc=rafael@kernel.org \
--cc=ratnadiraw@smu.edu.sg \
--cc=xutong.ma@inria.fr \
--cc=yunbolyu@smu.edu.sg \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox