From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F278C76196 for ; Fri, 31 Mar 2023 19:06:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 19E6F6B0078; Fri, 31 Mar 2023 15:06:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 14F2F6B007B; Fri, 31 Mar 2023 15:06:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 03ED56B007D; Fri, 31 Mar 2023 15:06:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id EA3CE6B0078 for ; Fri, 31 Mar 2023 15:06:02 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 9F90A1C674E for ; Fri, 31 Mar 2023 19:06:02 +0000 (UTC) X-FDA: 80630123364.27.82A6A7A Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf14.hostedemail.com (Postfix) with ESMTP id D928010001C for ; Fri, 31 Mar 2023 19:05:59 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="ph/7mpr4"; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf14.hostedemail.com: domain of jlayton@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jlayton@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680289560; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=y4jtQpVryQQtVPt1vPn1t7sDxnQJ5tMq17L9Nkmj0Do=; b=7KK9oib+ri7RdpdfPCGYXW1Gakl0lee7m2CCjCe523Z5IQWN6Rwp5oKebcEgghUUI9y0Dh yZ2AbxsvNhIFm7h49WhbfgktwPa6icZDwOT7vgQCh4l0s5ye1L5yPCppzd+FR/i4KX/skb pMFvGEslH9QwRDfBT9gLeFaYQnoBg+I= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="ph/7mpr4"; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf14.hostedemail.com: domain of jlayton@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jlayton@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680289560; a=rsa-sha256; cv=none; b=7l9zRaiwQ6zi4pOpTvonHvs3XhB+k+dXv3JqSNS1Td/bXanC20+/X/a93cOQ+hp3uz+pop 9RoWe/sBS2dlIWZMKeuyHFFOhBABjCJokNOHGBFKVkRMO2wt1dePkVlMV8Vj6hSuol0J52 JUsT0Fx/yQkmwrGOXgIfTAgB6uKSgOY= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DA83362B67; Fri, 31 Mar 2023 19:05:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6FC5DC433D2; Fri, 31 Mar 2023 19:05:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680289558; bh=iO9lT4G+VhW54/C/njgyZWfDAkyGJR8Jg6RkIdRfetY=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=ph/7mpr4I+PN8mUUNwZLB+N2Azsxl/vFp3YIJ+bdZhdrmM4ACyFf68tVeZCpFqJG4 gYjtsRlbUi3rt2F9V/ekTIedom19mcF67u0Ch4XpJIjyvWzzBtAx+3bj/VRKKxEW/+ SWyMTy2b9bFUbg9eU6qlA3Rys87qUQ/eOnI7py4DPEK3IcLOV8NnQkRv2fcS64pA1w 98pL9Ki9Of2ltspo2xcVvu5zw2hfke7ybOVlOg9XHOEFACFeFvDfdShI1GIrA7Hig9 b9RS5F1AabdNZIwjBa+O/XRFXlF+UlMwZYbtoQUUBprHWaK0lCbQGZqEY65cOKa93M +j9o2x3pShS/g== Message-ID: Subject: Re: [PATCH v3 01/55] netfs: Fix netfs_extract_iter_to_sg() for ITER_UBUF/IOVEC From: Jeff Layton To: David Howells , Matthew Wilcox , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Al Viro , Christoph Hellwig , Jens Axboe , Christian Brauner , Chuck Lever III , Linus Torvalds , netdev@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Steve French , Shyam Prasad N , Rohith Surabattula , linux-cachefs@redhat.com, linux-cifs@vger.kernel.org Date: Fri, 31 Mar 2023 15:05:55 -0400 In-Reply-To: <20230331160914.1608208-2-dhowells@redhat.com> References: <20230331160914.1608208-1-dhowells@redhat.com> <20230331160914.1608208-2-dhowells@redhat.com> Content-Type: text/plain; charset="ISO-8859-15" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: D928010001C X-Stat-Signature: wmzdjkazkjbo8jmphsbeu9jokd4bkrdo X-HE-Tag: 1680289559-800941 X-HE-Meta: U2FsdGVkX18nXBM6cezD9U7k5MDHdvkJUia9hCEe4y3lLw5WgqhziiSduziFy+ITQUVzhYaIKoeut8UGC0nD4gITrZuINqKsLBAWUrnEfsbilvwaoyI7sf8SKqMXY3UYm4xHVbzzBf5XzvB5zLOW9HbJzEgXEOzHuha4PpRLBEAhIYm7ZxirUK/7iKRJgpM+tAba0YHOBQR6gWuGXBQ7yDdK/v2PpVxe5jRyLLf6bKK2rvkned89KzpYFYOnm0+TfgOa819wxhC2sUbysb/M5mjhQFE3lnh6zcFeWIcPDjDhnhPbwVRSwZhd6MmyLhVCIqiQ1nF7QKvO8TDORBCMElEOpZA9nrVdWqNUdMuZg2RfGhmJxJv/Ah1qzsAy2kT4ZXsPEsVMoizn93FgwyWATp5gE/lQOM5hh+Px9X5Lg9HPvV/be9sFcSuHdVkSKv1HuigPlaVNNsF+tss8l13g+2E4PI03AhsGAsuFRDkr4xd8Lnmdv/4XuUrfe4aIFY3AoaTe5a0TWBF5CM9Sprt8fqUUWQT6+KGkeVB1Y3ggkOzDH4gGsN93nRTEzBuCxTt88O+IZJ23rgHpyia/1xGbkYyo4HNuCfKEeM/ZM6so9GR0LBoo0NPMm4ETj+pIpLKX5XGqqpSG0Hd5mZaxIp5xykAC0LhRtHjUf4hTean4qo0Qy6lLd4CKlFFvE6L2/iCvIrduEOXYxV9no4eMCvmH8+6WJbNa3cnVXCQxevQvp7HFps0C7r9OmvZK3GjqYj8ZykkugTY1qorkzPPTktEGol9g+bYyShKMKFd2C+wKtkTL0lz2zG0MCtrbZWqKWVnAxk42xscQnizjrfxDBB/GCcbYWoDSUnVgi8TqwSizIzGVcrOxL5KTl3F6D34gMTonGFA+fvuypzbN393U0CDv6GcptRnRvKmjQG/Vi13ooJxNH2BlkbBVZLKLOy5nBE1sO0hnFK1Fq8Yi6JwilBO 3cB/uvfa jp8lyLl/804vyM0SVfsyjd8n3C5xNvZj2BdYMb7xRrBI7j5K1a6IJjmYesp6JdR0m1VXF9khrClz65i+278O3N1SEexzqZ27HoS8DOoqSsTOG10L2I8qsmuTEYczHrZNMJNtZaVYcCjUSP/gNV+KY7JQx7mjUjvrQ3Ggqb85c1PPCL8M9+GaKGhrz15Ouii0p5iPQY2mKVE4AZ3JSU3JmkLOK7roc+jpNsa/Mpscbk7gYYhRjBDICbcl/YZUQroV7DRDPAqokUYhEiRjmfkUMFaxf5eM/2kGXvndrZVbKF/VK+g2Zwus4aizXT5U9AegYySvN0tcfsK0124S5Qu38EyI1JCqK2Xz5nfjHgxAgS9lo5eM8ohNQo99c/urJaz916bjGYLF1hMXWH6CRQ+FXrlYgzvy9RitDLjxQkwLqntJfrFuOtkJ2i+G1VGlHMrAu3q8go+F0M1kG0ALeoIpUmbzirJWrsDnEOJq4kiyp8NaE51A54abJZ8qh7LOqoU8tVucSNJTMJ75VWiy7NDV28oSVy3J5AiAaWOLJE/CLahY4cs0JNaqUDb4K9Rkkg7qjuZbYDZXTbAiHMfnmY8R14HzOmw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 2023-03-31 at 17:08 +0100, David Howells wrote: > Fix netfs_extract_iter_to_sg() for ITER_UBUF and ITER_IOVEC to set the si= ze > of the page to the part of the page extracted, not the remaining amount o= f > data in the extracted page array at that point. >=20 > This doesn't yet affect anything as cifs, the only current user, only > passes in non-user-backed iterators. >=20 > Fixes: 018584697533 ("netfs: Add a function to extract an iterator into a= scatterlist") > Signed-off-by: David Howells > cc: Jeff Layton > cc: Steve French > cc: Shyam Prasad N > cc: Rohith Surabattula > cc: linux-cachefs@redhat.com > cc: linux-cifs@vger.kernel.org > cc: linux-fsdevel@vger.kernel.org > --- > fs/netfs/iterator.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/fs/netfs/iterator.c b/fs/netfs/iterator.c > index e9a45dea748a..8a4c86687429 100644 > --- a/fs/netfs/iterator.c > +++ b/fs/netfs/iterator.c > @@ -139,7 +139,7 @@ static ssize_t netfs_extract_user_to_sg(struct iov_it= er *iter, > size_t seg =3D min_t(size_t, PAGE_SIZE - off, len); > =20 > *pages++ =3D NULL; > - sg_set_page(sg, page, len, off); > + sg_set_page(sg, page, seg, off); > sgtable->nents++; > sg++; > len -=3D seg; >=20 Reviewed-by: Jeff Layton