From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA3ADC83F1A for ; Fri, 11 Jul 2025 11:59:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7C2856B00A9; Fri, 11 Jul 2025 07:59:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 79A746B00AA; Fri, 11 Jul 2025 07:59:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6B0266B00AB; Fri, 11 Jul 2025 07:59:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 5C2126B00A9 for ; Fri, 11 Jul 2025 07:59:00 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 095DD1DAFB6 for ; Fri, 11 Jul 2025 11:59:00 +0000 (UTC) X-FDA: 83651837640.02.B601C4A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf18.hostedemail.com (Postfix) with ESMTP id 61C6B1C0018 for ; Fri, 11 Jul 2025 11:58:57 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dbKHLlgk; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752235137; a=rsa-sha256; cv=none; b=CgGYxvaMWvN63Pi6+CGe22TpkF1VHmSru3I9V4HPZP46WFNqmdKE/YqjOhezpwckYpOc/z xc6jpUskGATb6HGBzYFjyaklys1sWGVCuONxwKN8klseNpSMqhuxdovjHPOXUJKVpwc1gA lZ74RNxZT41JGIAx4K8ES+/ZoyW0L1Q= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dbKHLlgk; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752235137; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GD1ZVd4/AjOtZiQd6PXK5gen+3IMNVTa6EqawMIDX/k=; b=UF56BnxhT180qQa50vecFAALwnjN94VtWDRCMeYmsgHJgRFHaw+VulE/a+TKt315XHkjXI nUexrlgiZky/oevl8cDCFo0JWJERFJbXGmzUlX5eprXqDLM4orTRKBiuX3hMobAq8fPQAH uFFCItjRZWjmPCVoLuYDeYOgHiTHM7I= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752235136; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=GD1ZVd4/AjOtZiQd6PXK5gen+3IMNVTa6EqawMIDX/k=; b=dbKHLlgkDxBqBTAgljWfqMMpO3p9jAZz7qBJvElravKWtTxEfPM9zf0u+U+8RR+vVnVfxU Mh9+L9vZDryYFIh6Hpm2KpXqoLOtuPaBfTc5LuiY9H9kbrdsQ9BSUNSreCIbSn0xzg9pvn Txlml5Z24kEy8mAgxBV+8753SDzGs6A= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-393-IKUwUUAuP5mtzkutuW9EjA-1; Fri, 11 Jul 2025 07:58:55 -0400 X-MC-Unique: IKUwUUAuP5mtzkutuW9EjA-1 X-Mimecast-MFC-AGG-ID: IKUwUUAuP5mtzkutuW9EjA_1752235134 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3a4f3796779so825099f8f.1 for ; Fri, 11 Jul 2025 04:58:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752235134; x=1752839934; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=GD1ZVd4/AjOtZiQd6PXK5gen+3IMNVTa6EqawMIDX/k=; b=OS1C3zXSJIe8tZBkaAbYOmaMgoUkBEB3mubZI35noK8uMOwTOIiieInYFws8xFrycD /BZvzClCikYOoXRNa59X6kbGDhmI/+rohsCVQqmyWtMdwyCWTssQ1uwHGHoLFn//ZM8u dF8db9kEwt8337FmcjUeTlNUvfk9RPehN441E4UtcsWLwgk/TcZD2KmZoGaKPrDTGt90 ZTmnIB3ie7koSWRLLmJKcpkHhZPdwL0Nqo0GgAqhq0YO1mnuFE5uYh09eDVTs6pf0t5g BUJgDw1TK1I9jGApxQs6FCVgTAocNZczgAVA12uBl+/9V6hfGVUaJbE/J+bwL1KqAJ4G PIag== X-Forwarded-Encrypted: i=1; AJvYcCXEU4IBFvD62yISW8IzgGm6YTpHPwlo443vvdaI8Uu2Kb6PC8ZYJX8Bo7ygQw+qr3mbluR3hZVv8Q==@kvack.org X-Gm-Message-State: AOJu0YzeYGMIRPp60IBf2dZ6VY4YhqMXjjlM7RTCxjaWoXkRz4q+Nhmq QHKgRl/r54znAcFqowDYSlwDaAZJI9AbYNHkpbIUjrKnHZ6mocZO9xvWBkcp/3p0y1rnqCAAz/F Z5xMubhKpeRBH+kOMQJG22vvbZqRIDsaYAFdeHKz/AyXqfKo8l376 X-Gm-Gg: ASbGncsHYr572Gim44iOUWA9KRj9h5dUQqAXcWkjclrRacAHoKRLwqCmyXJZYbTsfGe K4GuHNC/I2pRO4B8dq7S4bC/mvKXLr6zZUBrpsepGdLYYE6vnfY1Nec5y3RdFrpo0kF98gOxBW0 4NzmVcdJmFaDgbgaU8k3APvsWnCA6qSAXvRa6TAa6iRQFnz0V4dszdu9SbE7kmspaD66sQKsI8f ZBhtCEGHlcEVaRTQyV7GE2tJZt4ozWK1DbffYDKqXz7vX4ZL6TPhqoRVCPIfJwqggIrofUpayYL oYpAYQ8RPW5PhSOHB1lSbqlyZEGW1S9W66nz8ob7ozzzEMQHLFms9kk8jDiFQEtZsGV9RjvVMAa pGIonqcjUNfVNM0RxyxtgirZMgZb/IptKKujTZit/LBib5bP5iMN7XN+50XqjVRqvvJY= X-Received: by 2002:a5d:5d0a:0:b0:3a5:5270:c38f with SMTP id ffacd0b85a97d-3b5f17f81efmr2490990f8f.0.1752235134235; Fri, 11 Jul 2025 04:58:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFwQ0yjfGgbrdPfsdS3XDPZ5kUA1A90UwOpxwFgAtqeIvAIy0tnjiXpyNWxRzo7dGabUFOX8g== X-Received: by 2002:a5d:5d0a:0:b0:3a5:5270:c38f with SMTP id ffacd0b85a97d-3b5f17f81efmr2490970f8f.0.1752235133773; Fri, 11 Jul 2025 04:58:53 -0700 (PDT) Received: from ?IPV6:2003:d8:2f3c:3a00:5662:26b3:3e5d:438e? (p200300d82f3c3a00566226b33e5d438e.dip0.t-ipconnect.de. [2003:d8:2f3c:3a00:5662:26b3:3e5d:438e]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b5e8dc1e4fsm4240246f8f.21.2025.07.11.04.58.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Jul 2025 04:58:53 -0700 (PDT) Message-ID: Date: Fri, 11 Jul 2025 13:58:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] fuse: use default writeback accounting To: Bernd Schubert , Joanne Koong , miklos@szeredi.hu Cc: linux-fsdevel@vger.kernel.org, willy@infradead.org, linux-mm@kvack.org References: <20250707234606.2300149-1-joannelkoong@gmail.com> <20250707234606.2300149-2-joannelkoong@gmail.com> <4ef06726-1851-44af-b4d1-45b828746ce2@bsbernd.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <4ef06726-1851-44af-b4d1-45b828746ce2@bsbernd.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: uYP1KZM7rTgwt0hOFNivxF3uuBl0P-P4d-2vmLw7BS8_1752235134 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam11 X-Rspam-User: X-Stat-Signature: 8g3dmndipda35c7oztsrswkp5n1jzt3q X-Rspamd-Queue-Id: 61C6B1C0018 X-HE-Tag: 1752235137-770147 X-HE-Meta: U2FsdGVkX19EIOOY3Qitv6/1uoR4QiwmN5fMU5kf8waVRaXV0+cuAfl9AkxVnRMfbsnWg5l8GAVk7N8OgbBIZwI+Qlk5FynGZ7ZOMI25yDU2luH5597PnYDZgtrQ4VD/B/9qvh0lHP7656wv3Izx+YwGSN8xeE1exlb2d2j2np4C8Jm0m6BAJwVCV7QlTPwbr0MMu4HFwYGcQ3Wu2Ae0lpCwUmhSe94dc5suRUkUyOrJFlhSv+otIYAJ7y8bXWdl88vnKQSwMy2MjEky15Oh74bHvpvGbt0YyVHottDDSAMD2nUbloJluYBb4u/rvsggBfKc5RUl0JMzygv2opPUzZjOuw+ucFMZ4+JeA8NfZjF/MzpA/930tAwlZ0juwLQGfo4hG9r5u0EkJU3lx5lehKkgOhchmoFIL0fVUMSu6YlmWrFv+iqFa69efupnuM5f9K9YHxBlDLJwr9Qav+ZAvecROQpXOfcPpJb+WzDerX346ouIJA8KSLLSbAThgMVNDxPQONTY0H5/rp5eqnjnHJhAVAMtwuhgrCx74AZCtTSnK6zh1aftWBQFiZkkvNM4U8YetXJXNpM/YRjG8AAEcS+4hJGktTSETTcEs1V3IyDzYwcjXXSxGgPLeI+vY+r8BoJ5jrwd9mPvrWwLXJnjpPnbtiTPoNfTPuBVJL6WmfMw4Vh/Mdd47OaKHK6MqHJMLDVlfV1L6FViv723dbryTF845jjh4C54/Fu6VHbN/Kr8v4PrC75HbhKES29MFzsJLVQD7vtikPupyDj29WcAS9bpiUoEpyf/v+Y9N5/voSz4pf2gkB0YXpmoJaKpNP8uJ6TkMK+uYdEVAn/0L4naK6NW0rLHFyCOYWmdHC7Iwp9wkUXqxoZy6DTckuM82OxYd6gvoUgrfBMXeVIdHvPRM/G5m2B1rrHt5f9VQA5vhvbZkwUTVvN+XQ4AZMvmm/Q/UZl21ONm6cucXMHWSZE N0j/Z3wh H5lj5ng52XrCtwxTVx7YynBjRnpDw1pI6xQZk0UCVpAY0RWyQhEiFDYnz4Mu6VUwxQ4sGL5YHejQXAs5TEDY4yqq0WP9hjijJpI+D6u+8nnq4s9pQzk4vVtL22pYITahBp8S683mNHl/U0zs+ybZjAd9YiKcT1D3Cfyz2EM+UH5KLAPaEhU7TZfhkBlhoJSid18pJ9OmiO435SRua61gvE2GzmncVJKwnpaQ8nUSdd3uM+nPNAwC8Yx+KzmryJdzWyngEQfCmahWIhmvHn3Q0Pt5baZqzcOy2P+yQ8L8Iazk07jaMY6tR+An9ULHfJMRSRqGuYGTcwgjsJa2be+KT/wcP+SlhoVPKoBitGCnugg34TOV5g513kNoniw1Uq7AKWmjnxypx2cXB+is9myzAY3IccrJZu5wYPTSG9r+Z68Jg78iSku6Ux7lMxlZ56OwmmM/Eb8URBUdE7rvfbjWiMWWGcRcIdbSXvK/a X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 09.07.25 13:06, Bernd Schubert wrote: > > > On 7/8/25 01:46, Joanne Koong wrote: >> commit 0c58a97f919c ("fuse: remove tmp folio for writebacks and internal >> rb tree") removed temp folios for dirty page writeback. Consequently, >> fuse can now use the default writeback accounting. >> >> With switching fuse to use default writeback accounting, there are some >> added benefits. This updates wb->writeback_inodes tracking as well now >> and updates writeback throughput estimates after writeback completion. >> >> This commit also removes inc_wb_stat() and dec_wb_stat(). These have no >> callers anymore now that fuse does not call them. >> >> Signed-off-by: Joanne Koong >> --- >> fs/fuse/file.c | 9 +-------- >> fs/fuse/inode.c | 2 -- >> include/linux/backing-dev.h | 10 ---------- >> 3 files changed, 1 insertion(+), 20 deletions(-) >> >> diff --git a/fs/fuse/file.c b/fs/fuse/file.c >> index adc4aa6810f5..e53331c851eb 100644 >> --- a/fs/fuse/file.c >> +++ b/fs/fuse/file.c >> @@ -1784,19 +1784,15 @@ static void fuse_writepage_finish(struct fuse_writepage_args *wpa) >> struct fuse_args_pages *ap = &wpa->ia.ap; >> struct inode *inode = wpa->inode; >> struct fuse_inode *fi = get_fuse_inode(inode); >> - struct backing_dev_info *bdi = inode_to_bdi(inode); >> int i; >> >> - for (i = 0; i < ap->num_folios; i++) { >> + for (i = 0; i < ap->num_folios; i++) >> /* >> * Benchmarks showed that ending writeback within the >> * scope of the fi->lock alleviates xarray lock >> * contention and noticeably improves performance. >> */ >> folio_end_writeback(ap->folios[i]); >> - dec_wb_stat(&bdi->wb, WB_WRITEBACK); >> - wb_writeout_inc(&bdi->wb); >> - } > > Probably, just my own style, personally I keep the braces when there are > comments. Yeah, sometimes it can aid readability. I tend to keep them on multi-line comments IIRC. Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb