From: David Hildenbrand <david@redhat.com>
To: Harry Yoo <harry.yoo@oracle.com>,
Andrew Morton <akpm@linux-foundation.org>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
"Liam R . Howlett" <Liam.Howlett@oracle.com>,
Vlastimil Babka <vbabka@suse.cz>, Mike Rapoport <rppt@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>
Cc: linux-mm@kvack.org
Subject: Re: [PATCH V1 2/2] treewide: include linux/pgalloc.h instead of asm/pgalloc.h
Date: Mon, 20 Oct 2025 15:39:42 +0200 [thread overview]
Message-ID: <a84bfe66-2713-487f-8ffa-8449385511b1@redhat.com> (raw)
In-Reply-To: <20251019072509.9488-3-harry.yoo@oracle.com>
On 19.10.25 09:25, Harry Yoo wrote:
> For now, including <asm/pgalloc.h> instead of <linux/pgalloc.h>
> is technically fine unless the .c file calls p*d_populate_kernel()
> helper functions.
>
> But it is a better practice to always include <linux/pgalloc.h>.
> Include <linux/pgalloc.h> instead of <asm/pgalloc.h> outside arch/.
>
> Signed-off-by: Harry Yoo <harry.yoo@oracle.com>
> ---
Acked-by: David Hildenbrand <david@redhat.com>
--
Cheers
David / dhildenb
next prev parent reply other threads:[~2025-10-20 13:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-19 7:25 [PATCH V1 0/2] mm: MISC follow-up patches for linux/pgalloc.h Harry Yoo
2025-10-19 7:25 ` [PATCH V1 1/2] MAINTAINERS: add include/linux/pgalloc.h to MM CORE section Harry Yoo
2025-10-19 22:07 ` SeongJae Park
2025-10-20 7:43 ` Harry Yoo
2025-10-20 13:38 ` David Hildenbrand
2025-10-20 13:51 ` Harry Yoo
2025-10-20 14:07 ` David Hildenbrand
2025-10-20 14:05 ` Lorenzo Stoakes
2025-10-20 14:10 ` Harry Yoo
2025-10-20 14:34 ` Mike Rapoport
2025-10-19 7:25 ` [PATCH V1 2/2] treewide: include linux/pgalloc.h instead of asm/pgalloc.h Harry Yoo
2025-10-20 13:39 ` David Hildenbrand [this message]
2025-10-20 14:12 ` Lorenzo Stoakes
2025-10-20 14:44 ` Mike Rapoport
2025-10-21 5:09 ` Harry Yoo
2025-10-21 6:07 ` Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a84bfe66-2713-487f-8ffa-8449385511b1@redhat.com \
--to=david@redhat.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=harry.yoo@oracle.com \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mhocko@suse.com \
--cc=rppt@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).