From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7376C4345F for ; Mon, 6 May 2024 02:15:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3C6246B0083; Sun, 5 May 2024 22:15:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 376D06B0085; Sun, 5 May 2024 22:15:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2172F6B0087; Sun, 5 May 2024 22:15:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 039356B0083 for ; Sun, 5 May 2024 22:15:25 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A05611206E1 for ; Mon, 6 May 2024 02:15:25 +0000 (UTC) X-FDA: 82086354210.25.B7DE14D Received: from dggsgout12.his.huawei.com (unknown [45.249.212.56]) by imf03.hostedemail.com (Postfix) with ESMTP id D67D220007 for ; Mon, 6 May 2024 02:15:21 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf03.hostedemail.com: domain of shikemeng@huaweicloud.com designates 45.249.212.56 as permitted sender) smtp.mailfrom=shikemeng@huaweicloud.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714961723; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dfiMbKO6jnY4J6LfPPkwis4W3ybLYw7d5ywxWCvuhus=; b=F8Syk/BR8tLJAv2Np0iW3EmYreUqc5/CF2hFOPsU7J5y6Rk2yXNNDjrBvNMXIrl1FZ3Aos OFEatwi/T3i8/teL750hJDEm5pqVUmtOK/MUaDyYL1uBabYCZxF3L07qlQJdQxNgWny2jj caHa9PYfYGQPFJZpNv4z0x7D3p0N7Ik= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf03.hostedemail.com: domain of shikemeng@huaweicloud.com designates 45.249.212.56 as permitted sender) smtp.mailfrom=shikemeng@huaweicloud.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714961723; a=rsa-sha256; cv=none; b=Q5ZvPiOtutPULEbIP/czNvfRLYdWIteJWD5n5aubPy1R0Pwu7SQuP4blMF50MfW+FrFcHG R3O2PrbSJuFMLPnbd0y7FC+ZT6l4AQ49y01KHE9DAnzHdllByimC6cPAgzjvbCW4mw+U34 NfLFVAUnmkAPzCxxus3TvVBYyGF1uig= Received: from mail.maildlp.com (unknown [172.19.93.142]) by dggsgout12.his.huawei.com (SkyGuard) with ESMTP id 4VXlNq08qgz4f3l2M for ; Mon, 6 May 2024 10:15:07 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.112]) by mail.maildlp.com (Postfix) with ESMTP id 327CD1A0179 for ; Mon, 6 May 2024 10:15:15 +0800 (CST) Received: from [10.174.178.129] (unknown [10.174.178.129]) by APP1 (Coremail) with SMTP id cCh0CgB3jgctPThmL6mELw--.10749S2; Mon, 06 May 2024 10:15:11 +0800 (CST) Subject: Re: [PATCH 09/10] writeback: factor out wb_dirty_exceeded to remove repeated code To: Dan Carpenter , oe-kbuild@lists.linux.dev, willy@infradead.org, akpm@linux-foundation.org, jack@suse.cz, tj@kernel.org Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <6d3471cd-f491-4949-ba75-9fae63198b59@moroto.mountain> From: Kemeng Shi Message-ID: Date: Mon, 6 May 2024 10:15:09 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: <6d3471cd-f491-4949-ba75-9fae63198b59@moroto.mountain> Content-Type: text/plain; charset=gbk Content-Transfer-Encoding: 7bit X-CM-TRANSID:cCh0CgB3jgctPThmL6mELw--.10749S2 X-Coremail-Antispam: 1UD129KBjvJXoW7uFykXryDWw18uF4DAFy8AFb_yoW8Gw18pF 4rua98KF4rXr1xtayDJrW7Za1Yqws5Jw17WwnxWw1fZFW29F9Fgr1I9rWagrsF9rn7KryY yrsIvFyDtw1UK3DanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUvab4IE77IF4wAFF20E14v26r4j6ryUM7CY07I20VC2zVCF04k2 6cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4 vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_tr0E3s1l84ACjcxK6xIIjxv20xvEc7Cj xVAFwI0_Gr1j6F4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x 0267AKxVW0oVCq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG 6I80ewAv7VC0I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFV Cjc4AY6r1j6r4UM4x0Y48IcVAKI48JM4IIrI8v6xkF7I0E8cxan2IY04v7Mxk0xIA0c2IE e2xFo4CEbIxvr21l42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxV Aqx4xG67AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r1q 6r43MIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6x kF7I0E14v26r4j6F4UMIIF0xvE42xK8VAvwI8IcIk0rVWrJr0_WFyUJwCI42IY6I8E87Iv 67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF7I0E14v26r4j6r4UJbIYCTnIWIevJa73UjIFyT uYvjxUrR6zUUUUU X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: D67D220007 X-Stat-Signature: 54kx4zdz7pk816kgnukq1zrt9km8x3qh X-HE-Tag: 1714961721-582863 X-HE-Meta: U2FsdGVkX1+W/qHIh5fOqvCWYeUm7wZdT9f9DSrC4Q17p69eEo990bF7TZPRJE1Wsd3oXGszKHRAhdW1iPNvKphvT9L3eO1yfBwXCB+qYfHJOJ/OE6bAn9dvVM8c0UpHJrTUwZbKxLCQLt8tHBXiA+99VEnc9ddHFrxYA5jk8K/EdRTZ1jQY8C1VlaWqwRakDz0+SPA076ImppdyFA7KVloO6DXmTvO317wwaWrxWKOHvCgh9CLxNTWN57/xdqIHZ95bs2t8iOxRZy8rnWRir/TM6FYhyxhJxI3SDeH6O1YYu4jZx7Rc7FXWB7+orU3w2Dm7RGYOO88KDQshZAyzvmXridzD3+AFOtQLlx0fhVZG5So1r7DOMzKO3WmBJZwVhPC4UoVgbtv0qgid1gUM48FIL/pOd5NrAcrcuv15d7B5ujQjWcW0qzz1aNxsvKpLfq6P0IXAV5Z7Sy5HwfBhgHpSSb92UXvV4yiMF9uyEpdpnk+MMQAYJMCYMI7FzRC+2frw1i7MQRTJ6nvmx2pwaz7Yd2u+QIg2eO2q2aWFa2eh3a+QAW+dAEP0+HXM/Ku5TNZd05A9txKNV4CxgCFFdAMbt2ZhDFsY9224XbIRH2TIOtG7ZNhHuCQwP4upfgtNJ3txXEJAPxAe8XES5g2ojEQ3MBqGngsAJaVjnmDOUAga0LZt7syuFxAqnoIe1cB59M9cr5Y9ylxF6nPn3k22XZrscJoho52BgcgoDPNecnKUiC5U8+sOCkSB9C/uNDaq0EXjrhDweEdplU9b1WB3+Tsb6CPJn3J6B+BKLZjNnMopkycGTNSJz4QEMR2X7YbTgnpAzYks5HLxpMkx9pAxHFDToh1g5IXQwJWw9/h7eZJj+wFzju2bOtU4UUWcVky+Ze5pXnpOJPqo7q7Nlc/Bv4JqVszg2y1fwYE0nEE9DaFZF/EWGa8nQ87d9r1+5S9eoygzVo7rasB6sYukTPl XDvkptFS 7gTQev8+qdR1qt2qdvTrGHXL570i0HJjwX96rpd7z7ITzU0wBVzs2SYLaoiMpu7adz1HqlMnd+0cS0tPvTdMv4+9HNeI/HAYlq5WkLGT+NoByaEJm9uKvX5wcsSbJXhR2HrVDFjrToJ+RWEox7wy1HeoV60rhaQmwDA11FO/nzAQ40cDp1EBeWz+/0ofVRPK/363rFj2WrZ0pcI/hbTX21doIH7fY9lshqGFZKBfW7qEV+WFAkg9sN0DBtWFrXf/on+pBHv6vkoBRM+pYn9/ru8Lo+rI8nAqBOup6Tx4HHZHmLFhombpd8s0//CV2zqA5woodmL1Ta6l2z0yR2KrD1P6FUlxKsH47Jw5mNTY0nvzRPe5q/XF0BiJZ1kcGpDSPk0a6N/ov70lGkYPA4ZGuBtDStAXAPQfQnL4xcXM595e+y0LFLWFg94fGACwvtmk5eieegDMjCkTqFDhFTFLINYPf13NN4s52CKfBIgBHap85sDKJSuvE0EDc9f5PLR2REF/CTcTdVfn0iQRdu2OdTawZUHwG2Q0pLo6e+Qg3h+BV9rW9A+9J+4bOxQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: on 4/30/2024 3:24 PM, Dan Carpenter wrote: > Hi Kemeng, > > kernel test robot noticed the following build warnings: > > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > url: https://github.com/intel-lab-lkp/linux/commits/Kemeng-Shi/writeback-factor-out-wb_bg_dirty_limits-to-remove-repeated-code/20240429-114903 > base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything > patch link: https://lore.kernel.org/r/20240429034738.138609-10-shikemeng%40huaweicloud.com > patch subject: [PATCH 09/10] writeback: factor out wb_dirty_exceeded to remove repeated code > config: i386-randconfig-141-20240429 (https://download.01.org/0day-ci/archive/20240430/202404300231.bnb28iB8-lkp@intel.com/config) > compiler: gcc-13 (Ubuntu 13.2.0-4ubuntu3) 13.2.0 > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Reported-by: Dan Carpenter > | Closes: https://lore.kernel.org/r/202404300231.bnb28iB8-lkp@intel.com/ > > New smatch warnings: > mm/page-writeback.c:1903 balance_dirty_pages() error: we previously assumed 'mdtc' could be null (see line 1886) Will fix this in next version. Thanks a lot for the report. Kemeng