From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9B8FC52D7C for ; Thu, 22 Aug 2024 12:36:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2BA136B016E; Thu, 22 Aug 2024 08:36:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 241BB6B020B; Thu, 22 Aug 2024 08:36:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 045746B0258; Thu, 22 Aug 2024 08:36:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id DA0336B0251 for ; Thu, 22 Aug 2024 08:36:04 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 014A4A075A for ; Thu, 22 Aug 2024 12:36:03 +0000 (UTC) X-FDA: 82479828648.15.4FBACBE Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) by imf13.hostedemail.com (Postfix) with ESMTP id ED11C2001D for ; Thu, 22 Aug 2024 12:36:01 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="T/KeKEEo"; spf=pass (imf13.hostedemail.com: domain of asml.silence@gmail.com designates 209.85.208.44 as permitted sender) smtp.mailfrom=asml.silence@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724330054; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Y0pMPsBjfu3dCB3+6WO3b2ZXmLp2DSYl2Qd4E0/Rydo=; b=i9VZlVuPYAwZ/GDhtjgeEXxbLr41l3z5wuYiX+U6ez8mrkBJ4XEnWs4owTETGMnND3H6Pe Q6H6xG4Xp59Q+IV6MTmK54nDDleGVHxnOT55tBgPykTk1dkXbAYmm295/lfV9be0Ps5cLK 5mhT9w6BXr/TQDvYEGgDITZDWvNLRq0= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="T/KeKEEo"; spf=pass (imf13.hostedemail.com: domain of asml.silence@gmail.com designates 209.85.208.44 as permitted sender) smtp.mailfrom=asml.silence@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724330054; a=rsa-sha256; cv=none; b=iuNHW1PRDaLiEz3iYYHw63xuoEly6L4/VWcabwlH0Ge6oirMhLpPBXV84tvLdeUaNeaLoy QZ0vZJAf5cs7Ynzun8LPezT7Afnk8qc8Inu2196puszMWnauzgfmIRl4SFjLREWBD850iy taRf13ekEAb9hftNi73Mnlvl+gDqPds= Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-5bed83488b3so1159989a12.0 for ; Thu, 22 Aug 2024 05:36:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724330160; x=1724934960; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Y0pMPsBjfu3dCB3+6WO3b2ZXmLp2DSYl2Qd4E0/Rydo=; b=T/KeKEEomG+ZuuwkkwSOGeUfSivcdvpiR6C1SYCbxTFuU2YT0bsGmI4SNL1obIH3uw Fr+fzY2C4iaiv/QYXTC8e/ClhKBA+X4MlfXzdGfnu1fE5byjwfBRBdU+WBhwXhPUsUU3 4rolhcPsY+42U8SxU4lb8bmkzZjEq0u1CzcObonFcyapgBWS/ww4roCbj6vdVt1FsDgR 4jdqElicX4EunHKUS50zg1+OH64ddCTHNzj1SBcDrHrU32UtL0fnawJU14oOU3YzfQqf Dk5s7Zcj2CJzbkBZHiuIZnfuHEIER4XwXwzm5lXHxr2wAVv4wspVyRWnwKWvT9n80TgE aF+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724330160; x=1724934960; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Y0pMPsBjfu3dCB3+6WO3b2ZXmLp2DSYl2Qd4E0/Rydo=; b=ap4SoYiKzTmnsns5lDJjXfJCcNA0UpLVmHCqlRWnDuoQcmrCLXYrGPISdbydUVSLZ+ 1U7LjAQmPUgEEWDW7Xdui8iytpfCxCPX+dHiNF7bW6s4KkNA/jMMIb+OSC8/oZ99uq1M JoCOJ65+Jx6y4k5aPv0jSNSRAqi20595yYJ9N3yvE+i46LDbwbobMYxM3jf/++S1htt2 lOSMOxt1+a5erSJRG+fVMHfSrAB9MWT84GaN3kBpq/XHZwrmt06+9AuydmtGXoSz8aKh MlVMfinIM5Y1mBdxL74L+o4zZXuNeybP+9JMlIW77HGA/MPdrUzoIwNqDI0W/Ou0M+RA jtrQ== X-Forwarded-Encrypted: i=1; AJvYcCXzu7KzFbboQey4v8tsrW1gqZ0qFhBMkwC159cOq9A83XAdOx14Kxecp28MFV+quJey4YKnzTwffw==@kvack.org X-Gm-Message-State: AOJu0YxYDvbOyfognvDLtx4fwn/GzTFOv7T1xIwbHbRmpUEgzxBJI1i8 1uvDqArtBjtz4/dtH2eFBBrJZ7+KPu+EjhB+UcCv310QBU9iJJ+6 X-Google-Smtp-Source: AGHT+IGKNaV7MLhLQaURhHOFGPu6Kqf5Qp99mLeFBENxbzRW3NVESyNh9p4Lt3JNZQQSiaQRVAnJTA== X-Received: by 2002:a05:6402:34d5:b0:5be:fbce:939e with SMTP id 4fb4d7f45d1cf-5bf1efb58c0mr4431296a12.0.1724330159914; Thu, 22 Aug 2024 05:35:59 -0700 (PDT) Received: from [192.168.42.32] ([163.114.131.193]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5c04a3ead28sm881866a12.56.2024.08.22.05.35.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Aug 2024 05:35:59 -0700 (PDT) Message-ID: Date: Thu, 22 Aug 2024 13:36:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 7/7] block: implement async secure erase To: Christoph Hellwig Cc: io-uring@vger.kernel.org, Jens Axboe , Conrad Meyer , linux-block@vger.kernel.org, linux-mm@kvack.org References: <5ee52b6cc60fb3d4ecc3d689a3b30eabf4359dba.1724297388.git.asml.silence@gmail.com> Content-Language: en-US From: Pavel Begunkov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: ED11C2001D X-Stat-Signature: ywz75o3j9qtj3ofgp1zbz3xo3b8hbwb7 X-Rspam-User: X-HE-Tag: 1724330161-490620 X-HE-Meta: U2FsdGVkX18qExTJdMQmbjt0ozM+qHTfV2yDI4kCAesHmLtmE2q6oeavw2N8B+S0n+x/CgGHQIbEMK6AXfPFgWLRexJ5P+xnNc+RB1ApqPiYC2LWpegwCsVAtK1BD8+ySYkBcQmn9ccyLBE7MsI+HfdBRpH/U6ZWZxturVxwxaZByj4NiMEEk0mhwmgw/yjN4zda96CQ9rsMulG6dhTOCq1tSrtf0zfQ5zuRQVJy4oZriio/++RSwZEFPCzLI7x+ZBB38XW+ZHjTfPgmxDO7OhjVUQYUP/NcEuUpOHkKlK1RcTDFNXRtPHsT8764luoODF/J+GLZx5dn12gVqAAMmD3Kud+dhMjgnfone/bVAZh7f8FAJ7kPIVzlgNJafBWDn5erca4Mcprsr76/tj6Ez/fKyfKg0URDJY17uHXXmpB7DsnHBJ6EQBRYTvOU42l0mMF5jTYCh3guujUYA4pSqDeLzFZUjyKIJ7wp3R/YGGDQ/7BvLx6A1DuXPWQvBvSOZ1FQ2S23KZBT7OKxd9bPRxqbIv3/MU2NtNXu+wCWvW8tkqOsLevCLUWpZcl8D9UgYb2/3B+S+EL/ogxXG1uVq7LVqokRPXR2jFDVKs1uys6QpWOniYzfW0TzceI4pndkf705uLOHZU5NSfgDFGS+ExvkV3B45jQOMMxM5kuVv0ATcHZ1xru/hlkRad1lsfkMoCVYvg/ZolvOx1/U/3tSFDaiXbEfEXL9wSVOFRLnFby1Z50vPtAumUuHWlG6jVPDpqqwYJO0fDsq1EuBGASfyW8scv3Lv5rBr4+Klz+EDSMK9qCKjkXOT7cAqJrn41b1dhE3/A5M+oG8BBiSboxPJxxqIYO6pc3u4rOo/G9WPseD+ucECNY8ZZ/VGT7BtOsVq6u4gDtdytrZWn+0faLijEHb+XMF/xv4BvLXhpermXNheN4VM4Ife1uEwI+N6Mj6dXa3utL9ZetZcf4nKPO 2Njn+BpS srgFUca+alGjOza4DLRgIt3GJlmZGqzGmkWmom18JeFjhr7+bgBJfXGXAEsuC6O3UKNSllo1vVTkLT8InJ+I+KknA+pERrZsPH/Q6j9bPhS8GtHbr/vx7WTrhedZ/vVytjl2oUvMmG2uuhHnPZhk/mDN2yVRPNECnGGB9qo8FSXIz9LR0RYeY3q3pOKwlep8lP4e5cRGRElRqB2XSxzihygSnwdsQB63UVZnZjwIeX/Cz948kvJJ8sA7zwY+fiQUSfY9aAx24iTPH59/eQH97U9hG29sse/7zcBJoZG7MJF93Ln54vxrj7jv1YBpszkumC3TfMlgBGQgCg+1rOtgBGnCkd9nv6r1PB8E1HlnFr1CECeciBXXzxFk1Y/fqodpciV1q+jUmeyf9y5DHzUd7boUOAw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.080815, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 8/22/24 07:36, Christoph Hellwig wrote: > On Thu, Aug 22, 2024 at 04:35:57AM +0100, Pavel Begunkov wrote: >> Add yet another io_uring cmd implementing async secure erases. >> It has same page cache races as async discards and write zeroes and >> reuses the common paths in general. > > How did you test this? Asking because my interruption fix for secure In short I didn't, exactly because it's a challenge finding anything that supports it. At least the change here is minimal, but ... > discard is still pending because I could not find a test environment > for it. And also because for a "secure" [1] erase proper invalidation > of the page cache actually matters, as otherwise you can still leak > data to the device. > > [2] LBA based "secure" erase can't actually be secure on any storage > device that can write out of place. Which is all of flash, but also > modern HDDs when encountering error. It's a really bad interface > we should never have have started to support. ... I should just drop it, not like async support makes much sense. -- Pavel Begunkov