From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27131C67861 for ; Fri, 5 Apr 2024 09:07:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B627D6B0128; Fri, 5 Apr 2024 05:07:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AEB9B6B0129; Fri, 5 Apr 2024 05:07:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9B3356B012A; Fri, 5 Apr 2024 05:07:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 7D7326B0128 for ; Fri, 5 Apr 2024 05:07:01 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 44131121113 for ; Fri, 5 Apr 2024 09:07:01 +0000 (UTC) X-FDA: 81974898642.26.E252491 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf18.hostedemail.com (Postfix) with ESMTP id 019341C0012 for ; Fri, 5 Apr 2024 09:06:58 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hRpCL6uY; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712308019; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0zRRYELJxrPHEgjDy1ctAUfjOu8XzSDkxN2W0uvQ3RM=; b=M134+SQWEELxfgkjCVEJ9rTlbI60V5EC+XLAHYcZyYo1Yu61KbS2WwEbebffdkT2RgO40T hx60FCwhXuzX3Fe6dWvXQABDYqGh6xQv2abJZiwTIY6GZJrE72280jwe6abjMslE1h3RMi GmhKj9ohw6DEsGWu022wdt+Z/5npcEA= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hRpCL6uY; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712308019; a=rsa-sha256; cv=none; b=TnaoN1V8NVUv3E4mNTp3bIe+7nf2vpzLNtob6UoEG7Hy7NPzr9EBbJfW0aIv4TcYuoMpte t4t4kyyxivT0K5+kQzLpWVQ4H7ruI9WBCZBQyl1uE6KuzB0zxqafBfsaQl8Xqkl2vlAvLG wlMkPv6HZVjzCSPx/p1MMhHx2PFzEGw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712308018; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=0zRRYELJxrPHEgjDy1ctAUfjOu8XzSDkxN2W0uvQ3RM=; b=hRpCL6uYa8GVKxLIzx63kJF/m1slJTOfnWOkSxR7gQvoHNRX9TcVZzNdcHALX+Atr5HPp5 TRi/BAnJEKhH6bifONeOVeTb0+xETpgg83wGhLY2KN74J7g1+INMkcSxs43FtFQei5RR4A pvMn37gxv1bsyjAPVk6DyhZe3+ssf4s= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-189-JXbkzERpPfaLz3PZAY3bfw-1; Fri, 05 Apr 2024 05:06:56 -0400 X-MC-Unique: JXbkzERpPfaLz3PZAY3bfw-1 Received: by mail-lf1-f69.google.com with SMTP id 2adb3069b0e04-515afa25560so1288976e87.0 for ; Fri, 05 Apr 2024 02:06:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712308014; x=1712912814; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0zRRYELJxrPHEgjDy1ctAUfjOu8XzSDkxN2W0uvQ3RM=; b=MN1e8zWNNdkgCz3KJxZ9gRrCXQ0Ng8JmrqIL+ntwHpzW+/lIUV7dPzJxj4Oy5l1TAz 5R/5CoXnX0Plv7EAn0AVhXiR4EyxSvgcP5q8mciAzRtutTmY5dbspMojP1UQ1wMaAVZL eI9CgMpk7A95bBPde5uLw1h6wNUXH0kl0RCdlm2JhB7jVxJ91xkB+jnAN2A4icFROBsi 0PcyfWWRAu3rrxz2c6noEaty1rR2TiaoiDLs/PZM7G+bCRmo25om6y4vzihG2IoWT4ll iXk/1Jqgxp+rQWWu9D+nMvWQSPDnPVCkAKXzxRawlZ/5X4WIIaJIjyqzADOUzJvLq2+7 NIkg== X-Forwarded-Encrypted: i=1; AJvYcCU7Xph+LSU2bmx7xJ2Ay9NKsOIbZ7ZK6YZD0Sn7uE7iBLO7j8qYEuiof79ni2YFuV/SGwIH9uBBJqoc5aSqf50LCQQ= X-Gm-Message-State: AOJu0YztU0dDoLeseEzzsjItgA6fHrD2K/LEKI6gX/DCUPKUCVCe1OzA FL1jjjJjCbXsnMp72ms/PtgaX9Cfhrc0Epcjs4qHvs852ryayb3RBII/LWlzMawbVbsh6nX0ftr XLA5X0JjLjCtEiMwAEeTBrCuEq/UzLq0lSmzluUdBCjNIKrvX X-Received: by 2002:a05:6512:475:b0:516:c1b9:22e9 with SMTP id x21-20020a056512047500b00516c1b922e9mr644985lfd.17.1712308014686; Fri, 05 Apr 2024 02:06:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFCQQbRCXessb7cmeerSHS4NLFh+aADVdDXL1rcQvtLSb51fucsBMtlYCwXl0HJTyrCJic3HQ== X-Received: by 2002:a05:6512:475:b0:516:c1b9:22e9 with SMTP id x21-20020a056512047500b00516c1b922e9mr644959lfd.17.1712308014201; Fri, 05 Apr 2024 02:06:54 -0700 (PDT) Received: from ?IPV6:2003:cb:c74b:5500:e1f8:a310:8fa3:4ec1? (p200300cbc74b5500e1f8a3108fa34ec1.dip0.t-ipconnect.de. [2003:cb:c74b:5500:e1f8:a310:8fa3:4ec1]) by smtp.gmail.com with ESMTPSA id b2-20020a5d5502000000b0033e786abf84sm1519965wrv.54.2024.04.05.02.06.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Apr 2024 02:06:53 -0700 (PDT) Message-ID: Date: Fri, 5 Apr 2024 11:06:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 13/14] mm/ksm: use folio_set_stable_node in try_to_merge_one_page To: alexs@kernel.org, Matthew Wilcox , Andrea Arcangeli , Izik Eidus , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, ryncsn@gmail.com Cc: Hugh Dickins , Chris Wright References: <20240325124904.398913-1-alexs@kernel.org> <20240325124904.398913-14-alexs@kernel.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240325124904.398913-14-alexs@kernel.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 019341C0012 X-Stat-Signature: htfh4myi364cip6so37sw9j6znf9t5ue X-HE-Tag: 1712308018-412604 X-HE-Meta: U2FsdGVkX1+LPyfYy9gK3eAPZ264/Lxf8FIT5kiMCjC5n92VE+uLYVDYLYhWC9DHT9ZKaQnYXu1oifn9z40SbDebY9vSouOyM49tS7i/6pnREaulQfyhzagZU4ZRmzf7wyvHWoV+ZmtptJbbnsXwt77uYggRg2eQNOY/TFZaMj9aRS2AQRRg0j8VomrMuSydmUzCDn63hmywtzMDNZ8vDBKwJi4jpSY20J2Yty47TttaiCzDnJARD96awDq9HZafxt8kFJAXnwD9p2zO5YruWbx0udBRH84QgMmUDJN4AhSHcLpKMuSNSByd2ODuVIyoTEySs/boTKuokNVtleFtEQ+jnWgmNIhup6+FV5W7OK2Qy9I0zdydqQ6uc8TCHYjec6J6aukOZyqjlfAoWSDi+qJZ/AVZHmxPwdztn7eNnbNh2dUVq+NNJmHZL7WRoBoyrcGzZ03J2xK5i/7c3LSjL5fnXO2q/HhcbbYibkdiaqEhuhF1vIZCyKmgXArwZEjoZEKBpoFCinst3ajPTSRe2AtiG+cuT+g9KrRuL/lHBWayP0mXZqDbd2DZnyzwjjHjGJVox1Aly4bORMS3sW3tZLmGJ69560JO2kZ8PWB1Xo6XbJBaBsAdx2U8Nrfx3C/bHNXLYL8LkjDEJ5Ad5y8wigTCV7uaWPWKHO/yBkBXNVHPEeIFt1O9m5B0TBCceZcIGLbCpEn9/6MhP+BrZO8969KlqqrzWxUoMf36TnIFSvfh7DZL9jc4+xcfMZXpXH+uPlA42L5NMF3NHdJ1Tls8CctD1xdpp1ab7XUcY7cl7WcomQLhHK54+uCWGrxOil5TmENHGygOh3FhBNMAiY+Z/jZwlMJjTsDZ8u0hNONGh7aF5prde1EDDtbSz9UWFO5vrqxIg28ZsBSHah/OehmP/PUTCNSkhSNJbvQcE3HddV0d7hAnDwQ9zh0CS26ipN8KsmpXd6Bk9Bk5UNxXXtX r4baunlS /QrGnJ/TNRrAzuDtn/WM9YmlIuT3SXqvwb/wBGj26d8PFCVVZ+R/vvkB6RxCsd/OwoEu8hdjoWkWUlzbg5PeX6QGs3tCzdN7IRKxIQlrXQOx+k/MEgSpNYGLkPgxHaxJMheNetcbCjnWPgwUMUSi34xpgSBakWcVx2ifwhPFWp2UtsNkxVvgO7eew9jJpTWrwietNu2udTEtJVoVdabOGslPphBv6OC5gTEyzWd94UOdpQ5j9U27NFGviV8AlWRH+2OE3OxUXcA7IWAqB8bfgfumj7Zj2LjWkfq2wiRlx8bHsRaRszH1bHrzWiPwd9M+7BbX9vatU44IwPd7ahv2guX7uNZDaAsRnOt5Hu4CTXTptFy3d79NMq1VINvhxvA32zrsywB+O5naXcfBhCa3PTpX0oiuZB2rWI0hIsKrTKush156EdqADPqigPR8MeVhcZVfoxWQJgpkUwGfzIhaQSYrXffkGmMyhGSypHnl/wuk/UYPaGkNSL3c14ZdUWhu+ZaajwxoecHJCwu6L58ih0u5MVi/bDT0yavazqYvHqNOmj+4NN1iKdO8g6iULGRVIAZkgHqzzL1I6cfd0iIpQ7/RbMY6H+U3Wsr5MDQoohXgAoaBfRrsLm+et5zpG24xJe8X5pQYjb6rS4VOjMOeZBYtvYhvt8cFYh5CK9BAZ4eamQYC7uHiJvFsKu2TmeKeXbBKI/ps1WwWqs9HlbuZUGNFdl0Na6bFNQfdpavi1l0lK3ndAmv+ZzvB5ag== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 25.03.24 13:49, alexs@kernel.org wrote: > From: "Alex Shi (tencent)" > > Only single page could be reached where we set stable node after write > protect, so use folio converted func to replace page's. > > Signed-off-by: Alex Shi (tencent) > Cc: Izik Eidus > Cc: Matthew Wilcox > Cc: Andrea Arcangeli > Cc: Hugh Dickins > Cc: Chris Wright > --- > mm/ksm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/ksm.c b/mm/ksm.c > index 15a78a9bab59..d7c4cc4a0cc1 100644 > --- a/mm/ksm.c > +++ b/mm/ksm.c > @@ -1518,7 +1518,7 @@ static int try_to_merge_one_page(struct vm_area_struct *vma, > * PageAnon+anon_vma to PageKsm+NULL stable_node: > * stable_tree_insert() will update stable_node. > */ > - set_page_stable_node(page, NULL); > + folio_set_stable_node(page_folio(page), NULL); > mark_page_accessed(page); > /* > * Page reclaim just frees a clean page with no dirty Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb