From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E8FDEB64D7 for ; Tue, 20 Jun 2023 10:18:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8F2D98D0003; Tue, 20 Jun 2023 06:18:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 87D308D0001; Tue, 20 Jun 2023 06:18:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6F5058D0003; Tue, 20 Jun 2023 06:18:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 601778D0001 for ; Tue, 20 Jun 2023 06:18:27 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 2370F14084E for ; Tue, 20 Jun 2023 10:18:27 +0000 (UTC) X-FDA: 80922726654.01.39DE326 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf05.hostedemail.com (Postfix) with ESMTP id C861E100009 for ; Tue, 20 Jun 2023 10:18:24 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Ta8a04Q8; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687256304; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ul8gzt2rqlqhcr1utmhEwWbBX32h2e3MNmkpVb/h7mU=; b=EZw42DghMhicJWfFiWlSvO4WRzCypL9R/jU9DRkOdJpyxcAuSCASYUNeG2wPzRZnojIxx+ +fcCzqvlEeLmq5hvVVAtJM6LMLwblnxmfWVc/GZri0cDivv9j4j4n/lsSJvIL7S1PfEkYW BsLo5YRAZmVst1p1belozYQiuu16Grw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687256304; a=rsa-sha256; cv=none; b=WSKRHbIMtXTqiW1fQe2n5h+sNIKXWH3i/swefd9SdQKDtVHKxVKBC+69wIcCnffsGqx5zA V2Re5MfOwU3eKBQaISfbgN216oFednJr8FoNYP1bcO3HW4CmHRkolMBmlZxPLsk9YfJHq1 s+zaeE+RfZn6uD9ooxLZlw6mybFnrFw= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Ta8a04Q8; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687256304; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ul8gzt2rqlqhcr1utmhEwWbBX32h2e3MNmkpVb/h7mU=; b=Ta8a04Q8v1TDsOGk4yl/3khEC7JKP4cEZestc0FCnNQm6nQVTONbViC7m64CqTkUPzXedm YL4RFn0YYqBqtrZwfIaTA+R4z5t7phDCoEGPNhzoTDw3HTkEWPpcUNDjzX/Io4Gp59qAG3 P3h5G88Lz5Jf6jMNqOp0SB0Me4tIlyc= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-433-gqL0JwY9MFSUOGShA1psbQ-1; Tue, 20 Jun 2023 06:18:22 -0400 X-MC-Unique: gqL0JwY9MFSUOGShA1psbQ-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-31283f4d22fso21242f8f.2 for ; Tue, 20 Jun 2023 03:18:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687256302; x=1689848302; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ul8gzt2rqlqhcr1utmhEwWbBX32h2e3MNmkpVb/h7mU=; b=esPoVwEtbcKZdHCXvD7+nWa0OH/CUH1kWeCLO4uBtLHGhWHMVeVGObczewneExZ8E0 Y6HH/Wzl8Eu9OON/nu/mSSb0z2how0rhHQcLlpWC3R1LH/wJVK+YrSihKqjWrw9AhOrS mcZ+iNCN450Mw0X2eGD7qOkka3yOxFA862WX/hc75jgllvU1MV8S+6YOYo8WQI6DQ170 ZMAgzD8XRwOSHEFa/ZYcUy39QhZ+B/L/l6r1wOp6pBTWXZYvn+DBnYGNStidGOfIx7FH qFyfPax01Qqon/U7hx9FPOrk/e1wIrtEg70GEYIvUWmbHqyhfbZhCz8OoRQ7vtOBRw6H XuDg== X-Gm-Message-State: AC+VfDzwAeEnGxjwXVFl/PCNdkWJf1d9wy8P9sx+JQHKdHqz69WJ2NpR XP1LG1bg2heT1dBmycykaBr57cFobO3L6+rCSvwqNRjeSJCVI9yz/R3Z3k1TRHfZC8OrI0tLjZw mXE3kLdRJBDA= X-Received: by 2002:adf:eb42:0:b0:30f:b7b4:3e55 with SMTP id u2-20020adfeb42000000b0030fb7b43e55mr7309577wrn.19.1687256301855; Tue, 20 Jun 2023 03:18:21 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7HRI2F0AQylpx3uL7mfns9KK5U8KdfYEgbExjOtghnkni4a1tLKu8LAGtMktVeV/7TXJgvpg== X-Received: by 2002:adf:eb42:0:b0:30f:b7b4:3e55 with SMTP id u2-20020adfeb42000000b0030fb7b43e55mr7309562wrn.19.1687256301420; Tue, 20 Jun 2023 03:18:21 -0700 (PDT) Received: from ?IPV6:2003:cb:c739:d200:8745:c520:8bf6:b587? (p200300cbc739d2008745c5208bf6b587.dip0.t-ipconnect.de. [2003:cb:c739:d200:8745:c520:8bf6:b587]) by smtp.gmail.com with ESMTPSA id h9-20020a5d4fc9000000b0031134bcdacdsm1653936wrw.42.2023.06.20.03.18.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Jun 2023 03:18:20 -0700 (PDT) Message-ID: Date: Tue, 20 Jun 2023 12:18:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v2 08/11] selftests/mm: fix uffd-unit-tests.c build failure due to missing MADV_COLLAPSE To: Muhammad Usama Anjum , John Hubbard , Oscar Salvador Cc: Andrew Morton , LKML , linux-mm@kvack.org, Peter Xu References: <20230620011719.155379-1-jhubbard@nvidia.com> <20230620011719.155379-10-jhubbard@nvidia.com> <575a395c-0608-00da-3aa3-cbe4a5bd157e@collabora.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <575a395c-0608-00da-3aa3-cbe4a5bd157e@collabora.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: C861E100009 X-Rspam-User: X-Stat-Signature: jqx9kyucu8s5ts5c7ssny3fxj734aurm X-Rspamd-Server: rspam03 X-HE-Tag: 1687256304-654702 X-HE-Meta: U2FsdGVkX1/NPvqIWJB6tSPjDfq4nfRmBAg2k/pR+jEzRJesXFGn6ZrmfD+hUmgQawFb+ScYZlZBwek4UmGVsTFH47EQAbpdNvGQkOHpHx/iHAZfoPgl0fYDpYz29t2PODeG1dxADjZTmfgsTOKWaIyhC1ZNB6YqFUJTrcbgKPC/y6CFxE2C2c13F9QF+f397FKmq1c6GnPihRIgqDzAlvjDp6oCq2SVstYxMP4Ob8uol5VQ+dMUa1zyPSJ0zohH2dMl6jHUmbGNG10OY2FpyR2SAUAQq8U3rS56EzYQIVbBa4Wj8H5B3+HMgh+W2qAub3/vHWFnNwh3Ve7ubG7AKAezYCAaDt5AQbgHg/bUUiNNHNmQNSHqPAnLeTz3bO/8jI4gspBaGZghTSWirsrY9xQHT9Y39QfUKK3Raaj/clQ6Ysa2ugaHV2B3L38eKc/2/mANciQbzKWs592eSCDfWz7KwNMrw7IFJVlFpOi17vbdoTMBndsDsCvqahKSpayikoCd+FoVsJ4SK0jUPZUqdJ0xkkWPMFj9dFX+Br2oi4PdQSvAK6XRmhCY5lMLuvU170elA09fkOXaKtiWeZXXeaiH5ZjDGBPqKSLps1FOh0aTh1t+bvPGrpLkEHbXrWWdMgKG2jygOBuYZCJUqk0M7xsHEPCR1McOGqcqbci+MJarLXK1zr+IVtFtUtGFQ1SMOPLVCXZoy8Qr1DR98EBkGBXPRY70dQRSVk9bmOAKw1e1zE60MfqIMVqcf2wNtgLhf/XpZ4rPe7k+I+kksaWfylCJFMF9KSPv0jvqp+HDsULtIadyjrRlD2r6K2Fp0XIZk7Aq05a/B3wrxdfKTaBEMLDfE5x/+vZyfwj9xF2H98WgK1fwJAxWAvIczr2QWjdBGeyn/K71Mu5flbMaURzYJTiQ3AJ5pfV8z9cg7DI6QKhR2Q08Oi87whXNT/dnbJZpbP15zW4jU2k9RoLuapZ 8wPwQxC1 ZAvbR3p2/F3tCmaX+bZjhKanIUP1pnhhwE/PbbT8fF5zi5ian2jX1gRkQ3/YnDMtXIs1vjPBSYxfKGN9dqEDFBw5DUj9SFnQWiUWEE5/snyF+94WGUmzoVwR1hj2LvscCav2Xt/eiGn51wOmEgWnXGGLmeYD30ha/tRiqUAY998smsWAP8HbEYIi/tAl5/JYlhq+P54fjkAcQsyu3uWkVydH7bOg8LU2a9qtIg0TJ4V/GHg86NlB/Em9dzoAJy0TXdWgeeKbSxRBiyIRWn/CZccWuAD5CFwK6CmRxxUcgfler2Xk7YLloAGM0Py6gHoefwnP2kXkIpTgUbGcRrip9fHeFvND4M7wOEJ8E1louG1yEEPEB6CthCmpH8eDwQh1BDl1NQjlimRndnXxWbYsfwfcLG9k1hg33MMH1yn2BLIT98t9SpI3r6C87uCwhSBzeo1yNrjntVSvpB59mVmCCVQ+9PFmxOt1G3gMzCrXeulsBoKqwTthgdCyaj7+DNoTigS/M X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 20.06.23 12:17, Muhammad Usama Anjum wrote: > On 6/20/23 6:17 AM, John Hubbard wrote: >> MADV_PAGEOUT, MADV_POPULATE_READ, MADV_COLLAPSE are conditionally >> defined as necessary. However, that was being done in .c files, and a >> new build failure came up that would have been automatically avoided had >> these been in a common header file. >> >> So consolidate and move them all to vm_util.h, which fixes the build >> failure. >> >> An alternative approach from Muhammad Usama Anjum was: rely on "make >> headers" being required, and include asm-generic/mman-common.h. This >> works in the sense that it builds, but it still generates warnings about >> duplicate MADV_* symbols, and the goal here is to get a fully clean (no >> warnings) build here. > I've not looked in detail. But it seems like your first revision was merged > and after that my cleanup has also been merged. My cleanup patch is adding > correct header files and removing these duplicate defines: It is in > mm-stable now. > https://lore.kernel.org/all/20230619232244.81CB3C433C0@smtp.kernel.org See https://lkml.kernel.org/r/0379db8e-744d-2876-7304-2a6db8c9cac0@nvidia.com -- Cheers, David / dhildenb