From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F61CC54E58 for ; Mon, 25 Mar 2024 12:30:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 25F8F6B0082; Mon, 25 Mar 2024 08:30:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 20F846B0083; Mon, 25 Mar 2024 08:30:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0D7906B0085; Mon, 25 Mar 2024 08:30:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id EFAE56B0082 for ; Mon, 25 Mar 2024 08:30:56 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 8D31A16053D for ; Mon, 25 Mar 2024 12:30:56 +0000 (UTC) X-FDA: 81935495712.13.05157E9 Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) by imf27.hostedemail.com (Postfix) with ESMTP id 7017D40023 for ; Mon, 25 Mar 2024 12:30:54 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=glBDBicM; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf27.hostedemail.com: domain of seakeel@gmail.com designates 209.85.215.174 as permitted sender) smtp.mailfrom=seakeel@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711369854; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VAcaRqwrbRM30TKi6X9l/01RCi8ibTxboxlerqqN1jg=; b=2y2IIVQnbJm9G0bIje4/aWPI1QJZw6OZBfSwTiAyuFYsM4QHYrezfIB39DbMSeEKw6t/xF 6DHJEGT14N3cBqZt0FcvHWkm2GHtJa7BZ/aiVeE4NTyJkZKZq8yIoMOqq9/NXoHMsrYeNg iS6cUXGFWbOWgPjOpW/64tu72QOa4kY= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=glBDBicM; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf27.hostedemail.com: domain of seakeel@gmail.com designates 209.85.215.174 as permitted sender) smtp.mailfrom=seakeel@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711369854; a=rsa-sha256; cv=none; b=xtqoXvSd1WP2jA68LR8RmD+pAGoGVbcKWqe0LLv7+6unVvo64tSkefQdWPRaI+3iMt2ziC mLHsP4yH84iwug0dva8k1u2IIZn9X3Jb56c+IRLK/Mc730WRqgJbCtyZup4tndR+B3Jy6b z73C7lmLYyUOGQIhZ3DkqRPjraAeZbU= Received: by mail-pg1-f174.google.com with SMTP id 41be03b00d2f7-5dbd519bde6so2410296a12.1 for ; Mon, 25 Mar 2024 05:30:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711369853; x=1711974653; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=VAcaRqwrbRM30TKi6X9l/01RCi8ibTxboxlerqqN1jg=; b=glBDBicMa2te8jNX73PML/q53/yJHmHEbR4AV7d3k7hAesp+KFjiHg8ZFEP37xm+fF Uf6Kt/mnJfOMjxz022uqO0WLKjrhg87bVe2PO1HM8DUSKSkRTm7QSptv8N4ls+FidA3i mz3MzOSxoPIc9UMQ07wwSK7sRcGl9ivdUCmPk17Zio03QFa4M3LY0qRYmOTtTwOq+FaU MEGGkrdniu+/64a1YM2RMrR+i5uCXbGYYn3bpLxFn/1yxdQ5iHnGWwalL9GsAo9xe+b2 Esh+ERejMQVv3BMpMVeKnht5qmHOuLZtw8X0DMkKuIJo9yJYxQeE23XEW54D74lwcOa+ V0AA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711369853; x=1711974653; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VAcaRqwrbRM30TKi6X9l/01RCi8ibTxboxlerqqN1jg=; b=GigkaWfB+JkbTKuG62c3A9ckCd72b7Rx4hWYga85KaLJMXsbdciP2yvBbLR6Xz7dtD FrqdJPi3HpOdiZ9B+DfJh/FSQQ44NScIZuCCn/rE2JwDnP6XsAScLEzU8OVcUY+q86hN yOaZaFMeU8CpPU54v+r1G7zXVvyl2Xxqngq5PqxfcSc71Voj36EfQfj+4hG5CHtDP3D8 RYMdMQphoEL+CF0pTrTSALJK87RmHL3l/AqiEAYoKG0axKmteLGeiVwqVMxy2Y+uvvvL Itxoja/6ZrCuu9GeGMDtEVhajGubvMdJj19fcyGoGsZMpLtAUAUoPayRVHv5ZLbdIAYi nm0A== X-Forwarded-Encrypted: i=1; AJvYcCVQku+/cPrcGXQXgrxPF8q1JenE6Nd4iedzbDvLiBG+dDJyc4i4Gteu7IxnFRFsG93KuY8G4qvzEc1dBOQZqIQnew8= X-Gm-Message-State: AOJu0YzlNqoPA1LjfLqnj54F02+zDl7eY/h1JOQxzcQTxTFdamuFZzmn broqjTQYDarSCiuMAnmc4mHwwd4O2PJ27LV5BMFj94f/sqGRlAsU X-Google-Smtp-Source: AGHT+IEat6rsjLdajx4W51QuWs+Y1lh7QaH+sRoXZSCvbdL3bJONNi7oYAq0aJavojZ/C1MnPmm07Q== X-Received: by 2002:a05:6a21:3949:b0:1a3:cb4d:3fd7 with SMTP id ac9-20020a056a21394900b001a3cb4d3fd7mr1854408pzc.56.1711369853059; Mon, 25 Mar 2024 05:30:53 -0700 (PDT) Received: from [192.168.255.10] ([43.132.141.20]) by smtp.gmail.com with ESMTPSA id n12-20020a056a000d4c00b006e6c0895b95sm4039410pfv.7.2024.03.25.05.30.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Mar 2024 05:30:52 -0700 (PDT) Message-ID: Date: Mon, 25 Mar 2024 20:30:48 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 05/14] mm/ksm: use folio in stable_node_dup Content-Language: en-US To: Matthew Wilcox , alexs@kernel.org Cc: Andrea Arcangeli , Izik Eidus , david@redhat.com, Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Hugh Dickins , Chris Wright References: <20240322083703.232364-1-alexs@kernel.org> <20240322083703.232364-6-alexs@kernel.org> From: Alex Shi In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: umzpsphrx69a5z8w7qcf96gzq87t1co8 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 7017D40023 X-HE-Tag: 1711369854-854801 X-HE-Meta: U2FsdGVkX19H3uEGzDBUTdNrgyik8ZzhNyp/s4bdiBsz7ABEnbxS8EOrJNhAwAzJ/jEijNHBUEVmLNZIitIi91pTWTfNyT7VKIWUoj8jdMVvNYbGyGd6XLERAn2B6Uf0vloyw95oDb7JUNnu773q4EwRl9ExdmtSgDCEjNcp4kwhFBgf15QrijIVKUsCNgsMvHqWKVqbNxPDbRsrpjqxlAWXc6PmE0vmhojOXrLHGtWZQglglhANdYgKkda97yE9WfnJuMUMnwOreBsH/VKReD0ZQZ62pxy9HsvSrAUw8gxltwD10TpAR9Cr35lSevaLzdEo4Bpbrclgg1LXa8ZSi7rTrZXZLyFX66W6XmETGPs4G4O8Z20zlzagN7wu5cK5XbgV5mw6BmpkRc4fwrxCT4zw+NF0JR4P9M5jrHWuhX2VrAVQoNC59hRNJINQ0Z0B6b0HXXlTS0kYkC3WY9vKq3M0ygXED4cFP7vz6jr1BYro3UyZJYaAdSMG1Q7eACfWGjLJEfTA09WIEq/Otej4YUXHBoWHhAXbDL41DyIBH/71Mt+1xQnmJsPibVa8IHcpbu2qFWsgqoCanSyDSauGWjxl7OlBLadAVSrKGAToq/MiIkZYwhEiZmtE+j7uMi9gm1e/eshYDyHcDI9T+IRs4bMf5YjgkSY/xo2r9orlXxp5qPilgqCtWBxdfByBBg34HRRuv8YTV+Mg7htahj5f+XkJmie/HpXSYkhKisClrpcx0obITO9Efobqxz4VMc8sHv8BLtx8AsOBri8zyJJzGacOTPZhp7iv847kxZFcheLtju0BFFVletr87NpFclUi/a/Uh8QYAJXa7eKbbDz4OtDUFJN6vqRB0FFeyiSA6xMM++UD3WnLyqY5VDcuchaLmTOAkFf5YAy+5G0YMCQGkutp5WChQvo+vW12I4gQiquPzsI404T+XjBv/FVleHAyXJG2JPuyyCLeEgd7HSv lAFB0DIC HAcLJ4FQWrdMee6YD1/92HMHLDoFrFtQqV9+YI9oWrzQQX4tXWfDeIqbw3GgHz0vMXX/HDdhl3GZYyuN96djiNuLmRIo9jS79Po7MnqQNw92va3KyRMKtkuWhrq4/ndVu/m/kjb9cVn8pbhYl4Ai2ChJTtH0n08CM8Q4DP2jFF4irWrZxJdn0L+ub+qhelSrzB5vZL9jPIoc/k4RiQaIkAFz1lDxOXL+fYAlD6BJyVA1cAXWyvjlhcjgHORaAQkMcjrIM8Z/Ox1Dvr8qssAE9XG8jbczz9Q7UPYSoDLYhKk795pbvT2YCRbtmeiMGWKlAU8MB60gJ5bCOzLkwpvUjEU6zWD+iop+9kwpqv9LO32Yo1JR6YVM8G43NBtZInbHx+4Dqrkhkd3vgaswFma+G7hkjI6tpLe3h/dHnV/SkD/2Prlz1/Wp5CZc3JqLqhylEmu5EaQFD+rIT73SKtQNU7C6aqdNt4Zl/G1Mm04e8q5ggO0HuGftkuutGZV+yY56Ixgzule16vHQHpkIdgSWx2DSjGgDojEjZOBLFxYY7Y/LMcGKKQEUJvkeUNjSWyv2nu+Ox20E/JWndf3M= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/22/24 11:57 PM, Matthew Wilcox wrote: > On Fri, Mar 22, 2024 at 04:36:52PM +0800, alexs@kernel.org wrote: >> -static struct page *stable_node_dup(struct ksm_stable_node **_stable_node_dup, >> - struct ksm_stable_node **_stable_node, >> - struct rb_root *root, >> - bool prune_stale_stable_nodes) >> +static void *stable_node_dup(struct ksm_stable_node **_stable_node_dup, >> + struct ksm_stable_node **_stable_node, >> + struct rb_root *root, >> + bool prune_stale_stable_nodes) > > Do we really have to go through this void * stage? Hi Willy, Thank a lot for reminder. Yes, we could keep the 'struct page*' return value here. And so we don't need to change indent here. Thanks! > > Also, please stop reindenting the arguments. I tend to just switch to > two tabs, but lining them up with the opening bracket leads to extra > churn. Either leave them alone for the entire series or switch _once_. >