From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Hongfu Li <lihongfu@kylinos.cn>,
jgg@ziepe.ca, leon@kernel.org, akpm@linux-foundation.org,
ljs@kernel.org, liam@infradead.org, vbabka@kernel.org,
rppt@kernel.org, surenb@google.com, mhocko@suse.com,
shuah@kernel.org
Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org, hongfu.li@linux.dev
Subject: Re: [PATCH] selftests/mm: Fix memleak in migration benchmark
Date: Wed, 8 Jul 2026 15:15:10 +0200 [thread overview]
Message-ID: <a9b3885b-b764-49ce-9335-6efce3e67b77@kernel.org> (raw)
In-Reply-To: <20260708103705.840679-1-lihongfu@kylinos.cn>
On 7/8/26 12:37, Hongfu Li wrote:
> Several early return paths in run_migration_benchmark() skip
> hmm_buffer_free(), leaking the buffer. Replace with a single cleanup
> label.
>
Probably best to add a Fixes: even when not really critical.
> Signed-off-by: Hongfu Li <lihongfu@kylinos.cn>
> ---
Nothing jumped at me
Reviewed-by: David Hildenbrand (Arm) <david@kernel.org>
--
Cheers,
David
next prev parent reply other threads:[~2026-07-08 13:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-08 10:37 [PATCH] selftests/mm: Fix memleak in migration benchmark Hongfu Li
2026-07-08 13:15 ` David Hildenbrand (Arm) [this message]
2026-07-09 1:54 ` Hongfu Li
2026-07-09 1:09 ` SJ Park
2026-07-09 2:02 ` Hongfu Li
2026-07-09 2:37 ` Andrew Morton
2026-07-09 3:03 ` Hongfu Li
2026-07-11 7:31 ` Lorenzo Stoakes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a9b3885b-b764-49ce-9335-6efce3e67b77@kernel.org \
--to=david@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=hongfu.li@linux.dev \
--cc=jgg@ziepe.ca \
--cc=leon@kernel.org \
--cc=liam@infradead.org \
--cc=lihongfu@kylinos.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=rppt@kernel.org \
--cc=shuah@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox