From: Anshuman Khandual <khandual@linux.vnet.ibm.com>
To: "Jérôme Glisse" <jglisse@redhat.com>, linux-mm@kvack.org
Cc: Michal Hocko <mhocko@suse.com>, Dan Williams <dan.j.williams@intel.com>
Subject: Re: [PATCH] mm, memory_hotplug: fix devm_memremap_pages() after memory_hotplug rework
Date: Wed, 5 Apr 2017 16:05:23 +0530 [thread overview]
Message-ID: <a9d6e8d2-7bd9-abf1-9323-d175f10f7559@linux.vnet.ibm.com> (raw)
In-Reply-To: <20170404165144.29791-1-jglisse@redhat.com>
On 04/04/2017 10:21 PM, JA(C)rA'me Glisse wrote:
> Just a trivial fix.
>
> Signed-off-by: JA(C)rA'me Glisse <jglisse@redhat.com>
> Cc: Michal Hocko <mhocko@suse.com>
> Cc: Dan Williams <dan.j.williams@intel.com>
> ---
> kernel/memremap.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/memremap.c b/kernel/memremap.c
> index faa9276..bbbe646 100644
> --- a/kernel/memremap.c
> +++ b/kernel/memremap.c
> @@ -366,7 +366,8 @@ void *devm_memremap_pages(struct device *dev, struct resource *res,
> error = arch_add_memory(nid, align_start, align_size);
> if (!error)
> move_pfn_range_to_zone(&NODE_DATA(nid)->node_zones[ZONE_DEVICE],
> - align_start, align_size);
> + align_start >> PAGE_SHIFT,
> + align_size >> PAGE_SHIFT);
All this while it was taking up addresses instead of PFNs ? Then
how it was working correctly before ?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-04-05 10:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-04 16:51 [PATCH] mm, memory_hotplug: fix devm_memremap_pages() after memory_hotplug rework Jérôme Glisse
2017-04-04 16:57 ` Michal Hocko
2017-04-05 10:35 ` Anshuman Khandual [this message]
2017-04-05 10:49 ` Michal Hocko
2017-04-06 5:34 ` Anshuman Khandual
2017-04-06 6:41 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a9d6e8d2-7bd9-abf1-9323-d175f10f7559@linux.vnet.ibm.com \
--to=khandual@linux.vnet.ibm.com \
--cc=dan.j.williams@intel.com \
--cc=jglisse@redhat.com \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).