From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02AA8C4345F for ; Fri, 26 Apr 2024 17:35:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8B4626B008A; Fri, 26 Apr 2024 13:35:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8636D6B008C; Fri, 26 Apr 2024 13:35:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7036A6B0092; Fri, 26 Apr 2024 13:35:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 52D3F6B008A for ; Fri, 26 Apr 2024 13:35:00 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 1002BC01B4 for ; Fri, 26 Apr 2024 17:35:00 +0000 (UTC) X-FDA: 82052383560.04.4862C45 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf23.hostedemail.com (Postfix) with ESMTP id 015B314001C for ; Fri, 26 Apr 2024 17:34:57 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cadZuOs1; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714152898; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=h07zmxvfavPZw7SWNp+BhnP1ppcXFwoYMZ75eLulG0o=; b=D04mtXcQlnhN0XA/n6+BHUxk2TFkLBxaU5bKajQTpMzSgv0VV0bPNlm7CyX6v3pC+Y/HXO ucch0uS/eBne/aJJCVmCpReu8R2Z+JQewqIKQ32xlYfbmDoEv8nzxx+9WimXoneRA+Fvc+ EkjvknZfgaYFGPG+6lvnN/BgGCG0BQE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714152898; a=rsa-sha256; cv=none; b=8SOQQwpg/sSWk96LMTED9s0DNwGaZWowf2FlXgrfw5BqjH6GEMl6SU7L2mJWiQBUHq0sIr bDlnHwS6z7H/3ngxSpSWjYP9T8eF6LC+yqXAP9e1mOp5aU23rUjnBsZB7VoIDBA31P3yxg SVmYi1RMMIZuWWxiG2rgQQnFLdK5VEs= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cadZuOs1; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1714152897; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=h07zmxvfavPZw7SWNp+BhnP1ppcXFwoYMZ75eLulG0o=; b=cadZuOs1szS0pJHLRWyIVXiBrGlrVu+kRjbFl5cJigs6BhVG30heOlgvPowV2t+41HXsyK +m1vTPyWX+mKHoVGctn3UOm0SmnvizD2mHLm5lyIuAcixwS7aQ2aHGOj/umB3qQC+vCZHg BaJx00AolJfs1oJ6RcbOD90w7Vcfb74= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-665-TRg6YYRUOQK4VWdgB2qwyQ-1; Fri, 26 Apr 2024 13:34:53 -0400 X-MC-Unique: TRg6YYRUOQK4VWdgB2qwyQ-1 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2dd05014390so21563271fa.3 for ; Fri, 26 Apr 2024 10:34:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714152892; x=1714757692; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=h07zmxvfavPZw7SWNp+BhnP1ppcXFwoYMZ75eLulG0o=; b=iGxFdymrKJJDDBUJASLm0RFKp9+K6V/1661u/u7wf82mFTduqnm6Tifva6JvXnsVDt 9faxCP1CsTBqYRIbZXFGn3ybBlKMR/4Pzt0EnebjiLtYbbMnZ6+neOYgRO7kqwaUOTUJ EcPSubg3wggvQ2cp55SSoHLTjKCZ0UMAxPxMX830+wjzYSE7kKC4hStTakx0fwloK0P4 9H0mZfXu4Ab5Ngbcjz7jBh8bMql3L8fOh0XWk8ao7idNUKUu4oGU1ttyfkaAzv7CFvfX c0B0r1oF/ELadJVtCp+TREsZEOxUnF3x3bneiJjvLj663dgKYi5uSjcuW/EwDqgRx3aO +bFw== X-Gm-Message-State: AOJu0YzLgVEZ377TWgPkn/qJUXX/X4afER95WVwtKulFjniSRHLKItQF wm956O6Grgk5CpILP0nEItsMsMCt62l7BoloBafUC0Jll+GXeZnUBWD+NFufmmQROGN1Z2twC4c Rp5Zp2zaVO2rwRKuXsD7TkkW3qArDn+G0wyys5vikCMWJrdLT8dmvIb52 X-Received: by 2002:a2e:b610:0:b0:2da:16fd:5c95 with SMTP id r16-20020a2eb610000000b002da16fd5c95mr2347350ljn.4.1714152892332; Fri, 26 Apr 2024 10:34:52 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHhDyYpArxHAjiA3YcLvbBCnWS5N7dxMPNjW8vQFzvLBWB9YJVoDIhFNX1bfa4MvC4IvocaAg== X-Received: by 2002:a2e:b610:0:b0:2da:16fd:5c95 with SMTP id r16-20020a2eb610000000b002da16fd5c95mr2347329ljn.4.1714152891887; Fri, 26 Apr 2024 10:34:51 -0700 (PDT) Received: from ?IPV6:2003:cb:c726:6100:20f2:6848:5b74:ca82? (p200300cbc726610020f268485b74ca82.dip0.t-ipconnect.de. [2003:cb:c726:6100:20f2:6848:5b74:ca82]) by smtp.gmail.com with ESMTPSA id o12-20020a05600c4fcc00b00418a6d62ad0sm35470236wmq.34.2024.04.26.10.34.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 26 Apr 2024 10:34:51 -0700 (PDT) Message-ID: Date: Fri, 26 Apr 2024 19:34:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/4] mm: Assert the mmap_lock is held in __anon_vma_prepare() To: "Matthew Wilcox (Oracle)" , Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Suren Baghdasaryan , Peter Xu References: <20240426144506.1290619-1-willy@infradead.org> <20240426144506.1290619-2-willy@infradead.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240426144506.1290619-2-willy@infradead.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 015B314001C X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: rsm3rnogqcwj3wpjgbrg8t3fb7h588kk X-HE-Tag: 1714152897-260355 X-HE-Meta: U2FsdGVkX1/pDGRNKgyQYJGYb+7IOkqOqugS+OI5Dp1vhMG27MQ3nUT728D+q7Gwcd4nPGsolM9vAGcPx8BG7eTndHuXJ7qfv0MOOGyIUG6NsEjQuvj2ScdU2jtfJqedK8POk16nlwqL0kGkloIq1tJpVvsSV8XEa3jryJf6YJJC/0m2P/5+IhgIMII2NJf2is19KuLHYSQxfbYcNav/UHU0lfVKRt2C93cWa4nKz8OIp8/3n4pVJxbKtTPp4rnwWxNJkylOG5J9+vU8f6DI2erWiFWKIEJ+jeSD6FW1spuTyCYGBOvGIpSRvWStTRP7XwW6WgzJF5wyLaDpMOCOXFR7Xz/scBRVbKO2izHLOHSZGKDsm4INXDka3O2V3SPH05QABNsJWvY5VaDhI69ViVCgQos4+uPyk8AfsUOP3iHFLbXTuBLZ0F5+CY0BmZ+asUM7reoLkDuW/AOxQ5wX65BdfDQHZxsP4R7Fn18W6UH2JDqoV8rJpr/2sQWIT/Gell5Xuadc+9z9t0vpO4LXmgFVIThOcr7uzCYs9YkZMlllaEMXX4jItymnQGjQd2OpPIUpKTCfpBKLhXDnvfQXnnP9s2WdkG46U39y7sGKliWLne86noiUvUMz3q/oIWG0ZsOhJo1QKvmR4N7oyIYCgNfa8SjomWVcA0giPKIDGMumsIk9/XJOOYkayXdoFMTKA1TCR8ItQQ2WC4nMQildKMkGYoNikNG/674m5dvpXszMA1e/HneSeAtqP9HSryMlVL3BtUjuTRd50Eji1c130/vxTkn9u/pqIDVlDjfdifPOU/vg/3ba5vktCGDrTg6keNwrEdFglYAbPNMJ0rHGfg6qaOR5uRkIyTXEkGBNtG6moVcGHn4sHeNDw7NiV9Ffxljnsv2sHVfFFsRdN8wXXv409/nhDF+a5sp09ddQHRHJN50ik1CfkMx4uS0McRXKncKPrbwlONCeeW3SMc8 OJC0eq7I twlgBym77MzmAWtuwqaqHULAMOwROQgimiyJFQzPoIKZfpaqMUROYDFI/3v1QjTn08vjbbpvkhXu0KhctFOPDUbT6z8qm529H+cQScvGtopRYvbQOWHoDCZ9Q53D8RxY968za+dxXKh1jKsUAXF+A0XYt7cIOty7VIYxJjveg1IYimu36V9TvGtbunPURY2rE/6ArKrIxINKerQonnMi5MbHSwg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 26.04.24 16:45, Matthew Wilcox (Oracle) wrote: > Convert the comment into an assertion. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > mm/rmap.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/mm/rmap.c b/mm/rmap.c > index 2608c40dffad..619d4d65d99b 100644 > --- a/mm/rmap.c > +++ b/mm/rmap.c > @@ -182,8 +182,6 @@ static void anon_vma_chain_link(struct vm_area_struct *vma, > * for the new allocation. At the same time, we do not want > * to do any locking for the common case of already having > * an anon_vma. > - * > - * This must be called with the mmap_lock held for reading. > */ > int __anon_vma_prepare(struct vm_area_struct *vma) > { > @@ -191,6 +189,7 @@ int __anon_vma_prepare(struct vm_area_struct *vma) > struct anon_vma *anon_vma, *allocated; > struct anon_vma_chain *avc; > > + mmap_assert_locked(mm); > might_sleep(); > > avc = anon_vma_chain_alloc(GFP_KERNEL); Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb