From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9047C369B2 for ; Thu, 17 Apr 2025 16:17:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CD7AC6B0169; Thu, 17 Apr 2025 12:17:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C5F276B016A; Thu, 17 Apr 2025 12:17:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B02196B016B; Thu, 17 Apr 2025 12:17:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 8BCA36B0169 for ; Thu, 17 Apr 2025 12:17:57 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id CB7E381BDE for ; Thu, 17 Apr 2025 16:17:57 +0000 (UTC) X-FDA: 83344042194.11.1C11EE7 Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) by imf15.hostedemail.com (Postfix) with ESMTP id BE5ACA001C for ; Thu, 17 Apr 2025 16:17:55 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="jmj/t+C7"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf15.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.51 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744906675; a=rsa-sha256; cv=none; b=2O9680kpuR7IohxM7tS/oaF4Kbn9pi5Ciuoy30qBvOoyphcA/tiTU8tt18S9ZvJi/OUe9F oHO8jy6Bi81NUp4NYyQsmE+lkunA93RpMoATVyuyRpF+TdN8TH7IQXm3/lbCQ3xUNlEbWF BAIctYbdmyG8j0Mm9HAJf2iAYgX8/YM= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="jmj/t+C7"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf15.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.51 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744906675; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aawqGQA7h7mWtnCzcBvSH6Tpe/FpQ6KN3oVwrmoliu8=; b=4rM+PUi+r7Zda1vAApApEbtm0KfJr/GBZH+wRXQ30x9RDpyJU3zCLIwvEPPekKZM/+CP34 jRHHEGgII0o4VDnWoWZOJkklDoCVpLG9antX7RKi7X//tXYvhMCfI5HfRH77t5ITYgnJYT RVc2dYpTP/fykN83VL+1oMEdfOPtQrs= Received: by mail-lf1-f51.google.com with SMTP id 2adb3069b0e04-54998f865b8so991048e87.3 for ; Thu, 17 Apr 2025 09:17:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744906674; x=1745511474; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=aawqGQA7h7mWtnCzcBvSH6Tpe/FpQ6KN3oVwrmoliu8=; b=jmj/t+C7V7HwpecrVoYacfwyJ/XnjYZMFSUzRiRiWXoe9Lrvm04YDjNdq+yk+Z6ync 6fnksFWtDSPtvVNKxLaopjOfnY6IHPKO0bPq559/PW5lbJ2Bo+zQ5tgZJdiweiaHtqJ3 JIXKIInKripvxAAORSorpUYreXULO29yYtHUmTinP7oBMP9YQ8cBF2lit/dk+9lSNr9R qnXeLViwa7OTPj1MqTgAYGvMHbCoBHDE408aCZzvHNbPTxFaimRzETy3pDl5M3qkHznX HJlobIhjwZl+duQTNQa7hHVMkjcEfV5j8KwyXThF2yEevdZ2FLoT0RabimPjuTa9CqJA YH0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744906674; x=1745511474; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=aawqGQA7h7mWtnCzcBvSH6Tpe/FpQ6KN3oVwrmoliu8=; b=vfjUzkkEh7mdBc/QmLILCceNJrLQQT/1c648n77t/mUqTsPOwTPwL0Mx9IB4rYvpMp 1pxrGLvZfpG6YYbUKH0avh19oXEZPTQ5z/beBaSCyRobPF7z/r9/kYt/NYKR/Cn576fZ h5Is9wEVdW3HGsmcH5RnoTJvE9ti2sXL/HZ5r9uaPQ5YUUKYhw7suk/Mje1sRToPjRlk hD6CMhCNxhP6AkzhZfcVb0sSvu8P93gOCcSjg94kzfT9NSiree+y2Kioq9cAWW2Scd+B I+ewzlBxesij51BaQWHPcbVf1f7QpYABgvMg8+/2GuzfRWdZqCre9lOeCDUnNVf99u+X aYgw== X-Forwarded-Encrypted: i=1; AJvYcCVoEWrl9eNaPranD8z4aRK0fs+NEJ9GPIn5g0UvzOCrDcoD2FVSHj1yVmNklIzgbtRLWzsgipc9vw==@kvack.org X-Gm-Message-State: AOJu0YyRcumswMhHKDoxyTuvYDQgK23eARhWq9xzZjKlkz/ok136cViH m25l4ZnJH4Qe5UNrsB4jgmhXH+Gi0CQbv4KC0T4piLfrSvkiwBying23eJ7r X-Gm-Gg: ASbGncsVGdPjyYgJjhuCUSIMm6GtKWs02tv08B4wiR3lDlwqg2jiSTYx97F3mTFffNd 6qlEHQ8SDuilr9CmX1ouW0LvG9vjblCw89ydUhxyUxvp+5B7Nmc0ESN8mWKCDOIVo3eS9SO8Qww j+8nbs1v7RX2Zw1SG9fe7Ui6/x8o5Ifr2Iov27ej99L9o93VPTgkarXvHk9OSmmdDnNJna7QNss sJHilbsUiW4xov0+vZmhJ7tVR9/JdGmqcWAzfG3GZuWQO828yGt8GjiFwOOmuUYEHJll8xK1vcK BENvVKjZSjcsfWSCgyG0lrukA9da84S81wxMUFB12CzAEl1r28alKlszdhoRAu0lUiVd X-Google-Smtp-Source: AGHT+IFw/cc14IFO9UCiR2xFD24fmph4C2vk2h0k2LliVIja/hNbA0EyNQRDigh7xH1Kf3h3LI54Pg== X-Received: by 2002:a05:6512:a8d:b0:549:9044:94b3 with SMTP id 2adb3069b0e04-54d64ab0c71mr2050136e87.29.1744906673833; Thu, 17 Apr 2025 09:17:53 -0700 (PDT) Received: from pc636 (host-90-233-217-52.mobileonline.telia.com. [90.233.217.52]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-54d6dfa1d1esm2066e87.174.2025.04.17.09.17.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Apr 2025 09:17:53 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Thu, 17 Apr 2025 18:17:51 +0200 To: Baoquan He Cc: Uladzislau Rezki , linux-mm@kvack.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/5] mm/vmalloc.c: return explicit error value in alloc_vmap_area() Message-ID: References: <20250415023952.27850-1-bhe@redhat.com> <20250415023952.27850-6-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: BE5ACA001C X-Stat-Signature: 4eztubq4qohbw6c3i3rc9besj7b1wtmt X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1744906675-666521 X-HE-Meta: U2FsdGVkX1+5+rZbN754/2GlWuGCtk+Yiyi1jwlwDZ7tuAbIFugwoy9bmtJTBgnfe8jHP6LWMrvne3n3smUKnZsMneP9M4zojfXZyEy0CnMr61xPAc63fsN0mVMwTq5WqOhXohdqpVfmBs4ZyhziUVt1OoOiWjLhKNG7L/Xv2dMrIQL6+wfZ6iqqt5fRwbOxabXUYI5w3eSxvRQgWy1aVypX1QQgH8PrcxPAkMov1qK9IdAw4o2LK15EpWEm/DnNVqf78ord5x8//3eL3novLSW4X3TwTLv8xcKYUTDnEUHYF0gupg6WZIapkmwp1ab98j61r5DnYu8CK7e/QMbQl1gbHQOFrONxsIGDIIOiT+BoDP0+g+iCbkOhYIxKJbi7DwCS9iFBYTKRVv6xya0wwZ1tL2IBiJkfhVswfIW4hMkrk/ANXLajJbSjJFmOODdPDhA3dRJpOGR/CIJXBAWf4KE0QexVxb0S7lqnqRX7A7HCsB5Vfy02U6Sezi8ncLqdfdtdUXBFbwokbi1noHKotbdSKDqNim7QEmxj314R2Heag5O9JRkp3x2WATaDvkCSS3k1IuULMAsqvM0rPvtnH8ds33ozuSfCJ8bENl4Z582cPY+D7178L6GnmDt37bEAAS7TKDm04k9V/VX62sspCErfj5oVDK6CGoExTESzbjTRXo82Xk66mNSSLAbDiIK29PMcUcorth4k36wS8wFDBKzVFRY+5k9vU/Ft8W/x8/GskJH2KGm9OUy1iSu6hV/kVXcPd1zHPAQCZvacDnD0UD4ARRlZn7j6t33iQsbPai5lzoHvu2jzCc9oP6at0K9C+Qq8YY6PB5X2QR6/qLcMCb1wR2qYGiQL66edTaM+3nItcLrQemeYCn0lW3q0jcUlcC9JebRIZtUBhUW85ssD/FACUS2mlHKKbeyQGVgvgVwyzkUfJdJh8Ft2oBZExJ/KH1SQW+iri/8khjBNt4L 2IdvFeVh BX1bO1sOmnq+vHiUErCbjq8GuXzhXxBr+wbdZqoZLSygJQ+EnSogoEUJmFwWQo4+DQWdu+9LE4X6t4LBkI3ApO1ZT5RlLIR6KZP+YhlXgJe7a8PmzH8eJwydSnC5G/+n94rKDuChY7OVrmgWhBLu55kVeGn/NGHyBnroBx/NnPv9BOkUqnZN1t+lqJU3SRGRuBE1P63xAKq2TtX3mXIEMHgpk9ts42RNqwhyL6OATohleJNBaklPAXZ7KSetkjRSNwGT6rig8jXy6AjWPYjStVfb83N5tK8D6LnxXugNnKwo0dGatVSlPNLHfmiauq+m91PMBBvKh8OeSL9y9pBsek4PHECPFUHdFbqM0k90xP5KF162HSz5J99DMzl7xqiWosk2qb9sLPh1t/ny8sse9ZwVN/PJ+BYFGiaKYSf86zwcdbQza4z83w5R3qPaoeSXWc57yPwSW9NYK+jbsC/9MllDwyw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 17, 2025 at 11:02:06AM +0800, Baoquan He wrote: > On 04/16/25 at 04:28pm, Uladzislau Rezki wrote: > > On Tue, Apr 15, 2025 at 10:39:52AM +0800, Baoquan He wrote: > > > In codes of alloc_vmap_area(), it returns the upper bound 'vend' to > > > indicate if the allocation is successful or failed. That is not very clear. > > > > > > Here change to return explicit error values and check them to judge if > > > allocation is successful. > > > > > > IS_ERR_VALUE already uses unlikely() internally > > > > > > Signed-off-by: Baoquan He > > > --- > > > mm/vmalloc.c | 34 +++++++++++++++++----------------- > > > 1 file changed, 17 insertions(+), 17 deletions(-) > > > > > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > > > index 3f38a232663b..5b21cd09b2b4 100644 > > > --- a/mm/vmalloc.c > > > +++ b/mm/vmalloc.c > > > @@ -1715,7 +1715,7 @@ va_clip(struct rb_root *root, struct list_head *head, > > > */ > > > lva = kmem_cache_alloc(vmap_area_cachep, GFP_NOWAIT); > > > if (!lva) > > > - return -1; > > > + return -ENOMEM; > > > } > > > > > > /* > > > @@ -1729,7 +1729,7 @@ va_clip(struct rb_root *root, struct list_head *head, > > > */ > > > va->va_start = nva_start_addr + size; > > > } else { > > > - return -1; > > > + return -EINVAL; > > > } > > > > > > if (type != FL_FIT_TYPE) { > > > @@ -1758,19 +1758,19 @@ va_alloc(struct vmap_area *va, > > > > > > /* Check the "vend" restriction. */ > > > if (nva_start_addr + size > vend) > > > - return vend; > > > + return -ERANGE; > > > > > > /* Update the free vmap_area. */ > > > ret = va_clip(root, head, va, nva_start_addr, size); > > > - if (WARN_ON_ONCE(ret)) > > > - return vend; > > > > > Not clear why you remove this WARN_ON by this patch. It should be > > a separate patch or just keep it as is. The warning here can mean > > that something is really wrong, especially if NOTHING_FIT. So we > > definitely want the warning. > > I remember one time someone reported that the slab allocation failure > triggered this warning which is confusing to them. But yes, it should be > discussed in a separate post or thread, not appropriate to remove it > silently. I will add it back in v2. > Thanks! > > > > > + if (ret) > > > + return ret; > > > > > > return nva_start_addr; > > > } > > > > > > /* > > > * Returns a start address of the newly allocated area, if success. > > > - * Otherwise a vend is returned that indicates failure. > > > + * Otherwise an error value is returned that indicates failure. > > > */ > > > static __always_inline unsigned long > > > __alloc_vmap_area(struct rb_root *root, struct list_head *head, > > > @@ -1795,14 +1795,13 @@ __alloc_vmap_area(struct rb_root *root, struct list_head *head, > > > > > > va = find_vmap_lowest_match(root, size, align, vstart, adjust_search_size); > > > if (unlikely(!va)) > > > - return vend; > > > + return -ENOENT; > > > > > > nva_start_addr = va_alloc(va, root, head, size, align, vstart, vend); > > > - if (nva_start_addr == vend) > > > - return vend; > > > > > > #if DEBUG_AUGMENT_LOWEST_MATCH_CHECK > > > - find_vmap_lowest_match_check(root, head, size, align); > > > + if (!IS_ERR_VALUE(nva_start_addr)) > > > > > Just keep it as it was. No need to check if addr is valid or not. > > This is to keep consistent with the old code. Before this patch, if > va_alloc() return vend, it returns directly, no > find_vmap_lowest_match_check() invocation is done. I tried to keep the > behaviour unchanged. That code is for debugging, both is fine to me. > Ack. Makes sense to keep same behaviour as it was/is. > > > > > + find_vmap_lowest_match_check(root, head, size, align); > > > #endif > > > > > > return nva_start_addr; > > > @@ -1932,7 +1931,7 @@ node_alloc(unsigned long size, unsigned long align, > > > struct vmap_area *va; > > > > > > *vn_id = 0; > > > - *addr = vend; > > > + *addr = -EINVAL; > > > > > > /* > > > * Fallback to a global heap if not vmalloc or there > > > @@ -2012,20 +2011,20 @@ static struct vmap_area *alloc_vmap_area(unsigned long size, > > > } > > > > > > retry: > > > - if (addr == vend) { > > > + if (IS_ERR_VALUE(addr)) { > > > preload_this_cpu_lock(&free_vmap_area_lock, gfp_mask, node); > > > addr = __alloc_vmap_area(&free_vmap_area_root, &free_vmap_area_list, > > > size, align, vstart, vend); > > > spin_unlock(&free_vmap_area_lock); > > > } > > > > > > - trace_alloc_vmap_area(addr, size, align, vstart, vend, addr == vend); > > > + trace_alloc_vmap_area(addr, size, align, vstart, vend, IS_ERR_VALUE(addr)); > > > > > > /* > > > - * If an allocation fails, the "vend" address is > > > + * If an allocation fails, the error value is > > > * returned. Therefore trigger the overflow path. > > > */ > > > - if (unlikely(addr == vend)) > > > + if (IS_ERR_VALUE(addr)) > > > goto overflow; > > > > > > va->va_start = addr; > > > @@ -4753,9 +4752,10 @@ struct vm_struct **pcpu_get_vm_areas(const unsigned long *offsets, > > > > > > ret = va_clip(&free_vmap_area_root, > > > &free_vmap_area_list, va, start, size); > > > - if (WARN_ON_ONCE(unlikely(ret))) > > > - /* It is a BUG(), but trigger recovery instead. */ > > Keep the comment. > > OK, will add it back. > Thank you. -- Uladzislau Rezki