From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E3DDC369D5 for ; Mon, 28 Apr 2025 21:34:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F0E556B0023; Mon, 28 Apr 2025 17:34:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EBC8E6B0026; Mon, 28 Apr 2025 17:34:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D83E36B0027; Mon, 28 Apr 2025 17:34:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id BA7C96B0023 for ; Mon, 28 Apr 2025 17:34:00 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 29B951CD287 for ; Mon, 28 Apr 2025 21:34:01 +0000 (UTC) X-FDA: 83384755482.09.75C6696 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by imf06.hostedemail.com (Postfix) with ESMTP id 3EBFC180011 for ; Mon, 28 Apr 2025 21:33:59 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="P/tOLK0R"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf06.hostedemail.com: domain of nifan.cxl@gmail.com designates 209.85.214.169 as permitted sender) smtp.mailfrom=nifan.cxl@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745876039; a=rsa-sha256; cv=none; b=CpwcpfD+ktZsiBU66DWN/iqA2jzGfBuVpEtj5rFRGEwVTt/i5vH8jjLhFJpMGX38LMHUjl UPr5vE89Qk16gEUsPOaJ4pqzAFXMQEjd26cP0rZCxOC4DxF+WL5oK7uQHBKvIHuK6lILwg TFbpR9cLcsAwD6b3iKfG5Jwt4Mx7LIM= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="P/tOLK0R"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf06.hostedemail.com: domain of nifan.cxl@gmail.com designates 209.85.214.169 as permitted sender) smtp.mailfrom=nifan.cxl@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745876039; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=y80dlApmP3WdHlVsCivNbxNkh24dV0wQ8ioMN0ge7FQ=; b=QBzJ2Tb4p7m2t0BERyYNB3Fgbe3Qw5kIRUP4nYw9+c61M5D2iHAF77QAruO42l6Uvi5Ezp G55a45ghLq6ful1hNXzPByqnXQyF9uVeHjN0RGskFUcN0CsroC8EYoW0fSGAREAzsZ8jHM I2wVDIFewkEn6+qlLzCQgyinCwQP8EM= Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-224100e9a5cso64465925ad.2 for ; Mon, 28 Apr 2025 14:33:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745876038; x=1746480838; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=y80dlApmP3WdHlVsCivNbxNkh24dV0wQ8ioMN0ge7FQ=; b=P/tOLK0R/XfJ+p9b03Y85WWRW2tqVKoDZnQq5L1uaC70D7H7SY+0rprBtbjA53FI4u GxlHu9beUKiE9X+G7u/9uX9e26P2BNJ9CoBxN9rHq8CmavrzH4QpJEY3cwH57wPSnUH4 MWIznlcLbi8cdDv0JSwkpK7WIng+sZ3U8kRZ3zVfLtjRnPj4hlYABmmH3WBx6lkPfInk Iq3NIu31ZF14pe1SmOktMnj92phUOPhz9T9zDHCZoZ2mkmlA6QLSdKPVyS9GrfDnM4JG bVfH1vhtP0o/ZsZFUa6S2Wj/dYu/q2CCdZDjaB20DAASCfXXKjhx2vBOBzHkzUzK9toF IOJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745876038; x=1746480838; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=y80dlApmP3WdHlVsCivNbxNkh24dV0wQ8ioMN0ge7FQ=; b=d3gj1ywb8IwhSYxRsroDe7C1mW0vOGPgwme7xr08lsJfghU++bw28UcOgqQdlsDSKq V3l/pR2ZLrRe984GZnTmeb6T5+v6iC2pT/nBJXRrrHns5fnsf7NKOwXnlUOzMVYYY2zM GWzoi16y6naUpzzZrHc70PwfYUFN+kkuHANW/p/5xkgWuu2pZdwUmMTLRKhmAPQNElO8 wRfvRsowTmRAmfV0vMW80ddKFnz17aASMrWoJaIukm/H3NkJ6fsebiNVkTGO77U2h452 GCy3nLwvv1p2bGdRp42dDgRUQSMW2d4C/T01WhpCWNe33IEVqsfTgt1tU0J1CSp960Nl CgLw== X-Forwarded-Encrypted: i=1; AJvYcCXSHy93IWtnMAak2lBcODvL5AmVfzBum/67K2iXdrAbGNSBY1OZEeA3dIX5mowJz8Mu57BcjiXFhg==@kvack.org X-Gm-Message-State: AOJu0YzzliIyS1FmJOremzbmMlpTKM46yXhvCjzXWdwYtbV0WgHrFthg mi/+V1+dyDAlxifTd13CL6IwnJn7Fzec7LmUBmfb9aRptnwjR35P X-Gm-Gg: ASbGncv5gXflzF2BVV11s23upCNhz2L0aJBeAES1TvNwrZHBDeSW7iBzApBTwHMFiFk l7JENMEed0I9CYt6ZP9dZrBlVhQ5+sugkg+niyn7xUknT8DyNnVf0F0gD9+4wXAahCfS3xo1S+F DRHA15PNZh5xpxLIPLaNWkwXMFdEdzmRLieZOd8zUiiUSg//2xzsIgavvtpHmL/mL4mNOfCIwVj QJzrxmCLvXMywfDsCXpLi5b2K+2U4xPY33Kx7YNexaeV0h4vC+h5IexjUq28HP3mdo9f7xwd3Bt OLTcac+zTQFDGOx//BhEEmP5oUcls0KGicON X-Google-Smtp-Source: AGHT+IEQ/Biz8EfdED6IIumEpHqFb2nvr2P/lGlfLXCMlTOxPSdv9RbvLpNCcn+KyaUf1fRenvRa8w== X-Received: by 2002:a17:903:1107:b0:224:191d:8a87 with SMTP id d9443c01a7336-22de5fdcd88mr15595845ad.26.1745876038014; Mon, 28 Apr 2025 14:33:58 -0700 (PDT) Received: from debian ([2607:fb91:20c0:f614:98be:8f32:92e7:f9cf]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22db51026dfsm88565485ad.170.2025.04.28.14.33.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Apr 2025 14:33:57 -0700 (PDT) From: Fan Ni X-Google-Original-From: Fan Ni Date: Mon, 28 Apr 2025 14:33:53 -0700 To: Matthew Wilcox Cc: nifan.cxl@gmail.com, muchun.song@linux.dev, mcgrof@kernel.org, a.manzanares@samsung.com, dave@stgolabs.net, akpm@linux-foundation.org, david@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 0/4] mm/hugetlb: Let unmap_hugepage_range() and Message-ID: References: <20250428171608.21111-3-nifan.cxl@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 3EBFC180011 X-Stat-Signature: 9fkupta5h6867p5adbmcef1hdanf6c7b X-HE-Tag: 1745876039-405269 X-HE-Meta: U2FsdGVkX18bF3rNDZUswVtIVPO6lZWAd3lM7QoKxsY1KcdTb1wCaYoeNSiJz1nQQKKK5D/XfyH2PDK3ncaOT621g/yp/jY878mhlagRyRojycmAIBQjDccxVQrVul2jsnViUKO3hbbZa81S570fBm71Roe87q/Oj7kPhy7AcGqk2LCPhvdMx6f0C2uxoSJGTMk0dXS8u7zeNVIF1XegEgwb5VGavl8pqcPERm5Jq4vr8HHQmFFOxx7Ymm/YKrV4z9xEWlJvbzsjsIejMyk+q2Y0Wd4JnIIXaaYb+cPX1B+VnX0Dn9ysnfXRqQn5ncrkWf75J5fTWHVc8DuZq065NejXYEcNbOp8Iw9lP//54EuO7m/d+FJ1+xS9LBwRkUtv7/YkxilfWrIIS7JaNAQZ7Sd8eVOLIh0S8ukEQTM+9kdRFFh6iQ7ANZaGCKqXdcOuNzwpSHslz3TJnOqRsaU8eH7Mt2LiMHldsn+UURK80suL7Ypvsfo0FTSTw4KnVfEwVaf6tgiR8GmmMLz3D/IP1lhMEwgaUZMpZYka0JADy7/pZMyHfycAF1ng+zn0TIaG3W+Tk2eZHNJg+0mGKf1D+KB6axdM4zmDXb8X4aZZuDvCxUvDmj2TNnfdcAT6EA2pSNASkYDFtsqz1f1JGzc9QVGl+tyGwQsCTHvBZInZ+zO7E+CYastx/UFjwaDBdnd+oqnMVWuvkxuNhNb/F84cTBOYCx+sA8sDruzvKpsbxqSrBcMK85JDWVF0mIr2iCC0dLLoL89VoulufWEMHrv0pX1XLYOXMcc7syqabLVMEWup3PqV5oRqjb7CCxL5667QFlahIL/paM1yFwdut7k3O1RlGcjNG2UnksZefy1Lg3Y+xujQBv3MnZ1WsEbnOFBGNahNgggJIJMst5qGRq+VVSij62dXy5PhssZMqgiZtkjY02y6dDsSVKzeMFVOW7GWAekMY3sc87CTuvmwd+3 72/+TwBp LFRu/I/5Z988uwOXmQF+MvccS/F7sp6G5z9ULmJWUwtgnaFTgKz/M/0KckZPCJYiVOTtO2Fw+NudnjWfHalpKGeSAh1b84MJL2ZlY+fq57DD94AZ/yaw7mvZYi69sIe40cxc3dg7osIxuE1EPizQtE4Uo3cv0tsiNKKNQx1FQyFmNZrxErnofI106+EwZgpIC1ERuA3/wxdA/W0PPtKWzinlU8JnyZkUwnI0Mxy4+ayqQJfp27h9XIdlBzvHmVTNwTikDxrsELiPHP01uVw6J1Or9eGEoNyKjA7wpXEm33q9upPBqPeUQ0Lz9XaLxqWTMX+GuRIM+21jUl3+4Ph0asX3BV+g9DgvOrn2ItVqTWFz3z6+L6e8i/kMCOjSAnm4VByHFRCzjXG32RE1vRaAIz91ZEAP/7PVDQTcCc2/PvNEhB+IpoKLMa0DQgaa4ft4rnPAolu8q7d+F4pSCgZIaZ/Ls0QyvXY59A4qR4/KNhUNKTHrRWX7dHVxRPdl89jt8zA5RMZD0WsgcY1YUghEQ2Pk3Vb+4udAGYthcMbDbBY5UYUrdiNvZ19cO1wLsDOBFNwUsDP8mpizDfwuBw3iPpXJlrYvauvWV39YAy/eDKYXyHHJALzrEZ6/CVw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Apr 28, 2025 at 10:01:36PM +0100, Matthew Wilcox wrote: > On Mon, Apr 28, 2025 at 10:11:43AM -0700, nifan.cxl@gmail.com wrote: > > From: Fan Ni > > When you're sending v2, send the same cover letter as you did for the > first one; don't make people go and look at v1 for the cover letter. > > Put what was changed in v2 after it, so they have some idea what to look > at when reviewing. Hi Matthew, Thanks for the instruction. The previous version of the series (v2) did not have a cover letter, so I only attached a link here. I will keep the rule in my mind for future sending. Fan > > > Changes compared to v2, > > > > Patch 1: > > 1) Update the commit log subject; > > 2) Use &folio->page instead of folio_page(folio) in unmap_ref_private() > > when calling unmap_hugepage_range(); > > > > Patch 2: > > 1) Update the declaration of unmap_hugepage_range() in hugetlb.h; > > 2) Use &folio->page instead of folio_page(folio) in unmap_hugepage_range() > > when calling __unmap_hugepage_range(); > > > > Patch 3: > > 1) Update the declaration of __unmap_hugepage_range() in hugetlb.h; > > 2) Rename ref_folio to folio; > > 3) compare folio instead of page in __unmap_hugepage_range() when folio is > > provided when calling __unmap_hugepage_range(); > > > > Patch 4: > > 1) Pass folio size instead of huge_page_size() when calling > > tlb_remove_page_size() by Matthew; > > 2) Update the processing inside __unmap_hugepage_range() when folio > > is provided as sugguested by David Hildenbrand; > > 3) Since there is some functional change in this patch, we do not pick up the > > tags; > > > > v2: > > https://lore.kernel.org/linux-mm/20250418170834.248318-2-nifan.cxl@gmail.com > > > > Fan Ni (4): > > mm/hugetlb: Pass folio instead of page to unmap_ref_private() > > mm/hugetlb: Refactor unmap_hugepage_range() to take folio instead of > > page > > mm/hugetlb: Refactor __unmap_hugepage_range() to take folio instead of > > page > > mm/hugetlb: Convert use of struct page to folio in > > __unmap_hugepage_range() > > > > include/linux/hugetlb.h | 8 ++++---- > > mm/hugetlb.c | 39 +++++++++++++++++++++------------------ > > 2 files changed, 25 insertions(+), 22 deletions(-) > > > > -- > > 2.47.2 > >