From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC25EC369C2 for ; Tue, 22 Apr 2025 12:14:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C86C76B0008; Tue, 22 Apr 2025 08:14:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C38006B000A; Tue, 22 Apr 2025 08:14:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B254F6B000C; Tue, 22 Apr 2025 08:14:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 9597A6B0008 for ; Tue, 22 Apr 2025 08:14:08 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 99CA214073F for ; Tue, 22 Apr 2025 12:14:09 +0000 (UTC) X-FDA: 83361571818.27.13F82E4 Received: from out-183.mta0.migadu.com (out-183.mta0.migadu.com [91.218.175.183]) by imf20.hostedemail.com (Postfix) with ESMTP id B359C1C000B for ; Tue, 22 Apr 2025 12:14:07 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=O715COAL; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf20.hostedemail.com: domain of yosry.ahmed@linux.dev designates 91.218.175.183 as permitted sender) smtp.mailfrom=yosry.ahmed@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745324048; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DsgsuiDl6yNL7CcpFW9U5jdCE7K00yNVVhC4h3Ewig8=; b=XctoFHNT1r2u7CDwdLSCo6+inGWNuHeYTAZQrCxoRgp3qgvbUcfu6hW3T6tokSrXXnF6Ou MCKo8G28C4uKBuZRo5m6ofZgbg2bZ7CAke0IZn55JEbcNWnI6yag+Ix9hdgTZHqzl+ACPa +shRi73PhiO5r0vJTK7Y8apF7r9Fb+g= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745324048; a=rsa-sha256; cv=none; b=UKOxAOu69XDXgH82/ByKYG4YKBVqUZ1/faKxBKY1QgC9y2iD5SKUHFe3++Y5n9/raGwosL sWJ3XMBrlG3NrWb+9B3uDGyxYPi68eftT+1h0bq55pDdCBFwG0KivnRAT0NB6M/ROGTglQ ZaiPj8Ly/ffcWpKcB2WKWGv1oD4CtZE= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=O715COAL; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf20.hostedemail.com: domain of yosry.ahmed@linux.dev designates 91.218.175.183 as permitted sender) smtp.mailfrom=yosry.ahmed@linux.dev Date: Tue, 22 Apr 2025 05:13:59 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1745324044; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DsgsuiDl6yNL7CcpFW9U5jdCE7K00yNVVhC4h3Ewig8=; b=O715COALotWAPIYZxS6G6xu7LjevqZhmQRPS77lt7eCX8EdWbdHCI5Qwc+cRCqZWuKU9Eu 65BtbEnC/iEieGzzCFYLCVbywYSGFCqKAhaycOW3HBrzEsZzdmtIm3xmYGB5Raz24E4/U2 uvJ6bMe1Z/70zT6FHGf/nWjJQixHxKQ= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Yosry Ahmed To: JP Kobryn Cc: tj@kernel.org, shakeel.butt@linux.dev, yosryahmed@google.com, mkoutny@suse.com, hannes@cmpxchg.org, akpm@linux-foundation.org, linux-mm@kvack.org, cgroups@vger.kernel.org, kernel-team@meta.com Subject: Re: [PATCH v4 1/5] cgroup: move rstat base stat objects into their own struct Message-ID: References: <20250404011050.121777-1-inwardvessel@gmail.com> <20250404011050.121777-2-inwardvessel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250404011050.121777-2-inwardvessel@gmail.com> X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: B359C1C000B X-Rspam-User: X-Stat-Signature: 6pejrk7ywqd5rk1xj1mwa1e6kwm1pugq X-HE-Tag: 1745324047-780294 X-HE-Meta: U2FsdGVkX1/K7icT9AS/MWIIlmKxWeXFWb6gcCX1oF8oqerFh1+6pLkdzz/bZXOF+8Sb0l01YuhuuUclKtmCjmMsyDMpQJcB9aCCKVEFF4ggH4dJ+2lmGyy5KLQS6cy6CuZ8f6bTDsBsRnR8+zoxj08gNFuWidlzz7Pqejsdq4+lk5Fg7uDbinWIM3MqU0s3gW8oQ2jXJ/JMun9oYZV7hlO4CzV3CSHL3uVwI2VA4z/sVw3THGBDkVJXWUyAN0qU8WvSJhUqnhX0psQSIm1kMWI9Muisskys/ImTAAEw3wsG+i7D1LY2R8rZ4RjQesxIN0vXmtpTSVL8JWB9NYLKMkO2BFi1YG6XC/hWIkz4ZHVCNlyK4q4h3YcMxbddZ2x6raOBSKWgand0DjHV7oyE+MSGqxL2JbFXa/wky4dfBKWzZ/epmqfhJWLoEaF0MKBWBDjRrFFrCYkIzSaP0KgiHyJDJ6pIznvf1ZrK60OHWBrFrVFLnKmBMUHNiWMiw5HjdNGdHFcvG8KQutXzhN6WxB+aUkMCQ+rKK1PGFWQnq3k0Gn6uv7t+dx9ouSceC3obtF5n1rU4Ts12Y84OuZiuUKaQk1tKOQPg8cwiMNhsjJ3UxqqX1Apb4Y+BKq2NxvwQhUB0jy1pu7UgOFaYMK7/EcxvyX9SNgsrt/fpUd9nJBdOV4N022K2mzrCGMJvvv5qseEuhMolDSCDeAV8W1tjidmnXGM2fVf8IIMPyDvQWwsV4df815CDWDSH3OACMpK8QinF+f/xAd743fxgab/EyDEhd98r1dq5bcmPEtNLPf9R/IrQc41JRRe1vZoBqd5omUg3YEFYS1kfBMpohMMXZwc6lzQ+31qzr7wqx9srTooS06tCe+Iyc2L5027OEur11k1ktIhsHt6HgImmL+9E+fD6ISKfus34/+l/bzc5n4tQaD0Hm23naZqV9KPCSZvOv6rBZVHiC4Bul0WyMss 06eVt9xS T001o8epjK4P8OYMsD8vAPIFUYGuSP7Q37ZJRzSjOFTx60ZueVHDG5tXcsuRJ0S1hfLrRIkEEJYAyf1essva9c4OlGuC6bAalNsqNAxzh9hyjV8LTT2vouxPiKUJ3cokd1sYHsx8IqiDyZ5bhWrfah6NeeL/0VDvvPdMTOClxVcjKKuEvU6VQ4rbK1LFMlGWebU0/ztVKh05TjdM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 03, 2025 at 06:10:46PM -0700, JP Kobryn wrote: > This non-functional change serves as preparation for moving to > subsystem-based rstat trees. The base stats are not an actual subsystem, > but in future commits they will have exclusive rstat trees just as other > subsystems will. > > Moving the base stat objects into a new struct allows the cgroup_rstat_cpu > struct to become more compact since it now only contains the minimum amount > of pointers needed for rstat participation. Subsystems will (in future > commits) make use of the compact cgroup_rstat_cpu struct while avoiding the > memory overhead of the base stat objects which they will not use. > > An instance of the new struct cgroup_rstat_base_cpu was placed on the > cgroup struct so it can retain ownership of these base stats common to all > cgroups. A helper function was added for looking up the cpu-specific base > stats of a given cgroup. Finally, initialization and variable names were > adjusted where applicable. > > Signed-off-by: JP Kobryn Reviewed-by: Yosry Ahmed