From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3940C369AB for ; Thu, 24 Apr 2025 16:34:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 251776B000A; Thu, 24 Apr 2025 12:34:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1B0C26B00AF; Thu, 24 Apr 2025 12:34:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 029686B00B7; Thu, 24 Apr 2025 12:34:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id D5E446B000A for ; Thu, 24 Apr 2025 12:34:37 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 779701CF8B4 for ; Thu, 24 Apr 2025 16:34:38 +0000 (UTC) X-FDA: 83369485836.28.2320F36 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) by imf21.hostedemail.com (Postfix) with ESMTP id 802EE1C0009 for ; Thu, 24 Apr 2025 16:34:35 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="P/STBUF0"; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf21.hostedemail.com: domain of andriy.shevchenko@intel.com designates 192.198.163.13 as permitted sender) smtp.mailfrom=andriy.shevchenko@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745512476; a=rsa-sha256; cv=none; b=k8LpJyqve1ftwUyfQDux+7/XYuceO8V8F4MLmdbsHIDBeWEf3Z9UorAxpBF/66Lufhv/5Y 1KkFsl9a7akpuZ20fSjLg9oZMzdkJWX+WEsClmFMlb75R4l8d29eE1gYIJ9OAVDMEnFap6 vbSJgjEhLKaF2/8+l9mfGCliFXHg854= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="P/STBUF0"; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf21.hostedemail.com: domain of andriy.shevchenko@intel.com designates 192.198.163.13 as permitted sender) smtp.mailfrom=andriy.shevchenko@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745512476; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=d2fU5Q32Ho+xJ1OsWyNdLbFlZl28CAG7JKc76QPKL5U=; b=zWg26vHRME7dnbrqca2iu7Upgy11V7SpTuMwSPqa/YXv31oqqv+ugGWS4Z2fxvs/IenWCc 9H2+NjNUIdzb8chbrSynK/dfZ91EBE1Tj9CFAnCOkaZ6GEj5zG4BGsHs6eHw5a1dNa1s9B jLX8EpwIm08AX9NOkSd3NDp5zByMxHE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1745512476; x=1777048476; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=/2+v4MrrIX1tru3YRH21EcKXQRarr69zuxlHYYHXpdg=; b=P/STBUF0xeK4neiZjDNdWhaAsQFD7JtEcUw0FUyfQOOjnHRTWGFtx9MY XpvDpukPInfV9o2xI+S2lWUIrU8aFd4i8RQcvFr89J2JOkEvQzLfs43QH 4BQzUsYcByJwEq4Czq1qhwvGeDS9E8iIKA81jwn1OojmFWcJM22SJGO8+ UOYSa3bsAVlF7fchO5MCAGojehrOU62WIAQbjQyFOiaGx05Wfs2lJjs/i XAQiIVUhE6QcaFwhgDP0Ma5sDMEiCy3OVC8NwX19Uapg1nyn1zlI3ujFP PAOYhJJ6dbTzMSfHsn0X4IZbav03qrdVYLCoOJaLOMafZCp00XMtxzHwU A==; X-CSE-ConnectionGUID: CziHf8fORD2Wzldhds0HOA== X-CSE-MsgGUID: I0HuEECXSfG4uM3SCGSs0g== X-IronPort-AV: E=McAfee;i="6700,10204,11413"; a="49815012" X-IronPort-AV: E=Sophos;i="6.15,236,1739865600"; d="scan'208";a="49815012" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Apr 2025 09:34:34 -0700 X-CSE-ConnectionGUID: riyFq7+hRgmuldfE9BonoQ== X-CSE-MsgGUID: 5sAVUh6aTpOxttr8Kgxhsw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,236,1739865600"; d="scan'208";a="132657353" Received: from black.fi.intel.com ([10.237.72.28]) by fmviesa007.fm.intel.com with ESMTP; 24 Apr 2025 09:34:30 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 9D4FC1AC; Thu, 24 Apr 2025 19:34:29 +0300 (EEST) Date: Thu, 24 Apr 2025 19:34:29 +0300 From: Andy Shevchenko To: Zhenhua Huang Cc: cl@linux.com, rientjes@google.com, vbabka@suse.cz, roman.gushchin@linux.dev, harry.yoo@oracle.com, surenb@google.com, pasha.tatashin@soleen.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, quic_tingweiz@quicinc.com, stable@vger.kernel.org Subject: Re: [PATCH v2] mm, slab: clean up slab->obj_exts always Message-ID: References: <20250421075232.2165527-1-quic_zhenhuah@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250421075232.2165527-1-quic_zhenhuah@quicinc.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 802EE1C0009 X-Stat-Signature: ndf1gq56q57i5qeyfjc1pbuy1owzcthh X-HE-Tag: 1745512475-185166 X-HE-Meta: U2FsdGVkX19mufdkXM8NWADzdNzyi3DRBGrE0PasPbYgPk2fUDt5uZ4ubiTQkfIFSjfnhhe6mvM9VGyoP9QJCxDLeCQ9yjo3X3V6TEEYcmsNX26+okQpYXNDMNMMINiRtuNdwloJGj7ChOyX0AvpEPWL/DPaL3lBdUcoIpJmu1Vd3uF6lVzvbVh6QnIVoMJHge865wf50egJ4fX7bqOsPVI0+Z2FodK8nvNh/kXqhXeQe70A/2OfulDrFu3yZAAd4iN8TTbJ998U1X0IFDFnRZGZkeBo9yEXN9aLTpUrHdCRvUBp80bYAfEvZ6Dhc7qBWDrPOAXAAReOjvKnEM6FT5FefP0niqZZ2PNawQCaOkSJfaWsC3t9WlvrMMJDlw7s//mnA2f3Q/NbABXH46e7hcY/HaxLKEjLEIKMY3mMVlPUi/qk5ej9X6T2XOTLmgfHWGiPRZl9LRghPfGU6SyEBzrXSnD3PUPBgSNO81J+re1CA/WRaXO9KHlmmIUQfj0qqvt8qoGyWB1QfEFTo7Yq1NI1M1JAWSvgWSv+Vk4FpDnxFLFZpNOhn2/Almui1at6t50wte58A72F+7XZA5EyG5OrqLup8rCm5t4rCezXM3fta2IZm0QCuzb2P1RzfSPrMc+7KIGXuIifTBZbpJ6fDL25B1EwRhkBeDWe+eLKxjuE4mMU8D7mpMMA6BinPJBscdl6AZVDGLwQGYrJSkK0nlPoEEhwaFi9m9eQ5fG6Mxgbetbe644mB7VL4hG9ZZ7iDH+sjK712tAQrMMrBXHNYh5W3Kt0Cjf7qdMjGG1FW2kCs1WElA1j7ZoBy/bNoG3DiYIyAqR/MhEfL9JEZAkm0Ztl0YNGU6Y48h4WLfqc9t3wNXW79LWjfPoSqaJDhx8EJW1PY2x7BY0rNjKZO/KM9wmYhNbFIFhKoFP8dL/CaLhlrC8cntxO/UqrQWXh/GMsZekorpgWPdNWc1+VjHt ARkHb+D2 6iu/ctX+l7iV9pD4Uu4wq4rK5KQLFj6ArDjluXrUuv8gkJhg+FDHiCwzAZWmq8OmVjLiSlTfLZ0wATqFHVhjFaYWnortefGgpQdUqGu4k7kwHURSiG80Kj66ep3/VWI00k1staHTmMr6nSa9M3kC5R4KDAInoa46xGtjT7EHI5cEqSMJgVG6Az73+Dcm3rx7040Pxe4VPJXZABQaVl3eelxwfxxZujJ4S5d3r5PnXaRfmCTbh9l/zDdyJH5ZNbe5n7i5LBsraXr/04i+3SNAQLM/s4xH3J9KkE9zp9LrpvTGWjpX7j00fUZ+EbQDtpdZghc+S X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Apr 21, 2025 at 03:52:32PM +0800, Zhenhua Huang wrote: > When memory allocation profiling is disabled at runtime or due to an > error, shutdown_mem_profiling() is called: slab->obj_exts which > previously allocated remains. > It won't be cleared by unaccount_slab() because of > mem_alloc_profiling_enabled() not true. It's incorrect, slab->obj_exts > should always be cleaned up in unaccount_slab() to avoid following error: > > [...]BUG: Bad page state in process... > .. > [...]page dumped because: page still charged to cgroup Please, always compile test with `make W=1`. Since CONFIG_WERROR=y this effectively breaks the build with Clang. -- With Best Regards, Andy Shevchenko