From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E97CC369AB for ; Thu, 24 Apr 2025 16:48:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4DC2C6B00CB; Thu, 24 Apr 2025 12:48:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 464816B00D0; Thu, 24 Apr 2025 12:48:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2B6E26B00CF; Thu, 24 Apr 2025 12:48:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 07F136B00CA for ; Thu, 24 Apr 2025 12:48:41 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id E8FAD1CFADB for ; Thu, 24 Apr 2025 16:48:41 +0000 (UTC) X-FDA: 83369521242.21.E0E129F Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) by imf26.hostedemail.com (Postfix) with ESMTP id 9FD0214000F for ; Thu, 24 Apr 2025 16:48:39 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Z35M7FDD; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf26.hostedemail.com: domain of andriy.shevchenko@intel.com designates 198.175.65.20 as permitted sender) smtp.mailfrom=andriy.shevchenko@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745513319; a=rsa-sha256; cv=none; b=PZXalXZKOqpPMVJvCB+1tXvKjPRPcy+kwAR0tlsD50Cxlc+maMITb6iL5ORI353DBFnUoD m1222fO0EwG8ikrb9/sfpwVBB8O+r/YWR010qHFNHZ8HFfYEwoHfkwKdWE3pLvDM7mn7cD 8fCeA+bGoBfdClou9vVAzkGn9hdA3XM= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Z35M7FDD; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf26.hostedemail.com: domain of andriy.shevchenko@intel.com designates 198.175.65.20 as permitted sender) smtp.mailfrom=andriy.shevchenko@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745513319; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YQ2FXDYeSW5C5+A1YQInzzxucY3FxMscG6YwZtAZwhk=; b=V47va0EzuPzuK34zTyDKGjNnj/cYQIppGcQiwQ1g5zLggoKqEDPblgJsDKU9mYl5YIht01 lfMC777rBvrils+VAFuLW3+cbXLzYmDGOPCka//rSzmF6oyJNs6mSTSlT48OScKdxU49pG XmhZ4t3JRum+NJp2Llv84fwm8TcAbdg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1745513320; x=1777049320; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=HC19li/AvVr/J/L0lBvGqhb0q0RGSas+mx14ehOq5v0=; b=Z35M7FDDyiZLFbKpPFtm0I42RohbQIUEnm8FC7PSlSosokMeuOp2sG3U Zku/qLRdhmnZxPSRPqZohCqJInDN7lFqENg1b8bcN1QzXOWhsFN4H3vkd 74IEvijvSo0z4jt8wpI4eOU0bfLl7KTOi70Y20j4gJDRzMWLzE5/eiPP9 3+57cTYscJ46ybzObIQ0ybffMJKXn1JlhRIGt4+RNl/WWRLoUtSphbsV1 g1pveMxseKvvLgAMsndLFCsmuDFW7RWFG/7oJ0BmHi6XpzWhYlW+V3GXV FUgSqw/Ak+jgggxuG/MQdJEbS+mpEcNPpsX60FsGVXgzQzH/b6w0IDmQ+ g==; X-CSE-ConnectionGUID: E63LAzswRgG2jnrVxM7ARg== X-CSE-MsgGUID: GvUYhg4ARV+cLwoMBCJr+A== X-IronPort-AV: E=McAfee;i="6700,10204,11413"; a="46874441" X-IronPort-AV: E=Sophos;i="6.15,236,1739865600"; d="scan'208";a="46874441" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Apr 2025 09:48:38 -0700 X-CSE-ConnectionGUID: lICXhsAfTs2lDVeEx4Nlog== X-CSE-MsgGUID: 9Wl/UvjAQFSmn6faTgzZoA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,236,1739865600"; d="scan'208";a="136747043" Received: from black.fi.intel.com ([10.237.72.28]) by fmviesa003.fm.intel.com with ESMTP; 24 Apr 2025 09:48:34 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 6EBEA1AC; Thu, 24 Apr 2025 19:48:33 +0300 (EEST) Date: Thu, 24 Apr 2025 19:48:33 +0300 From: Andy Shevchenko To: Zhenhua Huang Cc: cl@linux.com, rientjes@google.com, vbabka@suse.cz, roman.gushchin@linux.dev, harry.yoo@oracle.com, surenb@google.com, pasha.tatashin@soleen.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, quic_tingweiz@quicinc.com, stable@vger.kernel.org Subject: Re: [PATCH v2] mm, slab: clean up slab->obj_exts always Message-ID: References: <20250421075232.2165527-1-quic_zhenhuah@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 9FD0214000F X-Stat-Signature: 9gqppco7huuefs35e4yauqesosyi1pni X-HE-Tag: 1745513319-334691 X-HE-Meta: U2FsdGVkX1+PBVWltGF8blT9omfH7zUqJHWKMqGRyobCQF7U8FDW2UTQNX/kctY7exxzRhtttWxAP0rpyiUvEA2HxJsf6EMqBZ45SgoHsl7HPaCFO0gh4EkN+6b8Rj4B4t7BaBF1N+XUlcV3gnGPnuai01uXpY/7CnxBhz8oJo682u2OYHPKItlMe1zV5ojHIBYxBKHxdfQr0xb8FdjUzGoINDgsmzFUHYMarESOi/B2Ik5FOVNZlfhJnQbcKjPIJMVLsNZyIvOCrtYm+qerjFE+ut+88xm8tAjynU+WLdTxpQ0mo4V/i9/XWA4+0X/ENZR1QoajPnmKZXrwwNX3WG+f1P4ugj/wTDGqpwcmu5Me/WMWA81ZlzXwQQG+VXeuCz68i/NHF1C9i6hdu7mDH+yNCkz+Mqr7lsszVb3+AEKTn0Fg6Z2cd0fsZ1WrGSLesgxvsf05X4XeI2t6k4kpWFTlOj0XC7EcahSmhpYhMt6aWSR28eZ1BPrJqqh+o0YxKrZ7FY36B6zYNb4SiaO52fAHKqtaGrFNwD8lWuzGOpY7EVC2evBe+odpWleBSqgRaaI8tPSDBMK40kc0SBw6b0pSazu9ho7HDDB62x2+WIHmvqZ6YYZI13IXMWXC/kwj7BSj8oR+DaL++zAPAzY78uWGOy5B8mWf6xhnEHOMeUIc/IQsAgurRwpnqxUueOOWc8IHmIgnPo1TsMEARZlge3Di/Od11q3K+HQDxpYrYSZYNd+jvtTI0TkjEaCckBVxEScBLSnuNj772pOc7jOaN8HhxxHmd1bXa5/Li1FzDl5+eBNbM5eAFppE67JicFHyeEdK8bJwsGGuHwec/2MdXqhkyMVQ6BDrWH1MNaXFVf3Kb4s8hlbtSyY0Sl+OlIRmpS+lUnjQEjHyqswyBr/aD2Rn8xBeRfqzHjNbXKmmo2bMv1U96HXyQK0JQKxXaIFZVqIoBAyQB0KNZC665Eo xxsScr5f ZJbBsT46//Q8QVlSja0ldl8MpjASiVGuBCYZhJDXhQ+Gy4aoBX+lLKvLQAtfNf5gBDjb410ADbnFYH7Ws2Ou093ODvViNfRQR903UCS97zGuhY9HzXafRrRACu4Bo5rT4iIe1Ick6A9TI07k44RmIJ7f4muKUnqtSWoVlGxVpO1Fd+/P65tgKiMUAkM3WUOpk9hzQnCVImdJrq+vGPj/juam/LYkLgzKIjo+BFviVIXsqXhvWZFjVRMNQgA/qjNDPK1IxxqghKlZPR8nf0QnTsXAc1Kv1jh4AoJyT42rM24BEyUk27L06clXf9ZHmY1pBQW3pHZ710KIfRVPCDdTvs+UNBA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 24, 2025 at 07:34:29PM +0300, Andy Shevchenko wrote: > On Mon, Apr 21, 2025 at 03:52:32PM +0800, Zhenhua Huang wrote: > > When memory allocation profiling is disabled at runtime or due to an > > error, shutdown_mem_profiling() is called: slab->obj_exts which > > previously allocated remains. > > It won't be cleared by unaccount_slab() because of > > mem_alloc_profiling_enabled() not true. It's incorrect, slab->obj_exts > > should always be cleaned up in unaccount_slab() to avoid following error: > > > > [...]BUG: Bad page state in process... > > .. > > [...]page dumped because: page still charged to cgroup > > Please, always compile test with `make W=1`. Since CONFIG_WERROR=y this > effectively breaks the build with Clang. FWIW, fix has just been sent: 20250424164800.2658961-1-andriy.shevchenko@linux.intel.com -- With Best Regards, Andy Shevchenko