From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC012C369AB for ; Thu, 24 Apr 2025 17:19:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EF9CA6B0092; Thu, 24 Apr 2025 13:19:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E80A16B0093; Thu, 24 Apr 2025 13:19:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CAE746B00C6; Thu, 24 Apr 2025 13:19:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A21616B0092 for ; Thu, 24 Apr 2025 13:19:27 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id B6CD61A12D7 for ; Thu, 24 Apr 2025 17:19:27 +0000 (UTC) X-FDA: 83369598774.16.303A36F Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) by imf16.hostedemail.com (Postfix) with ESMTP id ED7E118000E for ; Thu, 24 Apr 2025 17:19:24 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=PySRH5SH; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf16.hostedemail.com: domain of andriy.shevchenko@intel.com designates 192.198.163.9 as permitted sender) smtp.mailfrom=andriy.shevchenko@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745515165; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EO9d7h37tzLCeDQ5LwsoS0hQR4jcCRqGEOTZtFKaBZk=; b=loqij8X/JM2Vm8c9m5LOKTWzVR3izWoE7znW3AvFg2kHvDloaJ2spmA/jXKDi5DLFvLlgk FA/lPs4ipM8FEvMa2QcgKnbu+qB9wPPuwpfPgkss/gi/k1iiRisuN/UhVP4mCWnmQ5g2mj lBXqKRtB6I5er8zSfC3A3xNzSZOKiSk= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=PySRH5SH; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf16.hostedemail.com: domain of andriy.shevchenko@intel.com designates 192.198.163.9 as permitted sender) smtp.mailfrom=andriy.shevchenko@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745515165; a=rsa-sha256; cv=none; b=mjChpnJ/csuQpyC8lvvKw9LedU9N1pJZPYGNZzAhk+MVZG5tLlkLEytPj13syRPJSnXM5q XzbfE+2SiD3TONkHnHOmHbsGaVMSqr5Tv/1m4fmUr7u9TjbsblshxdNyHsK/bdFvwHjTb5 Ronj0ET7NAZ6ojxxoIDlAVKoRQ8nIlM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1745515165; x=1777051165; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ItVrLqgKGeOUFRj5iB6zphXpB+2yCMawqMR3Hb/E/W4=; b=PySRH5SHNMwvHqLmAq8SbnZhhOb2/TLcwEdG3JBn2WAUNz0YysPK6/hl SEJFPYZZI0dh/cWU4iE0lM9WWRczu+ith4DMAaZIcA+pTs9/3fDR3l3eV vEimlijzBItehTd3d6WjtmjTZl+LtmSQ1cnDLlECMnLHkokb5+qnZ1PDE +NEZB3aHAL3cddnzG+xyjJ7IfVi5hJBXCxISmSSpm85YEWLes2y565IhP 1ik0J8hQ4WgMoehfmgxV0Gp6nFCTT8J53iUJTsb+9APD9/Ny869IIf1PF X1k8LDCSFMINNUWGYUWhcIf+mT+Sd0AdJ2s9A/f01bRwbndjkDi+wcvDH A==; X-CSE-ConnectionGUID: jWndG6j5RqS37IpbVRNAxg== X-CSE-MsgGUID: mrSKHzUtTzKUiDg+fa645w== X-IronPort-AV: E=McAfee;i="6700,10204,11413"; a="57802007" X-IronPort-AV: E=Sophos;i="6.15,236,1739865600"; d="scan'208";a="57802007" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Apr 2025 10:19:24 -0700 X-CSE-ConnectionGUID: YQmfbH4uQ+a3WDn2GGMy8Q== X-CSE-MsgGUID: lO9HtIHSQPO+InIyvQlNWA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,236,1739865600"; d="scan'208";a="137526823" Received: from smile.fi.intel.com ([10.237.72.55]) by orviesa003.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Apr 2025 10:19:20 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.98.2) (envelope-from ) id 1u80EG-000000003GS-3pQ2; Thu, 24 Apr 2025 20:19:16 +0300 Date: Thu, 24 Apr 2025 20:19:16 +0300 From: Andy Shevchenko To: Vlastimil Babka Cc: Zhenhua Huang , cl@linux.com, rientjes@google.com, roman.gushchin@linux.dev, harry.yoo@oracle.com, surenb@google.com, pasha.tatashin@soleen.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, quic_tingweiz@quicinc.com, stable@vger.kernel.org Subject: Re: [PATCH v2] mm, slab: clean up slab->obj_exts always Message-ID: References: <20250421075232.2165527-1-quic_zhenhuah@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Stat-Signature: t8hjpdfpryxc8e155ob1ea8pf11z34ta X-Rspamd-Queue-Id: ED7E118000E X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1745515164-767202 X-HE-Meta: U2FsdGVkX19WCftYhsVYZVoH5iG7G6jtSQ3cU+SqAxl51x0yMW6x8/6xSe7UNTgfj36yjqaj3/gTP3hugHvzWj+VxqG/sz7SluPiXQmD8Qb68qkaWpMMm+PAakETo5K+vmhpZd6LnzCVSgVtOSeU6o42NHh5dgiMOCsSo5kIdp5FAN0393F/AFLqkCOyAuoWUZpANx+VRpYoHVJw8YbELKC5Wly0VIJT8UltkuTYR1TxU9LaGDkiF5tC3DfdTGwwjYg29m2qvvSYhtiaUP3wueZHYiBiU7nsy8TbyDhcyIZnYoHwrTMnsFmTWjkev64b1nfKc0BnvNdUHIQ56ymrv9ql12TxD+TwI5PwzMtJ1tUx9UPul4up8xOh4dnIDOl46sZVZWWUz8be2tgeNXiGaMXFF77PcKSZOVjVXhsDjJerCSkOXoXIhNI0otgWWsBnQIUZ9qF516iZijtSlvvuiyjg5GVz/OGkArVLljvly1bOt3PCZNgnEbhym7vbTDtawe+O/nSftVvu+L2WNjNmxV+a8oZ7XsERel/RB1hM+nfz3cwwxHFv+OA7FcWF+iIrCMdYFkEUmB56akEtn2zUeNS5nt8yHGX2FhxWiu0juZeMMHmYuDnw9evjXyIZOugMvLJ9biBleLNtTmsPqtYBVwgY0ulN5lRm0HQtfygHTN3KEPV5hX+heN7pWl1naNKlSrvufU7Mb4yxAKZyRziUMoepidQbyHrwMnnZKVKf6X9IGJNiCfX/avGWjwLeD0ectyd9mqyxxtK8sUc3CekYTTufWJs1QfOwottfp3pOOGYut+zWnr4GcR5AOPqY0iPGBf/B4m/Am4/UUweF+2M3gTio1VQ4p+0OEFlxh8P6yJRWUjNwHWIXL91Atsq5tvwap3s7gmqFthMPPZAC+FwcG3zOj4uOhRc1Gbm+p4iJ3nZXdmdggrXF0PiXmjHnLvJN4UZbdK2iod9tDsAJJ6D q2rdeaP8 J6xF2POtCLLnZQmLgjYdxZyA/OwiPk9WgHCMrVugf+KNheS2u/e9UKD8PYPstVLfmi5MOLgLeATKxUBh6EC8EaEraxpVIjaBcOhBO4Jg+kcnlm/oLST6ascwfD3pkPdtpI6ADXfn0Kz/ZM9kUfcy9OWJ+lHX6c8PZQ1lEZmNHsUCuj8VyUxmy2lPNT74Eu+Yix4/J0kywwEhO+EU6Af1Nsjn7k34veStFrGDH0kVp57vgCJFdyrnxQkixbbr4PA5x5ZwRfHBfBLZ/5v40TDz/Lr5G4ulQ3kkwvz/R X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 24, 2025 at 06:48:46PM +0200, Vlastimil Babka wrote: > On 4/24/25 18:34, Andy Shevchenko wrote: > > On Mon, Apr 21, 2025 at 03:52:32PM +0800, Zhenhua Huang wrote: > >> When memory allocation profiling is disabled at runtime or due to an > >> error, shutdown_mem_profiling() is called: slab->obj_exts which > >> previously allocated remains. > >> It won't be cleared by unaccount_slab() because of > >> mem_alloc_profiling_enabled() not true. It's incorrect, slab->obj_exts > >> should always be cleaned up in unaccount_slab() to avoid following error: > >> > >> [...]BUG: Bad page state in process... > >> .. > >> [...]page dumped because: page still charged to cgroup > > > > Please, always compile test with `make W=1`. Since CONFIG_WERROR=y this > > effectively breaks the build with Clang. > > I don't see why, nor observe any W=1 warnings, can you be more specific? Thanks. Specifics are in the fix I sent. Just a relatively new Clang and relatively recent enabling of warning for unused static inline functions in the C code. If you are insisting in seeing the exact kernel configuration I have, tell me where to send, I'll send it privately to avoid noise here. -- With Best Regards, Andy Shevchenko