From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAC3CC369AB for ; Thu, 24 Apr 2025 17:22:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 798CC6B00CA; Thu, 24 Apr 2025 13:22:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 744EB6B00CB; Thu, 24 Apr 2025 13:22:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 573656B00CF; Thu, 24 Apr 2025 13:22:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 2FD6C6B00CA for ; Thu, 24 Apr 2025 13:22:42 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 664BBC151E for ; Thu, 24 Apr 2025 17:22:42 +0000 (UTC) X-FDA: 83369606964.25.EDFE117 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.14]) by imf24.hostedemail.com (Postfix) with ESMTP id 7DC5018000C for ; Thu, 24 Apr 2025 17:22:39 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=CdhFuXCb; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf24.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 192.198.163.14) smtp.mailfrom=andriy.shevchenko@linux.intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745515359; a=rsa-sha256; cv=none; b=ajCNn05Xbx6N+gLiUYZNWxaJZqLCMRQB1TRiLONA6KiBPrnk6zekNBlqqHGazR9TlrIvcQ 1nG4dQ8U+lSIIGbYvOEv9jIcX9XsHw75iYBC1WH+sEiqGKRGpIOtX+E302yUYnFYYjvC4N KdZXXUbCdONj7uYgQqGZaK2TlLHKFpw= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=CdhFuXCb; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf24.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 192.198.163.14) smtp.mailfrom=andriy.shevchenko@linux.intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745515359; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tmvwQ4sP20R/ASTUPzY4FajaybwwKXATsOP7F5OoYLg=; b=FusCbBsA5jNtL0f6WVMQHlUYFrjreLWvAS9+EyHNYVeYytCZXtMvKELy9m2NOcvpG0J6oI vyEpYA6ak0OIWYFZg5jEBJIL/1n4xif4PTp7HFTYWIXIKDju4UKU80ECSYBC5hunJRmLFi 95WTeC0dM+MdmTlbKCgxojxZTQAe1F4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1745515359; x=1777051359; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=5mUMu6rbhZGdHK9UQ3fq199ViRrbpnMG+Pe7EeSBYHk=; b=CdhFuXCbR2767AEtdwbQyhApUyefreDBlA7ZBiyirOn/JOBcSXlA7Mgr 0zv5jpmmZdx0pPtZkYSYblpiuHw3MD3Vu7c/JQewV8IKd9vhBUeF73zHU U5D2qMSf1Y9dU5BelSJDwC5EDmEVMM5mk0Iymawa4IG+fkqn7KBKbXp0k bIu27XuoW/G4Gca3Zci1ll7xFpXqM1V47ug4YP8bciGIXtxbaGaJhHNVt oHDTZG40YwKFkuSNMltAUkjyxlc0inal6+eGd9awcrKKRVVF9BmAyo78Q WNTh/hSPkaKhNuqViQuyL/m2oLMLy89sPACvAgiabmEfNehoFR1Eb5C9z A==; X-CSE-ConnectionGUID: JiJ0bCcmQTC/EtL9O/8eqw== X-CSE-MsgGUID: aMgb/1oYRr6dNbxxmvNLmA== X-IronPort-AV: E=McAfee;i="6700,10204,11413"; a="47337800" X-IronPort-AV: E=Sophos;i="6.15,236,1739865600"; d="scan'208";a="47337800" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Apr 2025 10:22:38 -0700 X-CSE-ConnectionGUID: tD2Gso2KSRuNHJoaLB2hYg== X-CSE-MsgGUID: LaysRMefQBqWQKcbLmi1ww== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,236,1739865600"; d="scan'208";a="132553866" Received: from smile.fi.intel.com ([10.237.72.55]) by fmviesa006.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Apr 2025 10:22:34 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.98.2) (envelope-from ) id 1u80HP-000000003Ju-1XjY; Thu, 24 Apr 2025 20:22:31 +0300 Date: Thu, 24 Apr 2025 20:22:31 +0300 From: Andy Shevchenko To: Vlastimil Babka Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, Christoph Lameter , David Rientjes , Andrew Morton , Roman Gushchin , Harry Yoo , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Zhenhua Huang Subject: Re: [PATCH v1 1/1] mm, slab: fold need_slab_obj_ext() into its only user Message-ID: References: <20250424164800.2658961-1-andriy.shevchenko@linux.intel.com> <691b0ba9-7587-4663-8aa3-8ce63ef509c6@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <691b0ba9-7587-4663-8aa3-8ce63ef509c6@suse.cz> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Rspam-User: X-Rspamd-Queue-Id: 7DC5018000C X-Rspamd-Server: rspam04 X-Stat-Signature: o3hziqmh9gyw8rpek7sfach3zq3pnmi8 X-HE-Tag: 1745515359-823925 X-HE-Meta: U2FsdGVkX1950JyyTKxnNnRmAkbnQvGObB5uRnYHKYRMKFx44/06mSDgUJpWIy29etNG9l7LRK0QVNZdiH+gqWGuQJ26xQFrLUOgSUqUr50IQKtakHg9DWzQ6hBP14xXDbcjjxyWEQpTJyXtX+0FOjaGR+Wly1KK2cWEevW7JyPDn3yB46SbwEjuSnxyG0iv6GvE2sEv0FpUuK8afoWoS8OLnM6XXt5bZTe57PVY6sZs5O9FKzwJnJlb8TdmXx0Ccp555qA40YwZoX6+kqs1/JRR/UOVOEaFwvEkbGtNe5bO6HlDBo2ieeDXO6+PLOmKn+1QsgoAdmsEDRwgVl3vmoGm6NT1quNzHgxsl1O2wKKNRcTjOx64uUn3k4r0tzkr0L4sMr6Ypgu7BOBkVOW+cyPT929LnlpwpgJ+u8S+EwLnLmqncfRtti1mPLn/yF11mMs5SRbGuOc9LmSwKnLdDiNoDrEn8imhLYEdM3NKHcoB/0H/FjqhknBcGCTpRbLsiiUw/vS2xaArEofM4vxDOLGZSBdUbcuuH0p9nlJ0wlkyVEeW1bGcg0SzbnCJoBfEuEaXVPbsPOg1t1X5j+/B6TwhAOVOo/F9HPbhIbjC/k79O/NcvYaMvqwU+7w7g+rTqvVdefQXo/JeEFGrxPzGXRZDgEUbhfHIfnBqPLJivI66ytsI5aApQrQODL8enKD9c3EHtA+bw/yjuilncIert21lG/urtQ0O2DOqnJ2T/A9x+PXIu1GIYyIJUsv93umhy+cpq1j1ZgXFEBFjl07mlXhKugrdLd/GMKopCkLnCI459JO7KNRgun6qR4j2WdTDoH5c7j/VjcuxeCfV3l95ogCUXk7nkKGr9Chdeg8f50CSE8qjqxbxhFqRlWKrTBtUta7kdfFWw/26CJ8tnszncb3cJPRx28zO/hIOTwyBSdNjhSffQ8dds6MQOpKdA8bobNl/9Rg65JcL7bSdG5C 006sAFVM pnKvdiB1zd1rthL4tnuZyRB6c5Y2btal/kmq2XbacQxBLngWKRL8UR5DJxb8MpVUtFz4ypm78CZopWVOAinFIoZMHPrn8X+bmkGJf0j6TFWxamDVgKWWwGu8ONKYSTssch3MdVB0x4Mh5ZlqbAfRJDSM8hWyjM7heMAm6xT5gc8Gtstoct1y3CXHWnMhuvxiBpuWI3JPj7d5J6+E4BshrNAZnpgMroky14g5eZk6oVy6cri6iXEoz/15OzCaIyy/nkv5YIvViQNVkXbr4lr98tbIlXPnS1fb79QyvZ2ITE/ml3op3nwzQzH/MZw3jhM71olrSemgKPCEur5JKmqaTXYOBtJ7JglfnbPeeBjkmyZMzH55YwJ4fTnkfWQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 24, 2025 at 07:15:00PM +0200, Vlastimil Babka wrote: > On 4/24/25 18:48, Andy Shevchenko wrote: > > need_slab_obj_ext() is used only in one place, fold it into there. > > Without that, clang can't build kernel with `make W=1` when > > CONFIG_WERROR=y, which is default in the x86 configurations. > > Note that gcc doesn't warn on this even with W=1. > > Is really clang + W=1 + CONFIG_WERROR building ok these days except this one > unused function? Almost, I'm working towards having it clean on x86 defconfigs that are in the Linux kernel. There are only few left to address. GCC, FWIW, complains on bunch of other things :-) > > mm/slub.c:2079:20: error: unused function 'need_slab_obj_ext' [-Werror,-Wunused-function] > > > > To solve this, fold need_slab_obj_ext() into its only user. > > > > Fixes: e33b7ae3d802 ("mm, slab: clean up slab->obj_exts always") > > Signed-off-by: Andy Shevchenko > > Thanks, I've folded the fix in. Thank you! -- With Best Regards, Andy Shevchenko