From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD116C3ABBC for ; Fri, 9 May 2025 18:03:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E29D36B008C; Fri, 9 May 2025 14:03:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DD8076B0093; Fri, 9 May 2025 14:03:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C9F3C6B009A; Fri, 9 May 2025 14:03:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id AA2256B008C for ; Fri, 9 May 2025 14:03:21 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 7000F1C7B36 for ; Fri, 9 May 2025 18:03:21 +0000 (UTC) X-FDA: 83424141402.08.1E24976 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf15.hostedemail.com (Postfix) with ESMTP id 8DD79A0002 for ; Fri, 9 May 2025 18:03:17 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=UCNJU1BO; dmarc=none; spf=none (imf15.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746813799; a=rsa-sha256; cv=none; b=7/FqmIJAeZTMCmZmZrmNjrzcw6a2ktWEwBdK02mZi3M/QjS7V0KO7MnMwjI6U+ajy1DXm+ 4pzIRKIgGObLCpfIwFEkcDDt2Xx5FzvM3/QS34Z7THKneqte/lq5Fkk2oPXeLv5hW1MQrs I0s5V95CDy4xorCX7QFFFQnRI3xSSK0= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=UCNJU1BO; dmarc=none; spf=none (imf15.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746813799; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7NNy3XcZQY5E+n5cILbOTq7vvjJkGbBTsW0q+cK8Ogs=; b=Ntpm4ldZvpXS8X7w/nME3LTq5NJoAVJC+aozeX6/GfH1l43Y3+iaVvzT2QHhaVrVTWJjjA 0phfs/HlOUpb518+HYQnNNiKiKhpu+2OQ38CD1VBijCdI0uaQMxOWmwlcFTAQ+0OhEzxvB HLXmT8Ak76+a4cn6e+8e1PtokHYn86w= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=7NNy3XcZQY5E+n5cILbOTq7vvjJkGbBTsW0q+cK8Ogs=; b=UCNJU1BOKJB13Fi0tE0jzjpSka aZIYeLpJIJ3h42m3B3UvKQ4beuFhCvtnarF2RNBXSvJQ1KoWTogRcWndg28AhC31xByvn+pcaTj3z QPieR6sDAzsIytDTu0bKLVoWJ/di8fjSB+7D8OWm1zCzHkxbXx6PB0LHarqEO98MUHF7jtfSqyeGt 8QifsGMjJ9EcopYMJnQxLxCzDF6zacb93ZhFkuONoyOtBIx5Me7zSjO0Cvw3+d9AASfd8GEFX0ow9 cN5ob6R/K7uzPxb3AuBLfJ1OmFhQLpt+SjlBUwMAGp+ZUnbqmqh1A/vKh0k4t8zYDDm7TD2JmvtUT u/19oCQg==; Received: from willy by casper.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1uDS3L-0000000DXhJ-02YZ; Fri, 09 May 2025 18:02:31 +0000 Date: Fri, 9 May 2025 19:02:30 +0100 From: Matthew Wilcox To: Byungchul Park Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com, kuba@kernel.org, almasrymina@google.com, ilias.apalodimas@linaro.org, harry.yoo@oracle.com, hawk@kernel.org, akpm@linux-foundation.org, ast@kernel.org, daniel@iogearbox.net, davem@davemloft.net, john.fastabend@gmail.com, andrew+netdev@lunn.ch, edumazet@google.com, pabeni@redhat.com, vishal.moola@gmail.com Subject: Re: [RFC 19/19] mm, netmem: remove the page pool members in struct page Message-ID: References: <20250509115126.63190-1-byungchul@sk.com> <20250509115126.63190-20-byungchul@sk.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250509115126.63190-20-byungchul@sk.com> X-Rspamd-Queue-Id: 8DD79A0002 X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: nybwqtrsaexa7o79echx68zmiknerh69 X-HE-Tag: 1746813797-975350 X-HE-Meta: U2FsdGVkX1/ge7+1ov2K3CRtdXDNdGkx45A6++My9hJ5sOvSJzmnzgmiEUB8bnBLqTNKM0rdOQkNsnSmTrpDxmLFFjSsZpdTJeUDp7rARPtf4+WPsfWD2C9oK+dgpLSOhnMwz9js9vUttAvNCjegtWGaAtxgAwYqRwPGo9SNfT8xNZu2hI+etQ2XlWnRag7l7RhcqsXMRNwx4wv8BybA2HyaqiL4YzLEqt4q+IHnkNROdzCfBg78Ju0PDSmrZ3dzhiJ+i1r9hNCojxnQtPf07LDhfDh+6Xjacw33XkAzP+RbIA+SnqAa+gOqgjfuD58RdxL47tcdfuCmBk4kGuP7h4d0PSrculpCaQokFVK2YxNkHfjc2IKqw8Y5/NL+F0ILNpQXE+hhJYxwccMZpquFzwC5oLLObWjNVAxkYv6R1ZQjEAHB3EMg3Oe+uYtx4IKHCezmcqFt57LpEge/r7k7tE8Z0taiJL7o1shPMIzuu3ebwqt1Qjuxdo1EvpNhZUa4ugCYQjG+bCerzieRb1We6SkPB0+MZJlo2BKuMyHkaVwDcYIekbY720vvmLdUf1844ScAjAlJyAxJrCbCiadnCcCNVQPMm9+E9uUP/eY1foXsOqBF72e/Lv+fA6AdSnpIHbLl6WPbCCPsVd2I5Mnk2R0B8dbw+TCvneBysFFQHXVu0H/aLrLYcv7mpNP8gFXLVHH0hPVlbYGMyLjo0ji8OvI/+K5pPo90azQbdMRpCMqza26MdqtY+hVo4x+YtlS+BkrDbUDHKqrTEe/Vmq+yNhkvIPIQOBUPJ3bwDjTjlUp12LfnVI9UT6NuxYG1t+ChSK4sEd1Mc3bPTBw1wETdb0AWDvb+19PMcD067KW885TnlSWfgLJrLbiLJR4DAH6J/3XGgUe5mC3mmWYtEENEIwtkgkstSm8XUbi9NLrEjfG4U+6g/x852UMiDsAxNjRIgYt4lRKitCi8qs50cQb 2+2xAk4l i//yJDMdPgya6GhI3Y/E3VU7lkcxaDmWK3JLsSP4jAOw2d1SjE78rygMrNnx12hFgGfpMFBJhg9+se1v0swIyxJ/7fhHhLmOBbZakH7MnLEpHoln1wPpbO4D1e1brJcZeYVuMy8ol5s8g2nFvGRai13CY6Kb/p62Vh54+JW5bdyc6bADJpNdqzA61Z2wFguEqfXYZvl+8kEz7FpfUqAY8+RlDD1pHY9QZ85i3gJdRmh9k1NJey6q8d5K01ER+rbFy8qE0nwP8q2YWx21gZmZo1YoEpynOFnPMyJ2Am23d1stBc32aFGhDMsY81A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, May 09, 2025 at 08:51:26PM +0900, Byungchul Park wrote: > +++ b/include/linux/mm_types.h > @@ -20,6 +20,7 @@ > #include > #include > #include > +#include /* for page pool */ > > #include > > @@ -118,17 +119,7 @@ struct page { > */ > unsigned long private; > }; > - struct { /* page_pool used by netstack */ > - /** > - * @pp_magic: magic value to avoid recycling non > - * page_pool allocated pages. > - */ > - unsigned long pp_magic; > - struct page_pool *pp; > - unsigned long _pp_mapping_pad; > - unsigned long dma_addr; > - atomic_long_t pp_ref_count; > - }; > + struct __netmem_desc place_holder_1; /* for page pool */ > struct { /* Tail pages of compound page */ > unsigned long compound_head; /* Bit zero is set */ > }; The include and the place holder aren't needed. > diff --git a/include/net/netmem.h b/include/net/netmem.h > index 00064e766b889..c414de6c6ab0d 100644 > --- a/include/net/netmem.h > +++ b/include/net/netmem.h > @@ -10,6 +10,7 @@ > > #include > #include > +#include ... which I think means you don't need the separate header file. > /* net_iov */ > > @@ -20,15 +21,6 @@ DECLARE_STATIC_KEY_FALSE(page_pool_mem_providers); > */ > #define NET_IOV 0x01UL > > -struct netmem_desc { > - unsigned long __unused_padding; > - unsigned long pp_magic; > - struct page_pool *pp; > - struct net_iov_area *owner; > - unsigned long dma_addr; > - atomic_long_t pp_ref_count; > -}; > - > struct net_iov_area { > /* Array of net_iovs for this area. */ > struct netmem_desc *niovs; > @@ -38,31 +30,6 @@ struct net_iov_area { > unsigned long base_virtual; > }; > > -/* These fields in struct page are used by the page_pool and net stack: > - * > - * struct { > - * unsigned long pp_magic; > - * struct page_pool *pp; > - * unsigned long _pp_mapping_pad; > - * unsigned long dma_addr; > - * atomic_long_t pp_ref_count; > - * }; > - * > - * We mirror the page_pool fields here so the page_pool can access these fields > - * without worrying whether the underlying fields belong to a page or net_iov. > - * > - * The non-net stack fields of struct page are private to the mm stack and must > - * never be mirrored to net_iov. > - */ > -#define NET_IOV_ASSERT_OFFSET(pg, iov) \ > - static_assert(offsetof(struct page, pg) == \ > - offsetof(struct netmem_desc, iov)) > -NET_IOV_ASSERT_OFFSET(pp_magic, pp_magic); > -NET_IOV_ASSERT_OFFSET(pp, pp); > -NET_IOV_ASSERT_OFFSET(dma_addr, dma_addr); > -NET_IOV_ASSERT_OFFSET(pp_ref_count, pp_ref_count); > -#undef NET_IOV_ASSERT_OFFSET ... but you do want to keep asserting that netmem_desc and net_iov have the same offsets. And you want to assert that struct page is big enough to hold everything in netmem_desc, like we do for slab: static_assert(sizeof(struct slab) <= sizeof(struct page));