From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAFC6C3ABA3 for ; Thu, 1 May 2025 19:50:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1F7DF6B0088; Thu, 1 May 2025 15:50:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1A5086B0089; Thu, 1 May 2025 15:50:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 06DDF6B008A; Thu, 1 May 2025 15:50:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id DB8706B0088 for ; Thu, 1 May 2025 15:50:08 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 6A4FE809A2 for ; Thu, 1 May 2025 19:50:09 +0000 (UTC) X-FDA: 83395380138.25.48D00E8 Received: from mail-pl1-f202.google.com (mail-pl1-f202.google.com [209.85.214.202]) by imf02.hostedemail.com (Postfix) with ESMTP id ACFD08000E for ; Thu, 1 May 2025 19:50:07 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=vq3GGx0u; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf02.hostedemail.com: domain of 3btATaAYKCKUXJFSOHLTTLQJ.HTRQNSZc-RRPaFHP.TWL@flex--seanjc.bounces.google.com designates 209.85.214.202 as permitted sender) smtp.mailfrom=3btATaAYKCKUXJFSOHLTTLQJ.HTRQNSZc-RRPaFHP.TWL@flex--seanjc.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746129007; a=rsa-sha256; cv=none; b=N2H0YEp9RFseNeUDfyWiMbhXvGUiEgg5Yko9AJq7Kzr18a+toJSPAE6jalitBO6ivNrZIY 86OQx3IQ6C8dnGGNa/sB/LAChR0p5R35Zg7Pht58DHRDmfOUAFz6fmmPqIjtmJK5oNxz02 wGkB7kSG3vCLsN4D0d04dH7vdj2chHs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746129007; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5WkPY+IyOhaPmE7ksJuei+YjVRdCjQvuKQAGefphhn0=; b=gatl9ejs480naIArk0xhSWLrpP4dk68dz4DzgmN1xqTC2KmzWySa1Jw4YZScQPyK60ZrCA 2avGMd2DI180+83vmsECtDfXkzv1vBO42ZAhwiqbWGpPUt+4NdtIrk9JxCwTgNVJuGfw/r Xl1IqRddvryOuIdm9H37NDfqO/vIAqA= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=vq3GGx0u; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf02.hostedemail.com: domain of 3btATaAYKCKUXJFSOHLTTLQJ.HTRQNSZc-RRPaFHP.TWL@flex--seanjc.bounces.google.com designates 209.85.214.202 as permitted sender) smtp.mailfrom=3btATaAYKCKUXJFSOHLTTLQJ.HTRQNSZc-RRPaFHP.TWL@flex--seanjc.bounces.google.com Received: by mail-pl1-f202.google.com with SMTP id d9443c01a7336-2240a960f9cso13587745ad.0 for ; Thu, 01 May 2025 12:50:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1746129006; x=1746733806; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=5WkPY+IyOhaPmE7ksJuei+YjVRdCjQvuKQAGefphhn0=; b=vq3GGx0uWVhZWvivMiGdbmQoUb2KHl6ZqoJcxj9I8lPRYd+XAqcGMZunyUtWebY4+1 9a4w3WEct1GU0XONYejAL7K7pw7l/K/RNinQ/l3k28keyisJMwcNu/RzmhBDPfA6LelI TaJ8zfIu3GfNdbUzhoGJUFOU9wak5FMuVGRRJ0iL5rgc1o6owQcVmkYHTUiK22rXnOJE Bf9D093EYb5USQeuCdy6R1XEm23JQPKjHzeNPTk6nqMzbNOqWCbKcRr7XKmZD5GraxGH MyU1jTMxDZyrMWwzAgonm1TpquZuZLTLIAx/KxKGpiGol4/C4CpTrnmGOQiWKHSOkwkw DJBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746129006; x=1746733806; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5WkPY+IyOhaPmE7ksJuei+YjVRdCjQvuKQAGefphhn0=; b=smD5bi21nrbmDgABgQ1/AVtn4WCIilT+mreWTT8wkpcnTsNpjv9iTmRt5lqwfK06eF Z0m/SqbabHHGkBqsL+kw7znh9vgsazzXFcHhd+6Z2sI/i2MXrCzL7iTr63zz6Ji9X1G5 iWqPddcEFDOi0m+zZMZFE3uL156oj4WX5phvs9x4Uc6/7ZEYfz43vtylNnudtAjjr79D OGtyH5eB0YZzXKhyQJbclMhS4qLnSTg5ctjB1xb34t+Ew+uRPgY8ttkEFDvggIJGZ7tw yAsMbx57RiYdp2Nlfn7IYszPFJS+9Gdie+Rz/4D+azCYp58ZCtJoyy9OQF+uqZ0UUIpm u3vQ== X-Forwarded-Encrypted: i=1; AJvYcCUBSl3ghSwKo2FbmI2zVgrprJQqFalNcSFIHy59H+ZUjTyVLq3SSE6PlAwQh1jriOEb8c4Gtst6Bg==@kvack.org X-Gm-Message-State: AOJu0Yyy51srKV8xOvpPIoUoIY8iyXHbTD7eZVPo/wgFM4y6b+NyB+VL y5B0HTgzfJaer0AQGv76PUQJpOi7FBaOorqbeylNfBo98YgyqxOGemv0QfiTNSINfZmkAs9IrZq AOA== X-Google-Smtp-Source: AGHT+IHPnH1hW0IfvKQ+lBW/azDi6UujtOpIW5dmyw0EC5ljOGt6t59+v/zFX71H5UcxugE1fcSMml30hc0= X-Received: from pjbsq5.prod.google.com ([2002:a17:90b:5305:b0:308:6685:55e6]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:902:cf0c:b0:21f:2ded:76ea with SMTP id d9443c01a7336-22e103b4341mr4441965ad.36.1746129006451; Thu, 01 May 2025 12:50:06 -0700 (PDT) Date: Thu, 1 May 2025 12:50:04 -0700 In-Reply-To: <20250501124646.GC4356@noisy.programming.kicks-ass.net> Mime-Version: 1.0 References: <5b0b8e1e-6f50-4e18-bf46-39b00376c26e@nvidia.com> <20250501114235.GP4198@noisy.programming.kicks-ass.net> <20250501124646.GC4356@noisy.programming.kicks-ass.net> Message-ID: Subject: Re: [PATCH v3 3/3] selftests: pidfd: add tests for PIDFD_SELF_* From: Sean Christopherson To: Peter Zijlstra Cc: John Hubbard , Lorenzo Stoakes , Shuah Khan , Christian Brauner , Shuah Khan , "Liam R . Howlett" , Suren Baghdasaryan , Vlastimil Babka , pedro.falcato@gmail.com, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, Oliver Sang Content-Type: text/plain; charset="us-ascii" X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: ACFD08000E X-Stat-Signature: gcnc69fukrc4d31ptnzxgceawzg4ughb X-Rspam-User: X-HE-Tag: 1746129007-521150 X-HE-Meta: U2FsdGVkX1+o2c0LojTrxVBsvoqOk1GKowKsX8dakHIxsVWEc9ED29N5k2Ah8i0EWTWvYUL0gm0IXf9SSw0+dwThgLAYE6vXdT8O9Cn5lVl0LBJh2kfF/secmTY/BiWYi2JHcymqAqG21F0sLo/AVdAUClFPLWgjtnNrxmu2DNxpKzqfr2ozepubIpVKOi7W6aXFDF1nypmdfZ3iffeyggD7K61HIi2l437tB5PNan0h9NRMJVyLTT53jh7PbmVSGP5IpDnS1sDNXr1gVDS/234CMOwg7FBz0UUWZ1cqItgPjfsBVodotg+uxynnvWAyTw2bOdqETcjgbSmv7Q7v84ajOhFiivauQVINpiIpExNyUHEBkb+VlogxpT6zFLZeFf6ckFZoFvlEAeIVe3KnTLN4o+Eik44tzv6vf9VAZk8x9jLePzAJgTwTNWdGeBD26aUOEP4Q4p0WZIVGE2sr5JJVVL4I3iMcacEJk9gSZyVv6KbA51Sb4U3uGphSV/sBoGtV1wEOQHUlDj1MZrB7QZ5r2SjjWRHpuHo5f5hIgiobQyxPLPvDdn3x4/b2mIveH6t8BjDTrPOYRhoxhjbsA0WwbaDMtmA9B5V4wYSY4KlrO5+9MrP82bNtEudF5nrf/uniOnFWfnJxxjcN9ddyWnZU0LXmzBGP2rNrLnUUDD3k9MiCYtVTmHJnb32TyAxa7g5j/Y9efQYJ8qZRcwKzCkZiv4giFbOPG2I23UDJbLWjwJJZt2xazZnEU5tq00rpXFduu3R6hYdIW5RU/XNLzbN+dLI7zIQapQLy5OLUSbmgoNBhy7NkWKNmlLc5CF4NEzmYDcxK1RNjqJdnSyjai6aMNi/m0Eyyp4gZCtIxlM+ZE4t64G2fQQy9PQzEmeKe+UF0eqjNnf1ufmYLwAbRZzy3+Zn21BkBp2z/GEhqO6IdQQENmm4Vu54wQDaPi2to2NNhiSFVd/YOkWUJOCX 1ycM/OpB 4Y3hxLZ7DxCCYx8t+9nlUfaKS/aUYhqMuYapPNaADxNUBchL7kRprWfjB8aGzWdvo0xhoi2kyBz8B3aRmTtbr1RqF8yhfGdE9qfhmNp+L19snI7kmL+JXKs8NSnN1HiAiPjZVCyaQzEbbgDXf1+Ty82yRdFuEVOEMfm+te+MF/UX7B3wyrAqOpl9bRXd3RmJCdO2bQOj8J2PUJwj3X86xj8LkYXjyGKuX9zmVUJsDuBkFTBG8FCT/YO80tyzRSwaRw+/Sh6wGqxGxsfmQZOZ7EQDBiUCdYGK2k33AFMVoxxBqwf7DJM8/ApOwdAi8kSL6ouqNXTdjbqfzhoTJ0Dt1wGgB38NDuXmu3+UEEu0pgszZQd6EgzfpBjRB08O3tJoJH3Ddo6QtcDHKuvpyl2qaNH33JWv0hAzdb/3O3uJtwyp8zzxAezVN+WywG/+F+AUGTyf4HH53ekuND2SwAoRjXzENGh2NPkf/l/a3vlwUMpdNiQAIQkFas9DmLvuxxmu6QDumDUyF2QYtuFDHeKlRLxlgcW3PSp6as9K7i2DWLldMrbjW8A4j1ZE/rSttQfRIubJoojRuy/C4QLl+Md5nqmxO+te8UtzjSEty1xWulgLr1GPnP1mvpaf26hg0GkAsqlxqgwizrv0sEO7KYzin6qNYDcKWkcx9at71iFXZx10gee0oH48zS9kPFM3laMEeyFzkIBnLo1quTw8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 01, 2025, Peter Zijlstra wrote: > On Thu, May 01, 2025 at 01:42:35PM +0200, Peter Zijlstra wrote: > > On Wed, Oct 16, 2024 at 07:14:34PM -0700, John Hubbard wrote: > > > Peter Zijlstra's "NAK NAK NAK" response [1] last year was the most > > > colorful, so I'll helpfully cite it here. :) > > > > Let me re-try this. > > > > This is driving me insane. I've spend the past _TWO_ days trying to > > build KVM selftests and I'm still failing. > > > > This is absolute atrocious crap and is costing me valuable time. > > > > Please fix this fucking selftests shit to just build. This is unusable > > garbage. > > So after spending more time trying to remember how to debug Makefiles (I > hate my life), I found that not only do I need this headers shit, the > kvm selftests Makefile is actively broken if you use: make O=foo > > -INSTALL_HDR_PATH = $(top_srcdir)/usr > +INSTALL_HDR_PATH = $(top_srcdir)/$(O)/usr > > > And then finally, I can do: > > make O=foo headers_install > make O=foo -C tools/testing/selftests/kvm/ This doesn't actually work either, because for whatever reason, the selftests infrastructure uses OUTPUT, not O, for the output directory. And the whole top_srcdir crud doesn't work if O/OUTPUT is completely out-of-tree, e.g. I use absolute paths that have nothing to do with the source tree. I am more than happy to support any cleanup of KVM selftests, but I've more or less given up myself because so much of the ugliness is inhereted from selftests. I've resorted to hacked wrappers to make it work for my setup. E.g. I force KHDR_INCLUDES and INSTALL_HDR_PATH so that make doesn't try to grab usr/ files from the source tree.