From: Tejun Heo <tj@kernel.org>
To: Waiman Long <longman@redhat.com>
Cc: "Johannes Weiner" <hannes@cmpxchg.org>,
"Michal Hocko" <mhocko@kernel.org>,
"Roman Gushchin" <roman.gushchin@linux.dev>,
"Shakeel Butt" <shakeel.butt@linux.dev>,
"Muchun Song" <muchun.song@linux.dev>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Michal Koutný" <mkoutny@suse.com>,
"Shuah Khan" <shuah@kernel.org>,
linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
linux-mm@kvack.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v8 0/2] memcg: Fix test_memcg_min/low test failures
Date: Fri, 2 May 2025 08:39:41 -1000 [thread overview]
Message-ID: <aBURbZD1ZpIUPt64@slm.duckdns.org> (raw)
In-Reply-To: <20250502010443.106022-1-longman@redhat.com>
On Thu, May 01, 2025 at 09:04:41PM -0400, Waiman Long wrote:
> v8:
> - Ignore the low event count of child 2 with memory_recursiveprot on
> in patch 1 as originally suggested by Michal.
>
> v7:
> - Skip the vmscan change as the mem_cgroup_usage() check for now as
> it is currently redundant.
>
> v6:
> - The memcg_test_low failure is indeed due to the memory_recursiveprot
> mount option which is enabled by default in systemd cgroup v2 setting.
> So adopt Michal's suggestion to adjust the low event checking
> according to whether memory_recursiveprot is enabled or not.
>
> The test_memcontrol selftest consistently fails its test_memcg_low
> sub-test (with memory_recursiveprot enabled) and sporadically fails
> its test_memcg_min sub-test. This patchset fixes the test_memcg_min
> and test_memcg_low failures by adjusting the test_memcontrol selftest
> to fix these test failures.
>
> Waiman Long (2):
> selftests: memcg: Allow low event with no memory.low and
> memory_recursiveprot on
> selftests: memcg: Increase error tolerance of child memory.current
> check in test_memcg_protection()
Acked-by: Tejun Heo <tj@kernel.org>
Probably best to go through -mm? If cgroup would be better, please let me
know.
Thanks.
--
tejun
prev parent reply other threads:[~2025-05-02 18:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-02 1:04 [PATCH v8 0/2] memcg: Fix test_memcg_min/low test failures Waiman Long
2025-05-02 1:04 ` [PATCH v8 1/2] selftests: memcg: Allow low event with no memory.low and memory_recursiveprot on Waiman Long
2025-05-02 9:43 ` Michal Koutný
2025-05-02 1:04 ` [PATCH v8 2/2] selftests: memcg: Increase error tolerance of child memory.current check in test_memcg_protection() Waiman Long
2025-05-02 18:39 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aBURbZD1ZpIUPt64@slm.duckdns.org \
--to=tj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=longman@redhat.com \
--cc=mhocko@kernel.org \
--cc=mkoutny@suse.com \
--cc=muchun.song@linux.dev \
--cc=roman.gushchin@linux.dev \
--cc=shakeel.butt@linux.dev \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).