From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE23CC3ABAA for ; Mon, 5 May 2025 14:51:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5BBEA6B0092; Mon, 5 May 2025 10:51:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 56B466B0093; Mon, 5 May 2025 10:51:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 40C576B0095; Mon, 5 May 2025 10:51:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 21D346B0092 for ; Mon, 5 May 2025 10:51:41 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 802511CC4DC for ; Mon, 5 May 2025 14:51:41 +0000 (UTC) X-FDA: 83409143202.18.7931C13 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) by imf21.hostedemail.com (Postfix) with ESMTP id 928921C000B for ; Mon, 5 May 2025 14:51:39 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=qL20NxpB; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf21.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.221.54 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746456699; a=rsa-sha256; cv=none; b=A5DicsXH9RkqcVd/0Mo+HwAlv/KZgJXEqaYAjpgekbwYhRXG1SnwsYr+8/Fp89oIinIQ1X DtNa6Ej+54TvlcN1fCZ4GpUwM/eonpuaj7CgHGGj45SI8UBzH4h9KUKR1wbHZGtG2Gc1GL QA9FBd4pRfcX0orHNN4P6HHDmMB9cng= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=qL20NxpB; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf21.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.221.54 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746456699; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=X5qEheQ78VUh9wA81z867KyoEw2DalbMlFj0qM+zfz0=; b=fG5v6D2xLHiv+jTddWZyyy7ShwKvelZ6H27Vz35e5tThpABUqStuwr6LcvXxA+NTQRTNs3 52xriroow9typr5RbgMNA/qcZC86WQFMSImGXMp+d7F4OyG/+tz4V2lnVK/OfroTJZsPHd BngiKdZ3uF2t2E589oEkW/1dQSLbqQc= Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-39c1efc457bso2993413f8f.2 for ; Mon, 05 May 2025 07:51:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1746456698; x=1747061498; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=X5qEheQ78VUh9wA81z867KyoEw2DalbMlFj0qM+zfz0=; b=qL20NxpBagX7+cXMVJm72RFPPc1mqRkOFEEFdyYngTy2Cp0HDcTEicSMoedzpRX5hY EuanhuQk5eOfxEuFPDtVewWxEG8H9+ENSTZqAYkNiuu8iePsNC7KoFJVzBnkUMJjrMMN FQi0xdyQALwJKGryirfueFFEqXLpYnoxdienOk3sPx8GaqbdnFrkuolRqIHH6n//Z48f 6ijOpsaENjlBWgeHYNJQf9vtw9XGVLXHAHvAe1ToIAEnx5qb6Ok2N8uDxowRg6B6Np9x tLvh/pomgu5nOImr/tSMU04RZHDCN0DDFUM2uIZ/+Bzj5z5lSoPdpHtt7ts1oNz6PolV uhWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746456698; x=1747061498; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=X5qEheQ78VUh9wA81z867KyoEw2DalbMlFj0qM+zfz0=; b=rAsCLIJVAofQXgSScM1XIxh6YXG2l+nZqdpdkiT5kUAL8dPlig12/9fQ3+0yDUpzJn 62KbGK/H3HqZMDyXypBPVjZTc7Op3aeUd1CzaQWn96pVIPXnGQCms/SLzHeWvg6byo4l HjQn0gBEveyxfye8oo6uo3k/bAAsqXwqZcyfEX/TrEFMH98MzBkayBJavcuvaMLjqSz3 ArxnHS0DI5xcgXJXItHNIShMcX4f3jHVoZbm8o7QQEPPsL8OBiQ8V6OcH6ZNcSEFxhG6 mBGw2YTJJB46143HVquByKKgHvpkywIvBTsM+4hHIA1qkoGRMioSZA8mZ5sLzhODsj46 Xlzw== X-Forwarded-Encrypted: i=1; AJvYcCXZ3z7587v/wJyW//0nVG8hVAtilm8rIGBuJliksxGybLgwCR0wne9FsrxQUEJIGBak6mu6Fjqx4g==@kvack.org X-Gm-Message-State: AOJu0Yw6LQth0IXZUBhKC9q+IgY3/lgKV3V1gssIHgnwYUj9AuHQk/sw axVCvjN+flsQwMqYjeCPXBJS4iMV0XSXDgvhcbvctBgFnjnVF2ytVyLB5J+HP5Y= X-Gm-Gg: ASbGncvpsMVBBgFsU0744H/LwK9URqSepmVdRA3Gx8ZZ6wL6NkaolPbE4T0Uw9RXLVY CPFgKR67Dyfwtp4t5KvhQhizSDtLnv5ylml+Mc4+sNbk3XNobHhtCxVJbNS8o5mvTzkkptwxH33 LzhCbI6lMSpHHcpLElJCtocweEFCMc70C70h83LvP0J8VJg2+KMrXXSzyKz6FzcYAU4Dw+22d96 1vbJdLrMyGlyOB25ahZ5I2DtekOS7p66b5AMg+vGE7pgnOGkGJlkfYUNYCvXUHIdvy0vepClBhe dZN15yU706ErL4eDc+AjEgqRr6Jtmr4Izw7a08JjAv4T4g== X-Google-Smtp-Source: AGHT+IEVyw/YGLqw4XgUqJUoi8KM9ui43BsDBRvgsDIU2uPCdWA10j2oTFbpLZc6LLbBVKhBuXsc7A== X-Received: by 2002:a5d:584c:0:b0:39c:e0e:b27a with SMTP id ffacd0b85a97d-3a09fd739d1mr4661103f8f.23.1746456698048; Mon, 05 May 2025 07:51:38 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-3a099ae7bbesm10434735f8f.49.2025.05.05.07.51.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 May 2025 07:51:37 -0700 (PDT) Date: Mon, 5 May 2025 17:51:33 +0300 From: Dan Carpenter To: Gregory Price Cc: Oscar Salvador , Andrew Morton , David Hildenbrand , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Vlastimil Babka , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Jonathan Cameron , Rakie Kim , Harry Yoo , honggyu.kim@sk.com Subject: Re: [PATCH v3 2/3] mm,memory_hotplug: Implement numa node notifier Message-ID: References: <20250502083624.49849-1-osalvador@suse.de> <20250502083624.49849-3-osalvador@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Queue-Id: 928921C000B X-Rspamd-Server: rspam04 X-Stat-Signature: knh6ky6mmgnje8m73psq9afuqmth9zau X-HE-Tag: 1746456699-578634 X-HE-Meta: U2FsdGVkX19V0f0M7IKpqvPOQ6R/sOixFhED+/SZeqX1SEzKR9nhvubI3X4YWN6gHsNIns3DYq/6eMpgYzV+sl9YUMj2v2yq84tFmmaY2sJD9cVc+viEED8DSW4blR0aZZJGfzYv0F2i5pA8kyiHOE8jrMkKO7LZE9ZpvM/kkGc4D/U9g0SwWeibK4NlSo428Yl1WXmfuzw3/a3KKUQCg1Lw2z5SCm5jSOtSBqbAOVVkVuxqUZrdViAv1jDdkBzM8K22wg+YztJ14CLOsXVl6DwiZ5sOyb1EW+LqnuBKSeNvjLcP24hQ8shITbtXtaR70vPxZgrtW8yYGNnxwVpO6XwCCjGOQuRcaWzunNUKaqW3FoWrYxdtTQ4YY8689my+fhkwEDhjd0/ziUHJokDP6I0AvXpXrDYjicsL6/SXoWF4CUsmw26ZdExR7aPRv02vx4eL8JTZCIKYWssqdNuk3AXvzOTqDPeNVaRkhvj3TclHMbj0+44XDLp7hi3dQEHWv72/bqt+GpzI79RBY66vWp3bVwD5hmf6ytz1P9Gejdup3Kv2syujIadUmCMy6RPYRZVDR3BItrOcRLq4ucTnGdT3L3ngog1w+Y5sO38umPHf1oF6E0J+Z9Dx7Aqk/joDURHJx2Wb7Zxnwo9TioV1644ZlVNafDhRAOie152M5rC998T5w0ZSi/JK/CL6P9mp2QtJ8X+3EyeGZTciZlK//xJ4DMMoaoVj311NOrrX4cKzcNtHYWW/MfTZ8hObBUCsX5Wq1QxIqUugz6gZwy1zD+xEwhGFBgr6KrAbyhugnqgN5CXD4OcEBD8oCc2+8Ow3egl4B4qv4DTZO/40a77ESpe6AByd1knD3VeUVy7irrOq+a8GMl8xRaHlsRt8+AX7cgtGxO7sWyGy6b++r0tBfdeKfY7iQMSR+zCwvBYLTe0Ez+aY8FybtQgRI5C69hvFQehhu1eELI5zTX92xno 9LPAhIWn PAJCuSBkS06xt7ap0Yfm1HIbWKULs30WHW/6lK1DdYk8OZjeOgFwspQTarCL5lQ9BvpG7WfOqlU8c6uzNXT8noE/ZYbspf2opgEQI7zuySN7DrElXBj+QahyJfpqyMkxl5c79ET5pC7wgmIxXNTpdOltNGw9ker8O/JJ98ZFxuUEtUqaZ98hhmuF/yLbpq8+6qZ279xOANNFyQYm3wHR90pQK84ZwEtBDhvhdf6peb+4Xg7n9SPf0m3M/b5z32sRX23Qc66P84jrhglIZSHq3KT7Xkbo4nhCmYgL3Qh0OjSXVOU23/rzQdvF8dowgRBWAXtiVjTQZMo9jZJI8M91DItk8IycslRVppJhvTSod2eqqZK5YCcQRViiszJruQAOMqQMorSSfuTZHDUZhLnS473Ll/CgY9zks1sLzu0VL7vKw8khPN1GpCIxGdqFoPi1LFG0Uj18cuyKtv6UdOw9Dm6hQeA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, May 02, 2025 at 11:28:02AM -0400, Gregory Price wrote: > On Fri, May 02, 2025 at 10:36:23AM +0200, Oscar Salvador wrote: > > There are at least six consumers of hotplug_memory_notifier that what they > > really are interested in is whether any numa node changed its state, e.g: going > > from being memory aware to becoming memoryless and vice versa. > > > > Implement a specific notifier for numa nodes when their state gets changed, > > and have those consumers that only care about numa node state changes use it. > > > > Signed-off-by: Oscar Salvador > > Reviewed-by: Harry Yoo > > Reviewed-by: Jonathan Cameron > > > > diff --git a/mm/mempolicy.c b/mm/mempolicy.c > > index f43951668c41..b3ad63fb3a2b 100644 > > --- a/mm/mempolicy.c > > +++ b/mm/mempolicy.c > > @@ -3591,20 +3591,20 @@ static int wi_node_notifier(struct notifier_block *nb, > > unsigned long action, void *data) > > { > > int err; > > - struct memory_notify *arg = data; > > + struct node_notify *arg = data; > > int nid = arg->status_change_nid; > > > > if (nid < 0) > > return NOTIFY_OK; > > > > switch (action) { > > - case MEM_ONLINE: > > + case NODE_BECAME_MEM_AWARE: > > err = sysfs_wi_node_add(nid); > > if (err) > > pr_err("failed to add sysfs for node%d during hotplug: %d\n", > > nid, err); > > break; > > May I suggest rolling this patch in with this change: > https://lore.kernel.org/linux-mm/aAij2oUCP1zmcoPv@stanley.mountain/ > > seems to fix the underlying problem, and returning an error now makes > sense given the change. > > +cc: Honggyu Kim, Dan Carpenter > Oops. I sent a v2 of that patch. I imagine that Andrew will fold that patch into Rakie Kim's patch. https://lore.kernel.org/all/aBjL7Bwc0QBzgajK@stanley.mountain regards, dan carpenter