From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 214A4C3ABBE for ; Thu, 8 May 2025 17:49:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 58AB06B0092; Thu, 8 May 2025 13:49:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 53A096B00A2; Thu, 8 May 2025 13:49:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 401696B00A3; Thu, 8 May 2025 13:49:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 2232B6B0092 for ; Thu, 8 May 2025 13:49:01 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 132921CF869 for ; Thu, 8 May 2025 17:49:02 +0000 (UTC) X-FDA: 83420476524.01.D26E634 Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) by imf11.hostedemail.com (Postfix) with ESMTP id 1E69840002 for ; Thu, 8 May 2025 17:48:59 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=mqgdJ6Qe; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf11.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.46 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746726540; a=rsa-sha256; cv=none; b=bTUJJUOfWTLV83b7HkUYK/0O5V9qpsxpeWlwt+/I9MdrY13LcGNF4SOKlMF5OvdMlbknh1 qjXvpietNQMUxIdaa/UyTwmnnpyFmADlyUq3rTl9kIOQf54iqRT/7I2VMeffKY1t2I6Qsa LHGRr1hubMAneRADTcK3MIycFZaa/c4= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=mqgdJ6Qe; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf11.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.46 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746726540; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RLVpkrLXml6z3gsyisKKJHxZUHvDSbaVwN7SOYZwBDU=; b=lZDO8Zf9asHf5JEppyvd4yO5O8/CcgIwOTy0gIt1AnrkY9Suec6m55xh4xAtilpu2oVDtT eeKZBUG8c5KpX35ZaYVNV5qEgRNCQKyNKfhpaabMk9Mh8PAjZQixrXnUtFeMS/V4fTFI2s ohhtHOKk+lvvp1AX/McXVi/+f6DelGc= Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-54fc36323c5so719273e87.0 for ; Thu, 08 May 2025 10:48:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746726538; x=1747331338; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=RLVpkrLXml6z3gsyisKKJHxZUHvDSbaVwN7SOYZwBDU=; b=mqgdJ6QeqW6tpi/KXiwMT5gF6R1tehlbHZ+pPj1i+or2VWpiNYdDqIxaoUrj2+CAUu q1XwBXHxo9QYAWnx/7PO7tPmQKEK1EdgdGlssNo7pGD9iHG+s2UYc/bbkWh/CblIAzoY 5sRSRbbyoYd6i27z5oBY/wlDXeEkFORIDujj2GiW6BqAZMTBmAX0ZhwtrSGrWc8MuTFS z3zd3F1STf6QpBSil/5idHLs7eNblquOd/TzGfqthw+20GcpMw0p3HLYvRYIYgXpQjax UqMyefrmsrkl4RvtQpEyPiD99bcyxNW3FaTcrUceTO59/FhhKAaYdZWskZnXMUbaoYvM qXKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746726538; x=1747331338; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=RLVpkrLXml6z3gsyisKKJHxZUHvDSbaVwN7SOYZwBDU=; b=cX5S6yt2fD2xSuzP8a5WjFTRKaywSDrwbQlb8oxtqUi6Kgy0471S3qbnH+9hL/xp21 QBVnobTB2EBWHE5OBb6gbrC6Ni6/46owpgMJOJAIsO4GLQ4ufs+L9MTiNSMHmxoObJlw leDwatWJ2GVGSf+9o30weAVUmAR7Fbumhye4VHy9hVoiE7aGSbC0IWDj//FzZlGyBJo3 8p4t0iRQhLZ1zrCTRJ2aSwMsqgod9L1iZONY1QhfhTUrC49HTY8IO1+eE+07rx/lG3N/ mlhT63t7MPaKgeyvSeDo8Po81YZBAbcdrKhtSg9G0NOBQxWqzWOI2cNuOreK3vfZ8rGE zqog== X-Forwarded-Encrypted: i=1; AJvYcCUqwDdNyzESFyAV+HVaQ0WLp845GYjOfehYE4otvIItV5EVmN04UVDMqLiaB9sKOIq0ee+a2ynjJA==@kvack.org X-Gm-Message-State: AOJu0YwajvqDqPJnjqjm7Y/kjAjxiijYk5xKt4QVXE58N8QaC82Xbp5R 5G/mXT0y2upJWLqQDXvUit5KucEonPOZIXWMjF7yNvVVLKzRU6Dd X-Gm-Gg: ASbGncuih1mUP90B03FX3Tsf09ks+V4uXOv+Gcip5hHiAZ77sny5Eq6C08Wrl6WOqFJ YancuuiEMYanFk4241aXbq0TOMcdwwekwhhQN2e8WVVnnvvc4akvBJQhcIUw/LCTiYiQcw7C88p i9ddl5ipU2pVAzwvbsg5IlR7QC2IyjWTlW4Dl1E18bnwNYvQqLqSLJpZKY2hRRlZr9ZQQN+cX2F F27bmjMsFPs3+yS2dNfehWZ1RDyhI4auGRnM69PUI3/2cvuj/+EQq7nMmJ7ckyQtg/SbU7yrC8S zewR7PKtp3wHC0HsC/2kTtxsWCicD9kzyJjPPowFnd8meAkPx7WwdMVYNSVabaJ8DOj/ X-Google-Smtp-Source: AGHT+IHezibg8GmkS41ZH1NUhSUyDp2pWTDD5Cr9WM1wZKs3IJpCD+KsI2JrnLwYW9i6Hc+A6f/zsw== X-Received: by 2002:a05:6512:6286:b0:549:4ca4:504a with SMTP id 2adb3069b0e04-54fc6758da9mr67120e87.4.1746726538038; Thu, 08 May 2025 10:48:58 -0700 (PDT) Received: from pc636 (host-95-203-26-194.mobileonline.telia.com. [95.203.26.194]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-54fc64ce953sm30346e87.256.2025.05.08.10.48.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 May 2025 10:48:57 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Thu, 8 May 2025 19:48:55 +0200 To: Jeongjun Park Cc: akpm@linux-foundation.org, urezki@gmail.com, edumazet@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6] mm/vmalloc: fix data race in show_numa_info() Message-ID: References: <20250508165620.15321-1-aha310510@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250508165620.15321-1-aha310510@gmail.com> X-Rspamd-Queue-Id: 1E69840002 X-Stat-Signature: a586b4nxdcuyset3aupgurn1xj76zrxw X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1746726539-663954 X-HE-Meta: U2FsdGVkX1+4e+qkir2c50zRnUaAhGZpj6E378mFeJqtT9Zop5by62KlbYlrTpq9odpuNLvK5VK6Rd8c/ud48usKJ+IRJ5JWs6DyEE0q6iUrfX5CMngGESk98F5Y2OnJ40fM3fyumpWY/JWeWive4sARB8gA3nkW1xVud/bXfNVNY6GpcMjRubarY8lNAchsrpCO6SN11vvF/EP9pUPV+0RQCM5JAv4KaXip+Y3h/g8QaoRoa8bLaya5LDB7FLu1GRKcfazB4ko5V/kd0nHCOX2/AZA22OYdCVOXUC0s3bZih52/f6pUq2VEuMsqx6sOL1w0o6Dmoro5d80rPj1lSwynnC4ob/8hp9chZ0yKKtn7Wu3P8zVicW5xfU7m7eH967z850oTVTKaoMcltdh5prvc3npcV+eibmHxH8zWjm0zJa5iBE6zC/DloT3BIm4td+Gj8yDq/zlWlaS5FtYONO7rE6Jofi3FI1ePhQUULRhKL8sm79FrLTjfFVWchqC4o9T3qZztCqfb16Snxo2ydYuWO9JebdOJy79Wz2c/ingLUyFY4yKEOvC+C5yN8aGXx/NC/BDYMG//CtvJoogBu7cjNeOkCDzFpl8AdQ4q/fjFdgBKVHvQPREjavUPco/chKYvp3P2J0pMyOH82ebJ/eh5zjl8kmIPIdrdt3Z9ztYOVmTxH6ltfyqTHWPF1oWbuPse9mFQZLlpcgX/8tP30aJahbQgJ4uCP8PlryYGYxDp5XjwjCeodHKfUkEw6TCUDV4K87OGz9dcAXajy8cn2aUm+y1Fv9WdtwvMgJA0qSz0V3q8qYkQZKVSwCOvDp3cyBe+qRXT7LO1wyyQVEzpYhzlmaTzz//k4KhyHpA5GJhWsRfBjqsoI+c+1LaRFxNpJ6DTnSbdoZPHkjDVsaYo9gZp/08WX3biqBvekWGVSI1vZRxQA4yr6+3ekqBQnyLFFL9jSR/FfjPVeHYILAq mMT0FTxH J5z9KTD4THSpd/cAI7viiiWBhgpsgsH2t7a0yABRtVsvoyFj44R74dOaxG2R7VWR3MJpzecGKLqg26Rtf2JyhStI14F82aEQIkKaUmB/HYSz/d2REMOyuy+GFnTaFs/lwfdgtUCPukdt2qhrVyyygtLGiErsbzfIS48eMeB0jmGnFUsakauUJMCtPgjX7jZcQAQkDvxOj6CJL1u58mJMP1M4j/YyjY2YpZGmxeTAa1962BQBKF2t24zFTdBzvGYBKFPthC7f56c0b3j/Md3D3ioTZNjp819Y7ZUoVhYNqrL7TZssb3PCHNmEdn3kncBMqd2LN0e7zEid1LEhhRVAhX10YC+o/g7N+yqDnPyG1FUmgEjTHvKxMqYUNVKP2O3G2vvxHV8YOgeSsckauMzoc1GxYjzKlOozGy/VF5xZ0mCe3hYXG+MH9Yk8WBzyo3RsThZd4tux53oHpk4wIGOeYuDKqKGySUBEjdaKrtFAo3bjA06cKLJZfzDSsiVfspL1437L8PLMAtWuTda1Z7NqOtWMO5g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, May 09, 2025 at 01:56:20AM +0900, Jeongjun Park wrote: > The following data-race was found in show_numa_info(): > > ================================================================== > BUG: KCSAN: data-race in vmalloc_info_show / vmalloc_info_show > > read to 0xffff88800971fe30 of 4 bytes by task 8289 on cpu 0: > show_numa_info mm/vmalloc.c:4936 [inline] > vmalloc_info_show+0x5a8/0x7e0 mm/vmalloc.c:5016 > seq_read_iter+0x373/0xb40 fs/seq_file.c:230 > proc_reg_read_iter+0x11e/0x170 fs/proc/inode.c:299 > .... > > write to 0xffff88800971fe30 of 4 bytes by task 8287 on cpu 1: > show_numa_info mm/vmalloc.c:4934 [inline] > vmalloc_info_show+0x38f/0x7e0 mm/vmalloc.c:5016 > seq_read_iter+0x373/0xb40 fs/seq_file.c:230 > proc_reg_read_iter+0x11e/0x170 fs/proc/inode.c:299 > .... > > value changed: 0x0000008f -> 0x00000000 > ================================================================== > > According to this report,there is a read/write data-race because m->private > is accessible to multiple CPUs. To fix this, instead of allocating the heap > in proc_vmalloc_init() and passing the heap address to m->private, > vmalloc_info_show() should allocate the heap. > > Fixes: a47a126ad5ea ("vmallocinfo: add NUMA information") > Suggested-by: Eric Dumazet > Suggested-by: Uladzislau Rezki (Sony) > Suggested-by: Andrew Morton > Signed-off-by: Jeongjun Park > --- > v6: Change CONFIG_NUMA to must be check before doing any work related to the counters array. > - Link to v5: https://lore.kernel.org/all/20250508160800.12540-1-aha310510@gmail.com/ > v5: Change heap to be allocated only when CONFIG_NUMA is enabled > - Link to v4: https://lore.kernel.org/all/20250508065558.149091-1-aha310510@gmail.com/ > v4: Change the way counters array heap is allocated, per Andrew Morton's suggestion. > And fix it to call smp_rmb() in the correct location. > - Link to v3: https://lore.kernel.org/all/20250507142552.9446-1-aha310510@gmail.com/ > v3: Following Uladzislau Rezki's suggestion, we check v->flags beforehand > to avoid printing uninitialized members of vm_struct. > - Link to v2: https://lore.kernel.org/all/20250506082520.84153-1-aha310510@gmail.com/ > v2: Refactoring some functions and fix patch as per Eric Dumazet suggestion > - Link to v1: https://lore.kernel.org/all/20250505171948.24410-1-aha310510@gmail.com/ > --- > mm/vmalloc.c | 63 +++++++++++++++++++++++++++++----------------------- > 1 file changed, 35 insertions(+), 28 deletions(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 3ed720a787ec..c1ea9713a1c0 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -3100,7 +3100,7 @@ static void clear_vm_uninitialized_flag(struct vm_struct *vm) > /* > * Before removing VM_UNINITIALIZED, > * we should make sure that vm has proper values. > - * Pair with smp_rmb() in show_numa_info(). > + * Pair with smp_rmb() in vread_iter() and vmalloc_info_show(). > */ > smp_wmb(); > vm->flags &= ~VM_UNINITIALIZED; > @@ -4914,28 +4914,29 @@ bool vmalloc_dump_obj(void *object) > #endif > > #ifdef CONFIG_PROC_FS > -static void show_numa_info(struct seq_file *m, struct vm_struct *v) > -{ > - if (IS_ENABLED(CONFIG_NUMA)) { > - unsigned int nr, *counters = m->private; > - unsigned int step = 1U << vm_area_page_order(v); > > - if (!counters) > - return; > +/* > + * Print number of pages allocated on each memory node. > + * > + * This function can only be called if CONFIG_NUMA is enabled > + * and VM_UNINITIALIZED bit in v->flags is disabled. > + */ > +static void show_numa_info(struct seq_file *m, struct vm_struct *v, > + unsigned int *counters) > +{ > + unsigned int nr; > + unsigned int step = 1U << vm_area_page_order(v); > > - if (v->flags & VM_UNINITIALIZED) > - return; > - /* Pair with smp_wmb() in clear_vm_uninitialized_flag() */ > - smp_rmb(); > + if (!counters) > + return; > > - memset(counters, 0, nr_node_ids * sizeof(unsigned int)); > + memset(counters, 0, nr_node_ids * sizeof(unsigned int)); > > - for (nr = 0; nr < v->nr_pages; nr += step) > - counters[page_to_nid(v->pages[nr])] += step; > - for_each_node_state(nr, N_HIGH_MEMORY) > - if (counters[nr]) > - seq_printf(m, " N%u=%u", nr, counters[nr]); > - } > + for (nr = 0; nr < v->nr_pages; nr += step) > + counters[page_to_nid(v->pages[nr])] += step; > + for_each_node_state(nr, N_HIGH_MEMORY) > + if (counters[nr]) > + seq_printf(m, " N%u=%u", nr, counters[nr]); > } > > static void show_purge_info(struct seq_file *m) > @@ -4962,8 +4963,12 @@ static int vmalloc_info_show(struct seq_file *m, void *p) > struct vmap_node *vn; > struct vmap_area *va; > struct vm_struct *v; > + unsigned int *counters; > int i; > > + if (IS_ENABLED(CONFIG_NUMA)) > + counters = kmalloc(nr_node_ids * sizeof(unsigned int), GFP_KERNEL); > + > for (i = 0; i < nr_vmap_nodes; i++) { > vn = &vmap_nodes[i]; > > @@ -4979,6 +4984,11 @@ static int vmalloc_info_show(struct seq_file *m, void *p) > } > > v = va->vm; > + if (v->flags & VM_UNINITIALIZED) > + continue; > + > + /* Pair with smp_wmb() in clear_vm_uninitialized_flag() */ > + smp_rmb(); > > seq_printf(m, "0x%pK-0x%pK %7ld", > v->addr, v->addr + v->size, v->size); > @@ -5013,7 +5023,9 @@ static int vmalloc_info_show(struct seq_file *m, void *p) > if (is_vmalloc_addr(v->pages)) > seq_puts(m, " vpages"); > > - show_numa_info(m, v); > + if (IS_ENABLED(CONFIG_NUMA)) > + show_numa_info(m, v, counters); > + > seq_putc(m, '\n'); > } > spin_unlock(&vn->busy.lock); > @@ -5023,19 +5035,14 @@ static int vmalloc_info_show(struct seq_file *m, void *p) > * As a final step, dump "unpurged" areas. > */ > show_purge_info(m); > + if (IS_ENABLED(CONFIG_NUMA)) > + kfree(counters); > return 0; > } > > static int __init proc_vmalloc_init(void) > { > - void *priv_data = NULL; > - > - if (IS_ENABLED(CONFIG_NUMA)) > - priv_data = kmalloc(nr_node_ids * sizeof(unsigned int), GFP_KERNEL); > - > - proc_create_single_data("vmallocinfo", > - 0400, NULL, vmalloc_info_show, priv_data); > - > + proc_create_single("vmallocinfo", 0400, NULL, vmalloc_info_show); > return 0; > } > module_init(proc_vmalloc_init); > -- LGTM: Reviewed-by: "Uladzislau Rezki (Sony)" Thank you! -- Uladzislau Rezki