Re: [PATCH 1/2] memblock: show a warning if allocation in KHO scratch fails

Oscar Salvador
2025-05-21T08:49:03Z

On Wed, May 21, 2025 at 10:43:15AM +0300, Mike Rapoport wrote:
> I think we should just make sparse_init_nid() panic or at least change
> "sparse_init_nid: node[0] memory map backing failed. Some memory will not be available."
> to something more visible and clear.

Panicking the system seems a bit too harsh.
Those sections will not be initialized, and sure you will lose some memory,
but still.

I think that making sure that subsection_map_init() does not access
non-initialized values is enough.
Because wrt. error message, I am not sure it can get more clear that we
failed we allocate memory to back the section and so that section will
not be activated :-)

--
Oscar Salvador
SUSE Labs