From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5FA1C54E65 for ; Thu, 22 May 2025 10:31:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0DC7D6B0082; Thu, 22 May 2025 06:31:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0B40E6B0083; Thu, 22 May 2025 06:31:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F0CC06B0085; Thu, 22 May 2025 06:31:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id D81E76B0082 for ; Thu, 22 May 2025 06:31:39 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 80DD01D3BFF for ; Thu, 22 May 2025 10:31:39 +0000 (UTC) X-FDA: 83470177518.24.F82E889 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf23.hostedemail.com (Postfix) with ESMTP id D323A14000C for ; Thu, 22 May 2025 10:31:37 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=WQ6NTKDd; spf=pass (imf23.hostedemail.com: domain of rppt@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747909897; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=S4EEMDM+Why1lFRGk1mTAsovv9E4AJkimmbBpX9hHbU=; b=mfo3eLG6emJUMvlO69LbYeubHcWXPW8xsZ39q01v48cvgjw6FgB1VaPiQCgzG1ZBVbMrCh s/hrBmo4HLNvHOo5KoxGrRcIo9GnhBddth4/Ho+mDnNCyTGGAbYkWaleV8levoJ6H0QHqz 83B9vhkKjwi+vawqBu87pfcKVyl5yZI= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=WQ6NTKDd; spf=pass (imf23.hostedemail.com: domain of rppt@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747909897; a=rsa-sha256; cv=none; b=E4cw0aSFHWctD6tblYAIAs3BZH4dP3WhNCd3nttmvQrqC4waTEXek78m4O2D5jV/+Etyu3 diF+o12BjlwgOWR/YrjO5qkVOrDIzKGTN1O/DZjSuA67WqEQW4mtKOyVQwsQcODVyGPg7+ HeTYWJ3G2PX0faihNifIC3pPlwaD6AE= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 33FF7A4A4E6; Thu, 22 May 2025 10:31:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0285FC4CEE4; Thu, 22 May 2025 10:31:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747909896; bh=U8t9LYXtxBujX4cBsLgR2bBSTLfPTV8nUtCJwGVkQKU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WQ6NTKDdKLSBTKx/Gn+f8Qmv/9r390/KAg3ehYsh4ITfOa1P22ndcmjcXJeErNywa 3Zu+0jDIxkp4xF9DMZsMzfEDsV/A/mC7Yd+ydzig9OQVjIaAOz5XvXzEIUnnseT0Ow mGT7CPYCwy091F0J9nBn+4+SamMMYYKguI1wSMzQmlB+9CM1L6NGEi9/10KOzrTJW7 Q9uxmcNO130gr2L4HWbintIOkcwI9a+zPXNHuz1kecH5/q+8cMJ1WoEbcqf41WIyBi aBS5l2c0o4p93R5K/yjO389mB2oGis9KfQZw99FpuRgP5JAdjM+uejiMaTBzRdw9gI GyHJvvwfWNzbg== Date: Thu, 22 May 2025 13:31:27 +0300 From: Mike Rapoport To: Oscar Salvador Cc: Donet Tom , David Hildenbrand , Andrew Morton , Zi Yan , Greg Kroah-Hartman , Ritesh Harjani , linux-mm@kvack.org, linux-kernel@vger.kernel.org, "Rafael J . Wysocki" , Danilo Krummrich , Jonathan Cameron , Alison Schofield , Yury Norov , Dave Jiang Subject: Re: [PATCH v5 3/4] drivers/base/node: Remove register_memory_blocks_under_node() function call from register_one_node Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: D323A14000C X-Stat-Signature: cdkp3h589anid66za3ocacr33cqc3n9h X-Rspam-User: X-HE-Tag: 1747909897-509521 X-HE-Meta: U2FsdGVkX1/okdOfgS1c9zJ3+8m2vSU/AySstkDYYLvkhSOgC6rRY98VfzETK9TKmft+CokqW50ngnySkoTuC2Wv0VFBIyfXF6M1UeEMUUId2ZJGbgoxWlWfkZgQbEDcEQolg6jAn7yy8hYVZcRGVq/eqefFLVM2oUCaAQ9STfXk2wLtkau+VhZMbRKjcooHP8nOCvm7j2zVxCeA+n96Ad5OdS3pW0ZxyIVLgwAC6xvrrI7PvSQiav30RWBEd0LXy2UnKUMNYIF+s7Zh0/egZYfqTWNNA/ej+lsdfQx/5JIa9VPsTNXXGXwFn1v8cTLB/GNg1pUNOSP4PckvlGWyGuDWPEUfbHyZBjByr+NCpy41+Ase5yM6z1sI1p51y+tVO8v+1lZXHgbCRNVKRJrtqiGsu94HpRBenSykGbbgoxOUBNKN/AfSoUYVxS0yGjU7IAqtMv+FkdvnG5IuTK90bcPwKazFzGLcjRX2iZ3G+mAeWw/F72mTh1n/X3o/UXFKqw/JnVYcsaYykSdCsRF8kel8/JJ5fK+s8IVqPf2irjiExgUaGLwjxx6Nl9zzAxXmDLvLyIQhcD/umDsOSB3NjkXiguiBAOQGq23mRDHl6kbaR63DOu6Y/XZnVLbU6IKMZeQOzA6DKEnlusdR+G0JViWDzoirOHWxiB9NEiHsHHpFDGvYzNOqiaJvFJg7wly7avoL3Rdob9CS6maQuieBH4i/x/2ecGxMt8vbzhR0+kaDWOrOy/Fu/6ipSGYGwifdOYtI8tBvKJ0AJ8kvr7gWrQVuyGuKs7CoR/AKqLJVsDLVvKRIrxrsyKDwdnRR4ZBVcKM+nAHWellr4FjKrQJqGkSCuLT/spUQTnAc0mw1DghghgJzB/VhaeWQR1ONeaoYsMkL1y55sjDzxsJRigvYQi+yUF1WU4aHhF6ptI0kxmef7VYo9tiBnqM6qAGhpuuFOLMZyA1SWyarCLFTUvR GuiBNEIt STOB3DQOtnfHv1eRN6hhZdmdrYkJ30w/KErrzb53j82Z/+VdT+2YV39H5+b7CQy2rYj/5r/N1BAC5z9p/o2g1ZkSsUcIjqxampStCaZyGuVOmWwoMDzP4CzqZk4NOAxVZv3NOz7S+zcP5GqazvW2XwEsz01csSWSrg0ORgwiR2XO2xseFV9byLaQU7cjWu2CWnZymAr5osfUVYgG6XdbFkZYDQNk4kZcrJGkHrIAiBltDyobwiUhI5//CiRUzN+g+RjqyykkMLcOmyb/0qSS1t7wfipnoYrNu2xN4O1wiZVxjckz+x3wre6aqJyK22TuLwDIbDacrSDk1C8sIQxGI1x94WfEpMT3LuoqDUnxdS3Ig0X0oL6wg+XW77w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 22, 2025 at 12:06:06PM +0200, Oscar Salvador wrote: > On Thu, May 22, 2025 at 04:17:30AM -0500, Donet Tom wrote: > > diff --git a/include/linux/node.h b/include/linux/node.h > > index 5c763253c42c..6cf349c26780 100644 > > --- a/include/linux/node.h > > +++ b/include/linux/node.h > > @@ -136,18 +136,8 @@ static inline int register_one_node(int nid) > > { > > int error = 0; > > > > - if (node_online(nid)) { > > - struct pglist_data *pgdat = NODE_DATA(nid); > > - unsigned long start_pfn = pgdat->node_start_pfn; > > - unsigned long end_pfn = start_pfn + pgdat->node_spanned_pages; > > - > > + if (node_online(nid)) > > error = __register_one_node(nid); > > Heh, remembering this code always brings me joy. > > After this patch, register_one_node() is only called from try_online_node(), right? > Which, before calling in, explicitly sets the node online, so... we can get rid of > the node_online() check unless I am missing something. I think you are right and a sensible follow up cleanup can be renaming __register_one_node() to register_one_node() :) > -- > Oscar Salvador > SUSE Labs > -- Sincerely yours, Mike.