From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0238C54E65 for ; Thu, 22 May 2025 11:49:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7ABE06B0085; Thu, 22 May 2025 07:49:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 783616B0088; Thu, 22 May 2025 07:49:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 672326B0089; Thu, 22 May 2025 07:49:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 49B5D6B0085 for ; Thu, 22 May 2025 07:49:32 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 0D067E75AC for ; Thu, 22 May 2025 11:49:32 +0000 (UTC) X-FDA: 83470373784.07.014B50F Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf13.hostedemail.com (Postfix) with ESMTP id EC90A20008 for ; Thu, 22 May 2025 11:49:29 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=P2TFZOnl; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=w7a29t8u; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=P2TFZOnl; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=w7a29t8u; spf=pass (imf13.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747914570; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GQRUtWyOBWmX6kLMyTdH5usDFLYr4fmjaiIBz46kNI8=; b=gUO5F7Wdu3I1dRFMp/6OYzXMGAnbAXfRaxc1+4G/0h600RfaHrluNIQMGRZzYCEzlFWRv6 dJY2hoM5B0fNdrFnMCUE8Ck7PZR/nh0dVb+nQFoqRcpIwX+mE1TXhWhnX/8feFd729m2bg qDvppQ4EvdB+JAiTw9bINnYmnEOS1u0= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=P2TFZOnl; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=w7a29t8u; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=P2TFZOnl; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=w7a29t8u; spf=pass (imf13.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747914570; a=rsa-sha256; cv=none; b=jnE+GvupLX6mCiFvxN0QqsFBeT+ZIuhnzHI70gr71xjLrrI7bEtuJvWyxY7z3MlYb/nJt+ RYFgVIgo1qHyeCd+1XZDgjONxnObYDBHRmfMvhucnhI93ssPLq9bk7mDgd4tCKkUSA2qnG 8Q+ka/3vKKyg0mQEKSw22c6ObCbnYTM= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 3F03B21A1C; Thu, 22 May 2025 11:49:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1747914568; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GQRUtWyOBWmX6kLMyTdH5usDFLYr4fmjaiIBz46kNI8=; b=P2TFZOnl4F5ci4DzulKguOM5w1aVEkvgjuxVMzS4WT1rvpAK/PoJ44urk1jsHWxEncr4qL 1Qz/WgoC8nc4uSQGVTtRfhgmffmbaHY8/MXjtbWXaWaUNE90R/Pgs69OkzQSP+D/dQDf6K Lh/p3Q97xyWKy2LssxEQwUEa9zrLdBQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1747914568; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GQRUtWyOBWmX6kLMyTdH5usDFLYr4fmjaiIBz46kNI8=; b=w7a29t8uekXu6usd189cm7ZRbvY+/sniNqB717Fc59cj5YGvVjosTB3V/hkUBL9XuyeEnH fQ2ux3/0sMPqIXCw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1747914568; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GQRUtWyOBWmX6kLMyTdH5usDFLYr4fmjaiIBz46kNI8=; b=P2TFZOnl4F5ci4DzulKguOM5w1aVEkvgjuxVMzS4WT1rvpAK/PoJ44urk1jsHWxEncr4qL 1Qz/WgoC8nc4uSQGVTtRfhgmffmbaHY8/MXjtbWXaWaUNE90R/Pgs69OkzQSP+D/dQDf6K Lh/p3Q97xyWKy2LssxEQwUEa9zrLdBQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1747914568; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GQRUtWyOBWmX6kLMyTdH5usDFLYr4fmjaiIBz46kNI8=; b=w7a29t8uekXu6usd189cm7ZRbvY+/sniNqB717Fc59cj5YGvVjosTB3V/hkUBL9XuyeEnH fQ2ux3/0sMPqIXCw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 0E663137B8; Thu, 22 May 2025 11:49:28 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id n1mzAkgPL2g5YwAAD6G6ig (envelope-from ); Thu, 22 May 2025 11:49:28 +0000 Date: Thu, 22 May 2025 13:49:26 +0200 From: Oscar Salvador To: Ge Yang Cc: Muchun Song , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, 21cnbao@gmail.com, david@redhat.com, baolin.wang@linux.alibaba.com, liuzixing@hygon.cn Subject: Re: [PATCH] mm/hugetlb: fix kernel NULL pointer dereference when replacing free hugetlb folios Message-ID: References: <1747884137-26685-1-git-send-email-yangge1116@126.com> <644FF836-9DC7-42B4-BACE-C433E637B885@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Queue-Id: EC90A20008 X-Rspamd-Server: rspam09 X-Stat-Signature: 58qpsq8werbpgr7e4pj8u8a9ysezckbx X-HE-Tag: 1747914569-970086 X-HE-Meta: U2FsdGVkX1/DOYW12GRnFqIidmERogQy+hIl/REb6GG2uUZm9yd1NV9V6AFpTkV2L10gQInpoLCPf2BZ5naDTLysqHVoMHglbzizyG5Vr0tI8AcE/cHnYp5YIJqb5djiAVhJwNqevw7nnAuIbSxNSz9TqTYJX5YyPEbQ8oTcSOPkuk1lXyYEBU0fI16Sp2RId0fU1u+aDf5NU19YgcrKm61TMMCFIeTO5yHs5Tv6yV4FUaqT4POGTmWn09B0zXeV+lBjv9V3VT9WDsFNeOwMig1TiCd6RtASkLsULycIT7XISNpJPA1PLEIq+h42GSFgTB4dWFEjVL8/51KtlDe+NmvYfrPA1RdDxM5z/T/r8hJciuadzrOg9YbjvGG+KgDQ3HDl2QAwr9GYgxk88KHYJYJa6PLZniB0GPFyPCkcUt82M2q1QcbdzCcwh+07BS30S4P0nEs8DQZKJcWUqKXirVJqkr08RpVR+Bjr8cUaC2Cu+BrR/PfdXheaEvuv5iHk/ZNqev4Zmgix6TBimmOGzt8b4vFzMSAKKiEwuSK0hEiEJqIrt30uVyoXU+heEvGJVlKqrESw04QI2z20NQrRCftnc0UN8Xc9y8uXq/nMUedaZ5csUaI5sdGvxgT20cAV3l/DSBvHoMa0z4ysAEo0eubI+BhONKQX4KSm3xPwY3ghwUY0F0TZSe5Vp6s2/kCO8ZIh3ayhit2agiAHpWP6pc8osGXzQPhj5a27Gi7kv/3LRGJI1QDZKBoZmuRt/HRD8IFPfK3wIfbK+1E/61WCx2o0IGnRTMlRfcaYuhNG95rP92+YnKaSi6LI+tGmjtR1yFODuZ6wyWXG6uuDYrsYlWwO0rsuQ8tpy4cag0c6UPlD2Po0f6MbSMSvqRwUInpSclgqfXHo61wqk2KX/3AZyfoLbuneZhA9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 22, 2025 at 07:34:56PM +0800, Ge Yang wrote: > It seems that we cannot simply remove the folio_test_hugetlb() check. The > reasons are as follows: Yeah, my thought was whether we could move the folio_hstate within alloc_and_dissolve_hugetlb_folio(), since the latter really needs to take the lock. But isolate_or_dissolve_huge_page() also needs the 'hstate' not only to pass it onto alloc_and_dissolve_hugetlb_folio() but to check whether hstate is gigantic. Umh, kinda hate sparkling the locks all around. -- Oscar Salvador SUSE Labs