Re: [PATCH] MAINTAINERS: add mm GUP section

David Hildenbrand
2025-05-08T08:53:35Z

>>>> (looks at vmscan.c)
>>>
>>> Current maintainers (mm/unstable) on 20 biggest files in mm, Andrew is
>>> implicit:
>>>
>>> $ find mm -name "*.c" -type f | xargs wc -l | sort -n -r | head -20
>>> 198195 total
>>> 7937 mm/hugetlb.c # Muchun
>>> 7881 mm/slub.c # Christoph/David/Vlastimil
>>> 7745 mm/vmscan.c #
>
> This is, as Andrew rightly points out, a key one, I will have a look around
> the git history and put something together here. I'm not sure if we will
> get an M here, but at least can populate some reviewers.

Yes. I would assume that at least MGLRU people are reviewing this ...
and probably memcg folks :)

[...]

>
>>> 4703 mm/huge_memory.c # David
>>> 4538 mm/filemap.c # Willy
>>> 3964 mm/swapfile.c #
>
> The various discussions at LSF lend themselves to suggesting people here,
> can take a look at this also.

Yes, we should be able to come up with some R.

>
>>> 3871 mm/ksm.c #
>
> As per discussion below, thanks for suggesting yourself David, I hope this
> is a case of 'well de facto I am maintaining this'

Yeah, it's exactly that I'm afraid :)

> rather than taking
> anything new on, as I worry about how much your workload involves :P
> > I will sniff around the git history too and put something together.
>
>>> 3720 mm/gup.c # David
>>> 3675 mm/mempolicy.c #
>
> Ack below, and will take a look here also.
>
>>> 3371 mm/percpu.c # Dennis/Tejun/Christoph
>>> 3370 mm/compaction.c #
>
> As you say lots of R's which is good.
>
> As per below would you want M for this?

Probably we'd want a migration section with sth. like

* mm/migrate.c
* mm/migrate_device.c
* include/linux/migrate.h

And maybe we also want also the following files in there (a separate
section might not make sense)

* include/linux/mempolicy.h
* mm/mempolicy.c

MEMORY POLICY AND MIGRATION ? I think I should have the capacity to be M
for that.

mm/compaction.c is a bit in-between the page allocator and migration
right now, but I think long-term stuff should simply me moved to the
proper files and compaction.c should be a consumer of migration
functionality. And likely compaction.c should stay in the "PAGE
ALLOCATOR" section.

M for "PAGE ALLOCATOR", hmmm ..., I was hoping that Vlastimil might have
capacity for that? :)

Not 100% sure what to do with

* include/linux/page_isolation.h
* mm/page_isolation.c

(I hate the word "page isolation")

They are mostly about page migration (either for alloc_contig... or
memory hotunplug). Likely they should either go to the MIGRATION section
or to the PAGE ALLOCATOR? Maybe MIGRATION makes more sense. Thoughts?

--
Cheers,

David / dhildenb