From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DE17C3ABCC for ; Wed, 14 May 2025 13:38:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6DC0C6B014E; Wed, 14 May 2025 09:38:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 68A816B014F; Wed, 14 May 2025 09:38:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 552EB6B0150; Wed, 14 May 2025 09:38:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 3703F6B014E for ; Wed, 14 May 2025 09:38:12 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 67899E1ED0 for ; Wed, 14 May 2025 13:38:12 +0000 (UTC) X-FDA: 83441617224.27.FCA6D55 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf20.hostedemail.com (Postfix) with ESMTP id 7AF271C000D for ; Wed, 14 May 2025 13:38:09 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=j+nwTLnG; spf=none (imf20.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=j+nwTLnG; spf=none (imf20.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747229890; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TCbxG0sR6k0ek2FO7HVhODHhtN5gSAWTcsnndt8bAnY=; b=Eh3WMa+5VIG/NhoqwySnKsvS1/2NiOkfSq0zQu713b5qveK66kBa9YXix+OYBJLZnAO9OI XnsUPW7qlsle1jinMxW/cL+p62rC8OzOQyeFurtOy7G41AKZ5NLZ+iR/eEYrp3poXdD4YL UB8HbDMaaQFbYbCd1TBSoaY+xw0CTEY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747229890; a=rsa-sha256; cv=none; b=suj+eoBh9Bz2VqIVEXXYpo6gKdMZzbKfTmYn3RjmOlAs0gjyiQeWoY3e/oFPhp3kl56m/Y tfldE2UQwe/T4cmttfclTNrwT1n7KrmAW2ItB9vPt8raq517bX6O9yTxPzEPFkqU8UZDdM FFamxFeWp2lkgVdw8M78abmsqWLELhE= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=TCbxG0sR6k0ek2FO7HVhODHhtN5gSAWTcsnndt8bAnY=; b=j+nwTLnGp++/pDuVRXV/5puhu4 kVt4UzOFXLKNMXzkbfTiLtkrR0d25rVC0U0VTpYJfSdtPfJWVBYfodTcI1hnN6xnnTt6RxAYe6evJ zmklAigZcqE/tcQtJmMdp+9yn32HRSoFeocohZPjWmNFyZq24AQ1bHw701u9aPB19Gkg5FCLEYKAF q6GWrWMUAqs4e2cDRduVkTalMj0E4DXS8IpzgTwT4zU87eZ4hjj1gff+qZrCfJCon0nGXEZnQu7ti Ac3rdd0IvOpfKjoMB27XqiZiAsA/778wpMIb0LYXd+UjP1zvUzAsgRmbJfBJo1aVZMi2tKiVoX9NQ lepIj0EA==; Received: from willy by casper.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1uFCJC-0000000CM7W-0D7K; Wed, 14 May 2025 13:38:06 +0000 Date: Wed, 14 May 2025 14:38:05 +0100 From: Matthew Wilcox To: Theodore Ts'o Cc: =?utf-8?B?6ZmI5rab5rab?= Taotao Chen , "adilger.kernel@dilger.ca" , "akpm@linux-foundation.org" , "linux-ext4@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" Subject: Re: [PATCH 1/3] mm/filemap: initialize fsdata with iocb->ki_flags Message-ID: References: <20250421105026.19577-1-chentaotao@didiglobal.com> <20250421105026.19577-2-chentaotao@didiglobal.com> <20250514035125.GB178093@mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250514035125.GB178093@mit.edu> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 7AF271C000D X-Stat-Signature: hb4fc45endixptto5sjimxzqk3oaxuia X-Rspam-User: X-HE-Tag: 1747229889-734668 X-HE-Meta: U2FsdGVkX197Sd6jYxQ4qjh1b5nfdERozifVKHtZim4AiHGE3Plgbf90RE/x5NlcfGrEsyOzKSmI8bT3XNkmfg9rWZ3Row+JnG5Tv3tsWsI7riCcO4b8cJ9JNeKQT3Mfyz60m1VfcbH9TK1Jx2OmHqLlwS/jGoQlqbfmX3BG3lQnVVYjXqQtFrM7Woqn2eXfoA+zrfOwhf9BiHl6dVjVInuonnXxSeKWJhm+FDZSAb7AQ865kpU+Wmn5t2OVfcmPAwzJNcYeXxWDshrq/qUcf3dsfN71Bg5xGp5wXXcmS095mwC5/LGUQBGDALQ5B35grEnqsPRoYPLARPB4qG1qNeOWOxXnrc90bXfOPnKs5fCGUBMhkuiAu2gnKvPZJRxvJX9PSxSRwfHulN/YcfKkVCdhCTvAIcLCD1E/ktwoAtQCsJNpMqW9zMEODfG6//0+msino0DC4KqBLxefbjeuQ2Pz/k/n1C2XjDmCk6QI6SetJ+kKr6Ea+ANDD7GbW3hv6r8BHQIF4YGJH/xop+4i7zXb0yZZ7mnF5pGKKqp+GQym/oCBjoiFkg1JQuS2/dJeWRBB8rh23weHaZpEJrdPOACgtu4chH02roDOOrrSVVYl/UB07zg9YzoxXCRmcm0j0rQVkvEuHaO/O/9yWqtQVRETxx/vZ7TEgudBtNOn4n8alc0FI802AVQJziqkApPjoL0MiuBqP5N2Bj4lpVtfMUTNzwUhL1km7ykZEX92URLtym+RmJtRMKKAvFfiB8tQ+AolL8AW92F/ZPqmEyxSadeqYyA52vz6ovyfjIz0wsNZvZb7lg9lC9kUuVFusJtcXzqhBKFnVOZ/oLE+YlFV16IOjBGNwSEVKtuPksAZVFo8SXHiYm7YjUz43rE50CvQ1vZ22ty2AvgQtCyAh+XAeB5ELpCWYXuOX3NvB/FH9hkdJWBr7/QiaMnhFRXzR4N67w7Smn4/ebCXncY46xv PdRULbMK eQ1N4CF+lGP8Bo/A8VF3guA37UjFlV6XLaOQbMrgv+D53X3Ils6tVp6a1xH4XFuUfCz4QTa01jpMXGKvz826u961fA40cBUV7jzn/8qbJjjBqh1xPIte9wvZRYwlcJ7wn11NKWxqBzE7K0fFXDw+CojRc8fsVvxMr2jmYro7Xcg8XrGXY3XtNSwCnR/HW0qqV5r0DKDN+6ud2KVsgmcX3XM4eLAG4NcT3X3FXEP2nTxUvoFZnkjgYREfZEBArcRK28WOe/Z44SI0nn4W1ysWiAJpavFfC24QQVjjG/ItMRQYWTVx/2AxPqOCgJrKYZSN1niUR X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, May 13, 2025 at 11:51:25PM -0400, Theodore Ts'o wrote: > I understand that it would be a lot more inconvenient change the > function signature of write_begin() to pass through iocb->ki_fags via > a new parameter. But I think that probably is the best way to go. I'd suggest that passing in iocb rather than file is the way to go. Most callers of ->write_begin already pass NULL as the first argument so would not need to change. i915/gem passes a non-NULL file, but it only operates on shmem and shmem does not use the file argument, so they can pass NULL instead. fs/buffer.c simply passes through the file passed to write_begin and can be changed to pass through the iocb passed in. exfat_extend_valid_size() has an iocb in its caller and can pass in the iocb instead. generic_perform_write() has an iocb.