From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB1BEC3ABCC for ; Wed, 14 May 2025 15:06:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AD3B26B016F; Wed, 14 May 2025 11:06:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A89976B0171; Wed, 14 May 2025 11:06:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 96F546B0172; Wed, 14 May 2025 11:06:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 77BF16B016F for ; Wed, 14 May 2025 11:06:33 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id A0386140E6A for ; Wed, 14 May 2025 15:06:33 +0000 (UTC) X-FDA: 83441839866.13.54757C3 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf24.hostedemail.com (Postfix) with ESMTP id F03B9180018 for ; Wed, 14 May 2025 15:06:30 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b="QjI/TLk8"; dmarc=none; spf=none (imf24.hostedemail.com: domain of BATV+829b1d53e8a87e0f045e+7934+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+829b1d53e8a87e0f045e+7934+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747235191; a=rsa-sha256; cv=none; b=HkBxUGZW6wJsXaxb5GgsNvAItp4jCjQcCCiTiY+8K3itaZAPp0uyUVCS38z0aRz7bQ+0pl xFkkLDARRS/JHIcQI8iIYOAKzSgE87A8sRerWgF6UdAA60QC4qRZCn6Lx6tNEddGe6v1VW xuBFSXwWaWAxPY+ROA13QEcQXYmk0uU= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b="QjI/TLk8"; dmarc=none; spf=none (imf24.hostedemail.com: domain of BATV+829b1d53e8a87e0f045e+7934+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+829b1d53e8a87e0f045e+7934+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747235191; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RKownVnGZe2UL1ciUHyNBkHcN2TX+C13oImW60hfDsM=; b=kN+UD88bvi5g/uwkkai3wK5wAIwMq4k9iiAn11e1mNmHoRpCBCiWexeg4B/XPgBMvRmbQV 6zJx7fqnk5SuJmFFWCPl7bp8hVmvybnfeaol28+Tv8fPNuzt3cFv0B3dM/7XLmW8fOV00t oz0JMBKmbr4cHZmFUMK9CJz1k/jQthg= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=RKownVnGZe2UL1ciUHyNBkHcN2TX+C13oImW60hfDsM=; b=QjI/TLk8bAz6m0/ahaZbmakyUt x6PoTRckDFJRJ7atnSUukQOhJomjiquCpNi81GTpWflVz30z9/umlbb1jXvT1UdwN7bfgW9LzvCIt oqHEpu5SVX9hIxPF75tqWarkJ46AAWqEBBfUnH8KWO0r2hmZZB+hQRDJqEsK8917vjwN/NPP3ZRkN hoJC24wE8zcuhSBPrVIUFAStqct9Oj77OKULK0+gK/V9daIMsV05BjaelUZeUBbigJaqHduOjbdqz q2Y4kll8asCQZOsNXocWuWvr9SvEDbgThaef+u+LHBdvANyq9ajbdFhfUPQTJixgZJ0kSjLarZoyE mbvvM7lQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1uFDgh-0000000FWFN-21pV; Wed, 14 May 2025 15:06:27 +0000 Date: Wed, 14 May 2025 08:06:27 -0700 From: Christoph Hellwig To: Matthew Wilcox Cc: Theodore Ts'o , =?utf-8?B?6ZmI5rab5rab?= Taotao Chen , "adilger.kernel@dilger.ca" , "akpm@linux-foundation.org" , "linux-ext4@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" Subject: Re: [PATCH 1/3] mm/filemap: initialize fsdata with iocb->ki_flags Message-ID: References: <20250421105026.19577-1-chentaotao@didiglobal.com> <20250421105026.19577-2-chentaotao@didiglobal.com> <20250514035125.GB178093@mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: F03B9180018 X-Stat-Signature: fosqpeyuhqsg93rdyjqhc43ynrtjrduy X-HE-Tag: 1747235190-314175 X-HE-Meta: U2FsdGVkX1/nLk+ur713P8fF1dFbm3TcYIes/vD7AGAK5ArHCnPgW0x1W/F0tQpXlStp3ult2lxFPKU76nIeF/mBwfvmaQCH6gjVi5Lw4Idh+whVOokPKwG9bSeZcD9855FMvPp2bmj1V/Ot9U8GVMFSE+GlyIC++y5SZjECdbiHpJ2nwVYd/rlp2W/Fs/Kuq+JW9pBi0O2FoYPpuhzB5Dxt5JXeskzjwiOf3VcvKQMTjBnmzKUZzH/FRAkgqkteoCvhJ1CmmEd9rV/EWtF55FGSJJFm0jwUT+Cpbwvj4wcVSRRQaBsg6R1TaazyPYnuxXIWXDh0ypzC/kMxx3QgHM6qitS7X3zWUTSCQ4w683RihrRFjsjzJbzZSMPvw5b6FIgHFQ34ZnQVE71pNPiA8Ulk8V+ERBj0pZXmrIe10twYh8D6kRQouVAB4pnBlADNedyje9+8PtNgiZ93g6gbmrLkzSHwqLA2NwrROPy4WAT4LzRn/mD4ulO4NHjYA2jcoFsVVjfeGWD9i1qGXc6LK2B1034w75a8dF/lkhBlpUjqpIlnbkGTZAxOPUCJ4ck7mhxLXzB+kfhSBjI4OhaP+Y9JfNOttFiYV2qpGlqhoJyuHOZTLm7ItjJ2+diEQkbqButaHVtpLd3J+BENiMiSNxB/jf6IbwBj6MAEu4qQXeTCdKY+ZmC1GKiEStKX1e7I3MGtlYwI1m56Ma5XZDDyN78nlXU1Zrs5Zq+3zCs0sOL+02gGuZ9+gvZ32mAedaFW5ZN1HhaCRzPYkHSwR6WO0Rm85sZICbamdDSTBdholAMPzSMl3mh9aVGwnWSSq8MmfnJD9xEhbCNA8kGgBEQST90xZRlf+m3fq6L1flaZkDcPyk7/vpduXHb95ulQ4OX5pU+NuJYCO6kW10PtUxUrUDurQIP3f7p26OIMPRWPGDColh1mAChc70lOvbTtL7t5K765WTVKTEe/RaD1Yc4 Dk9UK9ck phbjHmL30ze6TrHWepNEvmfDAiwSzhH/LvJ4K2oJPi6wxmD/qI0Nl9rTFS50OKyuwnhC38LZuo/9oa3912BVczwx7l3eswaS3ap4H36AFQX8ca1TfNw22CVLquykQLQaePD48eQ92t33twBFidzYx5t7aVl9DIKMzYiLRbh1np9y5S9pzQ+SJJbnm9KJUylg8kyjZqZkxr6Y9RmUZgWkvNZ8b5HWxK9vGSk/q9/gvyyv57twdb4h4Li6Mpw8+qERU8limvDDqGDlyWgLiTVhlDTt4CKiv0QFPfW7sW5rB5i5DtUAmuoR8a5ai7aMrvaY2BDsYtUTNkAz80PVPpoce3KIiiuA+zbDO1C5siKOsC4S4Ke8msgurVaEQS4HkodfswsZgQiTJPaZOhHVNRKX1UuF+Rht3BHkMOvo2u1fJmyVvSWbjQp8fm5QG3Y/uXslfradMrzzWwI6MJgS86Zs3dL8KqGYblGMjt3ahnfbyy434v9iLE2GhHZHyNR8+Jui9B3LeWqLpvg6Psuubrab8ceHE3wdV2P8jiqe3N/I5az0O7CaG2L3qhI+MhGUZVSHstsjn X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, May 14, 2025 at 02:38:05PM +0100, Matthew Wilcox wrote: > On Tue, May 13, 2025 at 11:51:25PM -0400, Theodore Ts'o wrote: > > I understand that it would be a lot more inconvenient change the > > function signature of write_begin() to pass through iocb->ki_fags via > > a new parameter. But I think that probably is the best way to go. > > I'd suggest that passing in iocb rather than file is the way to go. > Most callers of ->write_begin already pass NULL as the first argument so > would not need to change. i915/gem passes a non-NULL file, but it only > operates on shmem and shmem does not use the file argument, so they can > pass NULL instead. i915/gem needs to stop using write_begin/end and just do an iter_write. Someone who has the hardware and/or CI setup needs to figure out if vfs_write and kernel_write is fine, or this is magic enough to skip checks and protection and go straight to callig ->iter_write. > fs/buffer.c simply passes through the file passed > to write_begin and can be changed to pass through the iocb passed in. > exfat_extend_valid_size() has an iocb in its caller and can pass in the > iocb instead. generic_perform_write() has an iocb. And we really need to stop theading this through the address_space ops because it's not a generic method but a callback for the file system..