From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37DE3C3ABDA for ; Thu, 15 May 2025 02:09:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 187606B00C5; Wed, 14 May 2025 22:09:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0A5076B00FE; Wed, 14 May 2025 22:09:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E121D6B00FF; Wed, 14 May 2025 22:09:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id BE2AA6B00FD for ; Wed, 14 May 2025 22:09:19 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 785E3E29FA for ; Thu, 15 May 2025 02:09:21 +0000 (UTC) X-FDA: 83443510122.19.15A1F33 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf06.hostedemail.com (Postfix) with ESMTP id 2D2FF18000F for ; Thu, 15 May 2025 02:09:18 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="Gkb/Py1b"; spf=none (imf06.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="Gkb/Py1b"; spf=none (imf06.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747274959; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rcjPKZsckWOuKXk0QifKBxWsi1qc+2jD7wDRi0Ywjjc=; b=TqXGOlWJjD5RhjOEAfMolKOrW8hAxbIjn/+2qNoWETTZDk/oVU5NPRJhQKFHGgaJeEJ9Zo 0w76wt8yvpRWDCLF9WgXUYOEADUdlu0Kf6IOBlOXi2+QiIEB3VnCvvbUsUOBpLLtVyWXl0 fI3kUYfuhL6lPjxazuUWpohkVkt3+CU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747274959; a=rsa-sha256; cv=none; b=i0H1p53cksg+/NjxKL/wT0QDgaN4kgJo7YOOMva4FPp8nui4kK5xdcRQTaOb54/dJuJ1fu KAYLLEqBJ/cfwu7xvCd/1j+pCAQ9LyKSbMOBsWTnZ0L4M+6ZjKq8gfzY99ugb6/BwJwYxL atRIs59rwte5m7ypIzsDdCZ/ehQm1nQ= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=rcjPKZsckWOuKXk0QifKBxWsi1qc+2jD7wDRi0Ywjjc=; b=Gkb/Py1b7SjqiY1IGeHDhfdcCL yvhvtigNLD+QDMU8nTMuug0k4mBcU+NXK6ujLoVDD/sPcE+MKnU3S1ZcfCUbt4KjOvLFTzFsjAiyX /H4EhwPE/ersknsH/hoLBaJpJabGHmuveNdCnxSlZ5VqAyrgsF+7BJqJ15iWSmU6edqmvC/1SbV7w elk0lR+tJVedxKzMHM4iM4fuOYW4cETrHukFQCvJYId5QDcUI382ItL8qYyerpmlx2FuZOaKxx6iE qtaiiKM9R7055aVBDvgMfVciujS9UaGiuUPDIPmcgFB15pOOfwJXCm7R+wOcLyXhG1Km+oFw7N+Fc 5AS2L9Sw==; Received: from willy by casper.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1uFO21-0000000DAIW-1QpN; Thu, 15 May 2025 02:09:09 +0000 Date: Thu, 15 May 2025 03:09:09 +0100 From: Matthew Wilcox To: Ackerley Tng Cc: kvm@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, x86@kernel.org, linux-fsdevel@vger.kernel.org, aik@amd.com, ajones@ventanamicro.com, akpm@linux-foundation.org, amoorthy@google.com, anthony.yznaga@oracle.com, anup@brainfault.org, aou@eecs.berkeley.edu, bfoster@redhat.com, binbin.wu@linux.intel.com, brauner@kernel.org, catalin.marinas@arm.com, chao.p.peng@intel.com, chenhuacai@kernel.org, dave.hansen@intel.com, david@redhat.com, dmatlack@google.com, dwmw@amazon.co.uk, erdemaktas@google.com, fan.du@intel.com, fvdl@google.com, graf@amazon.com, haibo1.xu@intel.com, hch@infradead.org, hughd@google.com, ira.weiny@intel.com, isaku.yamahata@intel.com, jack@suse.cz, james.morse@arm.com, jarkko@kernel.org, jgg@ziepe.ca, jgowans@amazon.com, jhubbard@nvidia.com, jroedel@suse.de, jthoughton@google.com, jun.miao@intel.com, kai.huang@intel.com, keirf@google.com, kent.overstreet@linux.dev, kirill.shutemov@intel.com, liam.merwick@oracle.com, maciej.wieczor-retman@intel.com, mail@maciej.szmigiero.name, maz@kernel.org, mic@digikod.net, michael.roth@amd.com, mpe@ellerman.id.au, muchun.song@linux.dev, nikunj@amd.com, nsaenz@amazon.es, oliver.upton@linux.dev, palmer@dabbelt.com, pankaj.gupta@amd.com, paul.walmsley@sifive.com, pbonzini@redhat.com, pdurrant@amazon.co.uk, peterx@redhat.com, pgonda@google.com, pvorel@suse.cz, qperret@google.com, quic_cvanscha@quicinc.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, quic_svaddagi@quicinc.com, quic_tsoni@quicinc.com, richard.weiyang@gmail.com, rick.p.edgecombe@intel.com, rientjes@google.com, roypat@amazon.co.uk, rppt@kernel.org, seanjc@google.com, shuah@kernel.org, steven.price@arm.com, steven.sistare@oracle.com, suzuki.poulose@arm.com, tabba@google.com, thomas.lendacky@amd.com, usama.arif@bytedance.com, vannapurve@google.com, vbabka@suse.cz, viro@zeniv.linux.org.uk, vkuznets@redhat.com, wei.w.wang@intel.com, will@kernel.org, xiaoyao.li@intel.com, yan.y.zhao@intel.com, yilun.xu@intel.com, yuzenghui@huawei.com, zhiquan1.li@intel.com Subject: Re: [RFC PATCH v2 16/51] mm: hugetlb: Consolidate interpretation of gbl_chg within alloc_hugetlb_folio() Message-ID: References: <8548af334e01401a776aae37a0e9f30f9ffbba8c.1747264138.git.ackerleytng@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8548af334e01401a776aae37a0e9f30f9ffbba8c.1747264138.git.ackerleytng@google.com> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 2D2FF18000F X-Stat-Signature: r589y9poujssoizm57bixnhmn87uquf9 X-Rspam-User: X-HE-Tag: 1747274958-559825 X-HE-Meta: U2FsdGVkX19RZVqWUDck+obFJ572hPjX0l5s5SXb4i3BMrbyK52cbmhaU6F2KT9ksCqv9eVHnCIicG1QWKuvuED4Yi/bnXJIPGhnoWh3cfuHGxD6nhXaZAPFGar90MGAxXo9xJoWi41HGLm1+u6ZK+0jZOClqA5SvbOIYxvd4Y9sl46TKNTPPUy6VK6h5zsofOclBgtuFYpjbkF2VU0aW58CsaGKZRLsfcvpJ+yV58fEWCGMsbwxBP7f5YN6wyRUWrW39aV1SKP1aNYRPnwGmqW4naI/XHkMwgkFWPogHmELFdlvdsyjgcfaHbZ6UfAJOd1b5qIEei+3aeMIRTQXnCLB4WYpQoMc4sLzO/sXcYJLRIq0+ocx5quXXyXD320JK6bMG7hyK/b/Sj2wtNNnq/npW7np5nDrWGAP8AZ7xZB5lEKuL+mEyGyQg2eUkY+oFWKsVcBdPlTpZIIZ2loLQme0+MNBi5eOVyXaN94h+pvp8qjVuRF55VDjZwWm5Hm5NEa/pG9Q9pYQ5qUCj7NRXV+NXqV//ZifAKmrVYTMvHHuoIJSTxWIYJvOi6wXBDQBh/4w64pC/gwZ/DPwV59YojsQ6WHQLRYFT8Im/gums3OlAVkUmzBo/omfkbyfP969NBRBJKtHLqjr6LISkqhF8/yWMxUyHLKSFzjSKWpjJyQrIWchFnMG2/sjHSutS0Z+SE2irn3A/rV/lxSWQ1KFt/78873B2B7flSATCaxtmA8z+r8ap9LKssyx+wP38re5qgtS6H89Iajvg49xCGoWhnldXIYDBpakjB3DHz+eaKoLLJB8wKrMw+pfccOSAD0uPRU7LgbYwN2yBA9SK2cKW7yZ9iCsgbmOKBtCdMrxgJWqWCJFQTJB5uaG58OI78Ss6mVYUrG0/zRg0FhO09JnUOPLE3Y31Y2F1b2hRVssgMteBuxinwQp60h5yc1p4AEhvfZvgu3ZPVGzUc6lDKL bLiW/e5e XuGB/7etwo6vAw2OmC6hN235E2baWCWPHh79lOFbo6gJ/BvP6KDO3ZLsrEqj3VtKEgvW6XInxTBQR89/cF9VlZMg+L0DtSnPLs3/C4iqt1Xjqpp6lbSCvh+CMeAu6rcYQoXt0UpO/PiJYd6s6UdQ3DOqxXr/BMJazfKcRR7FHDGMH4cnOkKah2BD64q8D6KOhT/zFq5o9ezXI839mDiDSxXwRMwBkPlEJWppJ1a8SPPrsd56aqsYLl+VQYERpiXbsIj9GG1ih2QuFlXTneOfUA6O8h2ivyKAgzfVuGczuxFo0p/qub5NKKQG18VL/xYAxN2s0jKB0bI4oKJ1VFQh3mih6FgyVRGJ6LHhl X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, May 14, 2025 at 04:41:55PM -0700, Ackerley Tng wrote: > -static struct folio *dequeue_hugetlb_folio_vma(struct hstate *h, > - struct vm_area_struct *vma, > - unsigned long address, long gbl_chg) > +static struct folio *dequeue_hugetlb_folio(struct hstate *h, > + struct vm_area_struct *vma, > + unsigned long address) Pleaase don't mess with the indentation unless necessary. Nobody cares what your personal style preference is. You're obscuring the actual changes.