From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE3EFC3ABD8 for ; Fri, 16 May 2025 06:32:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 67BE96B00B7; Fri, 16 May 2025 02:32:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 62C526B00B8; Fri, 16 May 2025 02:32:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4F1DB6B00B9; Fri, 16 May 2025 02:32:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 311D66B00B7 for ; Fri, 16 May 2025 02:32:55 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 9485DBF280 for ; Fri, 16 May 2025 06:32:56 +0000 (UTC) X-FDA: 83447803152.17.0585240 Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) by imf23.hostedemail.com (Postfix) with ESMTP id 920BC140007 for ; Fri, 16 May 2025 06:32:54 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="Ah/NlVcL"; spf=pass (imf23.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.54 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747377174; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KUJKtPVwdVcpqXmFstCnFFaHnVm1C/pmwz6nmZZHgzI=; b=t5ylWKSn78C2Nx9z4NqN2s2MvpUJp7u2mYSjzPif8cdXybpv5I6qwGy+gt+5lWRD24OZP8 PwrCWcz56fp4v/BWT5GWloMhd5HjX2sv7Uz7JIoRTEvUNNeSacnSY4l/j5PJ5/Q1Nb9rGX 0NYKG0ccLbZkdtSa50MCUmpkxQFn8Vk= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="Ah/NlVcL"; spf=pass (imf23.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.54 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747377174; a=rsa-sha256; cv=none; b=LB+hX1Q8ngcftu5mVGslQOQvHJWuPDtGCpV1hxA/IzvxGG6hHUWx2+8OzAiJgla6fSyisN Nkfc6AkjvxyIbeTMaRR0a9KUb/Nrzxa6t1+8J9x0y2IPYLCzen8uz1wBmNc5ZaXiS0DASt wJT6HivvmAL83syKc5fSJN/c9C2Hgvo= Received: by mail-lf1-f54.google.com with SMTP id 2adb3069b0e04-54298ec925bso2581752e87.3 for ; Thu, 15 May 2025 23:32:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747377173; x=1747981973; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=KUJKtPVwdVcpqXmFstCnFFaHnVm1C/pmwz6nmZZHgzI=; b=Ah/NlVcLKyXz1YYYMxeJlskx+xt16U0tPcu2KXV60CeuJa2/r381fJDcE0L2PYKIjt rvDytzitUuyVf0rPL5eQXKZ36apU1ZsTxYOec5+dj+yxlNNBsuDcOyXuKr/HDk6gnP7L Qmlr/hpEsH83mUamhMWcochN1tEOyoB147WHugjiHxvcwSjQ4WJFHHThr8P4sIpfQRCr fR8WOO0N7VZuoQC6IEDDvSbIwy0AePHiG60gLL1iePvoGyPdJen4TL0tJvyHO5DbvAjv et45pcagA41NQvkN0My060fKRSH1+2NtpbkNJ15ftE+qcwF9+q07FiHQL8H/K6CaT1g4 ZLSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747377173; x=1747981973; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KUJKtPVwdVcpqXmFstCnFFaHnVm1C/pmwz6nmZZHgzI=; b=t7wQ/qPV5RUtwBzX71URAcuhyUGL+Veo85LMQcTwvmoeWkpgwZfE9s5bd7FJLpFoQD 1/pxfjEMLd2HeQ/p5w7V93ileJBqgerIpypt1ZIioBoSvD218auy+2+5YDcUdo2dHwzq 48pBuOzOr1MfzlHOnIuABQAqhJ+9+E7vR/H+OZUusceMX7Pjg8TcJ0LaBpxMCUqoZ5e+ DjYv7Z+p+HoT/d5Xn53rEdEOaZ0E9tcWQAJCraMnjfxqS8lFBAHC35KePdXLDYEolLKJ CSSGpNR5myGqv8YaM9e2zkZLgwq9dxB841H26TIulpxD4LHcfqdXI6C1VWojtNMIVSW4 jwiQ== X-Forwarded-Encrypted: i=1; AJvYcCWNL6o71FQA1YHIaa8A4cMiL0b5V4qO/Zd8FLlpeTbtgYfk/D0GnwvfhEYJYj512oRxfJLPDLG6Fg==@kvack.org X-Gm-Message-State: AOJu0YzzY2ws0Hv4f3VOznDwG54rzrScmHia9VBtrosatGU2h+fNqyER QCBzqMj4ScoUS65FhiA0bV2XPJqRkce7LYbmP+JXZKx72A/JYROtWfbGtcnMusL0 X-Gm-Gg: ASbGncs60ukOucFMLgmov0WL5+22XbgxjGxaVi1H65xTrmKr0ed3oKCVuyxODYiniU6 JO0jyhBEGYidXg89BBUUNI9wP6JeFDX19UVnR36enPYRxYCgo3PXy8o1mOaRk6zY+njM7VbwyHZ nSEaEWb/WPuZYG2sqc/CjJBbZxExG+9QfMKT17FUkkR2o4Z98M68W57Db3T95dOWrzwIBE1EN5v HXinPs2OzABPLKcNwYgdlgVP1F3A+XzsE3xuVhbj6/6ll5xOEWCv3P4pCNHoEPSnh8BMAf3tnV6 s6hmYqC94OdFydjEBg== X-Google-Smtp-Source: AGHT+IFRP/vXmfI6lHLwDlzDmnD+1TtQ98Hefzc+j7BWdek+k9pG/xT4EAPbSUkky9UNn9GYhdpyww== X-Received: by 2002:a05:6512:6501:b0:550:e147:8165 with SMTP id 2adb3069b0e04-550e71d0bf3mr569220e87.24.1747377172352; Thu, 15 May 2025 23:32:52 -0700 (PDT) Received: from pc636 ([2001:9b1:d5a0:a500::800]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-550e703c2f3sm275344e87.214.2025.05.15.23.32.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 May 2025 23:32:51 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Fri, 16 May 2025 08:32:49 +0200 To: Kees Cook Cc: Andrew Morton , Shung-Hsi Yu , Eduard Zingerman , Pawan Gupta , Uladzislau Rezki , Erhard Furtner , Danilo Krummrich , linux-kernel@vger.kernel.org, linux-mm@kvack.org, bpf@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH 0/2] mm: vmalloc: Actually use the in-place vrealloc region Message-ID: References: <20250515214020.work.519-kees@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250515214020.work.519-kees@kernel.org> X-Rspamd-Queue-Id: 920BC140007 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: or8xo8cg5iyh1tquihx99ttadde94h4o X-HE-Tag: 1747377174-127969 X-HE-Meta: U2FsdGVkX19tVMj5AG0t0ygCnpijhiSqdggrJDCiGWZUYCCImw4f01E1/u7/DnCaWrG1ULXVkHL0wnbM5pXapg7bWdAqEVY51D5TjuBho5fh6q/3C8oxao1M0sCSvhhh4kW5syTbk859MhZcr27q/+XmoshLYwKejI/UzW13fY29uk3Q4wmCXjc2gOwCBqo2sBesH6ycdxWwUbOdluIbWo3utoKz3r5+u2ayl8E83374MziynySrzM/L7JE/Re1k0Fq70t5KmFexyHkK0sexN+iOiasEUXk22fBifptswlEhX9ZHOXGOSeeCSy/mu0bB2HmD7ryEFKg/l/muldUF8ilPMT4IBgXNdGX4SYg9eLhJiBf+/9l2TFUnMlyFvoHAdhwpvCoIQAMS46dKQrPlwFh2+bqrnA+xgqz5VNHQudMQfYjxJEmnagJUHx0u85IqqSA7Qmn51oYme1itxSx3ZyYyNqVoiKSWM47no8bjYuC9foCWr3fZ7xw1rOb1LNfVzxWM409Vz4VR/sWi6jpkJXQdUEwCr0TzgXqtJY3/UXkIpkw9JCk5jP4FHp3i7XP+O076zZSabcrKxCsyhq4bDbRaDkieBRdsqraKTOFDclEDCkfNiep/fQnMkMH4yI0Bj6poOSTvLaJurtdghkMBgA2DGG/eBvz+6M4FztBTPds34yLpAP/HoF4KmhoxwmVz35h0GE9zIGDrlvH1dEid7GULPL6lzKh9pswIamL0JjmKTOP1lqGszRgeWYQpMmoi3EVjBHCqaUQ+5LG6vPhqsFYsG7Tnocjbj/zb/ksTIkkzb/SVRTTEWSQLDb4xEYEak2WJfLqveJrcRyN63T/M1igSRIU7FI+Q7ifm3dlKPx4Q00oryyRConPD99BUtCxUkboDxVfwFom13Yt1NvZamC/9vVEEqQ8/fna05El453TrBAq3hYCoZZ9K050a9CdtjUwVmMral4nHI+FUq7a FlP4/I8d DEFCIKHxeod/sPBl+KSBxW4mV0ziJP6B27J3Jf+33hKsHo03XLVyvZjoP0a18I0vjGFRVUcvbP/AozOIaSldxNW8M8hQLrKc0szx1//DTMoubqe2unGaIb69lUslp9XaEmzVMan9BUD7yrDyxGPbrFqjAALhYLAenzP8lssLEdsIJwrf24nCVSkfKX3M2oKG0HHbEWA77uOCC74imdUGgCbYgrt2K8yB21Rope1Mzb1AJLooKE54ZHF7tWDegZgtobdVdFzGebgQfkkaAQ8LokFiccbPiPHRLFb9KsReME+BFoUR3UGrRIQbX+lXTTXqrrYd+LtRkmDc0CM0q+hOZpsgFFDw4yetJHQ+9gFt3jld+lY7w6HgUpruwibYZZiSZ+StJi44ZQCFs0A8lUr3SZVbV19ixRIsVVaq52whpNhHg25spDhqAwPQAnSDdDKGwTp7Q X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 15, 2025 at 02:42:14PM -0700, Kees Cook wrote: > Hi, > > This fixes a performance regression[1] with vrealloc(). This needs to > get into v6.15, which is where the regression originates, and then it'll > get backport to the -stable releases as well. > > Thanks! > > -Kees > > [1] https://lore.kernel.org/lkml/20250515-bpf-verifier-slowdown-vwo2meju4cgp2su5ckj@6gi6ssxbnfqg/ > > Kees Cook (2): > mm: vmalloc: Actually use the in-place vrealloc region > mm: vmalloc: Only zero-init on vrealloc shrink > > mm/vmalloc.c | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) > Looks good to me both. Reviewed-by: "Uladzislau Rezki (Sony)" -- Uladzislau Rezki