From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60B4CC3ABDD for ; Tue, 20 May 2025 09:16:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DB9676B0098; Tue, 20 May 2025 05:16:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D42DA6B0099; Tue, 20 May 2025 05:16:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C59806B009A; Tue, 20 May 2025 05:16:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A84116B0098 for ; Tue, 20 May 2025 05:16:49 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 62F4C1A091F for ; Tue, 20 May 2025 09:16:49 +0000 (UTC) X-FDA: 83462731338.08.2E64601 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf15.hostedemail.com (Postfix) with ESMTP id 9E0C5A000B for ; Tue, 20 May 2025 09:16:47 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=OdUeFYZd; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf15.hostedemail.com: domain of mingo@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=mingo@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747732607; a=rsa-sha256; cv=none; b=ChpU/O5ChNB6U5qY4w9F1JfNbIa6nMdeAseANZ5cNRk2su5gAUkey3R4A+EOWeB2rGRKA1 A2nusQvavUNBlMWkflKKiO077B947yF7PsVoa88GCUMUhM8mn6i94sddYO+V3yW9qk/s2C b66ACUEcelkXTpkZUojjwQP7u3SHlcc= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=OdUeFYZd; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf15.hostedemail.com: domain of mingo@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=mingo@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747732607; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9sJI3vYMiDiHxaQ2D+HTPWxv3dFl8WDrCEb12uE4n6M=; b=SqxEqJuQih8GmOMh8xIWKC30dnQPZy4eOYd+JgtXyi0rh9bWOzzx/i2kJl5qIzj2eXp6aV 7g413LSqb8ChqXgHV6FkxX+C6zJUhD8nXzsa1zYOFIJChnVl7jUBi40u1ozh2J2vhiDBzN +F1fMRdUsZQ3vLR7/JiT5F90DaMALVY= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 4DAF549E95; Tue, 20 May 2025 09:16:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9A853C4CEF1; Tue, 20 May 2025 09:16:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747732606; bh=jR9xi//7cPiQ1oa8OB2YAKg66WDWujeTFTpQ4irEdFE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OdUeFYZdAPx4l3pLlT0kN66mBtZc0dMevUzQBThOQevhw30IsgFgpdlVgHkvI7pjM lPw9fEO8QkiRyENlpP4Wr9IU/5itTt1hxJDf5wbAPX9ck9TGgvlDbUmkeGtuHZmfIW qaTUZrl2ce/AfsdVoOFpRq7l89xiY+xVzZaNb7yjhZlJP5/JKAWeMno8oQbL/nVIrH l20m93esjYKpMXia5mAa1ldA3zi/E0QukO79pefgOzYv8PQCumR40qhcVHolnr5JFs tn8Q7J4s0N9Bq52WAnJ7aTsqirmVapOPtmm4XhcRB1a0gm4Qabfwh45GqcBRHf84gp g4SCMjGXURuIw== Date: Tue, 20 May 2025 11:16:40 +0200 From: Ingo Molnar To: Rik van Riel Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kernel-team@meta.com, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, nadav.amit@gmail.com, Rik van Riel , Yu-cheng Yu Subject: Re: [RFC v2 6/9] x86/apic: Introduce Remote Action Request Operations Message-ID: References: <20250520010350.1740223-1-riel@surriel.com> <20250520010350.1740223-7-riel@surriel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250520010350.1740223-7-riel@surriel.com> X-Rspam-User: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 9E0C5A000B X-Stat-Signature: zkmofyb6rzc14m7i5o14zet64eez1qfy X-HE-Tag: 1747732607-589209 X-HE-Meta: U2FsdGVkX1+Mp+XoQa3bmpqCXcr/hX8r1kNMU6xLuyeQFvO2PmL7BKWZFfoFhKb9NDIeWa8cRazZHNdMfWawmwdtrlnK0H8oenAwIjUQArS5BfjJeXrO7Mv3GjdESN6JNCH3yX1rcxL/69pNN659i+m0wnPwGRsDtFf/Q5xa7CkcmvCZzuiPu3XsAzvhF1EhO7/Zk+NJYsVRxqelISrWVta2GLOhLjdLD/Aq8GDSm9Rt22XaT0Y8yhQUoWccZIgMtasm4c8TTv8Nc3fcA9PhSUd5J5F8gO8vSe4ahURNwLH8dtNbu4x6Qr83mDRReZkzYcIHPulSBz54tnOUtx99rzzLN47ofsyir1Bm+LPEedq9cQzKQ6AJim81Uk31OVJ2DIv0L7qDXJ3zLiJmfFYhZeze0h3IXDblJ6OMrHeGtSeaC29u2mfhG0gmf0IFFDjpP3GUo+0cPDY41ft6oOcHbHWeBh7rALiENjr9m4ISbtOFl0cvF2C3mUP5dny1w1KR3YwCggqJQotgxLB0/t8lRkdA4Yb/2jrCfM1UiQP/Dg7b9YrqZWYfvdMeUMOvsVtkuMu0X8YBz55vYj8RgwEVhxE5EZhKRdALyQlFD3TUSAqhlefnrLov5j7Blqm00p6k6iKmPbo0QCByEKEsslPEr1vw0qrEWuWRlOL0+CSn1OKDu4KmZCywBA8Xt2ox979XuTdubD6qrDBacKsLoxBkOnnpAYbSHaOMki45xz6VCfWIV70sQckKv+bHdBuJxuaT1JKM5ZJtCy6pnw51/Odx16eQMuzmWdPTH0HlBKBhc64yIqjlvIg9WhufmXLaiONmhHef9O/8vt8jCQMYWYTCQfV1nl1LBtSQ13g0vI95R8Id0UJTl0VPSTSbcOIRaYvjdIDwaNEqH+CwXpoH0mLOJnPXZzOUY6AWSsOwFJueiX6L6L+xaQXcjfbg3ws8JIQRakq9bk33xBqOA3m8sDe UtcpTqi3 +vwusyAbim+7jsYVKCruk9rnY+Om22lndLUSbtC0IktYx8hh2A/ypXCA/tquDUU7pb1UCkLPLucwCJbzFQMaRfF/SiVMR1tozAyf2qYrUmvXtPVnZfw7ymLkMoarpvunBrCY9URlqsWh336ZiIuMWg1qiIIosrwMGdJ854iAIOxPQtNgnSMyYVau5UWwp+Se8YRQ9dvD3DxoGvG1ApndUQ3x/MH2NZkSSpn7jMeeDscY7tXp8O8lHIt+GVdvWljWSNIlLfPlRxqau7JEq2/R82c2VgpcOokvWefos8Jy7c5MvdoqFDMigoklFOfXxa3XssuiNFsbjiZqLtNPJctb2mXi7HQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: * Rik van Riel wrote: > diff --git a/arch/x86/include/asm/irq_vectors.h b/arch/x86/include/asm/irq_vectors.h > index 47051871b436..c417b0015304 100644 > --- a/arch/x86/include/asm/irq_vectors.h > +++ b/arch/x86/include/asm/irq_vectors.h > @@ -103,6 +103,11 @@ > */ > #define POSTED_MSI_NOTIFICATION_VECTOR 0xeb > > +/* > + * RAR (remote action request) TLB flush > + */ > +#define RAR_VECTOR 0xe0 > + > #define NR_VECTORS 256 This subtly breaks x86 IRQ vector allocation AFAICS. Right now device IRQ vectors are allocated from 0x81 to FIRST_SYSTEM_VECTOR (POSTED_MSI_NOTIFICATION_VECTOR) or 0xeb. But RAR_VECTOR is within that range, the the IRQ allocator will overlap it and result in what I guess will be misbehaving RAR code and misbehaving device IRQ handling once it hands out 0xeb as well. So you need to lower NR_EXTERNAL_VECTORS for there to be no overlap between device IRQ vectors and system IRQ vectors. This will substantially compresses the available device vector space from ~108 vectors to ~95 vectors, a ~12% reduction. RAR, under the current device IRQ vector allocator, will effectively reduce the number of vectors not by 1 vector, but by 13 vectors. This should be pointed out in the changelog. It probably doesn't matter much due to MSI multiplexing, but should nevertheless be implemented correctly and should be documented. Thanks, Ingo