From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33C4CC3ABDD for ; Tue, 20 May 2025 09:28:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CB92F6B0095; Tue, 20 May 2025 05:28:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C912B6B0096; Tue, 20 May 2025 05:28:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BAC0C6B0098; Tue, 20 May 2025 05:28:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 9BE846B0095 for ; Tue, 20 May 2025 05:28:27 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 5B80DBC3DB for ; Tue, 20 May 2025 09:28:27 +0000 (UTC) X-FDA: 83462760654.29.F565804 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf18.hostedemail.com (Postfix) with ESMTP id A3FE21C0005 for ; Tue, 20 May 2025 09:28:25 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=rwAlUglm; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf18.hostedemail.com: domain of mingo@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=mingo@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747733305; a=rsa-sha256; cv=none; b=oaL0m9v98wMi7eliuZpPRl8noP1vIaomz7KDaDAj4GH1s34T1MjPBa9tWthz9pLrdCfOdI IQSeb9rA3bkRoOKOsNaAOkVjEQvCpoZIY90LCuGdd51vDOq4yWH0dNpO+tij1vrIOOn6al 6V2ZeqDo3NtllhvZkuEWnrPnPqagVKA= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=rwAlUglm; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf18.hostedemail.com: domain of mingo@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=mingo@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747733305; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HaA1r7wN4FAKuodtPboZBIQJeq5FHQsWptTFZBwv1fI=; b=YFIbrmIyzGxeCqwWuxtgkaug2lkT946qiE778V92s3YTeXdHtlhDbk+aDpmYw2d7LavtpM c1G53Uw1Q4gaKBzm+7O+X1jHzuHGfrFZQQbBf3LjIOuVxGY0EMJDqkqt4cNLL351WdzI5p S2Y/a749tnVsoi7ATjtfn4AXFTmans0= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 6EE044A8C9; Tue, 20 May 2025 09:28:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 36962C4CEE9; Tue, 20 May 2025 09:28:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747733304; bh=qhLFlGcWAzMtuMxtHo20slg88sTeEROxFnPPOCEv/1A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rwAlUglms2rz7KvZSbbbk4yn4KnGFbItsnkjfYWRoZgAFCHztiEOZTAgUsRcTg2Xl MSAqW4X2rvOV+Z6i7E26y9dqnqg3PwlT0kc5fQsxdApgy1C4iMJPZJZ439fJ3Do305 VGWpzOeuJ2B032cUrwPFRi+CkY/MUt23+DVY5BGKcOMMxast8KoF0WlzKSPhzm7Ks+ +aHTAZt2akA/0V+xIi1w/CjIMzWxzm8DLAPPJkHRXLYMBGmVP86WeBRSw7ykLn3//n Q/9TaMGhQ/FqusAwzYEWapgEmcQ4pBAhrgMsfGZsXn53vNt2SfvM90mH/wmvPiF9v9 jc+PMwCAWQKyQ== Date: Tue, 20 May 2025 11:28:18 +0200 From: Ingo Molnar To: Rik van Riel Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kernel-team@meta.com, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, nadav.amit@gmail.com, Yu-cheng Yu Subject: Re: [RFC v2 7/9] x86/mm: Introduce Remote Action Request Message-ID: References: <20250520010350.1740223-1-riel@surriel.com> <20250520010350.1740223-8-riel@surriel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250520010350.1740223-8-riel@surriel.com> X-Rspam-User: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: A3FE21C0005 X-Stat-Signature: pp45q8ai8b87zi1nbk3xt5wx41und91e X-HE-Tag: 1747733305-421940 X-HE-Meta: U2FsdGVkX1+DaEv1sxBLM1+6ohQvbrNheUD6mnFUxtNGHcf/SMpQZpuDsD1eggNr/DLKJJhdAAR024542tzRDzYZo2nI6zNE7bUiIlg6GwqbZ9fltQ1h7wo+gM7SdOoLX29494nwIWPYxNTP2+GTsLQaxopK/IVhbCFFpCqI/nmT5RW352xec+mhmWta1HT7qDZ6kqGrzAi212PxdHfA+MYgHZhHAwUdKNkn1GOvertuYYVf6QSwKz8bMGuMmt5R0yq9Jqhea1vNoXi5v/XDKNM8XqUQvxKR5sn7HbKbVq2mWEwXhXX2IHN0A0KYGNrTMmUu6f0fb7o1RtmpGevqSX4d2YXe1utVME63x8FHwiNkiodal1LMZwmWUJoQ8pexMTpSpeVCQ8c9WTO4F5HAjPOwpirNCYSyqFLrXEOb/gTYhYz9jcrMvK2csKk+cxoG8af3U3BDQih7/1AypSV476nO3F89TToGf5x5FGU0t5gPJhxecdgl4q/Gw8QVFdpIKG3IOAQJSzt1TOsPeESPMryiHO/yeGhOlehDl102iAmspwrgXPHtyb1FtA7Mpqxs7lU4BT3DbVlsJvy4jx/zxSDHbrKow6fWVO0EnmOf9YAyrFkISzNydlXob9lmYeB3XEFC8sK4vmbEqZW6Mq0gT9QT8GJW6EgWTAN/rY+cXy6NJiGa72ODy7oI6IXkDE42jRVEgEaemvlL8bEp9TlvnehrA+P6mFDuaopnm9UglUJq6kJyNaEVH2Iri3CB3Imt4WFW80KzJ7QHQGaPYdMmOhGMfaeU6Xl2qcvYUeznsox9ss5hhkJ+xJcYa2IbuHTumO/iQwqrwkL22aCHZDlzbLD47EAZpM5fkqbRNDjzKe/FJLcTmVkYSAIkmH2LPYBjzcqXZBVoUX5HRH7cTvGoEwLvv9Rc0Dcp7I45+IaJTaXGU9FPDEMU63DvMx+rRYLbfT3TZqGS953jODeDIfY JweS10mY 82NuKz6yvVZZLWwV/iYv6cMDoTGB6cHFjQu+bTRgHvi+kO0SydPpbDp8B9evxYCxSDlU1JT6ftmGfbpyNN2M5AivbhHF1pIVfd+R3JVN9W89/Yf/OzVWus30fAU5YhtO/bUcfHrl5qCDwzznHoVdlFC4xvmraKoYWyNcN9jC/NKJXwfH+68n1jwXUcD1UBWguphfCil/O9w8gsy26kEH9TqGflQ+rwGSzMCtsFlcA1HrIUz+q1XtC72IpU3czLVVeu3juVxtJgNoeXaRnnLKGSDa6MaqpY9gr3oTAgI9bKRuV2DycTKGmL4JvsmHq/sCmMU0Q7lqZPrptIgvOyogEZDfHz5hAoS44E9LfJAhhvqrUzTV55ZsLlEY4pA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: * Rik van Riel wrote: > From: Yu-cheng Yu > > Remote Action Request (RAR) is a TLB flushing broadcast facility. > To start a TLB flush, the initiator CPU creates a RAR payload and > sends a command to the APIC. The receiving CPUs automatically flush > TLBs as specified in the payload without the kernel's involement. > > [ riel: add pcid parameter to smp_call_rar_many so other mms can be flushed ] Please actually review & tidy up patches that you pass through, don't just hack them up minimally and slap your tag and SOB on top of it. One example, of many: > + * We allow cpu's that are not yet online though, as no one else can Here the comment has 'CPU' in lowercase, and with a grammar mistake. > + * send smp call function interrupt to this cpu and as such deadlocks Here 'CPU' is in lowercase. > + /* Try to fastpath. So, what's a CPU they want? Ignoring this one. */ Oh, here 'CPU' is uppercase again! What happened? > + /* No online cpus? We're done. */ Lowercase again. Damn, I thought we settled on a way to spell this thing already. > + /* Do we have another CPU which isn't us? */ And uppercase. What a roller-coaster. > + /* Fastpath: do that cpu by itself. */ > + /* Some callers race with other cpus changing the passed mask */ And lowercase. > + /* Send a message to all CPUs in the map */ And uppercase. It's almost as if nobody has ever read these comments after writing them. There's like a zillion small random-noise details through the entire series that insert unnecessary extra white noise in critical system code that should be a lot more carefully written, which emits a foul aura of carelessness. Reviewers should not be forced to point these out to you, in fact reviewers should not be exposed to such noise at all. Please review the entire thing *much* more carefully before submitting -v3. Thanks, Ingo